On Wed, 30 Dec 2015 22:05:25 +0800
Geliang Tang wrote:
> Use dev_to_virtio() instead of open-coding it.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/s390/virtio/virtio_ccw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks, added to my queue.
--
To unsubscribe from this li
On Thu, 3 Dec 2015 17:23:59 +0100
Cornelia Huck wrote:
> Michael,
>
> here's one fix for the virtio-ccw driver.
>
> Patch is against master, as your git branches on mst/vhost.git seem
> to be quite old. Is there some branch I can base my own branch on,
> or do
Michael,
here's one fix for the virtio-ccw driver.
Patch is against master, as your git branches on mst/vhost.git seem
to be quite old. Is there some branch I can base my own branch on,
or do you prefer to take patches directly anyway?
Cornelia Huck (1):
virtio/s390: handle error valu
possible
pending I/O indications.
Signed-off-by: Cornelia Huck
Reviewed-by: Guenther Hutzl
Reviewed-by: Pierre Morel
---
drivers/s390/virtio/virtio_ccw.c | 62
1 file changed, 37 insertions(+), 25 deletions(-)
diff --git a/drivers/s390/virtio/virtio_
On Mon, 30 Nov 2015 15:41:20 +0300
Pavel Fedin wrote:
> Hello!
>
> > > Thank you for the note, i didn't know about irqchip-specific capability
> > > codes. There's the
> > > same issue with PowerPC, now i
> > > understand why there's no KVM_CAP_IRQCHIP for them. Because they have
> > > KVM_C
On Mon, 30 Nov 2015 14:56:38 +0300
Pavel Fedin wrote:
> Hello!
>
> > > case KVM_CAP_INTERNAL_ERROR_DATA:
> > > #ifdef CONFIG_HAVE_KVM_MSI
> > > case KVM_CAP_SIGNAL_MSI:
> > > + /* Fallthrough */
> > > #endif
> > > + case KVM_CAP_CHECK_EXTENSION_VM:
> > > + return 1;
> > >
On Mon, 30 Nov 2015 12:40:45 +0300
Pavel Fedin wrote:
> Now at least ARM is able to determine whether the machine has
> virtualization support for irqchip or not at runtime. Obviously,
> irqfd requires irqchip.
>
> Signed-off-by: Pavel Fedin
> ---
> virt/kvm/kvm_main.c | 6 --
> 1 file cha
drivers/vhost/test.c |2 ++
> drivers/vhost/vhost.c | 12 +++-
> drivers/vhost/vhost.h |1 +
> 5 files changed, 19 insertions(+), 5 deletions(-)
Makes sense.
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 5 Nov 2015 09:11:06 +0100
Cornelia Huck wrote:
> On Wed, 4 Nov 2015 10:14:11 -0800
> Andy Lutomirski wrote:
>
> > On Wed, Nov 4, 2015 at 9:52 AM, Cornelia Huck
> > wrote:
> > > On Wed, 4 Nov 2015 15:29:23 +0100
> > > Cornelia Huck wrote:
>
hanged, 14 insertions(+), 10 deletions(-)
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 4 Nov 2015 10:14:11 -0800
Andy Lutomirski wrote:
> On Wed, Nov 4, 2015 at 9:52 AM, Cornelia Huck
> wrote:
> > On Wed, 4 Nov 2015 15:29:23 +0100
> > Cornelia Huck wrote:
> >
> >> I'm currently suspecting some endianness issues, probably with the
On Wed, 4 Nov 2015 15:29:23 +0100
Cornelia Huck wrote:
> I'm currently suspecting some endianness issues, probably with the ecw
> accesses, which is why I'd be interested in your trace information (as
> I currently don't have a LE test setup at hand.)
I think I've
On Tue, 3 Nov 2015 10:45:12 -0800
Andy Lutomirski wrote:
> On Tue, Nov 3, 2015 at 9:59 AM, Cornelia Huck
> wrote:
> > It's just failing very early in the setup phase. As it works for me
> > with a kvm setup, I'm suspecting some error in qemu's emulation code,
On Mon, 2 Nov 2015 12:23:25 -0800
Andy Lutomirski wrote:
> No change.
I'm stumped :(
Here's what I see:
(...)
> CH DBG: css_interpret_ccw: cmd_code=e4
> CH DBG: css_interpret_ccw: ret=0
sense id -> works
(...)
> CH DBG: css_interpret_ccw: cmd_code=3
> CH DBG: css_interpret_ccw: ret=0
nop
On Tue, 3 Nov 2015 12:54:39 +0100
Christian Borntraeger wrote:
> As virtio-ccw now has dma ops, we can no longer default to the PCI ones.
> Make use of dev_archdata to keep the dma_ops per device. The pci devices
> now use that to override the default, and the default is changed to use
> the noo
On Fri, 30 Oct 2015 13:33:07 -0700
Andy Lutomirski wrote:
> On Fri, Oct 30, 2015 at 1:25 AM, Cornelia Huck
> wrote:
> > On Thu, 29 Oct 2015 15:50:38 -0700
> > Andy Lutomirski wrote:
> >
> >> Progress! After getting that sort-of-working, I figured out wh
On Fri, 30 Oct 2015 13:26:09 +0100
Christian Borntraeger wrote:
> I am currently reworking this to
>
> static inline struct dma_map_ops *get_dma_ops(struct device *dev)
> {
> if (dev && dev->archdata.dma_ops)
> return dev->archdata.dma_ops;
> return &dma_noop_ops;
>
On Tue, 27 Oct 2015 23:48:51 +0100
Christian Borntraeger wrote:
> With all infrastructure in place, lets provide dma_ops for virtio
> devices on s390.
>
> Signed-off-by: Christian Borntraeger
> ---
> drivers/s390/virtio/kvm_virtio.c | 2 ++
> drivers/s390/virtio/virtio_ccw.c | 2 ++
> 2 files
On Thu, 29 Oct 2015 18:09:47 -0700
Andy Lutomirski wrote:
> virtio_ring currently sends the device (usually a hypervisor)
> physical addresses of its I/O buffers. This is okay when DMA
> addresses and physical addresses are the same thing, but this isn't
> always the case. For example, this nev
On Thu, 29 Oct 2015 15:50:38 -0700
Andy Lutomirski wrote:
> Progress! After getting that sort-of-working, I figured out what was
> wrong with my earlier command, and I got that working, too. Now I
> get:
>
> qemu-system-s390x -fsdev
> local,id=virtfs1,path=/,security_model=none,readonly -devic
On Wed, 28 Oct 2015 09:43:34 +0900
Joerg Roedel wrote:
> On Tue, Oct 27, 2015 at 11:48:51PM +0100, Christian Borntraeger wrote:
> > @@ -1093,6 +1094,7 @@ static void virtio_ccw_auto_online(void *data,
> > async_cookie_t cookie)
> > struct ccw_device *cdev = data;
> > int ret;
> >
> > +
cpu->arch.sie_block->prog20);
> + atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
> }
>
> /*
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 15 Sep 2015 18:29:49 +0200
Paolo Bonzini wrote:
> On 15/09/2015 18:13, Cornelia Huck wrote:
> > On Tue, 15 Sep 2015 17:07:55 +0200
> > Paolo Bonzini wrote:
> >
> >> On 15/09/2015 08:41, Jason Wang wrote:
> >>> +With KVM_CAP_FAST_MMIO,
On Tue, 15 Sep 2015 17:07:55 +0200
Paolo Bonzini wrote:
> On 15/09/2015 08:41, Jason Wang wrote:
> > +With KVM_CAP_FAST_MMIO, a zero length mmio eventfd is allowed for
> > +kernel to ignore the length of guest write and get a possible faster
> > +response. Note the speedup may only work on some s
+++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
00 00
> RIP [] ioeventfd_release+0x28/0x60 [kvm]
> RSP
>
> Cc: sta...@vger.kernel.org
> Cc: Gleb Natapov
> Cc: Paolo Bonzini
> Signed-off-by: Jason Wang
> ---
> virt/kvm/eventfd.c | 43 +--
> 1 file changed, 25 insertio
ed-off-by: Jason Wang
> ---
> virt/kvm/eventfd.c | 85
> --
> 1 file changed, 50 insertions(+), 35 deletions(-)
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message
Bonzini
> Signed-off-by: Jason Wang
> ---
> virt/kvm/eventfd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
On Fri, 11 Sep 2015 17:25:45 +0800
Jason Wang wrote:
> On 09/11/2015 03:46 PM, Cornelia Huck wrote:
> > On Fri, 11 Sep 2015 11:17:35 +0800
> > Jason Wang wrote:
> >> +
> >> + /* When length is ignored, MMIO is also put on a separate bus, for
> >> +
On Fri, 11 Sep 2015 10:26:41 +0200
Paolo Bonzini wrote:
> On 11/09/2015 05:17, Jason Wang wrote:
> > + int len = r2->len ? r1->len : 0;
> > +
> > if (r1->addr < r2->addr)
> > return -1;
> > - if (r1->addr + r1->len > r2->addr + r2->len)
> > + if (r1->addr + len > r2->addr +
On Fri, 11 Sep 2015 11:17:35 +0800
Jason Wang wrote:
> We register wildcard mmio eventfd on two buses, one for KVM_MMIO_BUS
> and another is KVM_FAST_MMIO_BUS but with a single iodev
> instance. This will lead an issue: kvm_io_bus_destroy() knows nothing
> about the devices on two buses points to
On Fri, 11 Sep 2015 11:17:34 +0800
Jason Wang wrote:
> This patch factors out core eventfd assign/deassign logic and leave
> the argument checking and bus index selection to callers.
>
> Cc: Gleb Natapov
> Cc: Paolo Bonzini
> Signed-off-by: Jason Wang
> ---
> virt/kvm/eventfd.c | 83
> +
Michael,
here's a bugfix for the virtio-ccw driver.
Question: How would you like to get patches? This one is formatted
against your current linux-next branch; I can prepare a branch for
you to pull from as well.
Pierre Morel (1):
virtio/s390: handle failures of READ_VQ_CONF ccw
drivers/s390/
by: Pierre Morel
Signed-off-by: Cornelia Huck
---
drivers/s390/virtio/virtio_ccw.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
index f8d8fdb..e9fae30 100644
--- a/drivers/s390/virtio/virtio_ccw.c
+++
nges from v1:
> - change ioeventfd_bus_from_flags() to return KVM_FAST_MMIO_BUS when
> needed to save lots of unnecessary changes.
> ---
> virt/kvm/eventfd.c | 31 +--
> virt/kvm/kvm_main.c | 16 ++--
> 2 files changed, 23 insertions(+), 24 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; }
>
> static int
This version of the patch looks nice and compact. Regardless whether
you want to follow my (minor) style suggestions, consider this patch
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 24 Aug 2015 11:29:29 +0800
Jason Wang wrote:
> On 08/21/2015 05:29 PM, Cornelia Huck wrote:
> > On Fri, 21 Aug 2015 16:03:52 +0800
> > Jason Wang wrote:
> >> @@ -850,9 +845,15 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct
> >> kvm_ioeventfd *args)
On Fri, 21 Aug 2015 16:03:52 +0800
Jason Wang wrote:
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index 9ff4193..834a409 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -838,11 +838,6 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct
> kvm_ioeventfd *args)
>
>
> ---
> arch/arm/kvm/Kconfig | 1 +
> arch/arm64/kvm/Kconfig | 1 +
> arch/powerpc/kvm/Kconfig | 1 +
> drivers/net/Kconfig | 1 +
> drivers/vhost/Kconfig| 1 +
> virt/kvm/Kconfig | 3 +++
> 6 files changed, 8 insertions(+)
Acked-by: Cornelia Huck
On Wed, 1 Jul 2015 17:17:41 +0200
Paolo Bonzini wrote:
>
>
> On 01/07/2015 17:15, Cornelia Huck wrote:
> > The s390-specific virtio drivers have probably more to do with virtio
> > than with kvm today; let's move them out into a separate section to
> > re
This more accurately reflects what these drivers actually do.
Suggested-by: Paolo Bonzini
Acked-by: Christian Borntraeger
Signed-off-by: Cornelia Huck
---
MAINTAINERS | 2 +-
drivers/s390/Makefile | 2 +-
drivers/s390/{kvm => virtio}/Makef
The s390-specific virtio drivers have probably more to do with virtio
than with kvm today; let's move them out into a separate section to
reflect this and to be able to add relevant mailing lists.
CC: Christian Borntraeger
Signed-off-by: Cornelia Huck
---
MAINTAINERS | 10 +-
1
On Mon, 27 Apr 2015 13:07:58 +0200
Michael Mueller wrote:
> On Mon, 27 Apr 2015 12:52:54 +0200
> Christian Borntraeger wrote:
>
> > Am 27.04.2015 um 11:43 schrieb Michael Mueller:
> > > On Mon, 27 Apr 2015 10:15:47 +0200
> > > Christian Borntraeger wrote:
> > >
> > >> Am 13.04.2015 um 15:56 s
drivers/vhost/Kconfig | 15
> drivers/vhost/vhost.c | 85
> +++-
> drivers/vhost/vhost.h | 11 +-
> include/uapi/linux/vhost.h | 14 +++
> 4 files changed, 122 insertions(+), 3 deletions(-)
>
Reviewed-by: Cornelia Huck
--
To unsubscribe from th
+-
> drivers/net/tun.c|3 ++-
> drivers/vhost/vhost.h|3 ++-
> include/linux/virtio_byteorder.h | 24 ++--
> include/linux/virtio_config.h|3 ++-
> include/linux/vringh.h | 3 ++-
> 6 files changed, 24 insertions
On Fri, 24 Apr 2015 14:25:12 +0200
Greg Kurz wrote:
> Signed-off-by: Greg Kurz
> ---
> drivers/vhost/vhost.h | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscr
On Fri, 24 Apr 2015 14:24:58 +0200
Greg Kurz wrote:
> Signed-off-by: Greg Kurz
> ---
> include/linux/vringh.h | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kv
On Fri, 24 Apr 2015 14:24:48 +0200
Greg Kurz wrote:
> Signed-off-by: Greg Kurz
> ---
> drivers/net/macvtap.c |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe k
On Fri, 24 Apr 2015 14:24:38 +0200
Greg Kurz wrote:
> Signed-off-by: Greg Kurz
> ---
> drivers/net/tun.c |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
th
ruct virtio_device *vdev)
> +{
> + return virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> +}
> +
While this reads a bit funny in this patch, it will end up correctly at
the end of the series, so
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe k
On Fri, 24 Apr 2015 10:06:19 +0200
Greg Kurz wrote:
> On Fri, 24 Apr 2015 09:19:26 +0200
> Cornelia Huck wrote:
>
> > On Thu, 23 Apr 2015 17:29:42 +0200
> > Greg Kurz wrote:
> > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
>
On Thu, 23 Apr 2015 17:29:42 +0200
Greg Kurz wrote:
> This patch brings cross-endian support to vhost when used to implement
> legacy virtio devices. Since it is a relatively rare situation, the
> feature availability is controlled by a kernel config option (not set
> by default).
>
> The vq->is
On Thu, 23 Apr 2015 21:27:19 +0200
Thomas Huth wrote:
> On Thu, 23 Apr 2015 17:29:06 +0200
> Greg Kurz wrote:
>
> > The current memory accessors logic is:
> > - little endian if little_endian
> > - native endian (i.e. no byteswap) if !little_endian
> >
> > If we want to fully support cross-end
On Tue, 14 Apr 2015 17:13:52 +0200
Greg Kurz wrote:
> On Tue, 14 Apr 2015 16:20:23 +0200
> Cornelia Huck wrote:
>
> > On Fri, 10 Apr 2015 12:19:16 +0200
> > Greg Kurz wrote:
> >
> > > +#ifdef CONFIG_VHOST_SET_ENDIAN_LEGACY
> > > +static voi
On Fri, 10 Apr 2015 12:19:16 +0200
Greg Kurz wrote:
> This patch brings cross-endian support to vhost when used to implement
> legacy virtio devices. Since it is a relatively rare situation, the
> feature availability is controlled by a kernel config option (not set
> by default).
>
> The vq->is
On Tue, 07 Apr 2015 14:19:31 +0200
Greg Kurz wrote:
> This patch brings cross-endian support to vhost when used to implement
> legacy virtio devices. Since it is a relatively rare situation, the
> feature availability is controlled by a kernel config option (not set
> by default).
>
> The ioctls
-
> 1 file changed, 12 insertions(+), 13 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
| 4 +--
> arch/s390/kvm/kvm-s390.c | 10 +++---
> arch/s390/kvm/kvm-s390.h | 26 +---
> arch/s390/kvm/priv.c | 79
> ---
> arch/s390/kvm/sigp.c | 4 +--
> 8 files changed, 93 insertions(+), 58 deletions(-)
Acke
On Mon, 16 Mar 2015 09:51:45 +0100
Christian Borntraeger wrote:
> From: "Jason J. Herne"
>
> Provide the KVM_S390_GET_SKEYS and KVM_S390_SET_SKEYS ioctl which can be used
> to get/set guest storage keys. This functionality is needed for live migration
> of s390 guests that use storage keys.
>
Christian Borntraeger
> ---
> arch/s390/kvm/kvm-s390.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More m
m/gaccess.h | 2 +-
> arch/s390/kvm/priv.c| 4 ++--
> 3 files changed, 9 insertions(+), 8 deletions(-)
Acked-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 16 Mar 2015 09:51:40 +0100
Christian Borntraeger wrote:
> From: Thomas Huth
>
> On s390, we've got to make sure to hold the IPTE lock while accessing
> logical memory. So let's add an ioctl for reading and writing logical
> memory to provide this feature for userspace, too.
> The maximu
On Mon, 09 Mar 2015 17:43:19 +1030
Rusty Russell wrote:
> "Michael S. Tsirkin" writes:
> > virtio-balloon: do not call blocking ops when !TASK_RUNNING
> >
> > Rusty, it seems you prefer a different fix for this issue,
> > while Cornelia prefers mine. Maybe both me and Cornelia misunderstand
On Wed, 4 Mar 2015 11:25:56 +0100
"Michael S. Tsirkin" wrote:
> On Wed, Mar 04, 2015 at 04:44:54PM +1030, Rusty Russell wrote:
> > "Michael S. Tsirkin" writes:
> > > On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote:
> > >> Thomas Huth writes:
> > >> > On Thu, 26 Feb 2015 11:50:42 +
On Mon, 2 Mar 2015 21:44:10 +0100
"Michael S. Tsirkin" wrote:
> > > Normally, hotunplug requires guest cooperation.
> > > IOW unplug request should send guest interrupt,
> > > then block until guest confirms it's not using the
> > > device anymore.
> > > virtio pci already handles that fine, can
On Mon, 2 Mar 2015 13:19:43 +0100
"Michael S. Tsirkin" wrote:
> On Mon, Mar 02, 2015 at 01:11:02PM +0100, Cornelia Huck wrote:
> > On Mon, 2 Mar 2015 12:46:57 +0100
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Mar 02, 2015 at 12:31:06PM
On Mon, 2 Mar 2015 12:46:57 +0100
"Michael S. Tsirkin" wrote:
> On Mon, Mar 02, 2015 at 12:31:06PM +0100, Cornelia Huck wrote:
> > On Mon, 2 Mar 2015 12:13:58 +0100
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Mar 02, 2015 at 10:37:26
On Mon, 2 Mar 2015 12:43:43 +0100
"Michael S. Tsirkin" wrote:
> On Wed, Feb 25, 2015 at 02:50:22PM +1030, Rusty Russell wrote:
> > OK, I am trying to experiment with virtio 1.0 support using the
> > latest kernel and MST's qemu tree:
> >
> > https://git.kernel.org/cgit/virt/kvm/mst/qemu.
On Mon, 2 Mar 2015 12:13:58 +0100
"Michael S. Tsirkin" wrote:
> On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote:
> > Thomas Huth writes:
> > > On Thu, 26 Feb 2015 11:50:42 +1030
> > > Rusty Russell wrote:
> > >
> > >> Thomas Huth writes:
> > >> > Hi all,
> > >> >
> > >> > with t
On Thu, 26 Feb 2015 09:45:29 +0100
"Michael S. Tsirkin" wrote:
> On Thu, Feb 26, 2015 at 11:50:42AM +1030, Rusty Russell wrote:
> > Thomas Huth writes:
> > > Hi all,
> > >
> > > with the recent kernel 3.19, I get a kernel warning when I start my
> > > KVM guest on s390 with virtio balloon enabl
On Thu, 26 Feb 2015 11:50:42 +1030
Rusty Russell wrote:
> Thomas Huth writes:
> > Hi all,
> >
> > with the recent kernel 3.19, I get a kernel warning when I start my
> > KVM guest on s390 with virtio balloon enabled:
>
> The deeper problem is that virtio_ccw_get_config just silently fails on
>
woken.
>
> Cc: sta...@vger.kernel.org
> Reported-by: Thomas Huth
> Signed-off-by: Michael S. Tsirkin
> ---
>
> changes from v1:
> remove wait_event_interruptible
> noticed by Cornelia Huck
>
> drivers/virtio/virtio_balloon.c | 19 ++-
On Wed, 25 Feb 2015 15:14:36 +0100
"Michael S. Tsirkin" wrote:
> virtio balloon has this code:
> wait_event_interruptible(vb->config_change,
> (diff = towards_target(vb)) != 0
> || vb->need_stats_update
>
On Wed, 25 Feb 2015 14:50:22 +1030
Rusty Russell wrote:
> OK, I am trying to experiment with virtio 1.0 support using the
> latest kernel and MST's qemu tree:
>
> https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0
>
> The first issue is that the device config endian was wro
On Wed, 25 Feb 2015 11:13:18 +0100
Thomas Huth wrote:
>
> Hi all,
>
> with the recent kernel 3.19, I get a kernel warning when I start my
> KVM guest on s390 with virtio balloon enabled:
>
> [0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at
>[<
On Mon, 16 Feb 2015 13:16:41 +0100
Thomas Huth wrote:
> On s390, we've got to make sure to hold the IPTE lock while accessing
> logical memory. So let's add an ioctl for reading and writing logical
> memory to provide this feature for userspace, too.
>
> Signed-off-by: Thomas Huth
> ---
> Docu
On Wed, 04 Feb 2015 09:26:11 +0100
Christian Borntraeger wrote:
> the classic channel I/O does set the storage key change/reference and
> also triggers errors in the storage key protection value mismatches.
Just a bit of background for the benefit of innocent bystanders:
When classic channel I/
On Tue, 2 Dec 2014 14:00:26 +0100
Cornelia Huck wrote:
> Devices may support different sets of feature bits depending on which
> revision they're operating at. Let's give the transport a way to
> re-query the device about its features when the revision has been
> chang
On Tue, 2 Dec 2014 14:00:13 +0100
Cornelia Huck wrote:
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 070006c..23d713b 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -51,6 +51,17 @@ exte
On Tue, 9 Dec 2014 15:46:46 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote:
> > virtio-ccw should now have everything in place to operate virtio 1.0
> > devices, so let's enable revision 1.
> >
> > Sig
On Thu, 4 Dec 2014 18:20:05 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote:
> > From: Thomas Huth
> >
> > Handle the virtio-ccw revision according to what the guest sets.
> > When revision 1 is selecte
On Wed, 3 Dec 2014 13:19:17 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote:
> > On Wed, 3 Dec 2014 12:52:51 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Dec 03, 2014 at 10:50:0
On Wed, 3 Dec 2014 12:52:51 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote:
> > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
> > index 43b7e02..1e2a720 100644
> > --- a/hw/virtio/virtio-mmio.c
&g
On Wed, 3 Dec 2014 10:27:36 +0100
Cornelia Huck wrote:
> On Tue, 2 Dec 2014 21:03:45 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote:
> > > void virtio_queue_set_num(
On Tue, 2 Dec 2014 21:03:45 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote:
> > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num)
> > {
> > +/*
> > + * For virtio-1 devic
On Tue, 2 Dec 2014 15:54:44 +0100
Cornelia Huck wrote:
> On Tue, 2 Dec 2014 16:46:28 +0200
> "Michael S. Tsirkin" wrote:
> > pa == -1ULL tricks look quite ugly.
> > Can't we set desc/avail/used unconditionally, and drop
> > the pa value?
>
> And
On Tue, 2 Dec 2014 16:46:28 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Dec 02, 2014 at 02:00:15PM +0100, Cornelia Huck wrote:
> > For virtio-1 devices, we allow a more complex queue layout that doesn't
> > require descriptor table and rings on a physically-
virtio-ccw should now have everything in place to operate virtio 1.0
devices, so let's enable revision 1.
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h
index fe
Convert existing code manipulating features to use the new helpers.
Signed-off-by: Cornelia Huck
---
hw/9pfs/virtio-9p-device.c |2 +-
hw/block/virtio-blk.c | 16
hw/char/virtio-serial-bus.c |2 +-
hw/net/virtio-net.c | 34
Handle endianness conversion for virtio-1 virtqueues correctly.
Note that dataplane now needs to be built per-target.
Signed-off-by: Cornelia Huck
---
hw/block/dataplane/virtio-blk.c |4 +-
hw/scsi/virtio-scsi-dataplane.c |2 +-
hw/virtio/Makefile.objs
Devices operating as virtio 1.0 may not allow writes to the mac
address in config space.
Signed-off-by: Cornelia Huck
---
hw/net/virtio-net.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index d6d1b98..ebbea60 100644
--- a/hw/net/virtio-net.c
Support the new CCW_CMD_SET_VQ format for virtio-1 devices.
While we're at it, refactor the code a bit and enforce big endian
fields (which had always been required, even for legacy).
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c |
From: Thomas Huth
We need a possibility to run code when a subchannel gets disabled.
This patch adds the necessary infrastructure.
Signed-off-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/s390x/css.c | 12
hw/s390x/css.h |1 +
2 files changed, 13 insertions(+)
diff
virtio-1 allow setting of the FEATURES_OK status bit to fail if
the negotiated feature bits are inconsistent: let's fail
virtio_set_status() in that case and update virtio-ccw to post an
error to the guest.
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c |
From: Thomas Huth
Add the new VIRTIO_F_VERSION_1 definition to the virtio_config.h
linux header.
Signed-off-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
linux-headers/linux/virtio_config.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-headers/linux/virtio_config.h
b
does not negotiate the revision 1
anymore (e.g. the boot firmware uses revision 1, but the operating
system only uses the legacy mode).
Note that revisions > 0 are still disabled.
Signed-off-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c |
Add a helper function for checking whether a bit is set in the guest
features for a vdev as well as one that works on a feature bit set.
Convert code that open-coded this: It cleans up the code and makes it
easier to extend the guest feature bits.
Signed-off-by: Cornelia Huck
---
hw/block
The only user of this function was virtio-ccw, and it should use
virtio_set_features() like everybody else: We need to make sure
that bad features are masked out properly, which this function did
not do.
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c
With virtio-1, we support more than 32 feature bits. Let's extend both
host and guest features to 64, which should suffice for a while.
vhost and migration have been ignored for now.
Signed-off-by: Cornelia Huck
---
hw/9pfs/virtio-9p-device.c |2 +-
hw/block/virtio-
For virtio-1 devices, we allow a more complex queue layout that doesn't
require descriptor table and rings on a physically-contigous memory area:
add virtio_queue_set_rings() to allow transports to set this up.
Signed-off-by: Cornelia Huck
---
hw/virtio/virtio.c |
1 - 100 of 671 matches
Mail list logo
