Hello Christoffer,
On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall
wrote:
> On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote:
>> On 07/24/2015 08:00 AM, Matt Ma wrote:
>> > Hi all,
>> >
>> > Linaro has developed the foundation for the new Android Emulator code
>> > base bas
From: Asias He
Enable virtio-vsock and vhost-vsock.
Signed-off-by: Asias He
---
drivers/vhost/Kconfig | 4
drivers/vhost/Kconfig.vsock | 7 +++
drivers/vhost/Makefile | 5 +
net/vmw_vsock/Kconfig | 18 ++
net/vmw_vsock/Makefile | 4
ill suffer.
The controlq is used to control device. Currently, no control operation is
defined.
Asias He (7):
VSOCK: Introduce vsock_find_unbound_socket and
vsock_bind_dgram_generic
VSOCK: Add dgram_skb to vsock_sock
VSOCK: Introduce virtio-vsock-common.ko
VSOCK: Introduce virtio-vs
From: Asias He
Signed-off-by: Asias He
---
include/net/af_vsock.h | 2 ++
net/vmw_vsock/af_vsock.c | 70
2 files changed, 72 insertions(+)
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 7d64d36..88f559a 100644
--- a
From: Asias He
Signed-off-by: Asias He
---
include/net/af_vsock.h | 1 +
net/vmw_vsock/af_vsock.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 88f559a..ef668a0 100644
--- a/include/net/af_vsock.h
+++ b/include/net/af_vsock.h
From: Asias He
VM sockets virtio transport implementation. This module runs in guest
kernel.
Signed-off-by: Asias He
---
net/vmw_vsock/virtio_transport.c | 448 +++
1 file changed, 448 insertions(+)
create mode 100644 net/vmw_vsock/virtio_transport.c
diff
From: Asias He
Signed-off-by: Asias He
---
drivers/vhost/Makefile | 1 -
net/vmw_vsock/Makefile | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/vhost/Makefile b/drivers/vhost/Makefile
index eccff51..6b012b9 100644
--- a/drivers/vhost/Makefile
+++ b/drivers/vhost/Makefile
@@ -6,7
From: Asias He
VM sockets vhost transport implementation. This module runs in host
kernel.
Signed-off-by: Asias He
---
drivers/vhost/vsock.c | 572 ++
drivers/vhost/vsock.h | 4 +
2 files changed, 576 insertions(+)
create mode 100644 drivers
From: Asias He
This module contains the common code and header files for the following
virtio-vsock and virtio-vhost kernel modules.
Signed-off-by: Asias He
---
include/linux/virtio_vsock.h | 207
include/uapi/linux/virtio_ids.h|1
. Only iovec size is copied and in the next
>> run isn't place to copy the rest of len size.
>>
>> So solution may be increase dst iovec size or send data in dst iovec
>> to user (but i don't know how, I am not virtio expert :-)).
>
>
> I'm CC'ing Asias, Sasha and others.
Hell
vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
unregistered. We will have a use-after-free usage when the notifier
callback is called after virtscsi_freeze.
Signed-off-by: Asias He
---
drivers/scsi/virtio_scsi.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion
irtio-scsi DMA_TO_DEVICE -> WRITE payload case.
>
> This bug would manifest itself as random process segmentation faults on
> KVM host after repeated vhost starts + stops and/or with lots of vhost
> endpoints + LUNs.
>
> Cc: Stefan Hajnoczi
> Cc: Michael S. Tsirkin
On Mon, Oct 14, 2013 at 7:14 PM, Stefan Hajnoczi wrote:
>
> On Wed, Jul 24, 2013 at 2:50 PM, Anthony Liguori
> wrote:
> >
> > I will be hosting a key signing party at this year's KVM Forum.
> >
> > http://wiki.qemu.org/KeySigningParty2013
>
> keyserver.cryptnet.net seems broken. I get connectio
;flag it works fine.
> >
> >Am I using it incorrectly?
>
> Virtio console should work but I wonder if your guest kernel
> is too old. Sasha, Asias?
>
> Pekka
Did you start a getty program in your guest for virtio console?
commit 2a
works.
> >>
> >>I have also tried kernels 3.0.99, 3.4.65 an 3.10.15, but they seem to
> >>fail the same way.
> >>
> >>Am I using it correctly?
> >
> >Asias, Sasha, is mmio transport supported by virtio networking?
>
> It should be.
r->buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at
most. If more than 256 luns are specified by user, we have buffer
overflow in scsi_target_emulate_report_luns.
To fix, we allocate the buffer dynamically.
Signed-off-by: Asias He
Tested-by: Michael Roth
---
Changes in
r->buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at
most. If more than 256 luns are specified by user, we have buffer
overflow in scsi_target_emulate_report_luns.
To fix, we allocate the buffer dynamically.
Signed-off-by: Asias He
---
hw/scsi/scsi-bus.c |
AT
> to kzalloc() flags to do this fallback only when really needed.
>
> Reported-by: Dan Aloni
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Asias He
> ---
>
> I put this on my vhost fixes branch, intend to merge for 3.12.
> Dan, could you please confirm this works f
memcpy_fromiovec is moved from net/core/iovec.c to lib/iovec.c.
linux/uio.h provides the declaration for memcpy_fromiovec.
Include linux/uio.h instead of inux/socket.h for it.
Signed-off-by: Asias He
---
drivers/vhost/vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote:
> From: Asias He
> Date: Fri, 16 Aug 2013 09:27:43 +0800
>
> > On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
> >> From: Asias He
> >> Date: Thu, 15 Aug 2013 11:20:16 +0800
> >>
On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
> From: Asias He
> Date: Thu, 15 Aug 2013 11:20:16 +0800
>
> > memcpy_fromiovec is moved to lib/iovec.c. No need to include
> > linux/socket.h for it.
> >
> > Signed-off-by: Asias He
>
> Yo
memcpy_fromiovec is moved to lib/iovec.c. No need to include
linux/socket.h for it.
Signed-off-by: Asias He
---
drivers/vhost/vhost.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e58cf00..038c242 100644
--- a/drivers/vhost/vhost.c
+++ b
TIF_NEED_RESCHED task flag is set, wake up any vhost_work_flush()
> > >>waiters before rescheduling instead of after rescheduling.
> > >>
> > >>Signed-off-by: Bart Van Assche
> > >>Cc: Michael S. Tsirkin
> > >>Cc: Asias He
> > >
gt; 8b 47 20 48 8b 80 d0 01 00 00 48 8b 40 50 48 85 c0 74 07 be
RIP [] __virtscsi_set_affinity+0x6f/0x120
RSP
CR2: 0020
---[ end trace 99679331a3775f48 ]---
CC: sta...@vger.kernel.org
Signed-off-by: Asias He
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file changed, 1 insertion(+)
On Sun, Jul 07, 2013 at 05:40:51PM +0300, Michael S. Tsirkin wrote:
> On Sun, Jul 07, 2013 at 02:37:10PM +0300, Michael S. Tsirkin wrote:
> > On Mon, May 06, 2013 at 08:10:03PM +0800, Asias He wrote:
> > > On Mon, May 06, 2013 at 01:03:42PM +0300, Michael S. Tsirkin wrote:
>
Hi David,
On Fri, Jun 28, 2013 at 09:32:25PM -0700, David Miller wrote:
> From: Asias He
> Date: Thu, 27 Jun 2013 16:00:01 +0800
>
> > +static void
> > +virtio_transport_recv_dgram(struct sock *sk,
> > + struct virtio_vsock_pkt *pkt)
> ...
On Thu, Jun 27, 2013 at 01:42:46PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 27, 2013 at 04:00:03PM +0800, Asias He wrote:
> > VM sockets vhost transport implementation. This module runs in host
> > kernel.
> >
> > Signed-off-by: Asias He
>
> Has any thoug
On Thu, Jun 27, 2013 at 01:34:30PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 27, 2013 at 04:00:01PM +0800, Asias He wrote:
> > This module contains the common code and header files for the following
> > virtio-vsock and virtio-vhost kernel modules.
> >
> &
On Thu, Jun 27, 2013 at 03:03:01PM -0400, Sasha Levin wrote:
> Hi Asias,
>
> Looks nice! Some comments inline below (I've removed anything that mst already
> commented on).
Thanks.
> On 06/27/2013 03:59 AM, Asias He wrote:
> >Hello guys,
> >
> >In commi
On Thu, Jun 27, 2013 at 01:23:24PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 27, 2013 at 03:59:59PM +0800, Asias He wrote:
> > Hello guys,
> >
> > In commit d021c344051af91 (VSOCK: Introduce VM Sockets), VMware added VM
> > Sockets support. VM Sockets allows co
On Thu, Jun 27, 2013 at 07:25:40PM -0700, Andy King wrote:
> Hi Michael,
>
> > >__u32 guest_cid;
> >
> > Given that cid is like an IP address, 32 bit seems too
> > limiting. I would go for a 64 bit one or maybe even 128 bit,
> > so that e.g. GUIDs can be used there.
>
> That's likely
VM sockets vhost transport implementation. This module runs in host
kernel.
Signed-off-by: Asias He
---
drivers/vhost/vsock.c | 534 ++
drivers/vhost/vsock.h | 4 +
2 files changed, 538 insertions(+)
create mode 100644 drivers/vhost/vsock.c
VM sockets virtio transport implementation. This module runs in guest
kernel.
Signed-off-by: Asias He
---
net/vmw_vsock/virtio_transport.c | 424 +++
1 file changed, 424 insertions(+)
create mode 100644 net/vmw_vsock/virtio_transport.c
diff --git a/net
Enable virtio-vsock and vhost-vsock.
Signed-off-by: Asias He
---
drivers/vhost/Kconfig | 4
drivers/vhost/Kconfig.vsock | 7 +++
drivers/vhost/Makefile | 5 +
net/vmw_vsock/Kconfig | 18 ++
net/vmw_vsock/Makefile | 4
5 files changed
if it runs out, the performance will suffer.
The controlq is used to control device. Currently, no control operation is
defined.
Asias He (5):
VSOCK: Introduce vsock_find_unbound_socket and
vsock_bind_dgram_generic
VSOCK: Introduce virtio-vsock-common.ko
VSOCK: Introduce virtio-vsock.k
Signed-off-by: Asias He
---
net/vmw_vsock/af_vsock.c | 70
net/vmw_vsock/af_vsock.h | 2 ++
2 files changed, 72 insertions(+)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 593071d..bc76ddb 100644
--- a/net/vmw_vsock
This module contains the common code and header files for the following
virtio-vsock and virtio-vhost kernel modules.
Signed-off-by: Asias He
---
include/linux/virtio_vsock.h| 200 +++
include/uapi/linux/virtio_ids.h | 1 +
include/uapi/linux/virtio_vsock.h | 70
r passing it
> to vhost_net_ubuf_put_and_wait, this results
> in use after free.
> To fix, don't free the argument in vhost_net_ubuf_put_and_wait,
> add an new API for callers that want to free ubufs.
>
> Signed-off-by: Michael S. Tsirkin
Acked-by: Asias He
> ---
>
> D
On Fri, Jun 7, 2013 at 9:50 PM, Qin Chuanyu wrote:
> the wake_up_process func is included by spin_lock/unlock in
> vhost_work_queue,
> but it could be done outside the spin_lock.
> I have test it with kernel 3.0.27 and guest suse11-sp2 using iperf,
> the num as below.
> original
On Fri, Jun 07, 2013 at 08:20:33PM +0800, Asias He wrote:
> On Fri, Jun 07, 2013 at 02:06:40PM +0300, Pekka Enberg wrote:
> > On 06/07/2013 11:17 AM, Asias He wrote:
> > >>Ping! Is there someone out there who has a AMD box they could test this
> > >>on?
> >
On Fri, Jun 07, 2013 at 02:06:40PM +0300, Pekka Enberg wrote:
> On 06/07/2013 11:17 AM, Asias He wrote:
> >>Ping! Is there someone out there who has a AMD box they could test this on?
> >
> >I tested it on AMD box. Guest boots with this patch, guest does not
> >boo
unhandled rdmsr: 0xc0010048
>> | [1709265.397161] kvm: 25706: cpu7 unhandled rdmsr: 0xc0010048
>> | [1709265.425774] kvm: 25706: cpu8 unhandled rdmsr: 0xc0010048
>>
>> thus provide own string and kernel will use generic cpu init.
>>
>> Reported-by: Ingo Molnar
>> CC: Pekka
unhandled rdmsr: 0xc0010048
>> | [1709265.397161] kvm: 25706: cpu7 unhandled rdmsr: 0xc0010048
>> | [1709265.425774] kvm: 25706: cpu8 unhandled rdmsr: 0xc0010048
>>
>> thus provide own string and kernel will use generic cpu init.
>>
>> Reported-by: Ingo Molnar
>> CC: Pekka
9:6: warning: symbol 'tcm_vhost_done_inflight' was not
declared. Should it be static?
Signed-off-by: Asias He
---
drivers/vhost/net.c | 4 ++--
drivers/vhost/scsi.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 05bdc3c..f800
by: Wenchao Xia
Acked-by: Asias He
BTW, It would be nice to print more informative info in qemu when wwpn
is not available as well.
> ---
> drivers/vhost/scsi.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/s
Levin
>> Cc: Will Deacon
>> Signed-off-by: Marc Zyngier
Acked-by: Asias He
>> ---
>> tools/kvm/virtio/mmio.c | 7 ++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/kvm/virtio/mmio.c b/tools/kvm/virtio/mmio.c
>>
On Thu, May 23, 2013 at 10:30:00AM +0300, Pekka Enberg wrote:
> Hello,
>
> On 04/15/2013 10:11 AM, Lin Ming wrote:
> >On Mon, Apr 15, 2013 at 2:48 PM, Pekka Enberg wrote:
> >>Hello,
> >
> >Hi,
> >
> >>
> >>On Mon, Apr 15, 2013 at 5:27 AM, Lin Ming wrote:
> >>>Will BIOS support be added in kvmtoo
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote:
> Asias He writes:
> > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
> >> Asias He writes:
> >> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >> >
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote:
> "Nicholas A. Bellinger" writes:
> > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
> >> Asias He writes:
> >> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
> Asias He writes:
> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >
> > This patch fixes this build failure.
> >
> >From Randy Dunlap:
> >'''
> >on
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote:
> On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
> > Asias He writes:
> > > scsi.c includes vhost.c which uses memcpy_fromiovec.
> > >
> > > This patch fixes this build failu
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote:
> On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote:
> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >
> > This patch fixes this build failure.
> >
> >From Randy Du
tion.
'''
Reported-by: Randy Dunlap
Signed-off-by: Asias He
---
drivers/vhost/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
index 8b9226d..0403323 100644
--- a/drivers/vhost/Kconfig
+++ b/drivers/vhost/Kc
On Wed, May 08, 2013 at 10:56:19AM +0300, Michael S. Tsirkin wrote:
> On Wed, May 08, 2013 at 03:24:33PM +0800, Asias He wrote:
> > Fix it by switching to use the new device specific fields per vq
> >
> > Signed-off-by: Asias He
> > ---
> >
> > This is f
On Wed, May 08, 2013 at 10:59:03AM +0300, Michael S. Tsirkin wrote:
> On Wed, May 08, 2013 at 03:14:58PM +0800, Asias He wrote:
> > On Tue, May 07, 2013 at 02:22:32PM +0300, Michael S. Tsirkin wrote:
> > > On Tue, May 07, 2013 at 02:52:45PM +0800, Asias He wrote:
> >
Fix it by switching to use the new device specific fields per vq
Signed-off-by: Asias He
---
This is for 3.10.
drivers/vhost/test.c | 35 ---
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
index
On Tue, May 07, 2013 at 02:22:32PM +0300, Michael S. Tsirkin wrote:
> On Tue, May 07, 2013 at 02:52:45PM +0800, Asias He wrote:
> > Fix it by:
> > 1) switching to use the new device specific fields per vq
> > 2) not including vhost.c, instead make vhost-test.ko depend on
8 c2 75 f7 48 83
c4 08 5b c9 c3 55 48 89 e5 66 66 66 66 90 b8 00 01 00 00 66 0f c1 07 89 c2
66 c1 ea 08 38 c2 74 0c 0f 1f 00 f3 90 0f
RIP [] _raw_spin_lock+0xe/0x30
RSP
CR2:
---[ end trace 13fb1e4b6e5ab21f ]---
Signed-off-by: Asias He
---
virt/kvm/kvm_main.c | 18 +++
On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote:
> On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote:
> > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when
> > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko),
8 c2 75 f7 48 83
c4 08 5b c9 c3 55 48 89 e5 66 66 66 66 90 b8 00 01 00 00 66 0f c1 07 89 c2
66 c1 ea 08 38 c2 74 0c 0f 1f 00 f3 90 0f
RIP [] _raw_spin_lock+0xe/0x30
RSP
CR2:
---[ end trace 13fb1e4b6e5ab21f ]---
Signed-off-by: Asias He
---
virt/kvm/kvm_main.c | 11 ++---
te:
> > >
> > > > On Tue, May 07, 2013 at 05:10:41PM +0800, Asias He wrote:
> > > > > On Tue, May 07, 2013 at 11:42:07AM +0300, Gleb Natapov wrote:
> > > > > > On Tue, May 07, 2013 at 04:36:50PM +0800, Asias He wrote:
> > > > >
On Tue, May 07, 2013 at 11:42:07AM +0300, Gleb Natapov wrote:
> On Tue, May 07, 2013 at 04:36:50PM +0800, Asias He wrote:
> > On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
> > > On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
> > > > On T
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
> On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
> > On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
> > > On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
> > > > Hi,
>
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
> On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
> > On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
> > > On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
> > > > Hi,
>
On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
> On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
> > Hi,
> >
> > I am seeing this with linus/master. Any ideas?
> >
> How reproducible it this? What HEAD are you seeing this with?
Almost al
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 5531ebc..d78768b 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -896,19 +896,15
Now, vq->private_data is always accessed under vq mutex. No need to play
the vhost rcu trick.
Signed-off-by: Asias He
---
drivers/vhost/net.c | 16 ++--
drivers/vhost/scsi.c | 6 ++
drivers/vhost/test.c | 11 ---
drivers/vhost/vhost.h | 10 ++
4 fi
Signed-off-by: Asias He
---
drivers/vhost/test.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
index dc526eb..435b911 100644
--- a/drivers/vhost/test.c
+++ b/drivers/vhost/test.c
@@ -48,11 +48,12 @@ static void handle_vq
Signed-off-by: Asias He
---
drivers/vhost/net.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 2b51e23..b616d9a 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -349,12 +349,11 @@ static
Asias He (4):
vhost-net: Always access vq->private_data under vq mutex
vhost-test: Always access vq->private_data under vq mutex
vhost-scsi: Always access vq->private_data under vq mutex
vhost: Remove custom vhost rcu usage
drivers/vhost/net
Fix it by:
1) switching to use the new device specific fields per vq
2) not including vhost.c, instead make vhost-test.ko depend on vhost.ko.
---
drivers/vhost/test.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/drivers/vhost/test.c b/
It is disabled as a workaround. Now userspace bits works fine with it.
So, let's enable it.
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d860b58..5531ebc 100644
Hi,
I am seeing this with linus/master. Any ideas?
[ 34.168356] IPv6: ADDRCONF(NETDEV_UP): virbr0: link is not ready
[ 36.743758] BUG: unable to handle kernel paging request at 00030029
[ 36.745177] IP: [] __mutex_lock_slowpath+0x34/0x240
[ 36.746576] PGD 0
[ 36.747962] Oops: 0
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote:
> There's no net specific code in vhost.c anymore,
> don't include the virtio_net.h header.
Did you push the it to your tree. I am not seeing it.
> Signed-off-by: Michael S. Tsirkin
> ---
>
> This is on top of Asias' patches, a
On Mon, May 06, 2013 at 04:15:35PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 06, 2013 at 08:05:26PM +0800, Asias He wrote:
> > On Mon, May 06, 2013 at 01:07:46PM +0300, Michael S. Tsirkin wrote:
> > > On Mon, May 06, 2013 at 04:38:18PM +0800, Asias He wrote:
> > &g
On Mon, May 06, 2013 at 01:03:42PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 06, 2013 at 04:38:21PM +0800, Asias He wrote:
> > Currently, vhost-net and vhost-scsi are sharing the vhost core code.
> > However, vhost-scsi shares the code by including the vhost.c fi
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote:
> There's no net specific code in vhost.c anymore,
> don't include the virtio_net.h header.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Asias He
> ---
>
> This is on top of Asias' p
On Mon, May 06, 2013 at 01:07:46PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 06, 2013 at 04:38:18PM +0800, Asias He wrote:
> > MST, This is on top of [PATCH 0/2] vhost-net fix ubuf.
>
> Okay, how about making EVENT_IDX work for virtio-scsi?
> I'm guessing it
This way, we use cmd for struct tcm_vhost_cmd and evt for struct
tcm_vhost_cmd.
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 142 +--
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 154 +--
1 file changed, 88 insertions(+), 66 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d4798e1..d9781ed 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 122 +--
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d9781ed..353145f 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost
vs is used everywhere, make the naming more consistent.
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 56 ++--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 02ddedd..d4798e1
- Rename vhost_ubuf to vhost_net_ubuf
- Rename vhost_zcopy_mask to vhost_net_zcopy_mask
- Make funcs static
Signed-off-by: Asias He
---
drivers/vhost/net.c | 58 +++--
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git a/drivers/vhost
It was needed when struct tcm_vhost_tpg is in tcm_vhost.h
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 2dcb94a..02ddedd 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -115,7
Signed-off-by: Asias He
---
drivers/vhost/vhost.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e406d5f..74bc779 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
It is supposed to be removed when hdr is moved into vhost_net_virtqueue.
Signed-off-by: Asias He
---
drivers/vhost/vhost.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 94a80eb..51aeb5f 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers
Currently, vhost-net and vhost-scsi are sharing the vhost core code.
However, vhost-scsi shares the code by including the vhost.c file
directly.
Making vhost a separate module makes it is easier to share code with
other vhost devices.
Signed-off-by: Asias He
---
drivers/vhost/Kconfig | 8
It is net.c specific.
Signed-off-by: Asias He
---
drivers/vhost/vhost.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index cc23bc4..076c9ac 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -192,7 +192,4 @@ static inline int
vhost.h should not depend on device specific marcos like
VHOST_NET_F_VIRTIO_NET_HDR and VIRTIO_NET_F_MRG_RXBUF.
Signed-off-by: Asias He
---
drivers/vhost/net.c | 6 ++
drivers/vhost/vhost.h | 3 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/net.c b
MST, This is on top of [PATCH 0/2] vhost-net fix ubuf.
Asias He (11):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
vhost: Remove comments for hdr in vhost.h
vhost: Simplify dev->vqs[i] access
vhost-net: Clea
On Mon, May 6, 2013 at 4:17 PM, Michael S. Tsirkin wrote:
> Typo a/adn/and/
Yes. Catched this up and and fixed already.
>
> On Fri, May 03, 2013 at 02:25:18PM +0800, Asias He wrote:
>> - Rename vhost_ubuf to vhost_net_ubuf
>> - Rename vhost_zcopy_mask to vhost_net_zcopy
Hello Rusty,
On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote:
> Asias He writes:
> > Asias He (3):
> > vhost: Remove vhost_enable_zcopy in vhost.h
> > vhost: Move VHOST_NET_FEATURES to net.c
> > vhost: Make vhost a separate module
>
> I
On Sun, May 05, 2013 at 04:50:07PM +0300, Michael S. Tsirkin wrote:
> On Fri, May 03, 2013 at 02:25:17PM +0800, Asias He wrote:
> > Free ubuf when vhost_dev_ioctl for VHOST_SET_OWNER fails.
> >
> > Signed-off-by: Asias He
> > ---
> > drivers/vhost/net.c | 20
Signed-off-by: Asias He
---
drivers/vhost/net.c | 38 --
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index a3645bd..354665a 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -146,6
Signed-off-by: Asias He
---
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 749b5ab..de9441a 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -344,7
Asias He (2):
vhost: Export vhost_dev_set_owner
vhost-net: Free ubuf when vhost_dev_set_owner fails
drivers/vhost/net.c | 38 --
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 1 +
3 files changed, 34 insertions(+), 7 deletions(-)
--
1.8.1.4
On Fri, May 3, 2013 at 5:19 PM, Pekka Enberg wrote:
> On Wed, May 1, 2013 at 6:50 PM, Will Deacon wrote:
>> From: Marc Zyngier
>>
>> Kvmtool suppresses any output to a console that has not been elected
>> as *the* console.
>>
>> While this makes sense on the input side (we want the input to be s
This way, we use cmd for struct tcm_vhost_cmd and evt for struct
tcm_vhost_cmd.
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 142 +--
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 122 +--
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d9781ed..353145f 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost
It was needed when struct tcm_vhost_tpg is in tcm_vhost.h
Signed-off-by: Asias He
---
drivers/vhost/scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 2dcb94a..02ddedd 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -115,7
1 - 100 of 810 matches
Mail list logo
