[PATCH 2/5] tools lib traceevent: update KVM plugin

2015-10-21 Thread Arnaldo Carvalho de Melo
://lkml.kernel.org/r/1443695293-31127-1-git-send-email-pbonz...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/plugin_kvm.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/tools/lib/traceevent/plugin_kvm.c b/tools/lib/traceevent

[GIT PULL 0/5] perf/core improvements and fixes

2015-10-21 Thread Arnaldo Carvalho de Melo
ned-off-by: Arnaldo Carvalho de Melo Andi Kleen (1): perf evsel: Print branch filter state with -vv Arnaldo Carvalho de Melo (1): perf annotate: Add debug message for out of bounds sample Kan Liang (1): perf cpu_map

[PATCH 2/4] tools lib traceevent: update KVM plugin

2015-10-20 Thread Arnaldo Carvalho de Melo
://lkml.kernel.org/r/1443695293-31127-1-git-send-email-pbonz...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/plugin_kvm.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/tools/lib/traceevent/plugin_kvm.c b/tools/lib/traceevent

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 05:49:22PM +0200, Paolo Bonzini escreveu: > > > On 20/10/2015 17:48, Steven Rostedt wrote: > > On Tue, 20 Oct 2015 17:37:43 +0200 > > Paolo Bonzini wrote: > > > >> However, it frankly seems a bit academic. The parsing _will_ work, > >> apart from printing a nonsensical

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 10:10:13PM +0200, Paolo Bonzini escreveu: > On 01/10/2015 12:28, Paolo Bonzini wrote: > > The format of the role word has changed through the years and the > > plugin was never updated; some VMX exit reasons were missing too. > > > > Signed-off-by: Paolo Bonzini > > --- >

[GIT PULL 00/33] perf/core improvements and fixes

2014-08-04 Thread Arnaldo Carvalho de Melo
d even then the specified workload ends up running (Arnaldo Carvalho de Melo) . Do not ignore mmap events in 'perf kmem report'. This tool was using the kernel mmaps in the running machine instead of processing the mmap records from the perf.data file. (Namhyung Kim) . Properly show subm

[PATCH 04/33] perf kvm stat: Properly show submicrosecond times

2014-08-04 Thread Arnaldo Carvalho de Melo
@vger.kernel.org Link: http://lkml.kernel.org/r/1406805231-10675-2-git-send-email-borntrae...@de.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index

Re: [PATCH/RFC] KVM: perf/stat: Properly show submicrosecond times

2014-07-31 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 31, 2014 at 08:24:03AM -0600, David Ahern escreveu: > On 7/31/14, 5:13 AM, Christian Borntraeger wrote: > >For lots of exits the min time (and sometimes max) is 0 or 1. Lets > >increase the accurancy similar to what the average field alread does. > > Seems reasonable to me. > > Acked-

[PATCH 05/30] KVM: x86: Export svm/vmx exit code and vector code to userspace

2012-09-24 Thread Arnaldo Carvalho de Melo
: kvm@vger.kernel.org Cc: Runzhen Wang Link: http://lkml.kernel.org/r/1347870675-31495-2-git-send-email-haod...@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- arch/x86/include/asm/kvm.h | 16 +++ arch/x86/include/asm/kvm_host.h | 16 --- arch/x86/include/asm/svm.h |

[PATCH 06/30] perf kvm: Events analysis tool

2012-09-24 Thread Arnaldo Carvalho de Melo
Ingo Molnar Cc: Marcelo Tosatti Cc: kvm@vger.kernel.org Cc: Runzhen Wang Link: http://lkml.kernel.org/r/1347870675-31495-4-git-send-email-haod...@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-kvm.txt | 30 ++- tools/perf/MANIFEST

[GIT PULL 00/30] perf/core improvements and fixes

2012-09-24 Thread Arnaldo Carvalho de Melo
'perf record', from Stephane Eranian. . New 'kvm' analysis tool, from Xiao Guangrong. Signed-off-by: Arnaldo Carvalho de Melo ------------ Arnaldo Carvalho de Melo (11): perf kvm: Use perf_evsel__

[PATCH 09/18] perf stat: Move stats related code to util/stat.c

2012-09-17 Thread Arnaldo Carvalho de Melo
Wang Cc: Xiao Guangrong http://lkml.kernel.org/r/1347870675-31495-3-git-send-email-haod...@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile |1 + tools/perf/builtin-stat.c | 56 +-- tools/perf/util/stat.c|

Re: [PATCH v8 1/3] KVM: x86: export svm/vmx exit code and vector code to userspace

2012-09-17 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 17, 2012 at 04:31:13PM +0800, Dong Hao escreveu: > From: Xiao Guangrong > > Exporting KVM exit information to userspace to be consumed by perf. > > [ Dong Hao : rebase it on acme's git tree ] > Signed-off-by: Dong Hao > Signed-off-by: Xiao Guangrong Do we have acked/reviewed-by fo

Re: [PATCH v7 3/3] KVM: perf: kvm events analysis tool

2012-09-13 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 13, 2012 at 08:14:37AM -0600, David Ahern escreveu: > On 9/13/12 7:45 AM, Arnaldo Carvalho de Melo wrote: > >Em Wed, Sep 12, 2012 at 10:56:44PM -0600, David Ahern escreveu: > >>So, I spent a fair amount of time today implementing a live mode. > >>And aft

Re: [PATCH v7 3/3] KVM: perf: kvm events analysis tool

2012-09-13 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 12, 2012 at 10:56:44PM -0600, David Ahern escreveu: > >> static const char * const kvm_usage[] = { > >>+"perf kvm [] {top|record|report|diff|buildid-list|stat}", > >The usage for the report/record sub commands of stat is never shown. e.g., > >$ perf kvm stat > >--> shows help for

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 10, 2012 at 11:19:10AM +0800, Dong Hao escreveu: > From: Xiao Guangrong > > Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Some comments below about recent changes in my perf/core branch. > +static void process_raw_event(struct thread *thread, void *data, u64

Re: [PATCH 3/3] KVM: perf: kvm events analysis tool

2012-02-16 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 15, 2012 at 10:05:08PM -0700, David Ahern escreveu: > On 2/15/12 9:59 PM, Xiao Guangrong wrote: > > > > > >Okay, i will post the next version after collecting your new comments! > > > >Thanks for your time, David! :) > > > > I had more comments, but got sidetracked and forgot to come b

[PATCH 5/5] perf kvm: Fix copy & paste error in description

2012-01-03 Thread Arnaldo Carvalho de Melo
: Joerg Roedel Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index 34d1e85..032324a 100644 --- a/tools/perf/builtin-kvm.c +++ b/tools/perf/builtin

[GIT PULL 0/5] perf/core fixes and improvements

2012-01-03 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling from: git://github.com/acmel/linux.git perf/core Regards, - Arnaldo Joerg Roedel (1): perf kvm: Fix copy & paste error in description Namhyung Kim (4): perf session: Remove impossible condition check perf stat: Introduce get_ratio_color() helper

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 02:25:09PM -0500, Jim Paris escreveu: > Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 09, 2011 at 11:40:01AM +0100, Gerd Hoffmann escreveu: > > > As far I know it is pretty much impossible to figure the > > > foreground/background colors of the

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 01:46:42PM +0100, Peter Zijlstra escreveu: > On Wed, 2011-11-09 at 10:33 -0200, Arnaldo Carvalho de Melo wrote: > > > > Ingo, would that G+ page be useful for that? > > > *groan* > > Can we please keep things sane? ROFL, I had to

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 10:30:50AM -0200, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 09, 2011 at 01:26:34PM +0100, Gerd Hoffmann escreveu: > > > Its fully configurable as of now, what we need is a set of .perfconfigs > > > that show how people think its better, we

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 01:26:34PM +0100, Gerd Hoffmann escreveu: > Hi, > > >>> Plus allowing full .perfconfig configurability of all the relevant > >>> colors, for those with special taste. > >> > >> Sure. Maybe also allow multiple color sections and pick them by $TERM > >> or --colors switch

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 10:21:09AM +0100, Ingo Molnar escreveu: > Eventually someone will do the right thing and implement 'perf trace' > (there's still the tip:tmp.perf/trace2 prototype branch) and users I'm working on it, reworking its patches into the new evlist/evsel abstractions, etc. - Ar

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-09 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 09, 2011 at 11:40:01AM +0100, Gerd Hoffmann escreveu: > Hi, > > > What we want to have is to have a set of distinctive colors - just > > two (background, foreground) colors are not enough - we also need > > colors to highlight certain information - we need 5-6 colors for the > > o

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 04:38:48PM +0100, Gerd Hoffmann escreveu: > Seems to have no effect, guess the distro perf is too old (RHEL-6). > > [tui] > > report = off > That works. I don't want turn off the tui altogether though, I actually > like the interactive expanding+collapsing of the call

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 02:40:42PM +0100, Gerd Hoffmann escreveu: > > Indeed, documentation is lacking, I think coming from a kernel > > standpoint I relied too much in the "documentation is source code" > > mantra of old days. > Sorry for the shameless plug, but as you are speaking of lacking T

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 01:07:55PM +0100, Ingo Molnar escreveu: > * Vince Weaver wrote: > > as mentioned before I have my own perf_event test suite with 20+ tests. > > http://web.eecs.utk.edu/~vweaver1/projects/perf-events/validation.html > That should probably be moved into perf test. Arnaldo

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 05:21:50AM -0500, Theodore Tso escreveu: > > On Nov 8, 2011, at 4:32 AM, Ingo Molnar wrote: > > > > No ifs and when about it, these are the plain facts: > > > > - Better features, better ABIs: perf maintainers can enforce clean, > > functional and usable tooling suppor

Re: trace_printk() support in trace-cmd

2010-12-12 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 12, 2010 at 07:42:06PM +0200, Avi Kivity escreveu: > On 12/12/2010 07:36 PM, Arnaldo Carvalho de Melo wrote: > >Em Sun, Dec 12, 2010 at 06:35:24PM +0200, Avi Kivity escreveu: > >> On 11/23/2010 05:45 PM, Steven Rostedt wrote: > >> >Again, the

Re: trace_printk() support in trace-cmd

2010-12-12 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 12, 2010 at 06:35:24PM +0200, Avi Kivity escreveu: > On 11/23/2010 05:45 PM, Steven Rostedt wrote: > >Again, the work around is to replace your trace_printks() with > >__trace_printk(_THIS_IP_, ...) or just modify the trace_printk() macro > >in include/linux/kernel.h to always use the _

Re: [PATCH 3/3] perf events: Change perf parameter --pid to process-wide collection instead of thread-wide

2010-03-25 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 25, 2010 at 04:47:44PM +0800, Zhang, Yanmin escreveu: > On Thu, 2010-03-25 at 16:02 +0800, Li Zefan wrote: > Thanks for reporting it. Arnaldo, could you pick up below patch? > Zefan, Could you try it? Sure thing, will stash them in today's push to Ingo, thanks! - Arnaldo -- To unsubsc

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2010 at 08:20:10PM +0200, Avi Kivity escreveu: > On 03/24/2010 07:47 PM, Arnaldo Carvalho de Melo wrote: >> Em Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity escreveu: >> >>> Doesn't perf already has a dependency on naming conventions for

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity escreveu: > Doesn't perf already has a dependency on naming conventions for finding > debug information? It looks at several places, from most symbol rich (/usr/lib/debug/, aka -debuginfo packages, where we have full symtabs) to poorest (the p

Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

2010-03-23 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 23, 2010 at 03:20:11PM +0100, Andi Kleen escreveu: > Soeren Sandmann writes: > > I don't think the oprofile JIT interface solves any of these > > problems. (In fact, I don't see why the JIT problem is even hard. The > > JIT compiler can just generate a little ELF file with symbols in i

Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

2010-03-23 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 23, 2010 at 02:49:01PM +0100, Andi Kleen escreveu: > Soeren Sandmann writes: > > To fix that problem, it seems like we need some way to have python > > export what is going on. Maybe the same mechanism could be used to > > both access what is going on in qemu and python. > > oprofile

Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

2010-03-23 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 23, 2010 at 11:14:41AM +0800, Zhang, Yanmin escreveu: > On Mon, 2010-03-22 at 13:44 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Mar 22, 2010 at 03:24:47PM +0800, Zhang, Yanmin escreveu: > > > On Fri, 2010-03-19 at 09:21 +0100, Ingo Molnar wrote: > > >

Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

2010-03-22 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 22, 2010 at 03:24:47PM +0800, Zhang, Yanmin escreveu: > On Fri, 2010-03-19 at 09:21 +0100, Ingo Molnar wrote: > > So some sort of --guestmount option would be the natural solution, which > > points to the guest system's root: and a Qemu enumeration of guest mounts > > (which would be

Re: [PATCH 3/3] perf events: Change perf parameter --pid to process-wide collection instead of thread-wide

2010-03-18 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 18, 2010 at 10:35:48AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Mar 18, 2010 at 05:31:06PM +0800, Zhang, Yanmin escreveu: > > From: Zhang, Yanmin > > > > Parameter --pid (or -p) of perf currently means a thread-wide collection. > > For exmapl

Re: [PATCH 3/3] perf events: Change perf parameter --pid to process-wide collection instead of thread-wide

2010-03-18 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 18, 2010 at 05:31:06PM +0800, Zhang, Yanmin escreveu: > From: Zhang, Yanmin > > Parameter --pid (or -p) of perf currently means a thread-wide collection. > For exmaple, if a process whose id is has 10 threads, 'perf top -p ' > just collects the main thread statistics. That's

Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

2010-03-18 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 18, 2010 at 09:03:25AM +0100, Ingo Molnar escreveu: > > * Zhang, Yanmin wrote: > > > I worked out 3 new patches against tip/master tree of Mar. 17th. > > Cool! Mind sending them as a series of patches instead of attachment? That > makes it easier to review them. Also, the Signed-of

Re: KVM usability

2010-03-07 Thread Arnaldo Carvalho de Melo
Em Sun, Mar 07, 2010 at 08:15:40PM +0200, Avi Kivity escreveu: > On 03/07/2010 08:01 PM, Arnaldo Carvalho de Melo wrote: > >Em Sun, Mar 07, 2010 at 11:35:31AM +0200, Avi Kivity escreveu: > >>perf really is wonderful, but to be really competitive, and usable to > >>more

Re: KVM usability

2010-03-07 Thread Arnaldo Carvalho de Melo
Em Sun, Mar 07, 2010 at 11:35:31AM +0200, Avi Kivity escreveu: > perf really is wonderful, but to be really competitive, and usable to > more developers, it needs to be in a graphical environment. I want > 'perf report' output to start out collapsed and drill down by clicking > on a tree wid

Re: Enhance perf to support KVM

2010-03-02 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2010 at 05:46:03PM +0100, Paolo Bonzini escreveu: > On 02/26/2010 03:23 PM, Ingo Molnar wrote: >> I do think tools/X and tools/libc would make quite a bit of sense - this is >> one of the better design aspects of FreeBSD et al. It's a mistake that it's >> not being done. > > I don't

Re: KVM usability

2010-03-01 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 01, 2010 at 06:48:07AM -1000, Zachary Amsden escreveu: > On 02/27/2010 07:25 AM, Ingo Molnar wrote: >> I'm not talking about moving it into a kernel _module_ - albeit that >> alone is a worthwile thing to do for any performance sensitive hw >> component. >> >> I was talking about the op