Re: [Qemu-devel] [PATCH 0/2] Lost VNC patches

2012-03-14 Thread Corentin Chary
On Wed, Mar 14, 2012 at 11:16 PM, Stefan Weil wrote: > Am 14.03.2012 22:46, schrieb Anthony Liguori: > >> On 03/14/2012 01:58 AM, Corentin Chary wrote: >>> >>> Hi Anthony, >>> >>> Please merge these two patchs from another age, they fix crash in the VNC >>> server (the iohandler one is only for th

Re: KVM: x86: fix kvm_write_tsc() TSC matching thinko

2012-03-14 Thread Marcelo Tosatti
On Wed, Mar 14, 2012 at 12:02:41PM +0100, Jan Kiszka wrote: > On 2012-03-08 22:46, Marcelo Tosatti wrote: > > > > kvm_write_tsc() converts from guest TSC to microseconds, not nanoseconds > > as intended. The result is that the window for matching is 1000 seconds, > > not 1 second. > > > > Microse

[PATCH] KVM: VMX: call invvpid only when EPT is disabled

2012-03-14 Thread Davidlohr Bueso
From: Davidlohr Bueso With EPT enabled it is not required to explicitly run invvpid to invalidate tagged TLB entries, as KVM does not force vm-exits for cr3 writes and invlpg. Run invvpid only when these instructions are emulated and shadow pages are used. Signed-off-by: Davidlohr Bueso ---

RE: [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, March 14, 2012 4:54 PM > To: Zhang, Yang Z > Cc: qemu-de...@nongnu.org; Jan Kiszka; kvm@vger.kernel.org; > aligu...@us.ibm.com; Marcelo Tosatti > Subject: Re: [PATCH v3 0/7] RTC: New logic to emulate

Re: [Qemu-devel] [PATCH 0/2] Lost VNC patches

2012-03-14 Thread Stefan Weil
Am 14.03.2012 22:46, schrieb Anthony Liguori: On 03/14/2012 01:58 AM, Corentin Chary wrote: Hi Anthony, Please merge these two patchs from another age, they fix crash in the VNC server (the iohandler one is only for the threaded server). Applied. Thanks. Regards, Anthony Liguori The c

Re: [Qemu-devel] [PATCH 0/2] Lost VNC patches

2012-03-14 Thread Anthony Liguori
On 03/14/2012 01:58 AM, Corentin Chary wrote: Hi Anthony, Please merge these two patchs from another age, they fix crash in the VNC server (the iohandler one is only for the threaded server). Applied. Thanks. Regards, Anthony Liguori Thanks, Corentin Chary (1): vnc: don't mess up wit

[PATCH v5 21/43] target-s390x: Don't overuse CPUState

2012-03-14 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUS390XState/g" target-s390x/*.[hc] sed -i "s/#define CPUS390XState/#define CPUState/" target-s390x/cpu.h Signed-off-by: Andreas Färber Acked-by: Anthony Liguori --- target-s390x/cpu.h | 46 +++--- target-s390x/helper.

[PATCH v5 20/43] target-ppc: Don't overuse CPUState

2012-03-14 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUPPCState/g" target-ppc/*.[hc] sed -i "s/#define CPUPPCState/#define CPUState/" target-ppc/cpu.h Signed-off-by: Andreas Färber Acked-by: Anthony Liguori --- target-ppc/cpu.h| 38 ++-- target-ppc/helper.c | 80

[PATCH v5 15/43] target-i386: Don't overuse CPUState

2012-03-14 Thread Andreas Färber
Scripted conversion: sed -i "s/CPUState/CPUX86State/g" target-i386/*.[hc] sed -i "s/#define CPUX86State/#define CPUState/" target-i386/cpu.h Signed-off-by: Andreas Färber Acked-by: Anthony Liguori --- target-i386/cpu.h | 34 +- target-i386/helper.c| 38 +- targ

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Eric Northup
On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: >> On 03/14/2012 03:14 PM, Gleb Natapov wrote: >> > On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: >> > > On 03/14/2012 01:11 PM, Wen Congyang wrote: >> > > > > >> > > >

[RFC 06/12] target-ppc: QOM'ify CPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/cpu-qom.h| 84 ++ target-ppc/cpu.h| 25 + target-ppc/helper.c | 72 ++-- target-ppc/kvm.c| 29 +++-- target-ppc/kvm_ppc.h|6 - target-ppc/translate.c |2 +- ta

[RFC 07/12] target-ppc: Prepare finalizer for PowerPCCPU

2012-03-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/cpu.h|1 + target-ppc/helper.c |1 - target-ppc/kvm.c|1 + target-ppc/translate_init.c |6 ++ 4 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index f

[PATCH] KVM: PPC: Ignore unhalt request from kvm_vcpu_block

2012-03-14 Thread Alexander Graf
When running kvm_vcpu_block and it realizes that the CPU is actually good to run, we get a request bit set for KVM_REQ_UNHALT. Right now, there's nothing we can do with that bit, so let's unset it right after the call again so we don't get confused in our later checks for pending work. Signed-off-

[PATCH] KVM: PPC: Book3S: PR: Fix preemption

2012-03-14 Thread Alexander Graf
We were leaking preemption counters. Fix the code to always toggle between preempt and non-preempt properly. Signed-off-by: Alexander Graf --- arch/powerpc/kvm/book3s_pr.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/b

[PATCH] KVM: PPC: Book3s: PR: Add HV traps so we can run in HV=1 mode on p7

2012-03-14 Thread Alexander Graf
When running PR KVM on a p7 system in bare metal, we get HV exits instead of normal supervisor traps. Semantically they are identical though and the HSRR vs SRR difference is already taken care of in the exit code. So all we need to do is handle them in addition to our normal exits. Signed-off-by

Re: [PATCH] powerpc/kvm: Fix magic page vs. 32-bit RTAS on ppc64

2012-03-14 Thread Alexander Graf
On 14.03.2012, at 08:52, Benjamin Herrenschmidt wrote: > When the kernel calls into RTAS, it switches to 32-bit mode. The > magic page was is longer accessible in that case, causing the > patched instructions in the RTAS call wrapper to crash. > > This fixes it by making available a 32-bit mappi

Re: [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 05:58:20PM +0800, Amos Kong wrote: > On 14/03/12 03:47, Michael Roth wrote: > >On Wed, Mar 07, 2012 at 06:48:57AM +0800, Amos Kong wrote: > >>That method of representing an IPv6 address with a port is > > > >I'm not sure what "that" is referencing. > > 2312::8274:5200 (520

Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start()

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 06:19:48PM +0800, Amos Kong wrote: > On 14/03/12 02:35, Michael Roth wrote: > >On Wed, Mar 07, 2012 at 06:48:03AM +0800, Amos Kong wrote: > >>Introduce tcp_client_start() by moving original code in > >>tcp_start_outgoing_migration(). > >> > >>Signed-off-by: Amos Kong > >>---

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 04:33:14PM +0800, Amos Kong wrote: > On 14/03/12 00:39, Michael Roth wrote: > >On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: > >>Introduce tcp_server_start() by moving original code in > >>tcp_start_incoming_migration(). > >> > >>Signed-off-by: Amos Kong > >>---

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: > On 03/14/2012 03:14 PM, Gleb Natapov wrote: > > On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: > > > On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > > > > > > > I don't think we want to use the driver. Instead, have a

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 03:14 PM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: > > On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > > > > > I don't think we want to use the driver. Instead, have a small piece of > > > > code that resets the device and pushes out a st

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: > On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > > > I don't think we want to use the driver. Instead, have a small piece of > > > code that resets the device and pushes out a string (the panic message?) > > > without any interrupts

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 03:07 PM, Avi Kivity wrote: > On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > > > I don't think we want to use the driver. Instead, have a small piece of > > > code that resets the device and pushes out a string (the panic message?) > > > without any interrupts etc. > > > > > >

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 01:11 PM, Wen Congyang wrote: > > > > I don't think we want to use the driver. Instead, have a small piece of > > code that resets the device and pushes out a string (the panic message?) > > without any interrupts etc. > > > > It's still going to be less reliable than a hypercall,

User question: balloon memory, currentMemory and Linux/FreeBSD guests

2012-03-14 Thread Andy Smith
Hi, I'm a KVM user, using it for the first time and so far very happy with it. I wonder if someone can help me get my head round the issue of balloon memory and overallocation. Basically I have a Debian wheezy/sid KVM server, on which I have a couple of Linux guests and several FreeBSD gue

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: > On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: >> > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> >> > On 03/13/2012 12:42 PM,

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 08:51, schrieb Amos Kong: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>> r

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: > At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: > >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:58 PM, Gleb Natapov Wrote: > On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:52 PM, Gleb Natapov Wrote: >>> On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [17:5

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: > At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: > >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:48 PM, Avi Kivity Wrote: > On 03/14/2012 12:46 PM, Gleb Natapov wrote: >> On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: >>> On 03/14/2012 12:26 PM, Wen Congyang wrote: >> If so, is this channel visible to guest userspace? If the channle is >> visible to guest

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: > On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:52 PM, Avi Kivity Wrote: >>> On 03/14/2012 12:52 PM, Wen Congyang wrote: > >> If so, is this channel visible to guest userspace? If the channle is >> vi

Re: KVM: x86: fix kvm_write_tsc() TSC matching thinko

2012-03-14 Thread Jan Kiszka
On 2012-03-08 22:46, Marcelo Tosatti wrote: > > kvm_write_tsc() converts from guest TSC to microseconds, not nanoseconds > as intended. The result is that the window for matching is 1000 seconds, > not 1 second. > > Microsecond precision is enough for checking whether the TSC write delta > is wit

Re: [PATCH 2/4] KVM: Avoid checking huge page mappings in get_dirty_log()

2012-03-14 Thread Marcelo Tosatti
On Wed, Mar 14, 2012 at 02:34:32PM +0900, Takuya Yoshikawa wrote: > Marcelo Tosatti wrote: > > > guest fault enable dirty logging > > > > tdp_page_fault (all _page_fault functions) kvm_set_memory_region > > > > > > level = mapping_level(vcpu, gfn) > > (

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:57 PM, Daniel P. Berrange Wrote: > On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: >> On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: >>> At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 1

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Avi Kivity Wrote: > > On 03/14/2012 12:52 PM, Wen Congyang wrote: > >>> > If so, is this channel visible to guest userspace? If the channle is > visible to guest > userspace, the program running

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Avi Kivity Wrote: > > On 03/14/2012 12:52 PM, Wen Congyang wrote: > >>> > If so, is this channel visible to guest userspace? If the channle is > visible to guest > userspace, the program running

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: > At 03/14/2012 06:52 PM, Gleb Natapov Wrote: > > On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: > >> At 03/14/2012 06:37 PM, Amit Shah Wrote: > >>> On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > At 03/14/2012

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote: > At 03/14/2012 06:37 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: > >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote:

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > > >>> On 03/12

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Avi Kivity Wrote: > On 03/14/2012 12:52 PM, Wen Congyang wrote: >>> If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel. >>> >>> Acce

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Gleb Natapov Wrote: > On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: >> At 03/14/2012 06:37 PM, Amit Shah Wrote: >>> On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: > On 03/14/2012 10:29 AM, Wen Congyang

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:52 PM, Wen Congyang wrote: > > > >> If so, is this channel visible to guest userspace? If the channle is > >> visible to guest > >> userspace, the program running in userspace may write the same message to > >> the channel. > > > > Access control is via permissions. You can ha

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: > At 03/14/2012 06:37 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: > >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivit

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:37 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >>

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:46 PM, Gleb Natapov wrote: > On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: > > On 03/14/2012 12:26 PM, Wen Congyang wrote: > > > >> If so, is this channel visible to guest userspace? If the channle is > > > >> visible to guest > > > >> userspace, the program running

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > >> > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> >> Boot up guest with 232 virtio-blk

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: > On 03/14/2012 12:26 PM, Wen Congyang wrote: > > >> If so, is this channel visible to guest userspace? If the channle is > > >> visible to guest > > >> userspace, the program running in userspace may write the same message > > >> to the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 04:10:04PM +0530, Amit Shah wrote: > On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: > > At 03/14/2012 05:51 PM, Amit Shah Wrote: > > > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > >>> On 03/13/2012 11:18 AM,

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: > At 03/14/2012 05:51 PM, Amit Shah Wrote: > > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> > On 03/13/2012 12:42 PM, Amos Kong wrote: >> >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> >> allocate ioevent

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: > At 03/14/2012 05:24 PM, Avi Kivity Wrote: > > On 03/14/2012 10:29 AM, Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +0200, Av

Re: [PATCH] PCI: Can continually add funcs after adding func0

2012-03-14 Thread Michael S. Tsirkin
On Fri, Jan 27, 2012 at 09:17:21AM -0800, Jesse Barnes wrote: > On Mon, 5 Dec 2011 11:21:24 -0800 > Jesse Barnes wrote: > > > On Fri, 25 Nov 2011 15:03:07 +0800 > > Amos Kong wrote: > > > > > Boot up a KVM guest, and hotplug multifunction > > > devices(func1,func2,func0,func3) to guest. > > >

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:26 PM, Wen Congyang wrote: > >> If so, is this channel visible to guest userspace? If the channle is > >> visible to guest > >> userspace, the program running in userspace may write the same message to > >> the channel. > >> > > > > Surely there's some kind of access control on

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:07 PM, Avi Kivity Wrote: > On 03/14/2012 11:53 AM, Wen Congyang wrote: >> At 03/14/2012 05:24 PM, Avi Kivity Wrote: >>> On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >> On Mon,

Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start()

2012-03-14 Thread Amos Kong
On 14/03/12 02:35, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:48:03AM +0800, Amos Kong wrote: Introduce tcp_client_start() by moving original code in tcp_start_outgoing_migration(). Signed-off-by: Amos Kong --- net.c | 41 + qemu_socket.h

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-14 Thread Avi Kivity
On 03/12/2012 11:43 AM, Igor Mitsyanko wrote: > On 02/21/2012 07:33 PM, Peter Maydell wrote: >> >> Short summary: >> * switch wp groups to bitfield rather than int array >> * convert sd.c to use memory_region_init_ram() to allocate the wp >> groups >> (being careful to use memory_region_set_dir

Re: [PATCH 2/4 V16] Add functions to check if the host has stopped the vm

2012-03-14 Thread Jan Kiszka
On 2012-03-10 20:37, Eric B Munson wrote: > When a host stops or suspends a VM it will set a flag to show this. The > watchdog will use these functions to determine if a softlockup is real, or the > result of a suspended VM. > ... > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmc

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:04 PM, Wen Congyang wrote: > > > > This is sufficient. On the host, you can open /tmp/foo using a custom > > program or nc (nc -U /tmp/foo). On the guest, you can just open > > /dev/virtio-ports/port1 and read/write into it. > > I have two questions: > 1. does it OK to open this

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:53 AM, Wen Congyang wrote: > At 03/14/2012 05:24 PM, Avi Kivity Wrote: > > On 03/14/2012 10:29 AM, Wen Congyang wrote: > >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: > >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:51 PM, Amit Shah Wrote: > On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > On 03/12/2012 11:04 AM, Wen Congy

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > >> a

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:24 PM, Avi Kivity Wrote: > On 03/14/2012 10:29 AM, Wen Congyang wrote: >> At 03/13/2012 06:47 PM, Avi Kivity Wrote: >>> On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > On 03/12/2012 11:04 AM, Wen Congyang wrot

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/14/2012 09:51 AM, Amos Kong wrote: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>>

[PATCH] KVM: Convert intx_mask_lock to spin lock

2012-03-14 Thread Jan Kiszka
As kvm_notify_acked_irq calls kvm_assigned_dev_ack_irq under rcu_read_lock, we cannot use a mutex in the latter function. Switch to a spin lock to address this. Signed-off-by: Jan Kiszka --- include/linux/kvm_host.h |2 +- virt/kvm/assigned-dev.c | 14 +++--- 2 files changed, 8 in

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > On 03/13/2012 12:42 PM, Amos Kong wrote: >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), >> and check if available ioeventfd exists. If not, virtio-pc

Re: [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets

2012-03-14 Thread Amos Kong
On 14/03/12 03:47, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:48:57AM +0800, Amos Kong wrote: That method of representing an IPv6 address with a port is I'm not sure what "that" is referencing. 2312::8274:5200 (5200 is a port) I assumed the previous patch but the representation seems

Re: [PATCH 1/2] Isolation groups

2012-03-14 Thread David Gibson
On Tue, Mar 13, 2012 at 10:49:47AM -0600, Alex Williamson wrote: > On Wed, 2012-03-14 at 01:33 +1100, David Gibson wrote: > > On Mon, Mar 12, 2012 at 04:32:54PM -0600, Alex Williamson wrote: > > > Signed-off-by: Alex Williamson > > > --- > > > > > > drivers/base/Kconfig | 10 + > > > driv

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: > Do you have any other comm

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-14 Thread Igor Mitsyanko
On 03/12/2012 01:43 PM, Igor Mitsyanko wrote: On 02/21/2012 07:33 PM, Peter Maydell wrote: Short summary: * switch wp groups to bitfield rather than int array * convert sd.c to use memory_region_init_ram() to allocate the wp groups (being careful to use memory_region_set_dirty() when we touch t

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 10:29 AM, Wen Congyang wrote: > At 03/13/2012 06:47 PM, Avi Kivity Wrote: > > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: > >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: > Do you have any other comments abou

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/13/2012 12:42 PM, Amos Kong wrote: > Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > and check if available ioeventfd exists. If not, virtio-pci will > fallback to userspace, and don't use ioeventfd f

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 12:30 AM, Amos Kong wrote: > - Original Message - >> On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong wrote: > > ... > > Hi, Stefan > >> > diff --git a/kvm-all.c b/kvm-all.c >> > index 77eadf6..7157e78 100644 >> > --- a/kvm-all.c >> > +++ b/kvm-all.c >> > @@ -771,6 +771,

Re: [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 09:52, Zhang, Yang Z ha scritto: > Is there any comments with the version 3? >>> >>> Can you explain why you dropped the logic to set the timer to the >>> next event? > Do you mean why I change the rtc logic? The reason is that: When a > guest is idle, the main activity inside qe

RE: [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, March 14, 2012 4:35 PM > To: Zhang, Yang Z > Cc: qemu-de...@nongnu.org; Jan Kiszka; kvm@vger.kernel.org; > aligu...@us.ibm.com; Marcelo Tosatti > Subject: Re: [PATCH v3 0/7] RTC: New logic to emulate

Re: [PATCH] PCI: Device specific reset function

2012-03-14 Thread Tadeusz Struk
On 13/03/12 02:42, Alex Williamson wrote: > On Mon, 2012-03-12 at 16:55 +, Tadeusz Struk wrote: >> I have a use case where I need to cleanup resource allocated for Virtual >> Functions after a guest OS that used it crashed. This cleanup needs to >> be done before the VF is being FLRed. The only

Re: [PATCH v3 0/7] RTC: New logic to emulate RTC

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 01:00, Zhang, Yang Z ha scritto: > Is there any comments with the version 3? Can you explain why you dropped the logic to set the timer to the next event? Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org Mo

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong --- net.c | 28 qemu_socket.h |2 ++

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:51, Amos Kong ha scritto: > > > ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); > if (ret < 0) { > ret = -socket_error(); > closesocket(*fd); > } > return ret; > } Looks good. Paolo -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/13/2012 06:47 PM, Avi Kivity Wrote: > On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: >> On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: >>> On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? >>> >>> Not really, but I'm not 100

Re: [PATCH] powerpc/kvm: Fix magic page vs. 32-bit RTAS on ppc64

2012-03-14 Thread Benjamin Herrenschmidt
On Wed, 2012-03-14 at 18:52 +1100, Benjamin Herrenschmidt wrote: > When the kernel calls into RTAS, it switches to 32-bit mode. The > magic page was is longer accessible in that case, causing the > patched instructions in the RTAS call wrapper to crash. > > This fixes it by making available a 32-b

[PATCH] powerpc/kvm: Fix magic page vs. 32-bit RTAS on ppc64

2012-03-14 Thread Benjamin Herrenschmidt
When the kernel calls into RTAS, it switches to 32-bit mode. The magic page was is longer accessible in that case, causing the patched instructions in the RTAS call wrapper to crash. This fixes it by making available a 32-bit mapping of the magic page in that case. This mapping is flushed whenever

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 15:27, Paolo Bonzini wrote: Hi Paolo, Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) { closesocket(*fd); return -socket_error(); } return 0; and than you will not need ret But closesocket could clo

Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start()

2012-03-14 Thread Orit Wasserman
On 03/07/2012 12:48 AM, Amos Kong wrote: > Introduce tcp_client_start() by moving original code in > tcp_start_outgoing_migration(). > > Signed-off-by: Amos Kong > --- > net.c | 41 + > qemu_socket.h |1 + > 2 files changed, 42 insertions(+),

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:14, Orit Wasserman ha scritto: > if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)) < 0) > { > closesocket(*fd); > return -socket_error(); > } > return 0; > > and than you will not need ret But closesocket could clobber socket_error(), no? Paolo -- To unsubscri

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/07/2012 12:47 AM, Amos Kong wrote: > Introduce tcp_server_start() by moving original code in > tcp_start_incoming_migration(). > > Signed-off-by: Amos Kong > --- > net.c | 28 > qemu_socket.h |2 ++ > 2 files changed, 30 insertions(+), 0 deletions