Re: [PATCH -v2] KVM: fix kvm_coalesced_mmio_init()'s error handling

2010-03-11 Thread Takuya Yoshikawa
Wei Yongjun wrote: Takuya Yoshikawa wrote: This version may be better. Thanks, Takuya === kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio ring page and dev even after it has freed them. Also, if this function fails, though it must be rare, it seems to be suggesting

Re: [PATCH -v2] KVM: fix kvm_coalesced_mmio_init()'s error handling

2010-03-11 Thread Wei Yongjun
Takuya Yoshikawa wrote: > This version may be better. > > Thanks, > Takuya > > === > kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio > ring page and dev even after it has freed them. > > Also, if this function fails, though it must be rare, it seems to be > suggesting th

[PATCH -v2] KVM: fix kvm_coalesced_mmio_init()'s error handling

2010-03-11 Thread Takuya Yoshikawa
This version may be better. Thanks, Takuya === kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio ring page and dev even after it has freed them. Also, if this function fails, though it must be rare, it seems to be suggesting the system's serious state. This patch chang

Re: ioeventfd usage in KVM

2010-03-11 Thread Avi Kivity
On 03/12/2010 07:08 AM, Cam Macdonell wrote: +s->ivshmem_mmio_io_addr = cpu_register_io_memory(ivshmem_mmio_read, +ivshmem_mmio_write, s); +/* region for registers*/ +pci_register_bar(&d->dev, 0, 0x100, + PCI_BASE_ADDRESS_

Re: [PATCH 0/18][RFC] Nested Paging support for Nested SVM (aka NPT-Virtualization)

2010-03-11 Thread Avi Kivity
On 03/04/2010 05:58 PM, Joerg Roedel wrote: You probably need to include a flag in base_role to differentiate between l1 / l2 shadow tables (say if they use the same cr3 value). Not sure if this is necessary. It may be necessary when large pages come into play. Otherwise the host npt pages

Re: [PATCH 0/18][RFC] Nested Paging support for Nested SVM (aka NPT-Virtualization)

2010-03-11 Thread Avi Kivity
On 03/11/2010 10:58 PM, Marcelo Tosatti wrote: Can't you translate l2_gpa -> l1_gpa walking the current l1 nested pagetable, and pass that to the kvm tdp fault path (with the correct context setup)? If I understand your suggestion correctly, I think thats exactly whats done in the pat

Re: KVM: x86: ignore access permissions for hypercall patching

2010-03-11 Thread Gleb Natapov
On Fri, Mar 12, 2010 at 07:56:00AM +0200, Gleb Natapov wrote: > On Thu, Mar 11, 2010 at 06:16:05PM -0300, Marcelo Tosatti wrote: > > > > Ignore access permissions while patching hypercall instructions. > > Otherwise KVM injects a page fault when trying to patch vmcall > > on read-only text regio

Re: KVM: x86: ignore access permissions for hypercall patching

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 06:16:05PM -0300, Marcelo Tosatti wrote: > > Ignore access permissions while patching hypercall instructions. > Otherwise KVM injects a page fault when trying to patch vmcall > on read-only text regions: > > Freeing initrd memory: 8843k freed > Freeing unused kernel memo

Re: [patch 2/2] virtio-serial-bus: wake up iothread upon guest read notification

2010-03-11 Thread Amit Shah
On (Thu) Mar 11 2010 [23:45:51], Marcelo Tosatti wrote: > Wake up iothread when buffers are consumed. > > Signed-off-by: Marcelo Tosatti > > Index: qemu-ioworker/hw/virtio-serial-bus.c > === > --- qemu-ioworker.orig/hw/virtio-serial

ioeventfd usage in KVM

2010-03-11 Thread Cam Macdonell
Hi, I'm trying to use ioeventfd/irqfds for my shared memory patch. I followed the usage in the vhost-net patches to see how it's setup for virtio-pci and tried to follow it as closely as I could. Despite the call to kvm_vm_ioctl() returning 0, any writes to the assigned 4-byte memory area do not

[PATCH] KVM: fix the errno of ioctl KVM_[UN]REGISTER_COALESCED_MMIO failure

2010-03-11 Thread Wei Yongjun
This patch change the errno of ioctl KVM_[UN]REGISTER_COALESCED_MMIO from -EINVAL to -ENXIO if no coalesced mmio dev exists. Signed-off-by: Wei Yongjun --- virt/kvm/coalesced_mmio.c |4 ++-- virt/kvm/kvm_main.c |2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/v

Re: [PATCH] KVM: fix to not use NULL kvm->coalesced_mmio_ring in kvm_vcpu_fault()

2010-03-11 Thread Takuya Yoshikawa
Wei Yongjun wrote: If coalesced_mmio init fail, the kvm->coalesced_mmio_ring will be set to NULL. If so, we should return VM_FAULT_SIGBUS in kvm_vcpu_fault() even if vmf->pgoff == KVM_COALESCED_MMIO_PAGE_OFFSET. Signed-off-by: Wei Yongjun --- virt/kvm/kvm_main.c |3 ++- 1 files changed, 2

Re: [PATCH] KVM: coalesced_mmio: NULLify the pointers before freeing ring page and dev

2010-03-11 Thread Takuya Yoshikawa
Wei Yongjun wrote: Takuya Yoshikawa wrote: kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio ring page and dev even after it has freed them. This may trigger problems, e.g., if we call kvm_coalesced_mmio_free() in kvm_destroy_vm() or kvm_vm_ioctl_register_coalesced_mmio(

[PATCH] KVM: fix to not use NULL kvm->coalesced_mmio_ring in kvm_vcpu_fault()

2010-03-11 Thread Wei Yongjun
If coalesced_mmio init fail, the kvm->coalesced_mmio_ring will be set to NULL. If so, we should return VM_FAULT_SIGBUS in kvm_vcpu_fault() even if vmf->pgoff == KVM_COALESCED_MMIO_PAGE_OFFSET. Signed-off-by: Wei Yongjun --- virt/kvm/kvm_main.c |3 ++- 1 files changed, 2 insertions(+), 1 dele

Re: [PATCH] KVM: coalesced_mmio: NULLify the pointers before freeing ring page and dev

2010-03-11 Thread Wei Yongjun
Takuya Yoshikawa wrote: > kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio > ring page and dev even after it has freed them. > > This may trigger problems, e.g., if we call kvm_coalesced_mmio_free() in > kvm_destroy_vm() or kvm_vm_ioctl_register_coalesced_mmio() afterward.

[PATCH] KVM: coalesced_mmio: NULLify the pointers before freeing ring page and dev

2010-03-11 Thread Takuya Yoshikawa
kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced mmio ring page and dev even after it has freed them. This may trigger problems, e.g., if we call kvm_coalesced_mmio_free() in kvm_destroy_vm() or kvm_vm_ioctl_register_coalesced_mmio() afterward. This patch avoids such problems

[patch 1/2] Pass QEMUIOWorker to qemu_notify_event

2010-03-11 Thread Marcelo Tosatti
This can be used later to introduce generic iothread workers. Signed-off-by: Marcelo Tosatti Index: qemu-ioworker/async.c === --- qemu-ioworker.orig/async.c +++ qemu-ioworker/async.c @@ -180,7 +180,7 @@ void qemu_bh_schedule(QEMUBH

[patch 2/2] virtio-serial-bus: wake up iothread upon guest read notification

2010-03-11 Thread Marcelo Tosatti
Wake up iothread when buffers are consumed. Signed-off-by: Marcelo Tosatti Index: qemu-ioworker/hw/virtio-serial-bus.c === --- qemu-ioworker.orig/hw/virtio-serial-bus.c +++ qemu-ioworker/hw/virtio-serial-bus.c @@ -331,6 +331,7 @@ st

[patch 0/2] introduce QEMUIOWorker and wake up iothread on virtio-serial-bus notification

2010-03-11 Thread Marcelo Tosatti
-- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] KVM: ia64: fix the error of ioctl KVM_IRQ_LINE if no irq chip

2010-03-11 Thread Wei Yongjun
If no irq chip in kernel, ioctl KVM_IRQ_LINE will return -EFAULT. But I see in other place such as KVM_[GET|SET]IRQCHIP, -ENXIO is return. So this patch used -ENXIO instead of -EFAULT. Signed-off-by: Wei Yongjun --- arch/ia64/kvm/kvm-ia64.c |2 ++ 1 files changed, 2 insertions(+), 0 deletion

[PATCH] KVM: x86: fix the error of ioctl KVM_IRQ_LINE if no irq chip

2010-03-11 Thread Wei Yongjun
If no irq chip in kernel, ioctl KVM_IRQ_LINE will return -EFAULT. But I see in other place such as KVM_[GET|SET]IRQCHIP, -ENXIO is return. So this patch used -ENXIO instead of -EFAULT. Signed-off-by: Wei Yongjun --- arch/x86/kvm/x86.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

[PATCH] KVM: ia64: fix the error code of ioctl KVM_IA64_VCPU_GET_STACK failure

2010-03-11 Thread Wei Yongjun
The ioctl KVM_IA64_VCPU_GET_STACK does not set the error code if copy_to_user() fail, and 0 will be return, we should use -EFAULT instead of 0 in this case, so this patch fixed it. Signed-off-by: Wei Yongjun --- arch/ia64/kvm/kvm-ia64.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(

Re: [Qemu-devel] Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Jamie Lokier
Avi Kivity wrote: > On 03/10/2010 11:30 PM, Luiz Capitulino wrote: > > > >2. Do we have kvm-specific projects? Can they be part of the QEMU project > >or do we need a different mentoring organization for it? > > > > Something really interesting is kvm-assisted tcg. I'm afraid it's a bit >

Re: KVM: x86: ignore access permissions for hypercall patching

2010-03-11 Thread Stefan Bader
With this patch applied on top, I was able to boot my guest on a AMD host system. Marcelo Tosatti wrote: > Ignore access permissions while patching hypercall instructions. > Otherwise KVM injects a page fault when trying to patch vmcall > on read-only text regions: > > Freeing initrd memory: 8

KVM: x86: ignore access permissions for hypercall patching

2010-03-11 Thread Marcelo Tosatti
Ignore access permissions while patching hypercall instructions. Otherwise KVM injects a page fault when trying to patch vmcall on read-only text regions: Freeing initrd memory: 8843k freed Freeing unused kernel memory: 660k freed Write protecting the kernel text: 4780k Write protecting the ker

Re: [PATCH 0/18][RFC] Nested Paging support for Nested SVM (aka NPT-Virtualization)

2010-03-11 Thread Marcelo Tosatti
On Thu, Mar 04, 2010 at 04:58:20PM +0100, Joerg Roedel wrote: > On Thu, Mar 04, 2010 at 11:42:55AM -0300, Marcelo Tosatti wrote: > > On Wed, Mar 03, 2010 at 08:12:03PM +0100, Joerg Roedel wrote: > > > Hi, > > > > > > here are the patches that implement nested paging support for nested > > > svm. T

[ kvm-Bugs-2968899 ] guest lockup setting clock when smp > 1

2010-03-11 Thread SourceForge.net
Bugs item #2968899, was opened at 2010-03-11 14:31 Message generated for change (Comment added) made by high33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2968899&group_id=180599 Please note that this message will contain a full copy of the comment th

[ kvm-Bugs-2968899 ] guest lockup setting clock when smp > 1

2010-03-11 Thread SourceForge.net
Bugs item #2968899, was opened at 2010-03-11 14:31 Message generated for change (Tracker Item Submitted) made by high33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2968899&group_id=180599 Please note that this message will contain a full copy of the c

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-11 Thread Marcelo Tosatti
On Thu, Mar 11, 2010 at 10:32:50AM +0200, Avi Kivity wrote: > On 03/02/2010 02:14 AM, Marcelo Tosatti wrote: > >On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > >>This grand cleanup drops all reset and vmsave/load related > >>synchronization points in favor of four(!) generic hooks: >

Re: [patch 1/3] target-i386: print EFER in cpu_dump_state

2010-03-11 Thread Marcelo Tosatti
On Thu, Mar 11, 2010 at 10:35:21AM +0200, Avi Kivity wrote: > On 03/09/2010 03:53 AM, Marcelo Tosatti wrote: > >Signed-off-by: Marcelo Tosatti > > > >Index: qemu-kvm-uq/target-i386/helper.c > >=== > >--- qemu-kvm-uq.orig/target-i386/he

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Marcelo Tosatti
On Thu, Mar 11, 2010 at 09:58:12AM +0200, Avi Kivity wrote: > On 03/11/2010 09:52 AM, Sheng Yang wrote: > >I think we have already suffered enough timer issues due to this(e.g. I can't > >boot up well on 2.6.18 kernel)... > > 2.6.18 as guest or as host? > > >I have kept --no-hpet in my setup for

Re: [Qemu-devel] Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Cam Macdonell
On Thu, Mar 11, 2010 at 5:03 AM, Alexander Graf wrote: > > On 11.03.2010, at 12:58, Avi Kivity wrote: > >> On 03/11/2010 01:56 PM, Alexander Graf wrote: >>> On 11.03.2010, at 12:54, Avi Kivity wrote: >>> >>> On 03/11/2010 01:25 PM, Alexander Graf wrote: > The list is also still missi

Re: Shadow page table questions

2010-03-11 Thread Marek Olszewski
It doesn't, and there are often multiple shadow pages per guest page, distinguished by their sp->role field. Oh, great! Does this mean that there is already a mechanism for synchronizing all shadow pages shadowing the same guest when such a guest page changes? Marek -- To unsubscribe from

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread malc
On Thu, 11 Mar 2010, Nick Piggin wrote: > On Thu, Mar 11, 2010 at 03:10:47AM +, Jamie Lokier wrote: > > Paul Brook wrote: > > > > > In a cross environment that becomes extremely hairy. For example the > > > > > x86 > > > > > architecture effectively has an implicit write barrier before every

Re: [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread Arnd Bergmann
On Thursday 11 March 2010, Avi Kivity wrote: > >> That would be much slower. The current scheme allows for an > >> ioeventfd/irqfd short circuit which allows one guest to interrupt > >> another without involving their qemus at all. > >> > > Yes, the serial line approach would be much slower,

Re: how to tweak kernel to get the best out of kvm?

2010-03-11 Thread Harald Dunkel
Hi Avi, I had missed to include some important syslog lines from the host system. See attachment. On 03/10/10 14:15, Avi Kivity wrote: > > You have tons of iowait time, indicating an I/O bottleneck. > Is this disk IO or network IO? The rsync session puts a high load on both, but actually I do

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Luiz Capitulino
On Thu, 11 Mar 2010 14:00:46 +0100 Alexander Graf wrote: > > On 11.03.2010, at 13:59, Luiz Capitulino wrote: > > > On Thu, 11 Mar 2010 10:43:09 +0100 > > Paolo Bonzini wrote: > > > >> On 03/11/2010 08:55 AM, Avi Kivity wrote: > >>> On 03/10/2010 11:30 PM, Luiz Capitulino wrote: > >

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Luiz Capitulino
On Thu, 11 Mar 2010 13:09:37 +0100 Paolo Bonzini wrote: > On 03/11/2010 12:25 PM, Alexander Graf wrote: > > == Write a C QMP library based on QEMU JSON and QMP code == > > > > Suggested by Anthony, mentored by Anthony?:) Possible other > > candidates are Luiz and Kraxel I guess? I haven't really

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Luiz Capitulino
On Thu, 11 Mar 2010 12:25:24 +0100 Alexander Graf wrote: > == Write a C QMP library based on QEMU JSON and QMP code == > > Suggested by Anthony, mentored by Anthony? :) Possible other candidates are > Luiz and Kraxel I guess? I haven't really tracked QMP that much. I didn't candidate as a men

Re: [Qemu-devel] Ideas wiki for GSoC 2010

2010-03-11 Thread Lucas Meneghel Rodrigues
On Wed, 2010-03-10 at 18:30 -0300, Luiz Capitulino wrote: > Hi there, > > Our wiki page for the Summer of Code 2010 is doing quite well: > > http://wiki.qemu.org/Google_Summer_of_Code_2010 Just to let you guys know that I'm going to give a talk at the local university (Unicamp) about kvm autote

Re: [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread Avi Kivity
On 03/11/2010 02:57 PM, Arnd Bergmann wrote: On Thursday 11 March 2010, Avi Kivity wrote: A totally different option that avoids this whole problem would be to separate the signalling from the shared memory, making the PCI shared memory device a trivial device with a single memory BAR, and u

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Alexander Graf
On 11.03.2010, at 13:59, Luiz Capitulino wrote: > On Thu, 11 Mar 2010 10:43:09 +0100 > Paolo Bonzini wrote: > >> On 03/11/2010 08:55 AM, Avi Kivity wrote: >>> On 03/10/2010 11:30 PM, Luiz Capitulino wrote: 2. Do we have kvm-specific projects? Can they be part of the QEMU project

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Luiz Capitulino
On Thu, 11 Mar 2010 10:43:09 +0100 Paolo Bonzini wrote: > On 03/11/2010 08:55 AM, Avi Kivity wrote: > > On 03/10/2010 11:30 PM, Luiz Capitulino wrote: > >> > >> 2. Do we have kvm-specific projects? Can they be part of the QEMU project > >> or do we need a different mentoring organization for it?

Re: [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread Arnd Bergmann
On Thursday 11 March 2010, Avi Kivity wrote: > > A totally different option that avoids this whole problem would > > be to separate the signalling from the shared memory, making the > > PCI shared memory device a trivial device with a single memory BAR, > > and using something a higher-level concep

Re: [PATCH] KVM: Trace exception injection

2010-03-11 Thread Avi Kivity
On 03/11/2010 02:31 PM, Gleb Natapov wrote: On Thu, Mar 11, 2010 at 01:51:30PM +0200, Avi Kivity wrote: On 03/11/2010 01:09 PM, Gleb Natapov wrote: On Thu, Mar 11, 2010 at 01:03:12PM +0200, Avi Kivity wrote: Often an exception can help point out where things start to go wrong

Re: [PATCH] KVM: Trace exception injection

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 01:51:30PM +0200, Avi Kivity wrote: > On 03/11/2010 01:09 PM, Gleb Natapov wrote: > >On Thu, Mar 11, 2010 at 01:03:12PM +0200, Avi Kivity wrote: > >>Often an exception can help point out where things start to go wrong. > >> > >Adding guest rip where exception happened will b

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Avi Kivity
On 03/10/2010 11:30 PM, Luiz Capitulino wrote: 2. Do we have kvm-specific projects? Can they be part of the QEMU project or do we need a different mentoring organization for it? Complete big real mode emulation. I'll add this. -- error compiling committee.c: too many arguments to func

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread Paul Brook
> On 03/10/2010 07:41 PM, Paul Brook wrote: > >>> You're much better off using a bulk-data transfer API that relaxes > >>> coherency requirements. IOW, shared memory doesn't make sense for TCG > >> > >> Rather, tcg doesn't make sense for shared memory smp. But we knew that > >> already. > > > > I

Windows Driver for -vga std

2010-03-11 Thread erik . rull
Hi all, using the Default VGA settings Windows XP detects an unknown VGA Device, but everything is fine, Display settings are ok. But how can I setup my XP to detect this virtual graphics board correctly? I just want to continue using this setting but with no complaints in the system/hardware sett

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Avi Kivity
On 03/11/2010 02:03 PM, Alexander Graf wrote: Another idea I'd have would be upstream integration (and cleanup) of the ARM KVM port: https://wiki.ncl.cs.columbia.edu/wiki/index.php/AndroidVirt:MainPage Huh, didn't even know this thing existed. Definitely something to merge. -- error comp

Re: guest patched with pax causes "set_cr0: 0xffff88000[...] #GP, reserved bits 0x8004003?" flood on host

2010-03-11 Thread pageexec
On 11 Mar 2010 at 8:44, Avi Kivity wrote: > On 03/10/2010 06:17 PM, Antoine Martin wrote: > > Hi, > > > > I've updated my host kernel headers to 2.6.33, rebuilt glibc (and the > > base system), rebuilt kvm. > > ... and now I get hundreds of those in dmesg on the host when I start > > a guest ker

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Paolo Bonzini
On 03/11/2010 12:25 PM, Alexander Graf wrote: == Write a C QMP library based on QEMU JSON and QMP code == Suggested by Anthony, mentored by Anthony?:) Possible other candidates are Luiz and Kraxel I guess? I haven't really tracked QMP that much. If you guys are okay with this, I think I could

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Alexander Graf
On 11.03.2010, at 12:58, Avi Kivity wrote: > On 03/11/2010 01:56 PM, Alexander Graf wrote: >> On 11.03.2010, at 12:54, Avi Kivity wrote: >> >> >>> On 03/11/2010 01:25 PM, Alexander Graf wrote: >>> The list is also still missing a lot of potential mentors for the listed ideas.

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Avi Kivity
On 03/11/2010 01:56 PM, Alexander Graf wrote: On 11.03.2010, at 12:54, Avi Kivity wrote: On 03/11/2010 01:25 PM, Alexander Graf wrote: The list is also still missing a lot of potential mentors for the listed ideas. Let me propose some here :) == Shared memory transport between gues

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Avi Kivity
On 03/11/2010 01:56 PM, Avi Kivity wrote: On 03/11/2010 12:23 PM, Gleb Natapov wrote: If the problem it due to lost ticks reinjection may solve it, but only partially. What if IO thread haven't run even once during the time vcpu did clock source check? IIRC sometimes we trigger this even with

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Alexander Graf
On 11.03.2010, at 12:54, Avi Kivity wrote: > On 03/11/2010 01:25 PM, Alexander Graf wrote: >> The list is also still missing a lot of potential mentors for the listed >> ideas. Let me propose some here :) >> >> == Shared memory transport between guest(s) and host == >> >> Sounds like Avi would

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Avi Kivity
On 03/11/2010 12:23 PM, Gleb Natapov wrote: If the problem it due to lost ticks reinjection may solve it, but only partially. What if IO thread haven't run even once during the time vcpu did clock source check? IIRC sometimes we trigger this even with in kernel PIT. That is true. Rein

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Avi Kivity
On 03/11/2010 01:25 PM, Alexander Graf wrote: The list is also still missing a lot of potential mentors for the listed ideas. Let me propose some here :) == Shared memory transport between guest(s) and host == Sounds like Avi would be a good fit. I'm pretty unknowledgeable when it comes to sh

Re: [PATCH] KVM: Trace exception injection

2010-03-11 Thread Avi Kivity
On 03/11/2010 01:09 PM, Gleb Natapov wrote: On Thu, Mar 11, 2010 at 01:03:12PM +0200, Avi Kivity wrote: Often an exception can help point out where things start to go wrong. Adding guest rip where exception happened will be useful too. You get that from the previous kvm_exit tr

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Alexander Graf
On 11.03.2010, at 10:43, Paolo Bonzini wrote: > On 03/11/2010 08:55 AM, Avi Kivity wrote: >> On 03/10/2010 11:30 PM, Luiz Capitulino wrote: >>> >>> 2. Do we have kvm-specific projects? Can they be part of the QEMU project >>> or do we need a different mentoring organization for it? >> >> Someth

Re: guest patched with pax causes "set_cr0: 0xffff88000[...] #GP, reserved bits 0x8004003?" flood on host

2010-03-11 Thread pageexec
On 11 Mar 2010 at 8:44, Avi Kivity wrote: > On 03/10/2010 06:17 PM, Antoine Martin wrote: > > Hi, > > > > I've updated my host kernel headers to 2.6.33, rebuilt glibc (and the > > base system), rebuilt kvm. > > ... and now I get hundreds of those in dmesg on the host when I start > > a guest ker

Re: [PATCH] KVM: Trace exception injection

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 01:03:12PM +0200, Avi Kivity wrote: > Often an exception can help point out where things start to go wrong. > Adding guest rip where exception happened will be useful too. > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/trace.h | 32 >

Re: guest patched with pax causes "set_cr0: 0xffff88000[...] #GP, reserved bits 0x8004003?" flood on host

2010-03-11 Thread Antoine Martin
On 03/11/2010 04:31 PM, pagee...@freemail.hu wrote: On 11 Mar 2010 at 8:44, Avi Kivity wrote: On 03/10/2010 06:17 PM, Antoine Martin wrote: Hi, I've updated my host kernel headers to 2.6.33, rebuilt glibc (and the base system), rebuilt kvm. ... and now I get hundreds of those in dme

Re: [PATCH] KVM: Move kvm_exit tracepoint rip reading inside tracepoint

2010-03-11 Thread Avi Kivity
On 03/11/2010 01:03 PM, Takuya Yoshikawa wrote: > Avi Kivity wrote: > >> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h >> index b75efef..3cf9547 100644 >> --- a/arch/x86/kvm/trace.h >> +++ b/arch/x86/kvm/trace.h >> @@ -182,8 +182,8 @@ TRACE_EVENT(kvm_apic, >> * Tracepoint for kvm gu

[PATCH] KVM: Trace exception injection

2010-03-11 Thread Avi Kivity
Often an exception can help point out where things start to go wrong. Signed-off-by: Avi Kivity --- arch/x86/kvm/trace.h | 32 arch/x86/kvm/x86.c |3 +++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/t

Re: [PATCH] KVM: Move kvm_exit tracepoint rip reading inside tracepoint

2010-03-11 Thread Takuya Yoshikawa
Avi Kivity wrote: > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > index b75efef..3cf9547 100644 > --- a/arch/x86/kvm/trace.h > +++ b/arch/x86/kvm/trace.h > @@ -182,8 +182,8 @@ TRACE_EVENT(kvm_apic, > * Tracepoint for kvm guest exit: > */ > TRACE_EVENT(kvm_exit, > - TP_PROTO(un

Re: [PATCH 02/18] KVM: MMU: Make tdp_enabled a mmu-context parameter

2010-03-11 Thread Joerg Roedel
On Thu, Mar 11, 2010 at 08:47:21AM +0200, Avi Kivity wrote: > > tdp is still used in both cases, so that name is confusing. We > could call it mmu.direct_map (and set it for real mode?) or > mmu.virtual_map (with the opposite sense). Or something. I like the mmu.direct_map name. Its a good term

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 10:46:06AM +0200, Avi Kivity wrote: > On 03/11/2010 10:42 AM, Gleb Natapov wrote: > >On Thu, Mar 11, 2010 at 04:38:48PM +0800, Sheng Yang wrote: > >>On Thursday 11 March 2010 16:31:57 Gleb Natapov wrote: > >>>On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: >

[PATCH] KVM: Don't spam kernel log when injecting exceptions due to bad cr writes

2010-03-11 Thread Avi Kivity
These are guest-triggerable. Signed-off-by: Avi Kivity --- arch/x86/kvm/x86.c | 27 --- 1 files changed, 0 insertions(+), 27 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 169b1b3..66609f6 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.

Re: [PATCH 22/24] KVM: x86 emulator: restart string instruction without going back to a guest.

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 06:58:14PM +0900, Takuya Yoshikawa wrote: > Gleb Natapov wrote: > >On Wed, Mar 10, 2010 at 07:08:31PM +0900, Takuya Yoshikawa wrote: > >>Gleb Natapov wrote: > >Entering guest from time to time will not change semantics of the > >processor (if code is not modified und

Re: [PATCH 22/24] KVM: x86 emulator: restart string instruction without going back to a guest.

2010-03-11 Thread Takuya Yoshikawa
Gleb Natapov wrote: On Wed, Mar 10, 2010 at 07:08:31PM +0900, Takuya Yoshikawa wrote: Gleb Natapov wrote: Entering guest from time to time will not change semantics of the processor (if code is not modified under processor's feet at least). Currently we reenter guest mode after each iteration o

Status of KVM vulnerabilities

2010-03-11 Thread Daniel Bareiro
Hi, all. Recently Debian has published the DSA-2010-1 [1] where the following vulnerabilities are fixed: * CVE-2010-0298 & CVE-2010-0306 (Gleb Natapov) * CVE-2010-0309 (Marcelo Tosatti) * CVE-2010-0419 (Paolo Bonzini) I'm using Linux 2.6.32.3 with qemu-kvm-0.12.1.2 and I would like to know if it

guest kernel debugging through serial port

2010-03-11 Thread Neo Jia
hi, I have followed the windows guest debugging procedure from http://www.linux-kvm.org/page/WindowsGuestDrivers/GuestDebugging. And it works when I start two guests and bind tcp port to guest serial port, but it is really slow. And if I use -serial /dev/ttyS1 for the guest debugging target, I ca

Re: Ideas wiki for GSoC 2010

2010-03-11 Thread Paolo Bonzini
On 03/11/2010 08:55 AM, Avi Kivity wrote: On 03/10/2010 11:30 PM, Luiz Capitulino wrote: 2. Do we have kvm-specific projects? Can they be part of the QEMU project or do we need a different mentoring organization for it? Something really interesting is kvm-assisted tcg. I'm afraid it's a bit t

Re: [PATCH] x86/kvm: Show guest system/user cputime in cpustat

2010-03-11 Thread Sheng Yang
On Thursday 11 March 2010 15:50:54 Avi Kivity wrote: > On 03/11/2010 09:46 AM, Sheng Yang wrote: > > On Thursday 11 March 2010 15:36:01 Avi Kivity wrote: > >> On 03/11/2010 09:20 AM, Sheng Yang wrote: > >>> Currently we can only get the cpu_stat of whole guest as one. This > >>> patch enhanced cpu_

[PATCH] KVM: Move kvm_exit tracepoint rip reading inside tracepoint

2010-03-11 Thread Avi Kivity
Reading rip is expensive on vmx, so move it inside the tracepoint so we only incur the cost if tracing is enabled. Signed-off-by: Avi Kivity --- arch/x86/kvm/svm.c |2 +- arch/x86/kvm/trace.h |6 +++--- arch/x86/kvm/vmx.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) d

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Avi Kivity
On 03/11/2010 10:42 AM, Gleb Natapov wrote: On Thu, Mar 11, 2010 at 04:38:48PM +0800, Sheng Yang wrote: On Thursday 11 March 2010 16:31:57 Gleb Natapov wrote: On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: On 03/11/2010 10:23 AM, Sheng Yang wrote: I ha

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 04:38:48PM +0800, Sheng Yang wrote: > On Thursday 11 March 2010 16:31:57 Gleb Natapov wrote: > > On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: > > > On 03/11/2010 10:23 AM, Sheng Yang wrote: > > > >>>I have kept --no-hpet in my setup for > > > >>>months... > >

Re: [patch 3/3] kvm: allow qemu to set EPT identity mapping address

2010-03-11 Thread Avi Kivity
On 03/09/2010 03:53 AM, Marcelo Tosatti wrote: From: Sheng Yang If we use larger BIOS image than current 256KB, we would need move reserved TSS and EPT identity mapping pages. Currently TSS support this, but not EPT. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/target-i386/kvm.c

Re: [patch 2/3] kvm: handle internal error

2010-03-11 Thread Avi Kivity
On 03/09/2010 03:53 AM, Marcelo Tosatti wrote: Port qemu-kvm's KVM_EXIT_INTERNAL_ERROR handling to upstream. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/kvm-all.c === --- qemu-kvm.orig/kvm-all.c +++ qemu-kvm/kvm-all.c @@ -721,6

Re: [PATCH 2/2] KVM test: Support to SLES install

2010-03-11 Thread yogi
On Wed, 2010-03-10 at 10:42 -0300, Lucas Meneghel Rodrigues wrote: > On Wed, Mar 10, 2010 at 8:45 AM, Lucas Meneghel Rodrigues > wrote: > > From: yogi > > > > Adds new entry "SUSE" in test_base file for sles and > > contains autoinst file for doing unatteneded Sles11 64-bit > > install. > > Oh Y

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Sheng Yang
On Thursday 11 March 2010 16:31:57 Gleb Natapov wrote: > On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: > > On 03/11/2010 10:23 AM, Sheng Yang wrote: > > >>>I have kept --no-hpet in my setup for > > >>>months... > > >> > > >>Any details about the problems? HPET is important to some gu

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Avi Kivity
On 03/11/2010 10:31 AM, Gleb Natapov wrote: On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: On 03/11/2010 10:23 AM, Sheng Yang wrote: I have kept --no-hpet in my setup for months... Any details about the problems? HPET is important to some guests.

Re: [patch 1/3] target-i386: print EFER in cpu_dump_state

2010-03-11 Thread Avi Kivity
On 03/09/2010 03:53 AM, Marcelo Tosatti wrote: Signed-off-by: Marcelo Tosatti Index: qemu-kvm-uq/target-i386/helper.c === --- qemu-kvm-uq.orig/target-i386/helper.c +++ qemu-kvm-uq/target-i386/helper.c @@ -1176,6 +1176,7 @@ void cpu_

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-11 Thread Avi Kivity
On 03/02/2010 02:14 AM, Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (init

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Gleb Natapov
On Thu, Mar 11, 2010 at 10:28:12AM +0200, Avi Kivity wrote: > On 03/11/2010 10:23 AM, Sheng Yang wrote: > >>>I have kept --no-hpet in my setup for > >>>months... > >>Any details about the problems? HPET is important to some guests. > >> > >Seems like HPET reaction is too slow to satisfy some guest

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Avi Kivity
On 03/11/2010 10:23 AM, Sheng Yang wrote: I have kept --no-hpet in my setup for months... Any details about the problems? HPET is important to some guests. Seems like HPET reaction is too slow to satisfy some guests(for it would replace PIT). Here is the thread last time. http

Re: Make QEmu HPET disabled by default for KVM?

2010-03-11 Thread Sheng Yang
On Thursday 11 March 2010 15:58:12 Avi Kivity wrote: > On 03/11/2010 09:52 AM, Sheng Yang wrote: > > I think we have already suffered enough timer issues due to this(e.g. I > > can't boot up well on 2.6.18 kernel)... > > 2.6.18 as guest or as host? Guest > > I have kept --no-hpet in my setup fo

Re: [PATCH] x86/kvm: Show guest system/user cputime in cpustat

2010-03-11 Thread Zhang, Yanmin
On Thu, 2010-03-11 at 09:50 +0200, Avi Kivity wrote: > On 03/11/2010 09:46 AM, Sheng Yang wrote: > > On Thursday 11 March 2010 15:36:01 Avi Kivity wrote: > > > >> On 03/11/2010 09:20 AM, Sheng Yang wrote: > >> > > >>> Currently we can only get the cpu_stat of whole guest as one. This pa