Re: [Autotest] [KVM_AUTOTEST] add kvm hugepage variant

2009-07-21 Thread sudhir kumar
The patch looks to be pretty clean to me. I was running a small hugetlbfs script doing the same, but its good now as the script is being incorporated in the test. On Tue, Jul 21, 2009 at 9:34 PM, Lukáš Doktor wrote: > Well, thank you for notifications, I'll keep them in my mind. > > Also the probl

Re: USB passthrough does not work

2009-07-21 Thread Brian Jackson
I don't know if this might be effecting you, but KVM does not support USB-2. More and more devices these days are USB-2 only. It's at least worth checking out. In any case... copying files over USB-1.1 is going to be terribly painful. --Iggy On Tuesday 21 July 2009 19:44:33 Andreas Kinzler wro

USB passthrough does not work

2009-07-21 Thread Andreas Kinzler
I am using kvm-88 and trying to passthrough an USB storage device (usb memory stick) via -usb -usbdevice host:: In Vista x64 the device appears but has error code 10 (this device cannot start). Any ideas? Andreas -- GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freis

[PATCH] fix serious regression

2009-07-21 Thread Glauber Costa
Today I found a very catastrophic regression: I cannot run my mission critical servers running RHL7.1 anymore. This is a total disaster. Fortunately, I was able to isolate the commit that caused it: commit bb598da496c040d42dde564bd8ace181be52293e Author: Glauber Costa Date: Mon Jul

Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

2009-07-21 Thread Marcelo Tosatti
On Wed, Jul 22, 2009 at 01:29:24AM +0200, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Tue, Jul 21, 2009 at 10:24:08AM +0200, Jan Kiszka wrote: > >> Marcelo Tosatti wrote: > >>> Jan, > >>> > >>> This was suggested but we thought it might be safer to keep the > >>> get_cpu/put_cpu pair in case

Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

2009-07-21 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Tue, Jul 21, 2009 at 10:24:08AM +0200, Jan Kiszka wrote: >> Marcelo Tosatti wrote: >>> Jan, >>> >>> This was suggested but we thought it might be safer to keep the >>> get_cpu/put_cpu pair in case -rt kernels require it (which might be >>> bullshit, but nobody verified).

RE: VGA address mapping?

2009-07-21 Thread Saksena, Abhishek
Would also like to mention I am not using Qemu and building some basic IO models around KVM (only using libkvm.h) -Abhishek From: Saksena, Abhishek Sent: Tuesday, July 21, 2009 11:13 AM To: kvm@vger.kernel.org Subject: VGA address mapping? Hi I am implementing a

[PATCH v2 3/6] remove kvm_abi variable

2009-07-21 Thread Glauber Costa
We're not using this for anything Signed-off-by: Glauber Costa --- qemu-kvm.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 8eeace4..a8298e4 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -43,7 +43,6 @@ int kvm_pit = 1; int kvm_pit_reinjec

[PATCH v2 6/6] remove kvm_mmio_read and kvm_mmio_write

2009-07-21 Thread Glauber Costa
all they did was to call a qemu function. Call this function instead. Signed-off-by: Glauber Costa --- qemu-kvm-x86.c |7 +-- qemu-kvm.c | 34 -- 2 files changed, 9 insertions(+), 32 deletions(-) diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index 35

[PATCH v2 5/6] remove kvm_specific kvm_out* functions

2009-07-21 Thread Glauber Costa
As example of what was already done with inb. This is a little bit more tricky, because of SMM, but those bits are handled directly in apic anyway. Signed-off-by: Glauber Costa --- qemu-kvm.c | 60 +++- 1 files changed, 3 insertions(+), 5

[PATCH v2 4/6] remove created from kvm_state

2009-07-21 Thread Glauber Costa
Again, CPUState has it, and it means exactly that. Signed-off-by: Glauber Costa --- cpu-defs.h |1 - qemu-kvm.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index fce366f..ce9f96a 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -142,7

[PATCH v2 2/6] reuse env stop and stopped states

2009-07-21 Thread Glauber Costa
qemu CPUState already provides "stop" and "stopped" states. And they mean exactly that. There is no need for us to provide our own. Signed-off-by: Glauber Costa --- cpu-defs.h |2 -- qemu-kvm.c | 30 -- vl.c |2 +- 3 files changed, 13 insertions(+), 21

[PATCH v2 1/6] remove kvm_in* functions

2009-07-21 Thread Glauber Costa
We can use plain qemu's here, and save a couple of lines/complexity. I'm leaving outb for later, because the SMM thing makes it a little bit less trivial. Signed-off-by: Glauber Costa --- qemu-kvm.c | 25 - 1 files changed, 4 insertions(+), 21 deletions(-) diff --git a

[PATCH v2 0/6]

2009-07-21 Thread Glauber Costa
Marcelo, since you told me that you were not confrotable with the --enable-kvm change without avi's ack, I'm dropping it, and sending the rest of the series again. On top of that, I'm also including some more cleanup patches: one removes kvm_out{b,w,l}, in the same way I've already done with kvm

Re: [PATCH] qemu-kvm: reserve the low 24 gsi values

2009-07-21 Thread Michael S. Tsirkin
On Tue, Jul 21, 2009 at 08:21:15PM +0300, Gleb Natapov wrote: > On Tue, Jul 21, 2009 at 06:57:42PM +0300, Michael S. Tsirkin wrote: > > reserve gsi 0 to 23 so that they won't be allocated for msi > > > In the not so distant future we may want to support more then one > ioapic, so 23 will became 23

VGA address mapping?

2009-07-21 Thread Saksena, Abhishek
Hi I am implementing a VGA Device model. The model provides functions to read/write VGA memory space. Just for testing I want to capture memory reads/writes to addresses 0xA->0xC and forward it to my VGA model. I have used following function to create physical ram int kvm_create (

Re: [PATCH] KVM: VMX: Fix locking imbalance on emulation failure

2009-07-21 Thread Marcelo Tosatti
On Tue, Jul 21, 2009 at 10:43:07AM +0200, Jan Kiszka wrote: > We have to disable preemption and IRQs on every exit from > handle_invalid_guest_state, otherwise we generate at least a > preempt_disable imbalance. > > Signed-off-by: Jan Kiszka > --- > > arch/x86/kvm/vmx.c |2 +- > 1 files cha

Re: qemu-kvm missing some msix capability check

2009-07-21 Thread Michael S. Tsirkin
On Tue, Jul 21, 2009 at 10:42:19PM +0530, Amit Shah wrote: > On (Tue) Jul 21 2009 [19:54:00], Michael S. Tsirkin wrote: > > On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > > > Hello, > > > > > > Using recent qemu-kvm userspace with a slightly older kernel module I > > > get this when

Re: qemu-kvm missing some msix capability check

2009-07-21 Thread Michael S. Tsirkin
On Tue, Jul 21, 2009 at 10:42:19PM +0530, Amit Shah wrote: > On (Tue) Jul 21 2009 [19:54:00], Michael S. Tsirkin wrote: > > On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > > > Hello, > > > > > > Using recent qemu-kvm userspace with a slightly older kernel module I > > > get this when

Re: [Autotest] [KVM-AUTOTEST PATCH 15/17] KVM test: add timedrift test to kvm_tests.cfg.sample

2009-07-21 Thread Marcelo Tosatti
On Tue, Jul 21, 2009 at 06:41:09AM -0400, Michael Goldish wrote: > > - "Dor Laor" wrote: > > > On 07/20/2009 06:07 PM, Michael Goldish wrote: > > > Currently the test will only run on Windows. > > > It should be able to run on Linux just as well, but if I understand > > correctly, > > > test

Re: [PATCH 02/11] Unregister ack notifier callback on PIT freeing.

2009-07-21 Thread Gleb Natapov
On Tue, Jul 21, 2009 at 02:16:43PM -0300, Marcelo Tosatti wrote: > On Thu, Jul 16, 2009 at 05:03:30PM +0300, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > arch/x86/kvm/i8254.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/kvm

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Marcelo Tosatti
On Tue, Jul 21, 2009 at 12:23:15PM +0300, Dor Laor wrote: > On 07/20/2009 06:07 PM, Michael Goldish wrote: >> 1) Log into a guest. >> 2) Take a time reading from the guest and host. >> 3) Run load on the guest and host. >> 4) Take a second time reading. >> 5) Stop the load and rest for a while. >>

Re: [PATCH 02/11] Unregister ack notifier callback on PIT freeing.

2009-07-21 Thread Marcelo Tosatti
On Thu, Jul 16, 2009 at 05:03:30PM +0300, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/i8254.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c > index 137e548..472653c 100644 > --- a/arch/x86/

Re: [PATCH] qemu-kvm: reserve the low 24 gsi values

2009-07-21 Thread Gleb Natapov
On Tue, Jul 21, 2009 at 06:57:42PM +0300, Michael S. Tsirkin wrote: > reserve gsi 0 to 23 so that they won't be allocated for msi > In the not so distant future we may want to support more then one ioapic, so 23 will became 23*n where n is a number of ioapics. I prefer to fix it by moving msi inje

Re: [Autotest] [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Martin Bligh
> The advantages I see are: 1. it more closely follows the current > autotest structure/layout, 2. solves the problem of separating each test > out of the ever growing kvm_test.py and gives a sub dir of each test for > better structure (something we have been talking about) and 3. addresses > the c

[PATCH v2 5/5] use upstream cpuid code

2009-07-21 Thread Glauber Costa
use cpuid code from upstream. By doing that, we lose the following snippet in kvm_get_supported_cpuid(): ret |= 1 << 12; /* MTRR */ ret |= 1 << 16; /* PAT */ ret |= 1 << 7; /* MCE */ ret |= 1 << 14; /* MCA */ A quick search in mailing lists says this code is not really necessary,

[PATCH v2 4/5] check extension

2009-07-21 Thread Glauber Costa
use upstream check_extension code Signed-off-by: Glauber Costa --- hw/device-assignment.c |2 +- kvm-all.c |2 ++ qemu-kvm-x86.c |6 +++--- qemu-kvm.c | 18 -- qemu-kvm.h |2 +- 5 files changed, 11 insertions(+), 19 d

[PATCH v2 3/5] reuse kvm_ioctl

2009-07-21 Thread Glauber Costa
Start using kvm_ioctl's code. For type safety, delete fd from kvm_context entirely, so the compiler can play along with us helping to detect errors I might have made. Signed-off-by: Glauber Costa Also, we were slightly different from qemu upstream in handling error code from ioctl, since we were

[PATCH v2 2/5] reuse kvm_vm_ioctl

2009-07-21 Thread Glauber Costa
Start using kvm_vm_ioctl's code. For type safety, delete vm_fd from kvm_context entirely, so the compiler can play along with us helping to detect errors I might have made. Also, we were slightly different from qemu upstream in handling error code from ioctl, since we were always testing for -1, w

[PATCH v2 1/5] remove kvm types from handle unhandled

2009-07-21 Thread Glauber Costa
I'm in an ongoing process of not using kvm-specific types in function declarations. handle_unhandled() is the first victim. Since we don't really use this data, but just the reason, remove them entirely. Signed-off-by: Glauber Costa --- qemu-kvm.c |9 +++-- 1 files changed, 3 insertions(

[PATCH v2 0/5] qemu-kvm cleanups: ioctl merge

2009-07-21 Thread Glauber Costa
Marcelo, This is a resend of the ioctl series. I'm now changing all call sites to reflect upstream behaviour. Thanks! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: KVM Irq injection

2009-07-21 Thread Gleb Natapov
On Tue, Jul 21, 2009 at 08:57:26AM -0700, Saksena, Abhishek wrote: > > > > Hi, > I am building some device models around the KVM and am intersted in injecting > IRQs. > > The current LibKVM.h provides following function > > int kvm_inject_irq ( > kvm_context_t >kvm, >

Re: qemu-kvm missing some msix capability check

2009-07-21 Thread Amit Shah
On (Tue) Jul 21 2009 [19:54:00], Michael S. Tsirkin wrote: > On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > > Hello, > > > > Using recent qemu-kvm userspace with a slightly older kernel module I > > get this when using the virtio-net device: > > > > kvm_msix_add: kvm_get_irq_route_g

Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

2009-07-21 Thread Marcelo Tosatti
On Tue, Jul 21, 2009 at 10:24:08AM +0200, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > Jan, > > > > This was suggested but we thought it might be safer to keep the > > get_cpu/put_cpu pair in case -rt kernels require it (which might be > > bullshit, but nobody verified). > > -rt stumbles over b

Re: [PATCH 1/2][v2] KVM: Introduce KVM_SET_IDENTITY_MAP_ADDR ioctl

2009-07-21 Thread Marcelo Tosatti
On Tue, Jul 21, 2009 at 10:42:48AM +0800, Sheng Yang wrote: > Now KVM allow guest to modify guest's physical address of EPT's identity > mapping page. > > (change from v1, discard unnecessary check, change ioctl to accept parameter > address rather than value) > > Signed-off-by: Sheng Yang > --

Re: qemu-kvm missing some msix capability check

2009-07-21 Thread Michael S. Tsirkin
On Fri, Jul 17, 2009 at 06:34:40PM +0530, Amit Shah wrote: > Hello, > > Using recent qemu-kvm userspace with a slightly older kernel module I > get this when using the virtio-net device: > > kvm_msix_add: kvm_get_irq_route_gsi failed: No space left on device > > ... and the guest doesn't use the

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread David Huff
Michael Goldish wrote: > - "David Huff" wrote: >> The way I always envisioned it was something like this.. >> >> The config file specifies the whole test matrix, ie all variants that >> you could run each test on, ie all os's, all archs, all disk types, >> all >> cpu/mem configurations. >>

Re: [PATCH 1/2] virtio: fix memory leak on device removal

2009-07-21 Thread Michael S. Tsirkin
Free up msi vector tables. Signed-off-by: Michael S. Tsirkin --- Resending with corrected To list. Sorry about the churn. drivers/virtio/virtio_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 193c8

Re: [KVM_AUTOTEST] add kvm hugepage variant

2009-07-21 Thread Lukáš Doktor
Well, thank you for notifications, I'll keep them in my mind. Also the problem with mempath vs. mem-path is solved. It was just a misspell in one version of KVM. * fixed patch attached Dne 20.7.2009 14:58, Lucas Meneghel Rodrigues napsal(a): On Fri, 2009-07-10 at 12:01 +0200, Lukáš Doktor wr

[PATCH 1/2] virtio: fix memory leak on device removal

2009-07-21 Thread Michael S. Tsirkin
Free up msi vector tables. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 193c8f0..dab3c86 100644 --- a/drivers/virtio/virtio_pci.c +++ b/

[PATCH 2/2] virtio: fix double free_irq

2009-07-21 Thread Michael S. Tsirkin
Decrement used vectors counter when removing the vq so that vp_free_vectors does not try to free the vector again. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/v

[PATCH 0/2] virtio: device removal fixes

2009-07-21 Thread Michael S. Tsirkin
Here are a couple of obviously correct fixes for virtio device removal. Since these fix regressions (for devices with msi-x capability), I think we need them for 2.6.31. Sorry about the late notice. Michael S. Tsirkin (2): virtio: fix memory leak on device removal virtio: fix double free_irq

KVM Irq injection

2009-07-21 Thread Saksena, Abhishek
Hi, I am building some device models around the KVM and am intersted in injecting IRQs. The current LibKVM.h provides following function int kvm_inject_irq ( kvm_context_t kvm, int vcpu, unsignedirq ) Simulate an external

[PATCH] qemu-kvm: reserve the low 24 gsi values

2009-07-21 Thread Michael S. Tsirkin
reserve gsi 0 to 23 so that they won't be allocated for msi Signed-off-by: Michael S. Tsirkin --- diff --git a/qemu-kvm.c b/qemu-kvm.c index c6c9fc6..f440b2d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1613,10 +1613,12 @@ int kvm_get_irq_route_gsi(kvm_context_t kvm) { int i, bit;

Re: KVM: SVM: force new asid on vcpu migration

2009-07-21 Thread Joerg Roedel
On Tue, Jul 21, 2009 at 12:47:45PM -0300, Marcelo Tosatti wrote: > > If a migrated vcpu matches the asid_generation value of the target pcpu, > there will be no TLB flush via TLB_CONTROL_FLUSH_ALL_ASID. > > The check for vcpu.cpu in pre_svm_run is meaningless since svm_vcpu_load > already update

KVM: SVM: force new asid on vcpu migration

2009-07-21 Thread Marcelo Tosatti
If a migrated vcpu matches the asid_generation value of the target pcpu, there will be no TLB flush via TLB_CONTROL_FLUSH_ALL_ASID. The check for vcpu.cpu in pre_svm_run is meaningless since svm_vcpu_load already updated it on schedule in. Such vcpu will VMRUN with stale TLB entries. Based on

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 11:29:56AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote: > > > 1) Log into a guest. > > > 2) Take a time reading from the guest and host. > > > 3) Run load on the guest and host. > > >

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Michael Goldish
- "Yolkfull Chow" wrote: > On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote: > > 1) Log into a guest. > > 2) Take a time reading from the guest and host. > > 3) Run load on the guest and host. > > 4) Take a second time reading. > > 5) Stop the load and rest for a while. > > 6)

Re: KVM crashes when using certain USB device

2009-07-21 Thread Jim Paris
G wrote: > On Tue, Jul 21, 2009 at 1:23 AM, Jim Paris wrote: > > Here's a patch to try.  I'm not familiar with the code, but it looks > > like this buffer might be too small versus the packet lengths that > > you're seeing, and similar definitions in hw/usb-uhci.c. > > > > -jim > > > > diff -urN kv

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Michael Goldish
- "David Huff" wrote: > Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > > > >> Currently we have our kvm test control file and configuration > file, > >> having them split like this makes it harder for users to edit it, > >> let's > >> say, using the web frontend. > >>

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Yolkfull Chow
On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote: > 1) Log into a guest. > 2) Take a time reading from the guest and host. > 3) Run load on the guest and host. > 4) Take a second time reading. > 5) Stop the load and rest for a while. > 6) Take a third time reading. > 7) If the drift

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread David Huff
Michael Goldish wrote: > - "Lucas Meneghel Rodrigues" wrote: > >> Currently we have our kvm test control file and configuration file, >> having them split like this makes it harder for users to edit it, >> let's >> say, using the web frontend. >> >> So it might be good to merge the control fi

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Michael Goldish
- "Ryan Harper" wrote: > * Michael Goldish [2009-07-21 07:38]: > > > > - "Lucas Meneghel Rodrigues" wrote: > > > > > Currently we have our kvm test control file and configuration > file, > > > having them split like this makes it harder for users to edit it, > > > let's > > > say, us

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Ryan Harper
* Michael Goldish [2009-07-21 07:38]: > > - "Lucas Meneghel Rodrigues" wrote: > > > Currently we have our kvm test control file and configuration file, > > having them split like this makes it harder for users to edit it, > > let's > > say, using the web frontend. > > > > So it might be go

Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

2009-07-21 Thread Andrea Arcangeli
Hi, I suggested this too first time around when I've seen the patch but they reminded it's needed to make life easier to preempt-rt... On Mon, Jul 20, 2009 at 11:30:12AM +0200, Jan Kiszka wrote: > spin_lock disables preemption, so we can simply read the current cpu. > > Signed-off-by: Jan Kiszka

Re: [PATCH] rev7: support colon in filenames

2009-07-21 Thread Kevin Wolf
Ram Pai schrieb: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example filename scsi:0, is > interpreted as a protocol by name "scsi". > > This patch allows user to espace colon characters. For example the above > fil

Re: [RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Michael Goldish
- "Lucas Meneghel Rodrigues" wrote: > Currently we have our kvm test control file and configuration file, > having them split like this makes it harder for users to edit it, > let's > say, using the web frontend. > > So it might be good to merge the control file and the config file, > and >

Re: [PATCH 6/9] remove kvm_in* functions

2009-07-21 Thread Gleb Natapov
On Tue, Jul 21, 2009 at 09:23:24AM -0300, Glauber Costa wrote: > On Tue, Jul 21, 2009 at 09:11:06AM +0300, Gleb Natapov wrote: > > On Mon, Jul 20, 2009 at 07:10:13PM -0400, Glauber Costa wrote: > > > We can use plain qemu's here, and save a couple of lines/complexity. > > > I'm leaving outb for lat

Re: [PATCH 6/9] remove kvm_in* functions

2009-07-21 Thread Glauber Costa
On Tue, Jul 21, 2009 at 09:11:06AM +0300, Gleb Natapov wrote: > On Mon, Jul 20, 2009 at 07:10:13PM -0400, Glauber Costa wrote: > > We can use plain qemu's here, and save a couple of lines/complexity. > > I'm leaving outb for later, because the SMM thing makes it a little bit > > less trivial. > >

[RFC] KVM test: Refactoring the kvm control file and the config file

2009-07-21 Thread Lucas Meneghel Rodrigues
Currently we have our kvm test control file and configuration file, having them split like this makes it harder for users to edit it, let's say, using the web frontend. So it might be good to merge the control file and the config file, and make a refactor on the control file code. Do you think thi

Re: [Autotest] [KVM-AUTOTEST PATCH 15/17] KVM test: add timedrift test to kvm_tests.cfg.sample

2009-07-21 Thread Michael Goldish
- "Dor Laor" wrote: > On 07/20/2009 06:07 PM, Michael Goldish wrote: > > Currently the test will only run on Windows. > > It should be able to run on Linux just as well, but if I understand > correctly, > > testing time drift on Linux is less interesting. > > Linux is interesting too. The p

Re: [Autotest] [KVM-AUTOTEST PATCH 15/17] KVM test: add timedrift test to kvm_tests.cfg.sample

2009-07-21 Thread Dor Laor
On 07/20/2009 06:07 PM, Michael Goldish wrote: Currently the test will only run on Windows. It should be able to run on Linux just as well, but if I understand correctly, testing time drift on Linux is less interesting. Linux is interesting too. The problem is more visible on windows since it u

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Dor Laor
On 07/21/2009 12:37 PM, Michael Goldish wrote: - "Dor Laor" wrote: On 07/20/2009 06:07 PM, Michael Goldish wrote: 1) Log into a guest. 2) Take a time reading from the guest and host. 3) Run load on the guest and host. 4) Take a second time reading. 5) Stop the load and rest for a while. 6

Re: KVM crashes when using certain USB device

2009-07-21 Thread G
On Tue, Jul 21, 2009 at 1:23 AM, Jim Paris wrote: > G wrote: >> And thanks for your help and suggestions so far, btw. > > Here's a patch to try.  I'm not familiar with the code, but it looks > like this buffer might be too small versus the packet lengths that > you're seeing, and similar definitio

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Michael Goldish
- "Dor Laor" wrote: > On 07/20/2009 06:07 PM, Michael Goldish wrote: > > 1) Log into a guest. > > 2) Take a time reading from the guest and host. > > 3) Run load on the guest and host. > > 4) Take a second time reading. > > 5) Stop the load and rest for a while. > > 6) Take a third time read

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Dor Laor
On 07/20/2009 06:07 PM, Michael Goldish wrote: 1) Log into a guest. 2) Take a time reading from the guest and host. 3) Run load on the guest and host. 4) Take a second time reading. 5) Stop the load and rest for a while. 6) Take a third time reading. 7) If the drift immediately after load is high

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >> Previously, I used 'create partition primary' to verify whether the disk >> could be formatted but always got an error: >> --- >> diskpart has encou

[PATCH] KVM: VMX: Fix locking imbalance on emulation failure

2009-07-21 Thread Jan Kiszka
We have to disable preemption and IRQs on every exit from handle_invalid_guest_state, otherwise we generate at least a preempt_disable imbalance. Signed-off-by: Jan Kiszka --- arch/x86/kvm/vmx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >> Previously, I used 'create partition primary' to verify whether the disk >> could be formatted but always got an error: >> --- >> diskpart has encou

Re: [PATCH] kvm: Drop obsolete cpu_get/put in make_all_cpus_request

2009-07-21 Thread Jan Kiszka
Marcelo Tosatti wrote: > Jan, > > This was suggested but we thought it might be safer to keep the > get_cpu/put_cpu pair in case -rt kernels require it (which might be > bullshit, but nobody verified). -rt stumbles over both patterns (that's why I stumbled over it in the first place: get_cpu disa

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-21 Thread Yaniv Kaul
On 7/21/2009 9:11 AM, Yolkfull Chow wrote: Previously, I used 'create partition primary' to verify whether the disk could be formatted but always got an error: --- diskpart has encountered an error... --- And then I found the SCSI disk was added to Windows guest was read-only. So I