Re: guest gettimeofday behavior

2009-07-15 Thread Eran Rom
Eran Rom il.ibm.com> writes: > > When Host and Guest ran 2.6.27 with kvm-87 (both qemu-kvm and kvm-kmod), the > > problem persisted. Thus, I am looking for a kernel fix that is not > part of KVM, > > any lead? Am confined to use 2.6.27 > Marcelo Tosatti wrote on 16/07/2009 01:19:40: > Is it an

Re: [PATCH] always report x2apic as supported feature

2009-07-15 Thread Gleb Natapov
On Thu, Jul 16, 2009 at 02:09:09PM +0800, Sheng Yang wrote: > On Thursday 16 July 2009 14:00:15 Gleb Natapov wrote: > > On Thu, Jul 16, 2009 at 09:46:21AM +0800, Sheng Yang wrote: > > > On Thursday 16 July 2009 07:01:30 Marcelo Tosatti wrote: > > > > On Sun, Jul 12, 2009 at 04:10:55PM +0300, Gleb N

Re: [PATCH] always report x2apic as supported feature

2009-07-15 Thread Sheng Yang
On Thursday 16 July 2009 14:00:15 Gleb Natapov wrote: > On Thu, Jul 16, 2009 at 09:46:21AM +0800, Sheng Yang wrote: > > On Thursday 16 July 2009 07:01:30 Marcelo Tosatti wrote: > > > On Sun, Jul 12, 2009 at 04:10:55PM +0300, Gleb Natapov wrote: > > > > We emulate x2apic in software, so host support

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Gleb Natapov
On Wed, Jul 15, 2009 at 06:42:05PM -0300, Marcelo Tosatti wrote: > On Wed, Jul 15, 2009 at 11:52:24PM +0300, Gleb Natapov wrote: > > On Wed, Jul 15, 2009 at 03:18:00PM -0300, Marcelo Tosatti wrote: > > > On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > > > > Use gsi indexed array ins

Re: [PATCH] always report x2apic as supported feature

2009-07-15 Thread Gleb Natapov
On Thu, Jul 16, 2009 at 09:46:21AM +0800, Sheng Yang wrote: > On Thursday 16 July 2009 07:01:30 Marcelo Tosatti wrote: > > On Sun, Jul 12, 2009 at 04:10:55PM +0300, Gleb Natapov wrote: > > > We emulate x2apic in software, so host support is not required. > > > > > > Signed-off-by: Gleb Natapov > >

Re: "set_link" monitor command

2009-07-15 Thread Yaniv Kaul
On 7/16/2009 2:30 AM, Michael Jinks wrote: Like I said in my other network puzzlement thread, I have one KVM guest which is working fine. Or, it was until I tried to add a second one, and hosed my virtual bridge. The guest is still running, but since I restarted the bridge interface that its NI

Re: [PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Sheng Yang
On Thursday 16 July 2009 12:57:02 Jordan Justen wrote: > On Wed, Jul 15, 2009 at 8:08 PM, Sheng Yang wrote: > > On Thursday 16 July 2009 10:58:53 Jordan Justen wrote: > >> On Wed, Jul 15, 2009 at 6:34 PM, Sheng Yang wrote: > >> > On Thursday 16 July 2009 08:12:15 Jordan Justen wrote: > >> > > Mot

Re: [AUTOTEST] [PATCH 1/5] update ltp.patch

2009-07-15 Thread sudhir kumar
Martin, Lucas Do I need to resend the patches as attachments ? I hope you would have a given a look on the patches. Please let me know if still something more needs to be done. I am happy addressing all your comments. On Mon, Jul 13, 2009 at 11:33 AM, sudhir kumar wrote: > This patch updates the l

Re: [PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Jordan Justen
On Wed, Jul 15, 2009 at 8:08 PM, Sheng Yang wrote: > On Thursday 16 July 2009 10:58:53 Jordan Justen wrote: >> On Wed, Jul 15, 2009 at 6:34 PM, Sheng Yang wrote: >> > On Thursday 16 July 2009 08:12:15 Jordan Justen wrote: >> > > >> > > Motivation for making these changes: >> > > >> > > A larger fi

Re: [Autotest] [RFC] KVM-Autotest: remote shell utility for Windows guests

2009-07-15 Thread sudhir kumar
Thats great Michael !! On Wed, Jul 15, 2009 at 8:56 PM, Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > >> On Wed, Jul 8, 2009 at 4:46 AM, Michael Goldish >> wrote: >> > I'm resending the message because it probably got filtered out due >> to the >> > attached setup.bat file.

Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line

2009-07-15 Thread sudhir kumar
On Thu, Jul 16, 2009 at 8:12 AM, Yolkfull Chow wrote: > On 07/15/2009 09:36 PM, Dor Laor wrote: >> On 07/15/2009 12:12 PM, Yolkfull Chow wrote: >>> Would submit this patch which is from our internal kvm-autotest >>> patches submitted by Jason. >>> So that we could go on test case about parameters v

Re: [PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Sheng Yang
On Thursday 16 July 2009 10:58:53 Jordan Justen wrote: > On Wed, Jul 15, 2009 at 6:34 PM, Sheng Yang wrote: > > On Thursday 16 July 2009 08:12:15 Jordan Justen wrote: > > > Previously the KVM kernel module would allocate the address range > > > of 0xfffbc000-0xfffbcfff for the EPT Indentity Page T

Re: Mouse and keyboard handling on the VNC console

2009-07-15 Thread Michael Jinks
On Wed, Jul 15, 2009 at 8:04 PM, Michael Jinks wrote: > > I'm installing the old VNC package now, hoping it's better... Nope, it's worse. Carries the same sort of failure to connect that I saw with TightVNC, immediate failure and "Rect too big" to stderr. Has the world moved to some other set of

Re: [PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Jordan Justen
On Wed, Jul 15, 2009 at 6:34 PM, Sheng Yang wrote: > > On Thursday 16 July 2009 08:12:15 Jordan Justen wrote: > > Previously the KVM kernel module would allocate the address range > > of 0xfffbc000-0xfffbcfff for the EPT Indentity Page Tables. > > A separate patch is moving that to 0xfeffc000-0xfe

Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line

2009-07-15 Thread Yolkfull Chow
On 07/15/2009 09:36 PM, Dor Laor wrote: On 07/15/2009 12:12 PM, Yolkfull Chow wrote: Would submit this patch which is from our internal kvm-autotest patches submitted by Jason. So that we could go on test case about parameters verification(UUID, DMI data etc). Signed-off-by: Yolkfull Chow ---

Re: qcow2 relative paths (was: [PATCH] rev5: support colon in filenames)

2009-07-15 Thread Ram Pai
On Wed, 2009-07-15 at 22:04 +0100, Jamie Lokier wrote: > Ram Pai wrote: > > I have successfully verified qcow2 files. But then I may not be trying > > out the exact thing that you are talking about. Can you give me a test > > case that I can verify. > > Commands tried with qemu-0.10.0-1ubuntu1: >

Re: [PATCH] always report x2apic as supported feature

2009-07-15 Thread Sheng Yang
On Thursday 16 July 2009 07:01:30 Marcelo Tosatti wrote: > On Sun, Jul 12, 2009 at 04:10:55PM +0300, Gleb Natapov wrote: > > We emulate x2apic in software, so host support is not required. > > > > Signed-off-by: Gleb Natapov > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 00844e

Re: [PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Sheng Yang
On Thursday 16 July 2009 08:12:15 Jordan Justen wrote: > Previously the KVM kernel module would allocate the address range > of 0xfffbc000-0xfffbcfff for the EPT Indentity Page Tables. > A separate patch is moving that to 0xfeffc000-0xfeffcfff. Hi Jordan You need one more patch for upstream kvm,

Re: Mouse and keyboard handling on the VNC console

2009-07-15 Thread Michael Jinks
After finishing some Windows guest setups, I've now discovered thet vinagre's "send ctl-alt-delete" button doesn't work either. I'm installing the old VNC package now, hoping it's better... On Wed, Jul 15, 2009 at 7:24 PM, Michael Jinks wrote: > I'm not sure if I'm having VNC trouble, or KVM tro

Mouse and keyboard handling on the VNC console

2009-07-15 Thread Michael Jinks
I'm not sure if I'm having VNC trouble, or KVM trouble. I'm using vinagre as my VNC client, connecting to localhost. Usually I use TightVNC but Avi says it's broken, and it sure won't attach to a QEMU server. Both work fine if I connect to one of my own VNC servers (Linux). Against a KVM consol

[PATCH] Update qemu-kvm to allow a larger BIOS image.

2009-07-15 Thread Jordan Justen
Previously the KVM kernel module would allocate the address range of 0xfffbc000-0xfffbcfff for the EPT Indentity Page Tables. A separate patch is moving that to 0xfeffc000-0xfeffcfff. This patch updates qemu-kvm to move the VMX TSS Pages & update the KVM BIOS code to update the E820 BIOS call memo

[PATCH] Update KVM kernel module to allow a larger BIOS image.

2009-07-15 Thread Jordan Justen
Previously the KVM kernel module would allocate the address range of 0xfffbc000-0xfffbcfff for the EPT Indentity Page Tables. This change moves that to 0xfeffc000-0xfeffcfff. Another issue related to this change is the VMC TSS Pages were located at 0xfffbd000-0xfffb. This is controlled by the

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Anthony Liguori
Jamie Lokier wrote: So instead of consistency, you like the idea of using different quoting rules for the monitor than for command line arguments? Your proposal breaks Windows in a catastrophic way. It's almost certain that all existing front-ends/scripts will stop working after such a cha

Re: Trouble understanding net config options

2009-07-15 Thread Charles Duffy
Michael Jinks wrote: On Wed, Jul 15, 2009 at 6:24 PM, Chris Webb wrote: You want -net nic,vlan=0 -net tap,vlan=0,ifname=tap11 -net nic,vlan=1 -net tap,vlan=1,ifname=tap12 Progress! This works, I can bring up the guest and watch it boot, but both of its NICs came up bound to the first bridg

Re: "set_link" monitor command

2009-07-15 Thread Michael Jinks
Another monitor command question: trying to rescue my de-networked guest, I thought I'd try connecting to the console, but in its monitor: (qemu) info vnc Server: disabled According to the command line where I started this kvm instance, vnc should be enabled. Maybe it died? Is there a way to tu

Re: Trouble understanding net config options

2009-07-15 Thread Chris Webb
Michael Jinks writes: > How do I make a guest use a specific tap? Quoting > from my initial post, my -net options are: > > -net nic -net tap,name=tap11 -net nic -net tap,name=tap12 You want -net nic,vlan=0 -net tap,vlan=0,ifname=tap11 -net nic,vlan=1 -net tap,vlan=1,ifname=tap12 to get t

Re: Trouble understanding net config options

2009-07-15 Thread Andreas Plesner Jacobsen
On Thu, Jul 16, 2009 at 01:12:19AM +0200, Andreas Plesner Jacobsen wrote: > >> > >> I tried "fd=" instead of "name=", but that looks for a file descriptor > >> instead of a network interface name, and I didn't even know that Linux > >> had file descriptors for network interfaces let alone how to ma

Re: Trouble understanding net config options

2009-07-15 Thread Michael Jinks
On Wed, Jul 15, 2009 at 6:35 PM, Andreas Plesner Jacobsen wrote: > On Wed, Jul 15, 2009 at 06:22:56PM -0500, Michael Jinks wrote: >> I suppose that's a good sign, but it still leaves me wondering how to >> control which tap connects to which bridge, if I can't attach a guest >> to an existing tap

Re: Trouble understanding net config options

2009-07-15 Thread Michael Jinks
On Wed, Jul 15, 2009 at 6:24 PM, Chris Webb wrote: > You want > >  -net nic,vlan=0 -net tap,vlan=0,ifname=tap11 -net nic,vlan=1 -net > tap,vlan=1,ifname=tap12 Progress! This works, I can bring up the guest and watch it boot, but both of its NICs came up bound to the first bridge on the system.

Re: Trouble understanding net config options

2009-07-15 Thread Andreas Plesner Jacobsen
On Wed, Jul 15, 2009 at 06:22:56PM -0500, Michael Jinks wrote: > >>   # kvm -m 512M -net nic -net tap,name=tap11 -net nic -net > >> tap,name=tap12 -hda /vmstore/wee -vnc :11 -cdrom > >> /path/to/my/Windows.iso -boot d > > > > The parameter is "ifname", not "name". > > In that case, what does the "

"set_link" monitor command

2009-07-15 Thread Michael Jinks
Like I said in my other network puzzlement thread, I have one KVM guest which is working fine. Or, it was until I tried to add a second one, and hosed my virtual bridge. The guest is still running, but since I restarted the bridge interface that its NIC was attached to, it's no longer attached.

Re: Trouble understanding net config options

2009-07-15 Thread Stephane Bakhos
device tap11 is already a member of a bridge; can't enslave it to bridge br0. /etc/kvm/kvm-ifup: could not launch network script Could not initialize device 'tap' That's because your kvm-ifup scripts tries to connect the tap to the bridge and it's already there. You should either remove it f

Re: Trouble understanding net config options

2009-07-15 Thread Michael Jinks
>>   # kvm -m 512M -net nic -net tap,name=tap11 -net nic -net >> tap,name=tap12 -hda /vmstore/wee -vnc :11 -cdrom >> /path/to/my/Windows.iso -boot d > > The parameter is "ifname", not "name". In that case, what does the "name" parameter mean? Quoting from the manpage on my system: -net ta

Re: Trouble understanding net config options

2009-07-15 Thread Andreas Plesner Jacobsen
On Wed, Jul 15, 2009 at 07:05:48PM -0400, Stephane Bakhos wrote: >> >> I tried "fd=" instead of "name=", but that looks for a file descriptor >> instead of a network interface name, and I didn't even know that Linux >> had file descriptors for network interfaces let alone how to map them >> to a ta

Re: Trouble understanding net config options

2009-07-15 Thread Michael Jinks
On Wed, Jul 15, 2009 at 6:12 PM, Andreas Plesner Jacobsen wrote: > On Wed, Jul 15, 2009 at 07:05:48PM -0400, Stephane Bakhos wrote: >>> >> You need to add a vlan option to one of them, for example vlan=2 >> Otherwise kvm will bridge the interfaces together, and it's going to >> create a packet stor

Re: Trouble understanding net config options

2009-07-15 Thread Andreas Plesner Jacobsen
On Wed, Jul 15, 2009 at 05:54:14PM -0500, Michael Jinks wrote: > > Now I want to bring up a VM with two NICs, one attached to tap12 > (bridge 0), the other on tap11 (bridge 1), but I think I've > misunderstood the versious "-net" options as described in the kvm man > page. It *seems* to say that

Re: Trouble understanding net config options

2009-07-15 Thread Stephane Bakhos
bridge name bridge id STP enabled interfaces br0 8000.00144fa1f17a no eth0 tap0 tap1

Re: Trouble understanding net config options

2009-07-15 Thread Stephane Bakhos
You need to add a vlan option to one of them, for example vlan=2 Otherwise kvm will bridge the interfaces together, and it's going to create a packet storm. I wondered about that -- but what's the relationship of a KVM vlan to my existing bridge interfaces, and how can I control which one gets m

Re: Trouble understanding net config options

2009-07-15 Thread Michael Jinks
On Wed, Jul 15, 2009 at 6:05 PM, Stephane Bakhos wrote: > You need to add a vlan option to one of them, for example vlan=2 > Otherwise kvm will bridge the interfaces together, and it's going to create > a packet storm. I wondered about that -- but what's the relationship of a KVM vlan to my exist

Re: [PATCH] always report x2apic as supported feature

2009-07-15 Thread Marcelo Tosatti
On Sun, Jul 12, 2009 at 04:10:55PM +0300, Gleb Natapov wrote: > We emulate x2apic in software, so host support is not required. > > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 00844eb..c256da7 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x8

Trouble understanding net config options

2009-07-15 Thread Michael Jinks
On my desktop I have KVM working and one guest running, with the command line: # kvm -m 512M -net nic -net tap -hda /dev/mapper/pile-evil64 -boot c -vnc :2 -smp 2 -nographic Next I need to set up a virtual network for testing. The plan calls for four guest systems, and two virtual networks, one

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jamie Lokier
Anthony Liguori wrote: > Jamie Lokier wrote: > >Anthony Liguori wrote: > > > >>Jan Kiszka wrote: > >> > >>>We would still have to deal with the fact that so far '\' had no special > >>>meaning on Windows - except that is was the well-known path separator. > >>>So redefining its meaning would

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: Jan Kiszka wrote: We would still have to deal with the fact that so far '\' had no special meaning on Windows - except that is was the well-known path separator. So redefining its meaning would break a bit... That's the problem. You

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jamie Lokier
Anthony Liguori wrote: > Jan Kiszka wrote: > >We would still have to deal with the fact that so far '\' had no special > >meaning on Windows - except that is was the well-known path separator. > >So redefining its meaning would break a bit... > > > > That's the problem. You will break existing

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Anthony Liguori
Jan Kiszka wrote: We would still have to deal with the fact that so far '\' had no special meaning on Windows - except that is was the well-known path separator. So redefining its meaning would break a bit... That's the problem. You will break existing Windows users. I know this goes again

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Greg KH
On Wed, Jul 15, 2009 at 11:13:40PM +0300, Michael S. Tsirkin wrote: > This adds a generic uio driver that can bind to any PCI device. First > user will be virtualization where a qemu userspace process needs to give > guest OS access to the device. > > Interrupts are handled using the Interrupt Di

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jamie Lokier
Jan Kiszka wrote: > Jamie Lokier wrote: > > Jan Kiszka wrote: > >>> Now, I see one significant hurdle with that: it's quite inconvenient > >>> for Windows users, typing paths like c:\path\to\dir\file, if those > >>> backslashes are stipped. > >> We could exclude Windows from this (I think to rememb

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Marcelo Tosatti
On Wed, Jul 15, 2009 at 11:52:24PM +0300, Gleb Natapov wrote: > On Wed, Jul 15, 2009 at 03:18:00PM -0300, Marcelo Tosatti wrote: > > On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > > > Use gsi indexed array instead of scanning all entries on each interrupt > > > injection. Also main

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jan Kiszka
Jamie Lokier wrote: > Jan Kiszka wrote: >>> Now, I see one significant hurdle with that: it's quite inconvenient >>> for Windows users, typing paths like c:\path\to\dir\file, if those >>> backslashes are stipped. >> We could exclude Windows from this (I think to remember that filenames >> are more

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Hans J. Koch
On Wed, Jul 15, 2009 at 11:13:40PM +0300, Michael S. Tsirkin wrote: > This adds a generic uio driver that can bind to any PCI device. First > user will be virtualization where a qemu userspace process needs to give > guest OS access to the device. > > Interrupts are handled using the Interrupt Di

Re: [PATCH 08/10] Move IO APIC to its own lock.

2009-07-15 Thread Marcelo Tosatti
On Wed, Jul 15, 2009 at 11:48:17PM +0300, Gleb Natapov wrote: > > > + spin_unlock(&ioapic->lock); > > > + kvm_notify_acked_irq(ioapic->kvm, KVM_IRQCHIP_IOAPIC, i); > > > + spin_lock(&ioapic->lock); > > > > While traversing the IOAPIC pins you drop the lock and acquire it ag

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jamie Lokier
Jan Kiszka wrote: > > Now, I see one significant hurdle with that: it's quite inconvenient > > for Windows users, typing paths like c:\path\to\dir\file, if those > > backslashes are stipped. > > We could exclude Windows from this (I think to remember that filenames > are more restricted there anyw

Re: qcow2 relative paths

2009-07-15 Thread Jan Kiszka
Jamie Lokier wrote: > Ram Pai wrote: >> I have successfully verified qcow2 files. But then I may not be trying >> out the exact thing that you are talking about. Can you give me a test >> case that I can verify. > > Commands tried with qemu-0.10.0-1ubuntu1: > > $ mkdir unlikely_subdir > $ cd unl

qcow2 relative paths (was: [PATCH] rev5: support colon in filenames)

2009-07-15 Thread Jamie Lokier
Ram Pai wrote: > I have successfully verified qcow2 files. But then I may not be trying > out the exact thing that you are talking about. Can you give me a test > case that I can verify. Commands tried with qemu-0.10.0-1ubuntu1: $ mkdir unlikely_subdir $ cd unlikely_subdir $ qemu-img create -f q

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jan Kiszka
Jamie Lokier wrote: > Kevin Wolf wrote: >> Can we at least allow \, instead of ,, in parameter parsing, so that the >> backslash has the practical benefit of being a single universal escape >> character? > > Is there a good reason why we cannot simply use \ to escape > _any_ character, in every co

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Gleb Natapov
On Wed, Jul 15, 2009 at 03:18:00PM -0300, Marcelo Tosatti wrote: > On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > > Use gsi indexed array instead of scanning all entries on each interrupt > > injection. Also maintain back mapping from irqchip/pin to gsi to speedup > > interrupt ack

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Gleb Natapov
On Wed, Jul 15, 2009 at 10:17:22PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > > @@ -147,14 +149,13 @@ int kvm_set_irq(struct kvm *kvm, int irq_source_id, > > int irq, int level) > > * writes to the unused one. > > */ > > rcu_rea

Re: [PATCH 08/10] Move IO APIC to its own lock.

2009-07-15 Thread Gleb Natapov
On Wed, Jul 15, 2009 at 02:57:59PM -0300, Marcelo Tosatti wrote: > On Tue, Jul 14, 2009 at 05:30:43PM +0300, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > arch/ia64/kvm/kvm-ia64.c | 27 ++-- > > arch/x86/kvm/lapic.c |5 +--- > > arch/x86/kvm/x8

[PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Michael S. Tsirkin
This adds a generic uio driver that can bind to any PCI device. First user will be virtualization where a qemu userspace process needs to give guest OS access to the device. Interrupts are handled using the Interrupt Disable bit in the PCI command register and Interrupt Status bit in the PCI stat

Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Chris Wright
* Michael S. Tsirkin (m...@redhat.com) wrote: > Right. Note that the limitation that only a single thread should touch > config space through sysfs applies to any sub-byte field. If we wanted > to make such ops atomic, pci devices would need some kind of compare and > swap ioctl. > Looks good. A

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Michael S. Tsirkin
On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > @@ -147,14 +149,13 @@ int kvm_set_irq(struct kvm *kvm, int irq_source_id, int > irq, int level) >* writes to the unused one. >*/ > rcu_read_lock(); > - for (e = rcu_dereference(kvm->irq_routing); e && e->set;

Re: Broken Finnish keymap

2009-07-15 Thread Marcelo Tosatti
On Mon, Jul 13, 2009 at 12:59:28PM +0300, Anssi Kolehmainen wrote: > Hi, > > When I run kvm-88 with -vnc and -k fi and try to press "'" (apostrophe) in > vnc window I get "b" in the guest. Strange enough, in SDL window > everything seems to work just fine. > > Anyhow, the fix is to remove second

Re: [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in kvm_mmu_load()

2009-07-15 Thread Marcelo Tosatti
On Thu, Jul 09, 2009 at 05:00:42PM +0800, Sheng Yang wrote: > set_cr3() should already cover the TLB flushing. > > Signed-off-by: Sheng Yang > --- > arch/x86/kvm/mmu.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index

Re: [Qemu-devel] Re: [PATCH] rev5: support colon in filenames

2009-07-15 Thread Ram Pai
On Wed, 2009-07-15 at 19:20 +0100, Jamie Lokier wrote: > Ram Pai wrote: > > I have verified with relative paths and it works. > > > > After analyzing the code, i came to the conclusion that call to > > realpath() adds no real value. > > > > The logic in bdrv_open2() is something like this > >

KVM: MMU: fix missing locking in alloc_mmu_pages

2009-07-15 Thread Marcelo Tosatti
n_requested_mmu_pages/n_free_mmu_pages are used by kvm_mmu_change_mmu_pages to calculate the number of pages to zap. alloc_mmu_pages, called from the vcpu initialization path, modifies this variables without proper locking, which can result in a negative value in kvm_mmu_change_mmu_pages (say, wi

Re: [Qemu-devel] Re: [PATCH] rev5: support colon in filenames

2009-07-15 Thread Jamie Lokier
Ram Pai wrote: > I have verified with relative paths and it works. > > After analyzing the code, i came to the conclusion that call to > realpath() adds no real value. > > The logic in bdrv_open2() is something like this > > bdrv_open2() > { >if (snapshot) { > backup = realpath(fi

Re: [PATCH 10/10] Change irq routing table to use gsi indexed array.

2009-07-15 Thread Marcelo Tosatti
On Tue, Jul 14, 2009 at 05:30:45PM +0300, Gleb Natapov wrote: > Use gsi indexed array instead of scanning all entries on each interrupt > injection. Also maintain back mapping from irqchip/pin to gsi to speedup > interrupt acknowledgment notifications. > > Signed-off-by: Gleb Natapov > --- > inc

Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

2009-07-15 Thread Jamie Lokier
Kevin Wolf wrote: > Can we at least allow \, instead of ,, in parameter parsing, so that the > backslash has the practical benefit of being a single universal escape > character? Is there a good reason why we cannot simply use \ to escape _any_ character, in every context where a user-supplied str

Re: [PATCH 08/10] Move IO APIC to its own lock.

2009-07-15 Thread Marcelo Tosatti
On Tue, Jul 14, 2009 at 05:30:43PM +0300, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > arch/ia64/kvm/kvm-ia64.c | 27 ++-- > arch/x86/kvm/lapic.c |5 +--- > arch/x86/kvm/x86.c | 30 ++- > virt/kvm/ioapic.c| 50

Re: [PATCH] Fix non-KVM build

2009-07-15 Thread Michael S. Tsirkin
On Wed, Jun 24, 2009 at 01:13:46PM -0500, Anthony Liguori wrote: > This introduces some #ifdefs in pcspk to fix the build when KVM isn't enabled. > > Signed-off-by: Anthony Liguori > --- > hw/pcspk.c | 15 +-- > 1 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/hw/

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2009 at 10:40:37AM -0500, Anthony Liguori wrote: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=

[PATCH] replace qemu_kvm_cpu_env

2009-07-15 Thread Glauber Costa
We now have an upstream qemu function that does exactly that, but in a kvm-independent way. Use it. Signed-off-by: Glauber Costa --- hw/acpi.c | 24 +--- 1 files changed, 1 insertions(+), 23 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index 7de9cb7..d23abd1 100644 ---

Re: [PATCH] rev5: support colon in filenames

2009-07-15 Thread Ram Pai
On Wed, 2009-07-15 at 11:30 +0200, Jan Kiszka wrote: > Ram Pai wrote: > > Problem: It is impossible to feed filenames with the character colon because > > qemu interprets such names as a protocol. For example filename scsi:0, is > > interpreted as a protocol by name "scsi". > > > > This patch allo

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Kevin Wolf
Anthony Liguori schrieb: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img >> > > The ex

[PATCH 4/5] check extension

2009-07-15 Thread Glauber Costa
use upstream check_extension code Signed-off-by: Glauber Costa --- hw/device-assignment.c |2 +- kvm-all.c |2 ++ qemu-kvm-x86.c |6 +++--- qemu-kvm.c | 18 -- qemu-kvm.h |2 +- 5 files changed, 11 insertions(+), 19 d

[PATCH 5/5] use upstream cpuid code

2009-07-15 Thread Glauber Costa
use cpuid code from upstream. By doing that, we lose the following snippet in kvm_get_supported_cpuid(): ret |= 1 << 12; /* MTRR */ ret |= 1 << 16; /* PAT */ ret |= 1 << 7; /* MCE */ ret |= 1 << 14; /* MCA */ A quick search in mailing lists says this code is not really necessary,

[PATCH 3/5] reuse kvm_ioctl

2009-07-15 Thread Glauber Costa
Start using kvm_ioctl's code. For type safety, delete fd from kvm_context entirely, so the compiler can play along with us helping to detect errors I might have made. Signed-off-by: Glauber Costa --- kvm-all.c |2 +- qemu-kvm-x86.c | 18 +- qemu-kvm.c | 32 ++

[PATCH 2/5] reuse kvm_vm_ioctl

2009-07-15 Thread Glauber Costa
Start using kvm_vm_ioctl's code. For type safety, delete vm_fd from kvm_context entirely, so the compiler can play along with us helping to detect errors I might have made. Signed-off-by: Glauber Costa --- kvm-all.c |2 ++ qemu-kvm-x86.c | 18 +- qemu-kvm.c | 52

[PATCH 0/5] Further cleanups

2009-07-15 Thread Glauber Costa
Hi guys, I'm sending a series that moves further in reusing upstream code Here I'm reusing kvm_vm_ioctl, kvm_ioctl, kvm_check_extension and the cpuid bits for i386. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majord

[PATCH 1/5] remove kvm types from handle unhandled

2009-07-15 Thread Glauber Costa
I'm in an ongoing process of not using kvm-specific types in function declarations. handle_unhandled() is the first victim. Since we don't really use this data, but just the reason, remove them entirely. Signed-off-by: Glauber Costa --- qemu-kvm.c |9 +++-- 1 files changed, 3 insertions(

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Paul Brook
> Instead of using '-drive if=none' we could use some other syntax where > the filename can be passed as separate argument. Can switches have two > arguments? If so, maybe this: > >-hostdrive $file $options This only works for a single mandatory argument that needs to contain awkward charac

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Gerd Hoffmann
On 07/15/09 17:14, Anthony Liguori wrote: Blue Swirl wrote: I bet this won't compile on win32. Instead of this (IMHO doomed) escape approach, maybe the filename parameter could be specified as the next argument, for example: -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with f

KVM 88 Boot from Floppy Stops

2009-07-15 Thread Adam Barrett
I have tested and confirmed that in KVM-86 all worked fine. I attempted to test in KVM-87, however I was not able to finish install due to make errors KVM-87 configure: http://pastebin.ca/1495900 KVM-87 make: http://pastebin.ca/1495902 In KVM-88 I am able to install again, but I am not able to ge

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Paul Brook
On Wednesday 15 July 2009, Anthony Liguori wrote: > Blue Swirl wrote: > > I bet this won't compile on win32. > > > > Instead of this (IMHO doomed) escape approach, maybe the filename > > parameter could be specified as the next argument, for example: > > -hda format=qcow2,blah,blah,filename_is_next

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Anthony Liguori
Blue Swirl wrote: Then how about something like: -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img The explicit ordering part seems clunky to me. H

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Anthony Liguori
Kevin Wolf wrote: Anthony Liguori schrieb: Blue Swirl wrote: I bet this won't compile on win32. Instead of this (IMHO doomed) escape approach, maybe the filename parameter could be specified as the next argument, for example: -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filen

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Kevin Wolf
Anthony Liguori schrieb: > Blue Swirl wrote: >> I bet this won't compile on win32. >> >> Instead of this (IMHO doomed) escape approach, maybe the filename >> parameter could be specified as the next argument, for example: >> -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with >> fu

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Blue Swirl
On 7/15/09, Anthony Liguori wrote: > Blue Swirl wrote: > > > I bet this won't compile on win32. > > > > Instead of this (IMHO doomed) escape approach, maybe the filename > > parameter could be specified as the next argument, for example: > > -hda format=qcow2,blah,blah,filename_is_next_arg -hda >

Re: Problem with Grub and KVM 88

2009-07-15 Thread Erik Wartusch
I downloaded the tar.gz http://downloads.sourceforge.net/sourceforge/kvm/kvm-88.tar.gz?use_mirror=dfn unzipped it and followed the procedure according to the how to: ./configure --prefix=/usr/local/kvm make make install modprobe kvm-intel Erik Am Mittwoch, den 15.07.2009, 10:11 -0500 schrie

Re: [Autotest] [RFC] KVM-Autotest: remote shell utility for Windows guests

2009-07-15 Thread Michael Goldish
- "Lucas Meneghel Rodrigues" wrote: > On Wed, Jul 8, 2009 at 4:46 AM, Michael Goldish > wrote: > > I'm resending the message because it probably got filtered out due > to the > > attached setup.bat file. > > > > The contents of setup.bat were: > > > > copy D:\rss.exe C:\ > > > > net user Adm

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Anthony Liguori
Blue Swirl wrote: I bet this won't compile on win32. Instead of this (IMHO doomed) escape approach, maybe the filename parameter could be specified as the next argument, for example: -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with funky characters like ',' ':' & '!'" -d

Re: Problem with Grub and KVM 88

2009-07-15 Thread Brian Jackson
On Wednesday 15 July 2009 06:06:54 am Erik Wartusch wrote: > Hi all, > > Following problem. > I recently upgraded kvm from 7.2 (Debian Lenny repository version) to > the newest 88 KVM. How did you install kvm-88? Did you do a proper install? including the bios files, extboot, etc? --Iggy > >

Re: Problem with Grub and KVM 88

2009-07-15 Thread Erik Wartusch
I've reinstalled Debian Lenny now on a fresh virtual harddisk and now its working... Seems like my "old" images I used with 72 are the problem with 88. Erik Am Mittwoch, den 15.07.2009, 16:20 +0200 schrieb Erik Wartusch: > - "Erik Wartusch" mitacs.com> wrote: > > > Hi all, > > > > Followi

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Blue Swirl
On 7/15/09, Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example filename scsi:0, is > interpreted as a protocol by name "scsi". > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > +static int

Fix migration issue when the destination is loaded

2009-07-15 Thread Dor Laor
>From abbe3b57af6a28bb81e5fb8b09b10802a8ccc3fe Mon Sep 17 00:00:00 2001 From: Dor Laor Date: Wed, 15 Jul 2009 17:53:16 +0300 Subject: [PATCH] Fix migration issue when the destination is loaded If the migration socket is full, we get EAGAIN for the write. The set_fd_handler2 defers the write for

Problem with Grub and KVM 88

2009-07-15 Thread Erik Wartusch
- "Erik Wartusch" mitacs.com> wrote: > Hi all, > > Following problem. > I recently upgraded kvm from 7.2 (Debian Lenny repository version) to > the newest 88 KVM. > > Since then when I first started and stopped a Debian Lenny virtual > instance (guest) at the next (second) start I get the f

Re: [Autotest] [RFC] KVM-Autotest: remote shell utility for Windows guests

2009-07-15 Thread Lucas Meneghel Rodrigues
On Wed, Jul 8, 2009 at 4:46 AM, Michael Goldish wrote: > I'm resending the message because it probably got filtered out due to the > attached setup.bat file. > > The contents of setup.bat were: > > copy D:\rss.exe C:\ > > net user Administrator /active:yes > net user Administrator 1q2w3eP > netsh f

Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line

2009-07-15 Thread Dor Laor
On 07/15/2009 12:12 PM, Yolkfull Chow wrote: Would submit this patch which is from our internal kvm-autotest patches submitted by Jason. So that we could go on test case about parameters verification(UUID, DMI data etc). Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py |4

Re: Problem with Grub and KVM 88

2009-07-15 Thread Alexey Eromenko
- "Erik Wartusch" wrote: > Hi all, > > Following problem. > I recently upgraded kvm from 7.2 (Debian Lenny repository version) to > the newest 88 KVM. > > Since then when I first started and stopped a Debian Lenny virtual > instance (guest) at the next (second) start I get the following >

Problem with Grub and KVM 88

2009-07-15 Thread Erik Wartusch
Hi all, Following problem. I recently upgraded kvm from 7.2 (Debian Lenny repository version) to the newest 88 KVM. Since then when I first started and stopped a Debian Lenny virtual instance (guest) at the next (second) start I get the following error: "Grub loading, please wait. Error 2". S

  1   2   >