KVM and kernel 2.6.30 file system madness

2009-07-08 Thread Robert Wimmer
Hi there, back in days before kernel 2.6.25/2.6.26 and KVM 70-77 KVM decided to crash from time to time. That time we used XFS as filesystem (/ and /boot where ext3/ext2). Since XFS worked so very well for us on physical hosts the natural choise for our OSs in KVM of course was also XFS. This was

Re: R/W HG memory mappings with kvm?

2009-07-08 Thread Cam Macdonell
On 8-Jul-09, at 4:01 PM, Stephen Donnelly wrote: On Thu, Jul 9, 2009 at 9:45 AM, Cam Macdonell wrote: Hi Stephen, Here is the latest patch that supports interrupts. I am currently working on a broadcast mechanism that should be ready fairly soon. http://patchwork.kernel.org/patch/22368/

qemu-kvm process is running at 100% CPU, but no response from guest

2009-07-08 Thread SAL
Hello, today I have second incident, that my qemu-kvm process is running at 100% or 200% CPU (watched using top program), but there is no response from guest long time (some hours). First time lots of these messages appeared in dmesg: vcpu not ready for apic_round_robin vcpu not ready for apic_

Re: slow guest performance with build load, looking for ideas

2009-07-08 Thread Erik Jacobson
> Haven't followed the thread in great detail, but has anyone tried > putting the virtio disk back into rotational mode? Hello. I haven't had a chance to try all the suggestions in the thread so far. However, I did just run some tests with block queue rotation settings tonight. For the problem

Re: [PATCH][KVM][retry 4] Add support for Pause Filtering to AMD SVM

2009-07-08 Thread Sheng Yang
On Wednesday 08 July 2009 22:59:55 Langsdorf, Mark wrote: > The last variant of the scheduler that I tried > showed worse performance for both the baseline > case (no pause filter enabled) and the test > case (pause filter enabled) versus not changing > the scheduler. > > Some other work came up an

Re: [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg

2009-07-08 Thread Huang Ying
On Wed, 2009-07-01 at 02:12 +0800, Anthony Liguori wrote: > Hi Huang, > > Huang Ying wrote: > > - MCE features are initialized when VCPU is intialized according to CPUID. > > - A monitor command "mce" is added to inject a MCE. > > - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MC

Re: [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread Mike Frysinger
On Wednesday 08 July 2009 06:19:27 Subrata Modak wrote: > On Tue, 2009-07-07 at 10:45 -0700, Martin Bligh wrote: > > On Tue, Jul 7, 2009 at 12:24 AM, sudhir kumar wrote: > > > On Tue, Jul 7, 2009 at 12:07 AM, Martin Bligh wrote: > > Issues: LTP has a history of some of the testcases getting br

[WIKI] email confirmation not working

2009-07-08 Thread Brian Jackson
I tried doing the email confirmation on the wiki so I could be emailed on page changes, etc. Every time I hit the "Mail a confirmation code" button it says: "Could not send confirmation mail. Check address for invalid characters. " I've re-entered my email address and tried again. Same results.

Re: R/W HG memory mappings with kvm?

2009-07-08 Thread Cam Macdonell
Avi Kivity wrote: On 07/08/2009 01:23 AM, Stephen Donnelly wrote: Also it appears that PCI IO memory (cpu_register_io_memory) is provided via access functions, like the pci config space? It can also use ordinary RAM (for example, vga maps its framebuffer as a PCI BAR). So hos

Re: R/W HG memory mappings with kvm?

2009-07-08 Thread Stephen Donnelly
On Thu, Jul 9, 2009 at 9:45 AM, Cam Macdonell wrote: > Hi Stephen, > > Here is the latest patch that supports interrupts.  I am currently working > on a broadcast mechanism that should be ready fairly soon. > > http://patchwork.kernel.org/patch/22368/ > > I have some test scripts that can demonstra

Re: R/W HG memory mappings with kvm?

2009-07-08 Thread Stephen Donnelly
> Shared memory is fully coherent.  You can use the ordinary x86 bus lock > operations for concurrent read-modify-write access, and the memory barrier > instructions to prevent reordering.  Just like ordinary shared memory. Okay, I think I was confused by the 'dirty' code. Is that just to do with

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Avi Kivity
On 07/08/2009 10:44 PM, Jan Kiszka wrote: Deferred until v2. My first impression is that too much upstream code is moved or touched. Glauber, if you want to use some function that is currently under KVM_UPSTREAM, don't move it, just drop the #ifdef around it. And when done, have a look at the d

Re: [PATCH] virtio_blk: ioctl return value fix

2009-07-08 Thread Avi Kivity
On 07/08/2009 09:12 PM, Christoph Hellwig wrote: On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if they expect the block layer to handle generic

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Jan Kiszka
Jan Kiszka wrote: > Avi Kivity wrote: >> On 07/08/2009 04:39 PM, Glauber Costa wrote: >>> On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: >>> On 07/08/2009 04:09 PM, Glauber Costa wrote: > Signed-off-by: Glauber Costa > --- >kvm-all.c | 27 +++

KVM: cdrom passthrough?

2009-07-08 Thread Dâniel Fraga
I like very much KVM, but I decided to test Virtualbox and it has nice features KVM doesn't have. BUT... Virtualbox is orders of magnitude SLOWER than KVM. Virtualbox just can't compete with KVM regarding speed. KVM is much, much, much faster than any virtual machine on earth. Anyw

[ kvm-Bugs-2506814 ] TAP network lockup after some traffic

2009-07-08 Thread SourceForge.net
Bugs item #2506814, was opened at 2009-01-14 11:38 Message generated for change (Comment added) made by danny1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2506814&group_id=180599 Please note that this message will contain a full copy of the comment th

[ kvm-Bugs-2506814 ] TAP network lockup after some traffic

2009-07-08 Thread SourceForge.net
Bugs item #2506814, was opened at 2009-01-14 11:38 Message generated for change (Comment added) made by danny1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2506814&group_id=180599 Please note that this message will contain a full copy of the comment th

Re: [PATCH] virtio_blk: ioctl return value fix

2009-07-08 Thread Christoph Hellwig
On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > > they expect the block layer to handle generic ioctls. > > > > This triggered a BLKROSET failure in

Re: [PATCH] virtio_blk: don't bounce highmem requests

2009-07-08 Thread Christoph Hellwig
On Tue, Jun 23, 2009 at 04:42:52PM +0930, Rusty Russell wrote: > On Sun, 21 Jun 2009 04:02:15 am Christoph Hellwig wrote: > > Looks like I sent a patch that doesn't actually compile because qui > > decided to apply those fixes to a different one. Here's the correc > > one: > > > > -- > > > > Subje

Re: kvm-87 fails to compile under uClibc

2009-07-08 Thread Cristi Magherusan
On Wed, 2009-07-08 at 20:07 +0300, Avi Kivity wrote: > On 07/08/2009 07:59 PM, Cristi Magherusan wrote: > >> You can reduce qemu size by not compiling tcg; that'll save you a lot > >> more than the kernel. > >> > > How do I disable it? is it the --disable-cpu-emulation configure flag? > > Unf

Re: kvm-87 fails to compile under uClibc

2009-07-08 Thread Avi Kivity
On 07/08/2009 07:59 PM, Cristi Magherusan wrote: You can reduce qemu size by not compiling tcg; that'll save you a lot more than the kernel. How do I disable it? is it the --disable-cpu-emulation configure flag? Unfortunately that one breaks compilation, and I reproduced this both in my sy

Re: kvm-87 fails to compile under uClibc

2009-07-08 Thread Cristi Magherusan
On Tue, 2009-07-07 at 14:43 +0300, Avi Kivity wrote: > On 07/07/2009 02:31 PM, Cristi Magherusan wrote: > > The kernel will be 2.6.24 because it's smaller. I know this mismatch may > > not be good, but I have to get to a compromise. The kernel needs to be > > as small as possible (everything should

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Marcelo Tosatti
On Wed, Jul 08, 2009 at 07:40:57PM +0300, Gleb Natapov wrote: > On Wed, Jul 08, 2009 at 01:37:39PM -0300, Marcelo Tosatti wrote: > > On Wed, Jul 08, 2009 at 07:29:58PM +0300, Gleb Natapov wrote: > > > On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > > > > (but yes, bypassing the i

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 01:37:39PM -0300, Marcelo Tosatti wrote: > On Wed, Jul 08, 2009 at 07:29:58PM +0300, Gleb Natapov wrote: > > On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > > > (but yes, bypassing the irq injection system its not a very beatiful > > > shortcut, but its do

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Marcelo Tosatti
On Wed, Jul 08, 2009 at 07:29:58PM +0300, Gleb Natapov wrote: > On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > > (but yes, bypassing the irq injection system its not a very beatiful > > shortcut, but its done in other places too eg i8254.c NMI injection via > > all cpus LINT0).

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Avi Kivity
On 07/08/2009 07:24 PM, Marcelo Tosatti wrote: I wonder if we're really winning with this. Guests should be scheduled-out-but-not-halted rarely, and in all other cases we need to keep the timer. A timer comparison on each guest entry might be expensive (maybe not so much with tsc based timers).

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > (but yes, bypassing the irq injection system its not a very beatiful > shortcut, but its done in other places too eg i8254.c NMI injection via > all cpus LINT0). > I've looked at this. Why do you say i8254.c NMI injection bypass th

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Marcelo Tosatti
On Wed, Jul 08, 2009 at 04:41:22PM +0300, Avi Kivity wrote: > On 07/06/2009 04:55 AM, Marcelo Tosatti wrote: >> Replace hrtimer based timer emulation with host timebase (ktime_t) >> comparisons on guest entry. >> >> This avoids host load when guests are scheduled out, removes a >> spinlock acquisio

Re: [PATCH] qemu-kvm: Move extboot to other optionroms

2009-07-08 Thread Avi Kivity
On 07/08/2009 07:07 PM, Jan Kiszka wrote: This unbreaks out-of-tree builds and reduces the differences to upstream's top-level Makefile. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 12:42:52PM -0300, Marcelo Tosatti wrote: > On Wed, Jul 08, 2009 at 04:39:56PM +0300, Gleb Natapov wrote: > > On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > > > On Wed, Jul 08, 2009 at 03:58:19PM +0300, Gleb Natapov wrote: > > > > Excellent patch series. >

[PATCH] qemu-kvm: Move extboot to other optionroms

2009-07-08 Thread Jan Kiszka
This unbreaks out-of-tree builds and reduces the differences to upstream's top-level Makefile. Signed-off-by: Jan Kiszka --- Makefile| 11 - kvm/extboot/extboot.S | 695 --- pc-bios/optionrom/Makefile |2 pc-bios/optionr

Re: buildbot

2009-07-08 Thread Daniel Gollub
On Wednesday 08 July 2009 05:18:41 pm Jan Kiszka wrote: > > Some further questions to the build test: > > > > - incremental/quick or full/"safe" build tests? > > (e.g. "make clean" before actual configuration/build?) > > Maybe a full rebuild once per day and incremental rebuilds for each > update

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Marcelo Tosatti
On Wed, Jul 08, 2009 at 04:39:56PM +0300, Gleb Natapov wrote: > On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > > On Wed, Jul 08, 2009 at 03:58:19PM +0300, Gleb Natapov wrote: > > > Excellent patch series. > > > > > > On Sun, Jul 05, 2009 at 10:55:15PM -0300, Marcelo Tosatti wro

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Jan Kiszka
Avi Kivity wrote: > On 07/08/2009 04:39 PM, Glauber Costa wrote: >> On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: >> >>> On 07/08/2009 04:09 PM, Glauber Costa wrote: >>> Signed-off-by: Glauber Costa --- kvm-all.c | 27 ++- >>>

Re: buildbot

2009-07-08 Thread Jan Kiszka
Daniel Gollub wrote: > On Wednesday 08 July 2009 06:54:09 am Avi Kivity wrote: >>> Unfortuatnely i'm completely new to the buildbot itself. Only did in the >>> past brief checks of the documentation and feature overview. I already >>> maintain some different continous build testing infrastrucute (b

Re: [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread Martin Bligh
>> Yup, we can pass an excluded test list. I really wish they'd fix their >> tests, but I've been saying that for 6 years now, and it hasn't happened >> yet ;-( > > I would slightly disagree to that. 6 years is history. But, have you > recently checked with LTP ? I hate to be completely cynical ab

Re: [PATCH] rev4: support colon in filenames

2009-07-08 Thread Jan Kiszka
Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example filename scsi:0, is > interpreted as a protocol by name "scsi". > > This patch allows user to espace colon characters. For example the above > filen

Re: buildbot

2009-07-08 Thread Avi Kivity
On 07/08/2009 05:45 PM, Daniel Gollub wrote: A local instance of buildbot with one master and one slave is already running for qemu-kvm.git (clone). Preparing now the final buildmaster host ... Unfortunately there seems to be no Git-"poller" in buildbot, like for SVN. So there is need to install

RE: [PATCH][KVM][retry 4] Add support for Pause Filtering to AMD SVM

2009-07-08 Thread Langsdorf, Mark
The last variant of the scheduler that I tried showed worse performance for both the baseline case (no pause filter enabled) and the test case (pause filter enabled) versus not changing the scheduler. Some other work came up and I haven't have a chance to experiment with this for a while. -Mark L

Re: buildbot

2009-07-08 Thread Daniel Gollub
On Wednesday 08 July 2009 06:54:09 am Avi Kivity wrote: > > Unfortuatnely i'm completely new to the buildbot itself. Only did in the > > past brief checks of the documentation and feature overview. I already > > maintain some different continous build testing infrastrucute (based on > > ctest/cdash

Re: guest gettimeofday behavior

2009-07-08 Thread Eran Rom
Glauber Costa redhat.com> writes: > > This was happening with kvmclock back then when it did not handle > > cpu frequency changes. What are the details of the host hw? > > > > Glauber, any clues? > maybe it is exactly that. 2.6.27 is a little bit old, and probably does not > have the fixes. > W

Re: [PATCH 2/8] move qemu-kvm.c to kvm-all.c

2009-07-08 Thread Glauber Costa
On Wed, Jul 08, 2009 at 04:23:39PM +0300, Avi Kivity wrote: > On 07/08/2009 04:08 PM, Glauber Costa wrote: >> Big plan to start sharing code with upstream. >> >> > > This patch is very brittle - if qemu-kvm.c changes, it won't apply. I > suggest to simply add #include "qemu-kvm.c" and remove

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:39 PM, Glauber Costa wrote: On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: On 07/08/2009 04:09 PM, Glauber Costa wrote: Signed-off-by: Glauber Costa --- kvm-all.c | 27 ++- qemu-kvm.h|6 +++--- target-i

Re: [patch 0/8] RFC: in-kernel timer emulation changes

2009-07-08 Thread Avi Kivity
On 07/06/2009 04:55 AM, Marcelo Tosatti wrote: This still needs to survive kvm-autotest, posting early for comments. It replaces hrtimer based emulation with ktime_t comparisons on guest entry (avoids host load when guests are scheduled out, removes a spinlock acquision on entry (i8254.c's injec

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 10:17:21AM -0300, Marcelo Tosatti wrote: > On Wed, Jul 08, 2009 at 03:58:19PM +0300, Gleb Natapov wrote: > > Excellent patch series. > > > > On Sun, Jul 05, 2009 at 10:55:15PM -0300, Marcelo Tosatti wrote: > > > int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) > > > {

Re: [PATCH 6/8] provide env->kvm_fd

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 10:44:01AM -0300, Glauber Costa wrote: > On Wed, Jul 08, 2009 at 04:32:37PM +0300, Gleb Natapov wrote: > > On Wed, Jul 08, 2009 at 09:09:00AM -0400, Glauber Costa wrote: > > > qemu upstream puts kvm information on env. Do that too, since it will > > > allow us to use CPUStat

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Avi Kivity
On 07/06/2009 04:55 AM, Marcelo Tosatti wrote: Replace hrtimer based timer emulation with host timebase (ktime_t) comparisons on guest entry. This avoids host load when guests are scheduled out, removes a spinlock acquision on entry (i8254.c's inject_lock), and makes future improvements easier.

Re: [PATCH 6/8] provide env->kvm_fd

2009-07-08 Thread Glauber Costa
On Wed, Jul 08, 2009 at 04:32:37PM +0300, Gleb Natapov wrote: > On Wed, Jul 08, 2009 at 09:09:00AM -0400, Glauber Costa wrote: > > qemu upstream puts kvm information on env. Do that too, since it will > > allow us to use CPUState in cpu-specific functions, instead of kvm-specific > > types. > > >

Re: [PATCH 3/8] put qemu-kvm-x86.c into kvm.c

2009-07-08 Thread Glauber Costa
On Wed, Jul 08, 2009 at 04:28:51PM +0300, Gleb Natapov wrote: > On Wed, Jul 08, 2009 at 09:08:57AM -0400, Glauber Costa wrote: > > big plan to start sharing code with upstream. > > > It is hard enough (for me at least) to distinguish between upstream code > and qemu-kvm when I have to look at the

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Glauber Costa
On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: > On 07/08/2009 04:09 PM, Glauber Costa wrote: >> Signed-off-by: Glauber Costa >> --- >> kvm-all.c | 27 ++- >> qemu-kvm.h|6 +++--- >> target-i386/kvm.c |4 ++-- >> 3 files changed, 2

Re: [PATCH 6/8] provide env->kvm_fd

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 09:09:00AM -0400, Glauber Costa wrote: > qemu upstream puts kvm information on env. Do that too, since it will > allow us to use CPUState in cpu-specific functions, instead of kvm-specific > types. > > Signed-off-by: Glauber Costa > --- > kvm-all.c| 12

Re: [patch 1/8] KVM: timer interface unification

2009-07-08 Thread Avi Kivity
On 07/06/2009 04:55 AM, Marcelo Tosatti wrote: Hide details of timer emulation behind an interface, and unify the hrtimer based implementation. For bisectability, might want to split into three: introduce generic timer, migrate lapic timer, migrate pit timer. -- error compiling committee

Re: [PATCH 3/8] put qemu-kvm-x86.c into kvm.c

2009-07-08 Thread Gleb Natapov
On Wed, Jul 08, 2009 at 09:08:57AM -0400, Glauber Costa wrote: > big plan to start sharing code with upstream. > It is hard enough (for me at least) to distinguish between upstream code and qemu-kvm when I have to look at the code. Having them separated in different files is very helpful. Looking

Re: [PATCH 0/8] Move closer to upstream

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:08 PM, Glauber Costa wrote: Hi, This is another step at getting us closer to qemu upstream. I'm moving our code to kvm-all.c and kvm.c, and relying on the fact that we use USE_KVM, while upstream qemu uses CONFIG_KVM, to keep us isolated. The goal is to slowly reduce that isola

Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:09 PM, Glauber Costa wrote: Signed-off-by: Glauber Costa --- kvm-all.c | 27 ++- qemu-kvm.h|6 +++--- target-i386/kvm.c |4 ++-- 3 files changed, 23 insertions(+), 14 deletions(-) Did you test the functionality to ensu

Re: [PATCH 3/8] put qemu-kvm-x86.c into kvm.c

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:08 PM, Glauber Costa wrote: big plan to start sharing code with upstream. What's the big plan re qemu-kvm-ia64.c? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to

Re: [PATCH 2/8] move qemu-kvm.c to kvm-all.c

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:08 PM, Glauber Costa wrote: Big plan to start sharing code with upstream. This patch is very brittle - if qemu-kvm.c changes, it won't apply. I suggest to simply add #include "qemu-kvm.c" and remove it from the makefile. After I apply it, I'll perform the #include and

Re: [PATCH 1/8] Provide KVMState definition outside CONFIG_KVM

2009-07-08 Thread Avi Kivity
On 07/08/2009 04:08 PM, Glauber Costa wrote: This will allow qemu-kvm to refer to the structure, since qemu-kvm relies on USE_KVM, not CONFIG_KVM. This should be sent to qemu.git as well Signed-off-by: Glauber Costa --- kvm.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) di

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Marcelo Tosatti
On Wed, Jul 08, 2009 at 03:58:19PM +0300, Gleb Natapov wrote: > Excellent patch series. > > On Sun, Jul 05, 2009 at 10:55:15PM -0300, Marcelo Tosatti wrote: > > int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) > > { > > - int ret; > > + ktime_t now, expires; > > > > - ret = pit_has_p

[PATCH 8/8] use upstream code for breakpoint handling

2009-07-08 Thread Glauber Costa
--- kvm-all.c | 422 +++- target-i386/kvm.c | 514 ++--- 2 files changed, 314 insertions(+), 622 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 6f92874..a364d34 100644 --- a/kvm-all.c +++ b/kv

[PATCH 7/8] use kvm_upstream sw_breakpoints structure

2009-07-08 Thread Glauber Costa
Signed-off-by: Glauber Costa --- kvm-all.c | 27 ++- qemu-kvm.h|6 +++--- target-i386/kvm.c |4 ++-- 3 files changed, 23 insertions(+), 14 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index b404f76..6f92874 100644 --- a/kvm-all.c +++ b/kvm-all

[PATCH 6/8] provide env->kvm_fd

2009-07-08 Thread Glauber Costa
qemu upstream puts kvm information on env. Do that too, since it will allow us to use CPUState in cpu-specific functions, instead of kvm-specific types. Signed-off-by: Glauber Costa --- kvm-all.c| 12 libkvm-all.h | 12 2 files changed, 8 insertions(+), 16 delet

[PATCH 5/8] move kvm_context inside KVMState

2009-07-08 Thread Glauber Costa
To make transition smooth, we still keep a global variable kvm_context pointing to its position inside the global KVMState. This way we don't need to hurry about changing all callers. kvm_init() and kvm_finalize are changed, though, since they have now to deal with the creation/destruction of a gl

[PATCH 4/8] replace malloc with qemu_malloc

2009-07-08 Thread Glauber Costa
This patch replaces both malloc and malloc+memset sequences with qemu_malloc and qemu_mallocz. Target is upstream integration Signed-off-by: Glauber Costa --- kvm-all.c | 26 +- target-i386/kvm.c | 31 --- 2 files changed, 13 insert

[PATCH 0/8] Move closer to upstream

2009-07-08 Thread Glauber Costa
Hi, This is another step at getting us closer to qemu upstream. I'm moving our code to kvm-all.c and kvm.c, and relying on the fact that we use USE_KVM, while upstream qemu uses CONFIG_KVM, to keep us isolated. The goal is to slowly reduce that isolation. To demonstrate what I aim for, the last p

[PATCH 1/8] Provide KVMState definition outside CONFIG_KVM

2009-07-08 Thread Glauber Costa
This will allow qemu-kvm to refer to the structure, since qemu-kvm relies on USE_KVM, not CONFIG_KVM. This should be sent to qemu.git as well Signed-off-by: Glauber Costa --- kvm.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kvm.h b/kvm.h index d9723d7..7648c49

Re: [patch 4/8] KVM: x86: replace hrtimer based timer emulation

2009-07-08 Thread Gleb Natapov
Excellent patch series. On Sun, Jul 05, 2009 at 10:55:15PM -0300, Marcelo Tosatti wrote: > int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) > { > - int ret; > + ktime_t now, expires; > > - ret = pit_has_pending_timer(vcpu); > - ret |= apic_has_pending_timer(vcpu); > + e

Re: [ANNOUNCE] kvm-kmod-2.6.30.1

2009-07-08 Thread Avi Kivity
On 07/08/2009 03:45 PM, Avi Kivity wrote: This is a package containing the kvm external module, based on the Linux 2.6.30.1 release. kvm-kmod-2.6.30.1 contains the kvm code that is present in Linux 2.6.30.1, except that it can run on older kernels. It is a good companion to the qemu-kvm-0.10 ser

[ANNOUNCE] kvm-kmod-2.6.31

2009-07-08 Thread Avi Kivity
This is a package containing the kvm external module, based on the Linux 2.6.30.1 release. kvm-kmod-2.6.30.1 contains the kvm code that is present in Linux 2.6.30.1, except that it can run on older kernels. It is a good companion to the qemu-kvm-0.10 series. Note that performance and features wi

[PATCH] remove leftover:

2009-07-08 Thread Glauber Costa
get rid of kvm_callbacks structure definition Signed-off-by: Glauber Costa --- libkvm-all.h | 57 - 1 files changed, 0 insertions(+), 57 deletions(-) diff --git a/libkvm-all.h b/libkvm-all.h index e16646c..f0d2489 100644 --- a/libkvm-all

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Michael S. Tsirkin
On Wed, Jul 08, 2009 at 03:20:02PM +0300, Avi Kivity wrote: > On 07/08/2009 03:13 PM, Michael S. Tsirkin wrote: I think it's time we stopped worrying about builds against old kernel headers or without them. What do we gain from it? >>> qemu upstream doesn't carry its own

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Avi Kivity
On 07/08/2009 03:13 PM, Michael S. Tsirkin wrote: I think it's time we stopped worrying about builds against old kernel headers or without them. What do we gain from it? qemu upstream doesn't carry its own headers, so it we want to merge, we need to work against old headers. Was

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Michael S. Tsirkin
On Wed, Jul 08, 2009 at 03:11:45PM +0300, Avi Kivity wrote: > On 07/08/2009 10:59 AM, Michael S. Tsirkin wrote: >> >>> @@ -337,10 +346,12 @@ int msix_init(struct PCIDevice *dev, unsigned short >>> nentries, >>> if (nentries> MSIX_MAX_ENTRIES) >>> return -EINVAL; >>> >>> +#ifdef KV

Re: [PATCH 0/2] Fix compilation with --disable-kvm

2009-07-08 Thread Avi Kivity
On 07/07/2009 09:36 PM, Glauber Costa wrote: I just came across two errors in --disable-kvm builds. here's the patches to fix it. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Avi Kivity
On 07/08/2009 10:59 AM, Michael S. Tsirkin wrote: @@ -337,10 +346,12 @@ int msix_init(struct PCIDevice *dev, unsigned short nentries, if (nentries> MSIX_MAX_ENTRIES) return -EINVAL; +#ifdef KVM_CAP_IRQCHIP if (kvm_enabled()&& qemu_kvm_irqchip_in_kernel()) { d

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Avi Kivity
On 07/08/2009 03:09 PM, Glauber Costa wrote: I believe that the right thing to do is to define kvm_enabled as a macro returning 0, and let compiler optimize the code out. that already happens with kvm_enabled(). I have no idea why the compiler do not rip of code when we also test for qem

Re: [PATCH 2/2] fix compilation with kvm disabled

2009-07-08 Thread Glauber Costa
On Wed, Jul 08, 2009 at 10:59:13AM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2009 at 02:36:31PM -0400, Glauber Costa wrote: > > Signed-off-by: Glauber Costa > > --- > > hw/msix.c | 14 ++ > > 1 files changed, 14 insertions(+), 0 deletions(-) > > > > diff --git a/hw/msix.c

Re: [PATCH 1/5] BIOS changes for irq0->inti2 override (v9)

2009-07-08 Thread Avi Kivity
On 07/07/2009 06:50 PM, Beth Kon wrote: bios: allow qemu to configure irq0->inti2 override Win2k8 expects the HPET interrupt on inti2, regardless of whether an override exists in the BIOS. And the HPET spec states that in legacy mode, timer interrupt is on inti2. The i

Re: guest gettimeofday behavior

2009-07-08 Thread Glauber Costa
On Tue, Jul 07, 2009 at 05:12:16PM -0300, Marcelo Tosatti wrote: > On Tue, Jul 07, 2009 at 09:58:46AM +, Eran Rom wrote: > > Eran Rom il.ibm.com> writes: > > > > > > > > Eran Rom il.ibm.com> writes: > > > > > > Still getting a misbehaving clock: > > > guest uses kvmclock with kernel 2.6.27

Re: [KVM PATCH v9 1/2] KVM: make io_bus interface more robust

2009-07-08 Thread Gregory Haskins
Michael S. Tsirkin wrote: > On Tue, Jul 07, 2009 at 01:26:11PM -0400, Gregory Haskins wrote: > > >> I suppose its personal preference either way, so I guess unless Avi >> objects lets just each have our own style in that regard. >> > > I think Avi already said we don't need to standardize e

Re: kvm guest for 486 sx

2009-07-08 Thread Avi Kivity
On 07/08/2009 02:04 PM, Andre Przywara wrote: emulate a 486sx without a 487, but that will take a kernel patch. What are you thinking of? Forcing CR0.EM to 1 (and don't let the guest change it), then inject #NM into the guest? Yes. -- error compiling committee.c: too many arguments to funct

[autotest] [PATCH] add control file for kernbench under kvm

2009-07-08 Thread sudhir kumar
This patch adds the control file for kernbench to be executed under kvm tests. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/autotest_control/kernbench.control === --- /dev/null +++ autotest/client/tests/kvm/autotest_

Re: kvm guest for 486 sx

2009-07-08 Thread Andre Przywara
Avi Kivity wrote: On 07/07/2009 04:15 PM, Jerry Geis wrote: Notice FPU indicates yes and I requested -fpu on the command line. I think it detects the host fpu as a 487 coprocessor. Anything in dmesg about it? Note there's no fpu in the flags: line. That's a kvm kernel bug. also is this

Re: [Autotest] [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread Subrata Modak
On Wed, 2009-07-08 at 09:47 +0530, sudhir kumar wrote: > Ok Then. So my idea is to include the patch in autotest and let the > people report failures(in compilation or execution), and we can patch > autotest to apply the fix patch and build and run ltp. I do not think > we can find all cases until

Re: [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread Subrata Modak
On Tue, 2009-07-07 at 10:45 -0700, Martin Bligh wrote: > On Tue, Jul 7, 2009 at 12:24 AM, sudhir kumar wrote: > > On Tue, Jul 7, 2009 at 12:07 AM, Martin Bligh wrote: > Issues: LTP has a history of some of the testcases getting broken. > >> > >> Right, that's always the concern with doing this

Re: [PATCH] net: re-instate some lost vnet_hdr code

2009-07-08 Thread Avi Kivity
On 07/08/2009 11:47 AM, Mark McLoughlin wrote: Merge commit 211eb5f301 lost the code we had in tap_send_packet() to handle the case of the tapfd having IF_VNET_HDR enabled, but the NIC code not having support for virtio_net_hdr. In this case, we just strip off the header before passing it to the

Re: [Autotest] [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread sudhir kumar
On Wed, Jul 8, 2009 at 2:55 PM, Dor Laor wrote: > On 07/08/2009 07:40 AM, Martin Bligh wrote: >>> >>> ATM I will suggest to merge the patches in and let get tested so that >>> we can collect failures/breakages if any. >> >> I am not keen on causing regressions, which we've risked doing every >> tim

Re: [Autotest] [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest

2009-07-08 Thread Dor Laor
On 07/08/2009 07:40 AM, Martin Bligh wrote: ATM I will suggest to merge the patches in and let get tested so that we can collect failures/breakages if any. I am not keen on causing regressions, which we've risked doing every time we change LTP. I think we at least need to get a run on a non-vir

[ kvm-Bugs-2817367 ] Network doesn't work anymore switching from kvm-86 to kvm-87

2009-07-08 Thread SourceForge.net
Bugs item #2817367, was opened at 2009-07-06 11:33 Message generated for change (Comment added) made by markmc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2817367&group_id=180599 Please note that this message will contain a full copy of the comment th

[PATCH] net: re-instate some lost vnet_hdr code

2009-07-08 Thread Mark McLoughlin
Merge commit 211eb5f301 lost the code we had in tap_send_packet() to handle the case of the tapfd having IF_VNET_HDR enabled, but the NIC code not having support for virtio_net_hdr. In this case, we just strip off the header before passing it to the NIC. Fixes: http://sourceforge.net/tracker/?

[autotest] [PATCH 6/6] add-disktest-stress-ebizzy-entry-in-kvm-sample-config

2009-07-08 Thread sudhir kumar
This patch adds the test entries in the sample config file for kvm test execution. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/kvm_tests.cfg.sample === --- autotest.orig/client/tests/kvm/kvm_tests.cfg.sample +++ aut

[PATCH] rev4: support colon in filenames

2009-07-08 Thread Ram Pai
Problem: It is impossible to feed filenames with the character colon because qemu interprets such names as a protocol. For example filename scsi:0, is interpreted as a protocol by name "scsi". This patch allows user to espace colon characters. For example the above filename can now be expressed ei

[PATCH] silence kernel messages that can be triggered by a guest

2009-07-08 Thread Gleb Natapov
Some Linux versions (f8) try to read EOI register that is write only. Signed-off-by: Gleb Natapov diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index ccafe0d..6b5dad4 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -590,14 +590,14 @@ static int apic_reg_read(struct kvm_

Re: LILO incompatibility with KVM?

2009-07-08 Thread Andy Sy
Andy Sy wrote: I am trying to install Slackware on KVM-based VPS hosting and keep getting a "LILO keytable read / checksum error" upon booting. Grub-based distros install fine on said VPS. > Anthony Liguori wrote: Are you using virtio disks? It's probably that extboot doesn't implement enou

[autotest] [PATCH 5/6] add-disktest-control-file-in-kvmtest

2009-07-08 Thread sudhir kumar
This patch adds the disktest control file for the test to be executed under kvm tests. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/autotest_control/disktest.control === --- /dev/null +++ autotest/client/tests/kvm/au

[autotest] [PATCH 4/6] add-stress-test-control-file-in-kvmtest

2009-07-08 Thread sudhir kumar
This patch adds the control file for running stress test under kvm guests. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/autotest_control/stress.control === --- /dev/null +++ autotest/client/tests/kvm/autotest_control

[autotest] [PATCH 3/6] update-stress-test-in-autotest

2009-07-08 Thread sudhir kumar
this patch updates the stress test to the latest version 1.0. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/stress/stress.py === --- autotest.orig/client/tests/stress/stress.py +++ autotest/client/tests/stress/stress.py @

[autotest] [PATCH 2/6] add-ebizzy-control-file-in-kvm-test under autotest

2009-07-08 Thread sudhir kumar
This patch adds the control file for ebizzy test to be executed under kvm test. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/autotest_control/ebizzy.control === --- /dev/null +++ autotest/client/tests/kvm/autotest_co

[ kvm-Bugs-2817367 ] Network doesn't work anymore switching from kvm-86 to kvm-87

2009-07-08 Thread SourceForge.net
Bugs item #2817367, was opened at 2009-07-06 12:33 Message generated for change (Comment added) made by bernhardheld You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2817367&group_id=180599 Please note that this message will contain a full copy of the comm

[autotest] [PATCH 1/6] add ebizzy in autotest

2009-07-08 Thread sudhir kumar
This patch adds the wrapper for ebizzy into autotest. here is the link to get a copy of the test tarball. http://sourceforge.net/project/platformdownload.php?group_id=202378&sel_platform=3809 Please review the patch and provide your comments. Signed-off-by: Sudhir Kumar Index: autotest/client/

  1   2   >