KVM-87 compile failed

Hi, Compiling KVM-87 failed with following error: make -C /lib/modules/2.6.29-gentoo-r5/build M=`pwd` \ LINUXINCLUDE="-I`pwd`/include -Iinclude \ -Iarch/x86/include -I`pwd`/include-compat \ -include include/linux/autoconf.h \ -inclu

Re: [PATCH] support colon in filenames

Ram Pai schrieb: > On Thu, 2009-06-25 at 11:14 +0200, Kevin Wolf wrote: >> Ram Pai schrieb: >>> Copying the qemu-devel mailing list too. >>> >>> On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote: Problem: It is impossible to feed filenames with the character colon because qemu inter

rev1 [PATCH] support colon in filenames

Problem: It is impossible to feed filenames with the character colon because qemu interprets such names as a protocol. For example a filename scsi:0, is interpreted as a protocol by name "scsi". This patch allows user to espace colon characters. For example the above filename can now be expressed

RE: ia64: why is mmio bus access lockless?

Hi, Michael Since only virtual ioapic uses the lock-less logic, so it shouldn't introduce the issues. Anyway, it should be safer to add the lock considering its semantic and future usage models. Would you like to prepare a patch to enhance it ? Thanks! Xiantao Michael S. Tsirkin wrote: > H

Re: [Qemu-devel] KVMs default CPU type (was: allow sysenter on 32bit guests running on vmx host)

On Fri, Jun 26, 2009 at 02:42:17AM +0200, Andrea Arcangeli wrote: > that purely asks for troubles I think. At the same time I doubt we > want to deviate much from qemu code here, this seems messy enough > already without big changes to maintain in this area, and I guess this > explains why kvm is o

Re: [Qemu-devel] KVMs default CPU type (was: allow sysenter on 32bit guests running on vmx host)

Hi everyone, On Thu, Jun 25, 2009 at 10:11:58AM +0200, Andre Przywara wrote: > common denominator. This should be a family 15 CPU (AMD K8 or Intel P4) > with a constant vendor ID (in my experiments Intel showed less problems > with guests). Since 64bit Windows has a whitelist of known vendor IDs

Re: virtio-serial: A guest <-> host interface for simple communication

On (Thu) Jun 25 2009 [21:03:02], Rusty Russell wrote: > On Wed, 24 Jun 2009 10:09:37 pm Amit Shah wrote: > > On (Wed) Jun 24 2009 [13:45:01], Rusty Russell wrote: > > > On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > > > > Hello, > > > > > > > > Here are two patches. One implements a virtio-seri

Re: [PATCH] kvm: pass value to in_range callback

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 03:25:12PM -0400, Gregory Haskins wrote: > >> Michael S. Tsirkin wrote: >> >>> On Thu, Jun 25, 2009 at 10:49:51AM -0400, Gregory Haskins wrote: >>> >>> Michael S. Tsirkin wrote: > For write transa

Re: [PATCH] kvm: pass value to in_range callback

On Thu, Jun 25, 2009 at 03:25:12PM -0400, Gregory Haskins wrote: > Michael S. Tsirkin wrote: > > On Thu, Jun 25, 2009 at 10:49:51AM -0400, Gregory Haskins wrote: > > > >> Michael S. Tsirkin wrote: > >> > >>> For write transactions, pass the value written to in_range checks so > >>> that we

Re: [PATCH] kvm: pass value to in_range callback

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 10:49:51AM -0400, Gregory Haskins wrote: > >> Michael S. Tsirkin wrote: >> >>> For write transactions, pass the value written to in_range checks so >>> that we can make each iosignalfd a separate device on kvm bus. >>> >>> Signed-off-by: M

Re: [PATCH] kvm: pass value to in_range callback

On Thu, Jun 25, 2009 at 10:49:51AM -0400, Gregory Haskins wrote: > Michael S. Tsirkin wrote: > > For write transactions, pass the value written to in_range checks so > > that we can make each iosignalfd a separate device on kvm bus. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Reposti

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 01:32:22PM -0400, Gregory Haskins wrote: > >> Please take a close look at it and consider for merging, if you would. >> > > With all the incremental patching, I kind of lost track of what the > complete file would look like. Is there a gi

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

On Thu, Jun 25, 2009 at 01:32:22PM -0400, Gregory Haskins wrote: > Please take a close look at it and consider for merging, if you would. With all the incremental patching, I kind of lost track of what the complete file would look like. Is there a git tree I could pull? -- MST -- To unsubscribe

Re: [PATCH] support colon in filenames

On Thu, 2009-06-25 at 11:14 +0200, Kevin Wolf wrote: > Ram Pai schrieb: > > Copying the qemu-devel mailing list too. > > > > On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote: > >> Problem: It is impossible to feed filenames with the character colon > >> because > >> qemu interprets such names as

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

Davide Libenzi wrote: > On Thu, 25 Jun 2009, Rusty Russell wrote: > > >> On Thu, 25 Jun 2009 08:15:11 am Davide Libenzi wrote: >> >>> Some components would like to know if userspace dropped the fd, and take >>> proper action accordingly (release resources, drop module instances, >>> etc...)

Device assignment hotplug broken

The impact of the hotplug changes on device assignment were too difficult for me to fix up during the merge, so I disabled it temporarily. Please take a look at qemu-kvm.git commit a3b371477e3. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.

Re: [KVM PATCH v5 0/4] irqfd fixes and enhancements

On Thu, 25 Jun 2009, Gregory Haskins wrote: > So I know we talked yesterday in the review session about whether it was > actually worth all this complexity to deal with the POLLHUP or if we > should just revert to the prior "two syscall" model and be done with > it. Rusty reflected these same sen

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

On Thu, 25 Jun 2009, Rusty Russell wrote: > On Thu, 25 Jun 2009 08:15:11 am Davide Libenzi wrote: > > > > Some components would like to know if userspace dropped the fd, and take > > proper action accordingly (release resources, drop module instances, > > etc...). > > Like to know? Possibly. Ne

[KVM-AUTOTEST PATCH] bugfix for changing kvm_log to logging

diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4c7bae4..26ae46f 100644 --- a/client/tests/kvm/kvm.py +++ b/client/tests/kvm/kvm.py @@ -73,7 +73,7 @@ class kvm(test.test): resource.setrlimit(resource.RLIMIT_CORE, (-1, -1)) # Set the logging prefix -#

Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote: > On Wed, Jun 24, 2009 at 11:49:01AM +0300, Michael S. Tsirkin wrote: > >> On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote: >> >>> Michael S. Tsirkin wrote: >>> Remove in_range from kvm_io_device and ask read/write callbacks, if sup

about savevm and mem-path

Hello, When i 'm trying to do a savevm from qemu monitor, all is ok with standard qemu command. If i'm using -mem-path /hugepages, savevm leave vm in a block state, as i do a stop command I'm trying with last qem-kvm git tree. So is -mem-path also works with vm migration and savevm state ? Regard

Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 10:22:29AM -0400, Gregory Haskins wrote: > >> Gregory Haskins wrote: >> >>> Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if >>> it >>> fails. We want to create dynamic MMIO/PIO entries driven from userspace >>

Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

On Thu, Jun 25, 2009 at 10:22:29AM -0400, Gregory Haskins wrote: > Gregory Haskins wrote: > > Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if > > it > > fails. We want to create dynamic MMIO/PIO entries driven from userspace > > later > > in the series, so we need to e

Re: [PATCH] kvm: pass value to in_range callback

Michael S. Tsirkin wrote: > For write transactions, pass the value written to in_range checks so > that we can make each iosignalfd a separate device on kvm bus. > > Signed-off-by: Michael S. Tsirkin > --- > > Reposting with a subject now. Sorry. > > Avi, can you please merge this patch in kvm.git

Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

Gregory Haskins wrote: > Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if it > fails. We want to create dynamic MMIO/PIO entries driven from userspace later > in the series, so we need to enhance the code to be more robust with the > following changes: > >1) Add a ret

Re: [KVM PATCH v5 0/4] irqfd fixes and enhancements

Gregory Haskins wrote: > (Applies to kvm.git/master:4631e094) > > The following is the latest attempt to fix the races in irqfd/eventfd, as > well as restore DEASSIGN support. For more details, please read the patch > headers. > > This series has been tested against the kvm-eventfd unit test, and

[KVM PATCH v5 4/4] KVM: add irqfd DEASSIGN feature

DEASSIGN allows us to optionally disassociate an IRQFD from its underlying eventfd without destroying the eventfd in the process. This is useful for conditions like live-migration which may have an eventfd associated with a device and an IRQFD. We need to be able to decouple the guest from the ev

[KVM PATCH v5 3/4] KVM: Fix races in irqfd using new eventfd_kref_get interface

eventfd currently emits a POLLHUP wakeup on f_ops->release() to generate a "release" callback. This lets eventfd clients know if the eventfd is about to go away and is very useful particularly for in-kernel clients. However, until recently it is not possible to use this feature of eventfd in a ra

[KVM PATCH v5 2/4] eventfd - revised interface and cleanups (4th rev)

From: Davide Libenzi The following patch changes the eventfd interface to de-couple the eventfd memory context, from the file pointer instance. Without such change, there is no clean way to racely free handle the POLLHUP event sent when the last instance of the file* goes away. Also, now the inte

[KVM PATCH v5 1/4] kvm: prepare irqfd for having interrupts disabled during eventfd->release

We need to plug some race conditions on eventfd shutdown. In order to do this, we need to change the context in which the release notification is delivered so that the wqh lock is now held. However, there is currently code in the release callback that assumes it can sleep. We have a slight chick

[KVM PATCH v5 0/4] irqfd fixes and enhancements

(Applies to kvm.git/master:4631e094) The following is the latest attempt to fix the races in irqfd/eventfd, as well as restore DEASSIGN support. For more details, please read the patch headers. This series has been tested against the kvm-eventfd unit test, and appears to be functioning properly.

guest gettimeofday behavior

Hi All, Am a newbie (to kvm, linux kernel, git, etc.) so apologize in advance for missing/inaccurate info. I am experiencing inconsistent behavior of guest gettimeofday, described below. I have seen prior reference to the problem, however, it was not clear whether the issue was solved or not and wh

Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 09:02:28AM -0400, Gregory Haskins wrote: > >>> Here's what I have in mind: >>> kvm does >>> lock >>> dev = find >>> unlock >>> >>> <-- at this point group device is removed >>> >>> write access to device that has bee

Re: [PATCH] kvm: remove in_range from kvm_io_device

On Thu, Jun 25, 2009 at 09:02:28AM -0400, Gregory Haskins wrote: > > Here's what I have in mind: > > kvm does > > lock > > dev = find > > unlock > > > > <-- at this point group device is removed > > > > write access to device that has been removed > > > > > > > > Hmm

[PATCH] qemu-kvm: fix KVMs GET_SUPPORTED_CPUID feature usage

If we want to trim the user provided CPUID bits for KVM to be not greater than that of the host, we should a) not remove the bits _after_ we sent them to the kernel and b) not do the bitmangling on the original values while sending a copy This fixes the masking of features that are not present on

Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 08:08:04AM -0400, Gregory Haskins wrote: > >> The patch has been in circulation for weeks, is well tested/reviewed >> (and I hope its considered well written), and I want to get on with my >> life ;). >> > > Hey, I feel your pain, I've bee

Re: Latest kvm autotest patch queue

sudhir kumar 写道: On Mon, Jun 22, 2009 at 6:54 PM, Lucas Meneghel Rodrigues wrote: KVM Autotest patch queue Michael Goldish (mgold...@redhat.com) 1) KVM test: optionally convert PPM files to PNG format after te

[PATCH] kvm: pass value to in_range callback

For write transactions, pass the value written to in_range checks so that we can make each iosignalfd a separate device on kvm bus. Signed-off-by: Michael S. Tsirkin --- Reposting with a subject now. Sorry. Avi, can you please merge this patch in kvm.git so that Gregory can use it for iosignalf

[no subject]

mar...@redhat.com Subject: [PATCH] kvm: pass value to in_range callback Reply-To: For write transactions, pass the value written to in_range checks so that we can make each iosignalfd a separate device on kvm bus. Signed-off-by: Michael S. Tsirkin --- Avi, can you please merge this patch in kv

[PATCH] kvm-kmod: Fix tracepoint warnings against OpenSUSE's 2.6.27

OpenSUSE's 2.6.27 already includes tracepoints and generates a lot of warnings regarding redefinition of tracepoint_synchronize_unregister. Signed-off-by: Jan Kiszka --- external-module-compat-comm.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/external-module-comp

Re: [PATCH] kvm: remove in_range from kvm_io_device

On Thu, Jun 25, 2009 at 08:08:04AM -0400, Gregory Haskins wrote: > The patch has been in circulation for weeks, is well tested/reviewed > (and I hope its considered well written), and I want to get on with my > life ;). Hey, I feel your pain, I've been reviewing these .. > Your proposal doesn't c

[PATCH] Move x86 specific code from qemu-kvm.c to qemu-kvm-x86.c

Signed-off-by: Gleb Natapov --- qemu-kvm-ia64.c |4 qemu-kvm-x86.c | 43 +++ qemu-kvm.c | 44 +--- qemu-kvm.h |1 + 4 files changed, 49 insertions(+), 43 deletions(-) diff --git a/qemu-kv

[PATCH] Use cpu_is_bsp() to check for bsp cpu.

Signed-off-by: Gleb Natapov --- qemu-kvm-x86.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index 568df53..a78073e 100644 --- a/qemu-kvm-x86.c +++ b/qemu-kvm-x86.c @@ -23,6 +23,7 @@ #include #include "kvm.h" +#include "hw/pc.h"

[PATCH] Add kvm_set_boot_cpu_id() API.

Signed-off-by: Gleb Natapov --- hw/pc.c|3 ++- qemu-kvm.c | 17 + qemu-kvm.h |1 + 3 files changed, 20 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index cb5b4d0..9ef245d 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -901,7 +901,8 @@ static void pc_init1(ra

Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote: > On Thu, Jun 25, 2009 at 07:27:36AM -0400, Gregory Haskins wrote: > >> Michael S. Tsirkin wrote: >> >>> On Wed, Jun 24, 2009 at 11:49:01AM +0300, Michael S. Tsirkin wrote: >>> >>> On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote:

Re: [PATCH] kvm: remove in_range from kvm_io_device

On Thu, Jun 25, 2009 at 07:27:36AM -0400, Gregory Haskins wrote: > Michael S. Tsirkin wrote: > > On Wed, Jun 24, 2009 at 11:49:01AM +0300, Michael S. Tsirkin wrote: > > > >> On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote: > >> > >>> Michael S. Tsirkin wrote: > >>> >

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

On Thu, 25 Jun 2009 08:15:11 am Davide Libenzi wrote: > On Wed, 24 Jun 2009, Rusty Russell wrote: > > On Tue, 23 Jun 2009 03:33:22 am Davide Libenzi wrote: > > > What you're doing there, is setting up a kernel-to-kernel (since > > > userspace only role is to create the eventfd) communication, using

Re: virtio-serial: A guest <-> host interface for simple communication

On Wed, 24 Jun 2009 10:09:37 pm Amit Shah wrote: > On (Wed) Jun 24 2009 [13:45:01], Rusty Russell wrote: > > On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > > > Hello, > > > > > > Here are two patches. One implements a virtio-serial device in qemu > > > and the other is the driver for a guest ke

Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote: > On Wed, Jun 24, 2009 at 11:49:01AM +0300, Michael S. Tsirkin wrote: > >> On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote: >> >>> Michael S. Tsirkin wrote: >>> Remove in_range from kvm_io_device and ask read/write callbacks, if sup

Re: [PATCH] kvm: remove in_range from kvm_io_device

On Wed, Jun 24, 2009 at 11:49:01AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote: > > Michael S. Tsirkin wrote: > > > Remove in_range from kvm_io_device and ask read/write callbacks, if > > > supplied, to perform range checks internally. This all

Re: [PATCH] kvm-kmod: Fix condition for native_read_msr_safe wrapping

On 06/25/2009 11:24 AM, Jan Kiszka wrote: For i386, native_read_msr_safe was already introduced in 2.6.22. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord..

Re: [PATCH] introduce module parameter for ignoring unknown MSRs accesses

On 06/25/2009 01:36 PM, Andre Przywara wrote: KVM will inject a #GP into the guest if that tries to access unhandled MSRs. This will crash many guests. Although it would be the correct way to actually handle these MSRs, we introduce a runtime switchable module param called "ignore_msrs" (defaults

[PATCH] introduce module parameter for ignoring unknown MSRs accesses

KVM will inject a #GP into the guest if that tries to access unhandled MSRs. This will crash many guests. Although it would be the correct way to actually handle these MSRs, we introduce a runtime switchable module param called "ignore_msrs" (defaults to 0). If this is Y, unknown MSR reads will ret

Re: [ANNOUNCE] kvm-87 release

On 06/25/2009 12:21 PM, Avi Kivity wrote: Many fixes, performance improvements, a preview of irqfd, but all of these pale in comparison to That was kvm-87 released, not a kvm-86 rerun. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

[ANNOUNCE] kvm-86 release

Many fixes, performance improvements, a preview of irqfd, but all of these pale in comparison to qemu-system-x86_64 -m 1024 -cdrom http://example.com/livecd.iso yes, no need for tedious downloading any more. Changes from kvm-86: - merge qemu upstream (Mark McLoughlin, me) - tune and view

Re: [PATCH] support colon in filenames

Ram Pai schrieb: > Copying the qemu-devel mailing list too. > > On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote: >> Problem: It is impossible to feed filenames with the character colon because >> qemu interprets such names as a protocol. For example a filename scsi:0, >> is interpreted as a pro

Re: [Qemu-devel] KVMs default CPU type

On 06/25/2009 11:11 AM, Andre Przywara wrote: I think we should go away from using qemu64 as a default for KVM. In my opinion we should target -cpu host as KVM's default, while in parallel create a -cpu migrate type (still fiddling with the CPUID details of that), which takes over the qemu64 ro

[PATCH] kvm-kmod: Fix condition for native_read_msr_safe wrapping

For i386, native_read_msr_safe was already introduced in 2.6.22. Signed-off-by: Jan Kiszka --- x86/external-module-compat.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h index 881602e..8436e43 100644 --- a

[Qemu-devel] KVMs default CPU type (was: allow sysenter on 32bit guests running on vmx host)

[CCing k...@vger] Jamie Lokier wrote: Andrea Arcangeli wrote: Hi Jamie, >... It looks like it could be a KVM mis-feature. Is the changing vendor id actually useful for anything, without updating the family/model/stepping at the same time? E.g. does it make some guest things work, even thoug