Re: Kopete & KF5 switch

2017-08-07 Thread Pali Rohár
On Monday 07 August 2017 07:52:39 vijay krishnavanshi wrote: > Hi, > > I am fixing the raised issues in old review requests so how do I submit the > changes for review. Should I create a new review request addressing all the > issues or create a separate review request for each old review request?

Re: Kopete & KF5 switch

2017-08-07 Thread Luigi Toscano
Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha scritto: > >Anyway, I rebased kf5 branch on top of master with (semi-manual) >conflicts resolution and found out that changes between kf5 branch and >"kf5 rebased on top of master" differs. And I suspect that some merge >commits which was done from

Re: Kopete & KF5 switch

2017-08-07 Thread Pali Rohár
On Monday 07 August 2017 10:26:46 Luigi Toscano wrote: > Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha > scritto: > > > > >Anyway, I rebased kf5 branch on top of master with (semi-manual) > >conflicts resolution and found out that changes between kf5 branch and > >"kf5 rebased on top of maste

Re: Kopete & KF5 switch

2017-08-07 Thread Pali Rohár
On Monday 07 August 2017 09:34:37 Pali Rohár wrote: > On Monday 07 August 2017 07:52:39 vijay krishnavanshi wrote: > > Hi, > > > > I am fixing the raised issues in old review requests so how do I submit the > > changes for review. Should I create a new review request addressing all the > > issues