On Sunday 06 August 2017 03:30:35 vijay krishnavanshi wrote:
> Hi,
>
> > > 1) kf5 branch contains some commits which have open issues on
> > > reviewboard, namely:
> > >
> > > https://git.reviewboard.kde.org/r/124305/
> > > https://git.reviewboard.kde.org/r/124181/
> > > https://git.reviewboard.k
Hi,
> > This commit looks okay to me as nothing much is changed in terms of
> > behavior. In this commit an attempt to close all the windows is made
> > when we are able to close all window other wise return from the
> > function. In normal conditions returning in the middle of for loop
> > does
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/
---
(Updated Aug. 6, 2017, 11:45 p.m.)
Review request for Kopete, Laurent Mon
Hi,
I am fixing the raised issues in old review requests so how do I submit the
changes for review. Should I create a new review request addressing all the
issues or create a separate review request for each old review request? or
comment on the old review request for the changes?
Regards,
Vijay