Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-19 Thread R.Harish Navnit
> On July 15, 2015, 10:16 a.m., Laurent Montel wrote: > > plugins/autoreplace/autoreplacepreferences.cpp, line 50 > > > > > > Why ? > > Why not add directly setColumCount(2) ? Isn't it better not to hardcode

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-19 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated July 19, 2015, 5:45 p.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-19 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82643 --- plugins/autoreplace/autoreplacepreferences.cpp (line 49)

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-19 Thread R.Harish Navnit
> On July 19, 2015, 6:13 p.m., Laurent Montel wrote: > > plugins/autoreplace/autoreplacepreferences.cpp, line 50 > > > > > > why it's better ? > > you know how many column you added. > > => so not necessar