Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly rena

2011-12-03 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/ --- Review request for Kopete. Description --- This adds a context option "

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-03 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/ --- (Updated Dec. 3, 2011, 1:23 p.m.) Review request for Kopete. Description -

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-12-03 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6823/ --- (Updated Dec. 3, 2011, 1:30 p.m.) Review request for Kopete. Changes -

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-12-03 Thread cyberbeat
> On Nov. 9, 2011, 3:01 p.m., Pali Rohár wrote: > > Your patch disable updating nickname of all contacts from jabber server. > > This is bad because some people want to autoupdate new nicknames from > > server. > > Instead totally disabling this functions, it should be configurable (in > > jab

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-03 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10510 --- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlis

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-03 Thread cyberbeat
> On Dec. 3, 2011, 2 p.m., Pali Rohár wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, > > line 550 > > > > > > I think you should remove this dead commented code. oops, forgot t