Re: Review Request: use directly jasper library for yahoo webcam image conversion - do not run anymore the external program (expensive; uses disk files)

2011-01-15 Thread Cristi P
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6312/ --- (Updated Jan. 15, 2011, 11:13 a.m.) Review request for Kopete. Changes ---

Re: Review Request: use directly jasper library for yahoo webcam image conversion - do not run anymore the external program (expensive; uses disk files)

2011-01-15 Thread Cristi P
> On Jan. 10, 2011, 7:19 p.m., Frank Schaefer wrote: > > When disabling of the video part is cleaned up / fixed, you can simplify > > your patch a lot: > > > > Just do > > > > if ( NOT DISABLE_VIDEOSUPPORT ) > > find_package(Jasper) > > macro_log_feature(...) > > endif > > > > in

Re: Review Request: use directly jasper library for yahoo webcam image conversion - do not run anymore the external program (expensive; uses disk files)

2011-01-15 Thread Cristi P
> On Jan. 9, 2011, 6:02 p.m., Raphael Kubo da Costa wrote: > > The idea of not relying on an external process for this sounds good (it'd > > be nice if you could look up our bugzilla and see if there's any bug report > > related to this). > > > > The code still needs some work IMO. The files y

Re: Review Request: use directly jasper library for yahoo webcam image conversion - do not run anymore the external program (expensive; uses disk files)

2011-01-15 Thread Cristi P
> On Jan. 12, 2011, 4:49 p.m., Frank Schaefer wrote: > > Hmm... thinking about it for some minutes... the question is: how do we > > define "video support disabled" ? > > It's main purpose is to skip the video device part (doesn't compile on all > > platforms, much code, additional dependencies

Review Request: yahoo webcam protocol - fix a bit sending several outgoing webcam requests + a typo fix that denies in some cases sending webcam data

2011-01-15 Thread Cristi P
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6333/ --- Review request for Kopete. Summary --- a) seems like yahoo protocol doe

Re: Review Request: use directly jasper library for yahoo webcam image conversion - do not run anymore the external program (expensive; uses disk files)

2011-01-15 Thread Cristi P
> On Jan. 12, 2011, 4:49 p.m., Frank Schaefer wrote: > > Hmm... thinking about it for some minutes... the question is: how do we > > define "video support disabled" ? > > It's main purpose is to skip the video device part (doesn't compile on all > > platforms, much code, additional dependencies