KDE/kdenetwork/kopete/protocols/oscar/icq/ui

2010-06-15 Thread Nick Shaforostoff
SVN commit 1138264 by shaforo: remove redundant checks for NULL see: http://www.parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.8 http://www.parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.6 CCMAIL: m...@gehn.net CCMAIL: kopete-devel@kde.org M +0 -8 icqeditaccountwidget.cpp

permission to break string freeze - kopete proxy config ui

2010-06-15 Thread Nick Shaforostoff
Hi all. As part of fixing the issue about kopete's proxy support [1], I've added a UI for configuring proxy settings to ICQ account preferences page. It adds about 10 strings, including long 'what's this' help ('The IP address or hostmask of the proxy server you wish to use for connecting to IC

Re: KDE/kdenetwork/kopete/protocols/oscar/icq/ui

2010-06-15 Thread Tomáš Trnka
Dne Út 15. června 2010 Nick Shaforostoff napsal(a): (snip) > @@ -222,8 +216,6 @@ > { > kDebug(14153) << "Creating a new account"; > mAccount = new ICQAccount(mProtocol, > mAccountSettings->edtAccountId->text()); > - if(!mAccount) > -

Re: KDE/kdenetwork/kopete/protocols/oscar/icq/ui

2010-06-15 Thread Olivier Goffart
Le Tuesday 15 June 2010, Tomáš Trnka a écrit : > Dne Út 15. června 2010 Nick Shaforostoff napsal(a): > (snip) > > mAccount = new ICQAccount(mProtocol, mAccountSettings->edtAccountId > > - if(!mAccount) > > - return NULL; > Hello, > > do we really want this? All hell will break loose