Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review84302 --- plugins/history/chathistoryplugin.cpp (lines 22 - 23)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review84301 --- please close issues which you are already fixed - Pali Rohár

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/ --- (Updated Aug. 24, 2015, 11:08 a.m.) Review request for Kopete and Pali Ro

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review84049 --- plugins/history/databasemanager.h (line 62)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83663 --- plugins/history/databasemanager.cpp (line 188)

Re: Review Request 124643: First review request for the history plugin

> On Aug. 6, 2015, 4:37 p.m., Pali Rohár wrote: > > plugins/history/databasemanager.h, line 62 > > > > > > Now from documentation text, parameters and return value I'm trying to > > understand: > > 1) What th

Re: Review Request 124643: First review request for the history plugin

> On Авг. 6, 2015, 4:37 п.п., Pali Rohár wrote: > > plugins/history/databaseconstants.cpp, line 139 > > > > > > *All* I mean really *all* SQL statements mustn't contains any external > > data, like return value

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83662 --- plugins/history/databaseconstants.cpp (line 116)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83661 --- plugins/history/chathistoryplugin.cpp (line 58)

Re: Review Request 124643: First review request for the history plugin

> On Aug. 6, 2015, 4:37 p.m., Pali Rohár wrote: > > plugins/history/chathistoryplugin.cpp, line 58 > > > > > > Can you exaplin me what is this line supposed to do? Specially what do > > you expect in chatMemebers

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83555 --- plugins/history/historybrowser.h (line 40)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83554 --- plugins/history/databasemanager.cpp (line 195)

Re: Review Request 124643: First review request for the history plugin

> On Авг. 6, 2015, 4:37 п.п., Pali Rohár wrote: > > plugins/history/databasemanager.cpp, line 188 > > > > > > And this will break chat history for contacts which name contains char > > ',' > > > > Yes,

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83551 --- plugins/history/databasemanager.cpp (line 179)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83550 --- plugins/history/databasemanager.cpp (line 154)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83549 --- plugins/history/databasemanager.cpp (line 55)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83547 --- plugins/history/databaseconstants.cpp (line 117)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83544 --- plugins/history/chathistoryplugin.cpp (line 45)

Re: Review Request 124643: First review request for the history plugin

> On Авг. 6, 2015, 4:37 п.п., Pali Rohár wrote: > > plugins/history/databaseconstants.h, line 1 > > > > > > Just remove this whole file and rewrite code to better. Function > > which just return is useless. Colu

Re: Review Request 124643: First review request for the history plugin

> On Авг. 6, 2015, 4:37 п.п., Pali Rohár wrote: > > plugins/history/chathistoryplugin.cpp, line 58 > > > > > > Can you exaplin me what is this line supposed to do? Specially what do > > you expect in chatMemebers

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83542 --- plugins/history/chathistoryplugin.cpp (line 23)

Re: Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/#review83503 --- I did just quick look at code, nothing deeply! Problems are ma

Re: Review Request 124643: First review request for the history plugin

On Thursday 06 August 2015 12:10:55 Joseph Joshua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124643/ > --- > > Revi

Review Request 124643: First review request for the history plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124643/ --- Review request for Kopete and Pali Rohár. Repository: kopete Descriptio