Re: Review Request: Set notification title for 'Incoming message' events

2010-09-10 Thread Igor Poboiko
> On 2010-08-30 19:47:51, Raphael Kubo da Costa wrote: > > Well, since nobody else has said anything on this patch, I think it may be > > safe to commit it. Do you have an account? > > Igor Poboiko wrote: > No, I don't. So can anyone else commit it? Ok, finally I get a svn account, so I co

Re: Review Request: Set notification title for 'Incoming message' events

2010-09-01 Thread Olivier Goffart
Le Wednesday 01 September 2010, Igor Poboiko a écrit : > > On 2010-08-30 19:47:51, Raphael Kubo da Costa wrote: > > > Well, since nobody else has said anything on this patch, I think it may > > > be safe to commit it. Do you have an account? > > No, I don't. So can anyone else commit it? If you p

Re: Review Request: Set notification title for 'Incoming message' events

2010-09-01 Thread Igor Poboiko
> On 2010-08-30 19:47:51, Raphael Kubo da Costa wrote: > > Well, since nobody else has said anything on this patch, I think it may be > > safe to commit it. Do you have an account? No, I don't. So can anyone else commit it? - Igor ---

Re: Review Request: Set notification title for 'Incoming message' events

2010-08-30 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5175/#review7300 --- Ship it! Well, since nobody else has said anything on this patch, I t

Re: Review Request: Set notification title for 'Incoming message' events

2010-08-30 Thread Raphael Kubo da Costa
> On 2010-08-29 19:23:59, Raphael Kubo da Costa wrote: > > Looks OK at first sight; have you tried contacting someone else about the > > KNotify behaviour you think is a bug? > > Igor Poboiko wrote: > I didn't try, but I have just filled a bugreport. See bug 249468. > > Igor Poboiko wrote:

Re: Review Request: Set notification title for 'Incoming message' events

2010-08-30 Thread Igor Poboiko
> On 2010-08-29 19:23:59, Raphael Kubo da Costa wrote: > > Looks OK at first sight; have you tried contacting someone else about the > > KNotify behaviour you think is a bug? > > Igor Poboiko wrote: > I didn't try, but I have just filled a bugreport. See bug 249468. I created a simple patc

Re: Review Request: Set notification title for 'Incoming message' events

2010-08-29 Thread Igor Poboiko
> On 2010-08-29 19:23:59, Raphael Kubo da Costa wrote: > > Looks OK at first sight; have you tried contacting someone else about the > > KNotify behaviour you think is a bug? I didn't try, but I have just filled a bugreport. See bug 249468. - Igor ---

Re: Review Request: Set notification title for 'Incoming message' events

2010-08-29 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5175/#review7272 --- Looks OK at first sight; have you tried contacting someone else about

Review Request: Set notification title for 'Incoming message' events

2010-08-28 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5175/ --- Review request for Kopete. Summary --- Currently, notifications for incomin