Re: kopete API breakage

2013-06-21 Thread Jussi Kekkonen
On 21 June 2013 11:05, Pali Rohár wrote: > On Thursday 20 June 2013 13:45:36 Pali Rohár wrote: > > On Thursday 20 June 2013 12:00:21 Jonathan Riddell wrote: > > > On Thu, Jun 20, 2013 at 11:34:44AM +0200, Pali Rohár wrote: > > > > On Wednesday 19 June 2013 15:54:53 Jonathan Riddell wrote: > > > >

Re: kopete API breakage

2013-06-21 Thread Pali Rohár
On Thursday 20 June 2013 13:45:36 Pali Rohár wrote: > On Thursday 20 June 2013 12:00:21 Jonathan Riddell wrote: > > On Thu, Jun 20, 2013 at 11:34:44AM +0200, Pali Rohár wrote: > > > On Wednesday 19 June 2013 15:54:53 Jonathan Riddell wrote: > > > > Another one is 7d8f948e33b861b3d5f013deb985ede3e36

Re: kopete API breakage

2013-06-20 Thread Jonathan Riddell
On Thu, Jun 20, 2013 at 11:34:44AM +0200, Pali Rohár wrote: > On Wednesday 19 June 2013 15:54:53 Jonathan Riddell wrote: > > Another one is 7d8f948e33b861b3d5f013deb985ede3e36725b2 > > virtual QList *customContextMenuActions( > > ChatSession *manager ); > > > > Jonathan > > Jonathan, please test

Re: kopete API breakage

2013-06-20 Thread Pali Rohár
On Thursday 20 June 2013 12:00:21 Jonathan Riddell wrote: > On Thu, Jun 20, 2013 at 11:34:44AM +0200, Pali Rohár wrote: > > On Wednesday 19 June 2013 15:54:53 Jonathan Riddell wrote: > > > Another one is 7d8f948e33b861b3d5f013deb985ede3e36725b2 > > > virtual QList *customContextMenuActions( > > > C

Re: kopete API breakage

2013-06-20 Thread Pali Rohár
On Wednesday 19 June 2013 15:54:53 Jonathan Riddell wrote: > Another one is 7d8f948e33b861b3d5f013deb985ede3e36725b2 > virtual QList *customContextMenuActions( > ChatSession *manager ); > > Jonathan Jonathan, please test this patch if it now fixing all API breakage. diff --git a/libkopete/kopete

Re: kopete API breakage

2013-06-19 Thread Jonathan Riddell
Another one is 7d8f948e33b861b3d5f013deb985ede3e36725b2 virtual QList *customContextMenuActions( ChatSession *manager ); Jonathan ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: kopete API breakage

2013-06-19 Thread Jonathan Riddell
On Wed, Jun 19, 2013 at 12:45:59PM +0200, Pali Rohár wrote: > But now I see that broke API. So what to do? Revert commit? > Revert back duplicate handleURL() functions which will only call > current funcions? Or change soname? What do you think? Any of those is fine but the first is probably eas

Re: kopete API breakage

2013-06-19 Thread Pali Rohár
On Wednesday 19 June 2013 12:19:17 Jonathan Riddell wrote: > Looks like kopete broke API in 4.10.80 > > virtual void handleURL( const KUrl &url ) const; > and > void handleURL( const KUrl &url ) const; > are missing from > kopetemimetypehandler.h > > But the SONAME has not changed. > > Jonathan