Re: Review Request 124305: Remove K3 classes from kopete main application

2017-11-02 Thread Pali Rohár
> On okt. 3, 2017, 1:08 dopoludnia, Luigi Toscano wrote: > > This was committed as > > https://commits.kde.org/kopete/ea461c02b22681ca50bca40e83c9da6ea517b582 > > > > but for some reason the git hook did not close it (maybe because not on the > > master branch? I don't remember). Luigi, I let

Re: Review Request 124305: Remove K3 classes from kopete main application

2017-10-04 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated Ott. 4, 2017, 11:22 p.m.) Status -- This change has been ma

Re: Review Request 124305: Remove K3 classes from kopete main application

2017-10-02 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review103774 --- This was committed as https://commits.kde.org/kopete/ea461c

Re: Review Request 124305: Remove K3 classes from kopete main application

2016-03-11 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated March 11, 2016, 4:24 p.m.) Status -- This change has been m

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-09-17 Thread R.Harish Navnit
> On Aug. 11, 2015, 10:44 p.m., Pali Rohár wrote: > > kopete/chatwindow/chatview.cpp, line 995 > > > > > > Why is !Q3UriDrag::canDecode(event) changed do > > event->mimeData()->hasText() ? My thinking was that

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-08-11 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review83712 --- kopete/chatwindow/chatview.cpp (line 995)

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-08-03 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review83409 --- Ship it! Seems good. I hope that it works as expected. - Lau

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-26 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 12:49 p.m.) Review request for Kopete, Laurent Mo

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-25 Thread R.Harish Navnit
> On July 26, 2015, 11:19 a.m., Laurent Montel wrote: > > kopete/contactlist/kopeteaddrbookexport.cpp, line 109 > > > > > > Why you don't : > > QListWidgetItem *item = new QListWidgetITem(QIcon, QString); > >

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-25 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82968 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 108)

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-25 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 11:13 a.m.) Review request for Kopete, Laurent Mo

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-25 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 9:59 a.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124305: Remove K3 classes from kopete main application

2015-07-09 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82268 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 131)