Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Rafael Fernández López
Do you mean a non-static attribute ?I've several questions:That static variable (the last patch) was declared into the class, but initialized outside, that's the common way of proceeding i've learnt. I can't understand why to have a parameter "bool firstRun", because we could make the trick and hav

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Michel Hermier
I commited the first patch, since it looks much what I thinks is good. If you have time, think about making the last bool an attribute. Michel 2006/10/11, Rafael Fernández López <[EMAIL PROTECTED]>: > In that case somebody should update the patch that you want (the one with 2 > parameters in cons

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Rafael Fernández López
In that case somebody should update the patch that you want (the one with 2 parameters in constructor as you said), because I've no SVN writing access.Please tell me when udpated.I will work on that d-pointer. Thank you,Rafael Fernández López. ___ kopete-

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Michel Hermier
I think it's better to have it as an attribute (can be a little more complicated). Since if move that code to a plugin, we may need to be able to control the behaviour from designer, and more importantly we need to be able to use it depending on the configuration (I think). The next step would be t

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Rafael Fernández López
Sorry for the last mail. I was thinking in other things.What I mean is this:* Add a new attribute to the class, for example, "static bool firstRun;".* Remove "bool firstRun;" from constructor parameters. * At a first time, firstRun will be true, and setted outside the class (since it is a static va

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Rafael Fernández López
Well, here is the other patch that you talked about Michel. With only parent parameter. I created a new static bool, I have compiled and tested it and it works correctly. But I'm pretty sure this patch will be more critized than the others. Take a look and tell me your comments or suggestions.Thank

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Rafael Fernández López
Well, I can do the trick. Do you mean by adding a new attribute to the class, (bool firstRun), that only is setted to true at firstRun, and remove it from constructor parameter ??Thank you,Rafael Fernández López. ___ kopete-devel mailing list kopete-deve

Re: [kopete-devel] About AddAccountWizard extra constructor parameters

2006-10-11 Thread Michel Hermier
It sounds correct. But I think that the last the firstrun parameter should go to a setter/getter. So that we fallow the Qt QWidget default constructor rule (to allow to have it in a plugin). Comments ? Michel 2006/10/11, Rafael Fernández López <[EMAIL PROTECTED]>: > Hi folks, > > I got 10 minutes