Hi,
> Montel, Vijay, do you think also that KF5 version is really ready for
> release
> into KDE Applications 17.12?
Not sure. Command-line argument function and history plugin part needs to
be fixed (but they are not the primary part of the application). I am
working on it but because of unive
On Thursday 09 November 2017 11:38:19 Luigi Toscano wrote:
> Pali Rohár ha scritto:
> > On Monday 07 August 2017 10:43:17 Pali Rohár wrote:
> >> On Monday 07 August 2017 10:26:46 Luigi Toscano wrote:
> >>> Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha
> >>> scritto:
> >>>
>
> Anyway,
Pali Rohár ha scritto:
> On Monday 07 August 2017 10:43:17 Pali Rohár wrote:
>> On Monday 07 August 2017 10:26:46 Luigi Toscano wrote:
>>> Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha
>>> scritto:
>>>
Anyway, I rebased kf5 branch on top of master with (semi-manual)
conflicts re
On Monday 07 August 2017 10:43:17 Pali Rohár wrote:
> On Monday 07 August 2017 10:26:46 Luigi Toscano wrote:
> > Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha
> > scritto:
> >
> > >
> > >Anyway, I rebased kf5 branch on top of master with (semi-manual)
> > >conflicts resolution and found out t
Hi,
I looked into the diff and I see following things like -
- Issue with the history plugin - I have addressed it with this review
request
Link - https://phabricator.kde.org/D7635
History plugin is revived as well and is working correctly after this RR.
Though some issues need to be fixed on Imp
There was some problem with this clone repository, kde sysadmin fixed it
https://cgit.kde.org/clones/kopete/pali/kopete.git/log/?h=master-kf5
On Wednesday 09 August 2017 22:57:04 Pali Rohár wrote:
> Hi! Try direct clone:
>
> git clone g...@git.kde.org:clones/kopete/pali/kopete.git
>
> and then
Hi! Try direct clone:
git clone g...@git.kde.org:clones/kopete/pali/kopete.git
and then checkout branch master-kf5
Looks like some problem with git kde infra...
On Thursday 10 August 2017 01:37:32 vijay krishnavanshi wrote:
> Hi Pali,
>
> I am still unable to access the repo. Can you please se
Hi Pali,
I am still unable to access the repo. Can you please see if the link that
you gave is correct?
I don't think syncing should take this long, I may be wrong also.
Regards,
Vijay Krishnavanshi
New branch master-kf5 is in my cloned repository, available at:
> https://cgit.kde.org/clones/ko
On Monday 07 August 2017 09:34:37 Pali Rohár wrote:
> On Monday 07 August 2017 07:52:39 vijay krishnavanshi wrote:
> > Hi,
> >
> > I am fixing the raised issues in old review requests so how do I submit the
> > changes for review. Should I create a new review request addressing all the
> > issues
On Monday 07 August 2017 10:26:46 Luigi Toscano wrote:
> Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha
> scritto:
>
> >
> >Anyway, I rebased kf5 branch on top of master with (semi-manual)
> >conflicts resolution and found out that changes between kf5 branch and
> >"kf5 rebased on top of maste
Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár" ha scritto:
>
>Anyway, I rebased kf5 branch on top of master with (semi-manual)
>conflicts resolution and found out that changes between kf5 branch and
>"kf5 rebased on top of master" differs. And I suspect that some merge
>commits which was done from
On Monday 07 August 2017 07:52:39 vijay krishnavanshi wrote:
> Hi,
>
> I am fixing the raised issues in old review requests so how do I submit the
> changes for review. Should I create a new review request addressing all the
> issues or create a separate review request for each old review request?
Hi,
I am fixing the raised issues in old review requests so how do I submit the
changes for review. Should I create a new review request addressing all the
issues or create a separate review request for each old review request? or
comment on the old review request for the changes?
Regards,
Vijay
Hi,
> > This commit looks okay to me as nothing much is changed in terms of
> > behavior. In this commit an attempt to close all the windows is made
> > when we are able to close all window other wise return from the
> > function. In normal conditions returning in the middle of for loop
> > does
On Sunday 06 August 2017 03:30:35 vijay krishnavanshi wrote:
> Hi,
>
> > > 1) kf5 branch contains some commits which have open issues on
> > > reviewboard, namely:
> > >
> > > https://git.reviewboard.kde.org/r/124305/
> > > https://git.reviewboard.kde.org/r/124181/
> > > https://git.reviewboard.k
Hi,
> > 1) kf5 branch contains some commits which have open issues on
> > reviewboard, namely:
> >
> > https://git.reviewboard.kde.org/r/124305/
> > https://git.reviewboard.kde.org/r/124181/
> > https://git.reviewboard.kde.org/r/124349/
> >
>
I will look into these changes and fix whatever neces
On Saturday 05 August 2017 14:58:20 Pali Rohár wrote:
> Hi!
>
> Now I'm looking at Kopete kf5 git branch and thinking if now it is
> time to switch master branch to kf5 code.
>
> IIRC KDE Applications 17.08 is the last version which can be based on
> KDE4 code base.
>
> Before switching I see th
Hi!
Now I'm looking at Kopete kf5 git branch and thinking if now it is time
to switch master branch to kf5 code.
IIRC KDE Applications 17.08 is the last version which can be based on
KDE4 code base.
Before switching I see there two issues:
1) kf5 branch contains some commits which have open i
18 matches
Mail list logo
