[Koha-patches] [PATCH] bugfix Guided Reports - allow user specified limit in sql

2009-11-04 Thread Michael Hafen
Tweak the regular expression in strip_limit to work. Tweak execute_query to use the user limit if it's lower than the hard coded one. Also total is calculated somewhere else now. This helps most with the csv export of a report so the user can set their own limit instead of having the hard coded li

[Koha-patches] [PATCH] Items modification Performance improvement

2009-11-04 Thread Henri-Damien LAURENT
--- C4/Items.pm| 84 +-- t/db_dependent/Items.t | 33 +++ 2 files changed, 78 insertions(+), 39 deletions(-) create mode 100755 t/db_dependent/Items.t diff --git a/C4/Items.pm b/C4/Items.pm index 61126d9..9a1e81f 100644

[Koha-patches] [PATCH] (Bug 3767 - Return error if checkin passed an invalid item

2009-11-04 Thread Colin Campbell
If an invalid item barcode is passed to checkin the sip2 connection dies. This is because although no item object is created its mehods are called in Checkin To maintain the connection properly catch the condition and return the correct response to the unit (should also fix Bug #3696 ) --- C4/SIP/

Re: [Koha-patches] [PATCH] Bug 3764: Made city/town admin form clear

2009-11-04 Thread Nicole Engard
I matched it to all other places we have City, State - like the patron form where it is listed at City, State all over - the goal was to make things consistent across the board and translators are free to change it from City, State to whatever it is in their country/language. Nicole On Wed, Nov 4

Re: [Koha-patches] [PATCH] Bug 3764: Made city/town admin form clear

2009-11-04 Thread Walls, Ian
I suppose generalizing to a hierarchy of geopolitical units might be more trouble than it's worth, particularly if the address is only used for reading by humans. Perhaps having the label be updatable via syspref? Ian Walls Systems Integration Librarian NYU Health Sciences Libraries 550 Firs

Re: [Koha-patches] [PATCH] Bug 3764: Made city/town admin form clear

2009-11-04 Thread Owen Leonard
> -       City name: > +       City, State: This seems like an American generalization to me. Many countries do not have states. That said, I'm not sure what the best solution is! -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

[Koha-patches] [PATCH] Bug 3764: Made city/town admin form clear

2009-11-04 Thread Nicole Engard
>From d7f575146918ef175429547dcc417121a4f2f48e Mon Sep 17 00:00:00 2001 From: Nicole Engard Date: Tue, 3 Nov 2009 17:01:00 -0500 Subject: [PATCH] Bug 3764: Made city/town admin form clear Content-Type: text/plain; charset="utf-8" --- .../prog/en/modules/admin/cities.tmpl | 12

[Koha-patches] [PATCH] (bug #3762) fix warnings in GetCoinsBiblio

2009-11-04 Thread Nahuel ANGELINETTI
set defaults values to delete warnings. --- C4/Biblio.pm | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 8cb7a38..e5471b2 100755 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -1200,8 +1200,8 @@ sub GetCOinSBiblio { $genre =

[Koha-patches] [PATCH] (bug #3761) fix virtualshelf ordering

2009-11-04 Thread Nahuel ANGELINETTI
This patch fix the way to order shelfs, and delete an useless warn --- C4/VirtualShelves/Page.pm |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm index b32424e..241b79a 100644 --- a/C4/VirtualShelves/Page.pm +++ b/C4/Vir

Re: [Koha-patches] [PATCH] (bug #3760) fix and improve some reports

2009-11-04 Thread Nahuel ANGELINETTI
Done in followup Le Wed, 4 Nov 2009 08:40:16 -0700, Mike Hafen a écrit : > Looks good. I see a couple of warn's though. > > On Wed, Nov 4, 2009 at 8:02 AM, Nahuel ANGELINETTI < > nahuel.angeline...@biblibre.com> wrote: > > > This patch fix some problems with dates, and itemtypes level. > > An

[Koha-patches] [PATCH] [followup](bug #3760) delete some warn

2009-11-04 Thread Nahuel ANGELINETTI
--- reports/borrowers_out.pl |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl index 3f91635..e16166f 100755 --- a/reports/borrowers_out.pl +++ b/reports/borrowers_out.pl @@ -198,7 +198,6 @@ sub calculate {

Re: [Koha-patches] [PATCH] (bug #3760) fix and improve some reports

2009-11-04 Thread Mike Hafen
Looks good. I see a couple of warn's though. On Wed, Nov 4, 2009 at 8:02 AM, Nahuel ANGELINETTI < nahuel.angeline...@biblibre.com> wrote: > This patch fix some problems with dates, and itemtypes level. > And it improve some sql queries. > --- > reports/borrowers_out.pl | 26 +++--

[Koha-patches] [PATCH] (bug #3760) fix and improve some reports

2009-11-04 Thread Nahuel ANGELINETTI
This patch fix some problems with dates, and itemtypes level. And it improve some sql queries. --- reports/borrowers_out.pl | 26 +++--- reports/cat_issues_top.pl | 38 +- 2 files changed, 24 insertions(+), 40 deletions(-) diff --git a/

[Koha-patches] [PATCH] ISBD view enhancement: accept {...@kohafield} in the isbd system preference.

2009-11-04 Thread Sébastien Hinderer
Dear all, Not sure whether this feature will be useful to others. Not sure its implementation is satisfactory either. So, comments are very welcome. Sébastien. >From a3041b72f7d2827c4c9ffd1f7ca6b184a0346979 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Hinderer?= Date: Wed, 4 Nov 2009

[Koha-patches] [PATCH] C4/Biblio.pm: bugfix in GetISBDView

2009-11-04 Thread Sébastien Hinderer
Dear all, To be a bit more precise than the commit message: In s/A/B/gx Only A may contain comments, comments are not allowed in B. Sébastien. >From 913cbfa5f57d4a173ccc987162f1622ebab13bc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Hinderer?= Date: Wed, 4 Nov 2009 08:57:25 +0100