[Koha-patches] [PATCH] Adding Liz Rea to the history.txt

2009-04-29 Thread Chris Cormack
--- docs/history.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index a6a189c..420fd91 100644 --- a/docs/history.txt +++ b/docs/history.txt @@ -416,3 +416,4 @@ April 19 2009 Cory Jaeger becomes the 83rd committer developer

[Koha-patches] [PATCH] Adding warnings, fixing a bug that meant the title of an item that had

2009-04-29 Thread Chris Cormack
--- C4/Members.pm |1 + .../opac-tmpl/prog/en/modules/opac-account.tmpl|2 +- opac/opac-account.pl |6 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index c0af30

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Joe Atzberger
Jane -- > When I added the TMPL_VAR statements into the various .tmpl files, I > definitely added a closing TMPL_IF statement for each one. I'm positive of > that because I was doing them in pairs. > If you did, it wasn't part of the same commit from which this patch was generated. You can see

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Wagner, Jane
A couple of questions, now that I look at your message more closely. I copied the syntax from opac-detail.pl and .tmpl, because that was the only screen where it worked. I didn't think to check Auth.pm -- does that mean the existing param code block is superfluous to the opac-detail.pl script?

Re: [Koha-patches] [PATCH] Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international

2009-04-29 Thread Galen Charlton
[This time with correct email address --gmc] On Wed, Apr 29, 2009 at 6:03 PM, Galen Charlton wrote: > Hi Liz, > > I've pushed this patch and your second patch, so welcome to the ranks > of Koha committers. > > Regards, > > Galen > > On Wed, Apr 29, 2009 at 12:22 PM, Liz Rea wrote: >> From: Liz R

Re: [Koha-patches] [PATCH] Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international

2009-04-29 Thread Galen Charlton
Hi Liz, I've pushed this patch and your second patch, so welcome to the ranks of Koha committers. Regards, Galen On Wed, Apr 29, 2009 at 12:22 PM, Liz Rea wrote: > From: Liz Rea > > --- >  .../prog/en/modules/members/mancredit.tmpl         |    2 +- >  .../prog/en/modules/members/maninvoice.t

[Koha-patches] [PATCH] Tweak ceilingDueDate and CalcDateDue

2009-04-29 Thread Michael Hafen
This patch moves ceilingDueDate and ReturnBeforeExpiry checking into CalcDateDue(), so the renewal due date is also calculated with those. Also restores a check in CanBookBeIssued. If the due date isn't given call CalcDateDue and make sure it's not in the past. --- C4/Circulation.pm | 56 +

[Koha-patches] [PATCH] new author test for syntax errors in HTML templates

2009-04-29 Thread Galen Charlton
Added a new author test to look for syntax errors in the HTML templates. Run by doing prove xt/author/valid-templates.t from the root of a Koha source tree. This test will help catch the following errors: * unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g., cases where a TMPL_IF

[Koha-patches] [PATCH] Whoops I typo'd Garry's name - fixed

2009-04-29 Thread Chris Cormack
--- docs/history.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index 3e6984c..a6a189c 100644 --- a/docs/history.txt +++ b/docs/history.txt @@ -415,4 +415,4 @@ April 18 2009 Jane Wagner becomes the 82nd committer developer

[Koha-patches] [PATCH] Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international mone

2009-04-29 Thread Liz Rea
From: Liz Rea --- .../prog/en/modules/members/mancredit.tmpl |2 +- .../prog/en/modules/members/maninvoice.tmpl|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tmpl b/koha-tmpl/intranet-tmpl/p

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Wagner, Jane
Well, darn. I hate it when it works fine on my system I'll have another go at it when I get a chance. Thanks. Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwag...@ptfs.com --

[Koha-patches] [PATCH] Updating history docs for new developer

2009-04-29 Thread Chris Cormack
--- docs/history.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index af72b50..3e6984c 100644 --- a/docs/history.txt +++ b/docs/history.txt @@ -414,4 +414,5 @@ April 18 2009 Brendan A. Gallagher narrowly beats Jane to becom

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Galen Charlton
Hi Jane, This needs work - please see below: On Wed, Apr 29, 2009 at 3:30 PM, Jane Wagner wrote: > diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl > b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl > index a102457..5897f86 100644 > --- a/koha-tmpl/opac-tmpl/prog/en/modul

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Michael Hafen
Looking at this I'm not seeing how you get from the scrip to the template. I know opacuserlogin is already pushed out to the template, but I don't see RequestOnOpac getting pushed here. Thanks. On Wed, 2009-04-29 at 15:30 -0400, Jane Wagner wrote: > If the syspref RequestOnOpac is turned off, th

Re: [Koha-patches] [PATCH] [Liblime Bug 3158] [Head] Tweak ceilingDueDate and CalcDateDue

2009-04-29 Thread Galen Charlton
Hi Michael, The patch generally looks OK. I have a couple comments, one of which I think requires that the patch be changed and resubmitted: On Tue, Apr 28, 2009 at 12:18 PM, Michael Hafen wrote: > +        my $branch = (C4::Context->preference('CircControl') eq > 'PickupLibrary') ? C4::Conte

[Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-29 Thread Jane Wagner
If the syspref RequestOnOpac is turned off, the link to place a hold does not show in the detail page. However, the link is still present in the results list as well as in the basket and in lists. Modified scripts and templates to check for the syspref and to obey it. --- .../opac-tmpl/prog/en/m

Re: [Koha-patches] [PATCH] Enhancements/fixes for OPAC advanced search screen

2009-04-29 Thread Wagner, Jane
I've fixed the problem -- I'll send a replacement patch. Thanks. Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwag...@ptfs.com -Original Message- From: Galen Charlton [mailt

[Koha-patches] [PATCH] Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.

2009-04-29 Thread Liz Rea
From: root --- koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc index debbd70..4e8203d 100644 --- a/koha-tmpl/opac-tmp

[Koha-patches] [PATCH] Enhancements/fixes for OPAC advanced search screen

2009-04-29 Thread Jane Wagner
Fixed opac-search.pl for correct test of expanded options and to pass variable for MARC21 to advanced search screen. Added Publication Date Range search to advanced search screen Removed obsolete item type code section from advanced search screen (wasn't displaying anyway because expanded options

[Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-29 Thread Brian Harrington
It turns out that the "blank" record created by MARC::Record->new() has a leader, so now I explicitly create one in addbiblio.pl. I also realized I can't count. :-) Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag and move it and the leader set to earlier in the process. --- cat

[Koha-patches] [PATCH] Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international mone

2009-04-29 Thread Liz Rea
From: Liz Rea --- .../prog/en/modules/members/mancredit.tmpl |2 +- .../prog/en/modules/members/maninvoice.tmpl|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tmpl b/koha-tmpl/intranet-tmpl/p

Re: [Koha-patches] [PATCH] (bug #3172) support stemming for all languages using lingua::stem::snowball

2009-04-29 Thread LAURENT Henri-Damien
Joe Atzberger a écrit : > > + require Lingua::Stem::Snowball; > ... > + 'Lingua::Stem::Snowball' => 0.952, # optional > > > It doesn't look optional if Search.pm requires it. > --Joe As it is now, without if $C4::Context->preference("QueryStemming"){ require Lingua::Stem::Sno

Re: [Koha-patches] [PATCH] (bug #3172) support stemming for all languages using lingua::stem::snowball

2009-04-29 Thread Joe Atzberger
> + require Lingua::Stem::Snowball; > ... > + 'Lingua::Stem::Snowball' => 0.952, # optional > It doesn't look optional if Search.pm requires it. --Joe ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/list

[Koha-patches] [PATCH] Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international mone

2009-04-29 Thread root
--- .../prog/en/modules/members/mancredit.tmpl |2 +- .../prog/en/modules/members/maninvoice.tmpl|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/m

[Koha-patches] [PATCH] (bug #3172) support stemming for all languages using lingua::stem::snowball

2009-04-29 Thread Nahuel ANGELINETTI
This patch add a function to get the user language, and add the support of lingua::stem::snowball instead of lingua::stem, which support a lot of languages and is better. The stemming is now dynamic based on the user language. --- C4/Output.pm| 18 -- C4/Search.pm

Re: [Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-29 Thread Galen Charlton
Hi, On Tue, Apr 28, 2009 at 11:36 AM, Brian Harrington wrote: > 1.  I had SetMarcUnicodeFlag() as MARC21-only because that's how it is > in the original version.  The comments indicate that it isn't necessary > in UNIMARC.  Should I move it anyway? On second thought, no, because as you point out

Re: [Koha-patches] [PATCH] Bug 3166 Penny round off error when summing fines for patrons

2009-04-29 Thread Galen Charlton
Hi Darrell, To avoid having the committer show up as 'root ', please set user.name using git-config and redo and resubmit the patch. Thanks, Galen On Tue, Apr 28, 2009 at 10:19 AM, wrote: > From: root > > Thanks! D.Ulm > --- >  C4/Members.pm |    4 ++-- >  1 files changed, 2 insertions(+), 2

Re: [Koha-patches] [PATCH] (bug #3170) check if mandatory fields are not empty

2009-04-29 Thread Galen Charlton
Hi, On Tue, Apr 28, 2009 at 11:06 AM, Nahuel ANGELINETTI wrote: > This patch make authority and biblio add/edit to check that at least one > subfield of mandatory fields are filled-in. This patch does not apply against HEAD. Please rebase and resubmit. Regards, Galen -- Galen Charlton VP, R

Re: [Koha-patches] [PATCH] minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.

2009-04-29 Thread Galen Charlton
Hi Garry, I have pushed this patch. As this appears to be the first patch of yours accepted into the public repository, let me welcome to the ranks of Koha committers. Send more patches! By the way, if you find and fix a bug that hasn't been reported yet, it's fine (and recommended) for you to

Re: [Koha-patches] [PATCH] Enhancements/fixes for OPAC advanced search screen

2009-04-29 Thread Galen Charlton
Hi, When I tested this, I found a problem with the display of the expanded options. Specifically, they are now always displayed, and clicking on more/fewer options link has no effect. Instead, when I try that, I'm observing the following error in the Apache log: [Wed Apr 29 07:39:10 2009] [erro