[Koha-patches] [PATCH] Bug 2505 Adding use warnings, and fixing the warnings generated

2009-04-24 Thread Chris Cormack
--- opac/opac-main.pl |1 + opac/opac-search.pl | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/opac/opac-main.pl b/opac/opac-main.pl index 1062109..5a56db0 100755 --- a/opac/opac-main.pl +++ b/opac/opac-main.pl @@ -17,6 +17,7 @@ use strict; +u

Re: [Koha-patches] [PATCH] fix for 2896

2009-04-24 Thread Galen Charlton
Hi, This patch doesn't apply against HEAD. Regards, Galen On Sat, Apr 18, 2009 at 7:45 PM, wrote: > From: Paul Poulain > > fixed by setting the description to: > > "Choose the fines mode, 'off', 'test' (emails admin report) or 'production' > (accrue overdue fines).  Requires fines.pl cronjo

[Koha-patches] [PATCH] fix XHTML error - duplicate tabindex

2009-04-24 Thread Galen Charlton
--- .../prog/en/modules/cataloguing/addbiblio.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl index 67e5947..fcecfed 100644 --

[Koha-patches] [PATCH] fix default authority search in bib editor

2009-04-24 Thread Galen Charlton
When clicking on the '...' of an headings field in the bib editor, the authority search that popped up did not take the default search string from the bib field. Fixed by making sure that openAuth is always used to do the popup link. --- cataloguing/addbiblio.pl |2 +- 1 files changed, 1 inse

[Koha-patches] [PATCH] BUG-3160: fixes 'itemlost' check on item return.

2009-04-24 Thread Mason James
--- C4/Circulation.pm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 2d852bd..b4e589d 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1310,6 +1310,7 @@ sub AddReturn { my $curr_iteminfo = GetItem($iteminf

[Koha-patches] [PATCH] bug 3159: allow editing child patron that has no valid guarantor

2009-04-24 Thread Galen Charlton
If a patron with a child patron category is not linked to a guarantor (or a valid one), it was not possible to edit the child patron's record. When attempt, no changes were saved and the following error is recorded in the Apache error log: memberentry.pl: DBD::mysql::st execute failed: Cannot add

[Koha-patches] [PATCH] Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.

2009-04-24 Thread Joe Atzberger
--- .../prog/en/modules/cataloguing/addbiblio.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl index 67e5947..7bf5601 100644 --

[Koha-patches] [PATCH] New developer for history.txt

2009-04-24 Thread Chris Cormack
--- docs/history.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index 3e042a2..5477e40 100644 --- a/docs/history.txt +++ b/docs/history.txt @@ -412,4 +412,5 @@ April 16-17 2009 Kohacon 2009 in Plano, Texas, USA April 18-20 20

[Koha-patches] [PATCH] Bug 3127 - Stub function prevents undefined reference

2009-04-24 Thread Joe Atzberger
--- .../en/modules/authorities/authorities-home.tmpl |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tmpl index 425e373..c

Re: [Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-24 Thread Joe Atzberger
I think SetMarcUnicodeFlag should stay, in part because BiblioAddAuthorities() should move to a C4 .pm and be used by other scripts. In fact, SetMarcUnicodeFlag should be called earlier in the sub, before any add_subfields() or field assignments, to avoid munging unicode data. -- Joe Atzberger L

Re: [Koha-patches] [PATCH] Modified log reporting to allow multiple modules to be selected.

2009-04-24 Thread Galen Charlton
Hi David, On Fri, Apr 24, 2009 at 2:21 PM, David Goldfein wrote: > Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up > the template, change mime type to text/csv and other minor changes. I have pushed this patch. Since this is your first commit accepted into the main tre

[Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-24 Thread Brian Harrington
It turns out that the "blank" record created by MARC::Record->new() has a leader, so now I explicitly create one in addbiblio.pl. I also realized I can't count. :-) --- C4/AuthoritiesMarc.pm|2 +- cataloguing/addbiblio.pl |9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-)

[Koha-patches] [PATCH] Modified log reporting to allow multiple modules to be selected.

2009-04-24 Thread David Goldfein
Reworked ViewLog.pl and the template. Eliminated html errors, cleaned up the template, change mime type to text/csv and other minor changes. --- C4/Log.pm | 40 ++- .../prog/en/modules/tools/viewlog.tmpl | 423 ++-- tools/vie

[Koha-patches] [PATCH] DB rev 025: ceilingDueDate syspref

2009-04-24 Thread Galen Charlton
--- installer/data/mysql/updatedatabase.pl |2 +- kohaversion.pl |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 4e20927..16167f9 100755 --- a/installer/data

[Koha-patches] [PATCH] New feature Number of Returned Items to Show

2009-04-24 Thread Michael Hafen
This adds a system preference controlled feature. This controls how many returned items are shown on the check-in page. --- admin/systempreferences.pl |1 + circ/returns.pl|3 ++- installer/data/mysql/en/mandatory/sysprefs.sql

[Koha-patches] [PATCH] New feature - database update - Number of Returned Items to Show

2009-04-24 Thread Michael Hafen
This is the database update to add the system preference for numReturnedItemsToShow --- installer/data/mysql/updatedatabase.pl |8 kohaversion.pl |2 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b

Re: [Koha-patches] [PATCH] New feature Number of Returned Items to Show

2009-04-24 Thread Galen Charlton
Hi, On Fri, Apr 24, 2009 at 1:43 PM, Michael Hafen wrote: > Hmm, you're right.  I didn't look into that loop far enough.  Though > this begs the question: why is there a limit on the number of items you > can check in?  That hard coded limit of 20 suddenly seems out of place > to me.  Unless it's

Re: [Koha-patches] [PATCH] New feature Number of Returned Items to Show

2009-04-24 Thread Michael Hafen
Hmm, you're right. I didn't look into that loop far enough. Though this begs the question: why is there a limit on the number of items you can check in? That hard coded limit of 20 suddenly seems out of place to me. Unless it's to protect against D.O.S. attacks on this script. But that loop is

[Koha-patches] [PATCH] Make js prompts translatable using _("...") and comment out unused vars.

2009-04-24 Thread Joe Atzberger
--- .../prog/en/includes/circ-toolbar.inc | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc index fab39e8..359e697 100644 --- a/k

Re: [Koha-patches] [PATCH] New feature Number of Returned Items to Show

2009-04-24 Thread Galen Charlton
Hi, On Wed, Feb 25, 2009 at 6:48 PM, Michael Hafen wrote: > This adds a system preference controlled feature.  This controls how > many returned items are shown on the check-in page. This patch doesn't seem to be doing that - instead, it seems to be establishing a limit on the number of items yo

Re: [Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

2009-04-24 Thread Galen Charlton
Hi, 2009/4/24 Frédéric DEMIANS : > Looking at C4::External:Amazon.pm, get_amazon_details call Amazon for those > services: > >   * Similarities >   * EditorialReview >   * Reviews >   * ItemAttributes >   * Images > > ItemAttributes and Images should be removed. Image is already retrieved > client

Re: [Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

2009-04-24 Thread Frédéric DEMIANS
>> In OPAC opac-detail.pl page (same in intranet) AmazonSimilarItems is >> not used to control if Amazon web service is called or not. >> It means that even if AmazonSimilarItems is disabled, requests are >> sent to Amazon to retrieve reader reviews and similar items. It's >> a waste of resources.

[Koha-patches] [PATCH] bug 2505 followup: restored correct item type image display

2009-04-24 Thread Galen Charlton
--- opac/opac-detail.pl |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 3df0989..ae6bc41 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -146,6 +146,10 @@ for my $itm (@items) { if ( defined $itm->{'loca

Re: [Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

2009-04-24 Thread Galen Charlton
Hi Frederic, On Wed, Jan 21, 2009 at 4:06 AM, Frederic Demians wrote: > In OPAC opac-detail.pl page (same in intranet) AmazonSimilarItems is > not used to control if Amazon web service is called or not. > It means that even if AmazonSimilarItems is disabled, requests are > sent to Amazon to retri

[Koha-patches] [PATCH] bug 2765: updatedatabase to increase width of ISBN columns

2009-04-24 Thread Galen Charlton
--- installer/data/mysql/updatedatabase.pl | 10 ++ kohaversion.pl |2 +- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index e3a5606..4bd0075 100755 --- a/insta

[Koha-patches] [PATCH] DB rev 022: set DBrev for bug 2945 fix

2009-04-24 Thread Galen Charlton
--- installer/data/mysql/updatedatabase.pl |2 +- kohaversion.pl |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 9193ad6..e3a5606 100755 --- a/installer/data

[Koha-patches] [PATCH] fixed typos in LTFL sysprefs

2009-04-24 Thread Galen Charlton
--- admin/systempreferences.pl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl index 63937a9..790138a 100755 --- a/admin/systempreferences.pl +++ b/admin/systempreferences.pl @@ -236,8 +236,8 @@ $tabsysprefs{BakerT

[Koha-patches] [PATCH] Bug 3152 OPAC reading history column headers don't line up with text

2009-04-24 Thread Jane Wagner
Fixed template files to make column headers and text line up; moved the for cover art outside the various content provider IF statements. --- .../prog/en/modules/opac-readingrecord.tmpl| 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/opac-tmpl/

Re: [Koha-patches] [PATCH] Bug 3152 OPAC reading history column headers don't line up with text

2009-04-24 Thread Wagner, Jane
I tried that once & didn't have any luck, but tried it again this morning and it worked. Without cover art, there is now a barely noticeable empty first column and the headers line up with the appropriate data. With cover art, it shows properly and the headers still line up OK. Looks like about

[Koha-patches] [PATCH] bug 3155 followup: tweak OPACAmazonReviews syspref

2009-04-24 Thread Galen Charlton
* add to enhanced content tab of syspref editor * during upgrade, if database has OPACAmazonEnabled turned on, ensure that OPACAmazonReviews is on as well. --- admin/systempreferences.pl |1 + installer/data/mysql/updatedatabase.pl |3 ++- 2 files changed, 3 insertions(+),

Re: [Koha-patches] [PATCH] bug 3093: Enhance placing of holds in the staff interface.

2009-04-24 Thread Frederic Demians
> Fixed display of item type. > > Removed side menu for multiple items; removed item-oriented button for > multiple items It works. -- Frédéric ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patch