[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5446 Fix a bug introduces by previous patch

2010-12-17 Thread Marcel de Rooy
From: Frédéric Demians When AcqCreateItem was set to 'cataloguing' there was no items fields in the acq web form to validate in JS... Alert commented. Signed-off-by: Marcel de Rooy --- .../prog/en/modules/acqui/neworderempty.tmpl | 21 +++ 1 files c

[Koha-patches] Patch for Bug 5193

2010-12-20 Thread Marcel de Rooy
Hi, I was interested in your patch, but applying it fails on current master. Regards, Marcel HEAD is now at 3c19f22 Merge remote branch 'kc/new/enh/bug_5283' into kcmaster Applying: Bug 5193 Enhancement to allow use of specialized auction indexes error: patch failed: etc/zebradb/biblios/etc/bib1

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload

2010-12-20 Thread Marcel de Rooy
seems redundant. Signed-off-by: Marcel de Rooy --- .../prog/en/modules/acqui/neworderempty.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui

[Koha-patches] [PATCH] [SIGNED-OFF] bug 5035 remove default opaccolorstylesheet value for new installs

2010-12-20 Thread Marcel de Rooy
might break things. This patch does not remove the blank color.css file, it only edits the default system preference. Signed-off-by: Marcel de Rooy --- installer/data/mysql/en/mandatory/sysprefs.sql |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/installer/data/mysql/en

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5026 Undefined dates formatted poorly in serials-edit

2011-01-17 Thread Marcel de Rooy
From: Colin Campbell Don't display junk in empty fields Don't generate errors Merged some changes to make variable names moremeaningful in loops ( within loops) Thanks to M De Rooy for spotting a couple of issues in the original patch Signed-off-by: Marcel de Rooy --- C4/

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5399: remove useless eval 'use C4::Foo'

2011-01-17 Thread Marcel de Rooy
From: Galen Charlton Also add a couple FIXMEs Marcel: Signed and updated for current master Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy --- acqui/addorderiso2709.pl |6 +- acqui/basketgroup.pl |7 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff

[Koha-patches] [PATCH] [SIGNED-OFF] [RESENT] Bug 5399: remove useless eval 'use C4::Foo'

2011-01-17 Thread Marcel de Rooy
From: Galen Charlton Also add a couple FIXMEs Marcel: Signed and updated for current master Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy --- acqui/addorderiso2709.pl |6 +- acqui/basketgroup.pl |7 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff

[Koha-patches] [PATCH] Bug 5622 (Show 773 host in staff normal view)

2011-01-17 Thread Marcel de Rooy
Applies to XSLT generated results in staff normal view. Remove limitation to show host item entry only for leader19==c. Use generic LOC label In: instead of Set: Show title from 773t. --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 10 +- 1 files changed, 5 insertions(+), 5 dele

[Koha-patches] [PATCH] Bug 5642: Item field serial enumeration (enumchron) should be longer

2011-01-20 Thread Marcel de Rooy
Field enumchron in items table is now varchar(80). We have records that need a much longer field, even up to 400 or 500 chars. I suggest to change its type to TEXT (variable length with max 64K; tinytext goes up to 255 chars and is just too short). Mediumtext or longtext are not needed; as a side n

[Koha-patches] [PATCH] Bug 5643: Tidy up MARC21slim2OPACResults.xsl, add code for Call Number.

2011-01-20 Thread Marcel de Rooy
--- .../prog/en/xslt/MARC21slim2OPACResults.xsl| 306 +++- 1 files changed, 174 insertions(+), 132 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl index b3f61e5..3116778 1

Re: [Koha-patches] [PATCH] Bug 5642: Item field serial enumeration (enumchron) should be longer

2011-01-20 Thread Marcel de Rooy
Will correct that. Thanks. Van: Ian Walls [mailto:ian.wa...@bywatersolutions.com] Verzonden: donderdag 20 januari 2011 14:12 Aan: Marcel de Rooy CC: koha-patches@lists.koha-community.org Onderwerp: Re: [Koha-patches] [PATCH] Bug 5642: Item field serial enumeration (enumchron) should be longer

[Koha-patches] [PATCH] [REVISED] Bug 5642: Item field serial enumeration (enumchron) should be longer

2011-01-20 Thread Marcel de Rooy
Field enumchron in items table is now varchar(80). We have records that need a much longer field, even up to 400 or 500 chars. I suggest to change its type to TEXT (variable length with max 64K; tinytext goes up to 255 chars and is just too short). Mediumtext or longtext are not needed; as a side n

[Koha-patches] [PATCH] Bug 5660: Webinstaller should check if KohaOpacLanguage exists on staff side

2011-01-26 Thread Marcel de Rooy
--- installer/InstallAuth.pm | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm index 3a55b21..9353200 100644 --- a/installer/InstallAuth.pm +++ b/installer/InstallAuth.pm @@ -109,10 +109,8 @@ InstallAuth

[Koha-patches] [PATCH] [REVISED] Bug 5622: Always show host entry (773) in staff; control number without organization code

2011-01-27 Thread Marcel de Rooy
Applies to XSLT generated results in staff normal view. Remove limitation to show host item entry only for leader19==c. Use generic LOC label In: instead of Set: Show title from 773t. Revision: Add logic for control number containing MARC Org Code. --- .../prog/en/xslt/MARC21slim2intranetDetail.x

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 3009 - Change items.content field so it prints due date by default

2011-01-31 Thread Marcel de Rooy
From: Katrin Fischer in overdue notices prints issuedate instead of duedate by default. This patch changes default to issues.date_due. Signed-off-by: Marcel de Rooy --- misc/cronjobs/overdue_notices.pl |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/misc

[Koha-patches] [PATCH] [REVISED] 5622: Improve display of MARC21 773 field in XSLT detail view

2011-02-02 Thread Marcel de Rooy
Applies change to OPAC and staff detail view. Chops punctuation. Adds 773g. Strips MARC org code from URL. Utils code is used as basis for patches #5662 and #5663 too. --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 10 +- .../intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 1

[Koha-patches] [PATCH] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

2011-02-03 Thread Marcel de Rooy
This patch contains the functionality, not the install stuff. --- catalogue/search.pl|3 +++ .../en/modules/admin/preferences/staff-client.pref |6 ++ .../prog/en/modules/catalogue/results.tmpl |4 ++-- 3 files changed, 11 insertions(+), 2 de

[Koha-patches] [PATCH] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

2011-02-03 Thread Marcel de Rooy
This patch contains only the install stuff. (Functionality in previous patch.) --- installer/data/mysql/en/mandatory/sysprefs.sql |1 + installer/data/mysql/updatedatabase.pl |7 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/installer/data/mysql/en/mandator

[Koha-patches] [PATCH] Bug 5701: Distinction between authors/additional authors in staff normal view (MARC21/XSLT)

2011-02-07 Thread Marcel de Rooy
At this time all entries in 100/110/111 and 700/710/711 are shown together. We want to see the difference between an author and an added entry. (The 700 author could for instance be an illustrator.) To this end we like to see the eventual relator code or term in $4 or $e too (displayed between brac

[Koha-patches] [PATCH] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

2011-02-07 Thread Marcel de Rooy
This patch contains the functionality, not the install stuff. Revised: recent commit renamed the staff client pref file. --- catalogue/search.pl|3 +++ .../en/modules/admin/preferences/staff_client.pref |6 ++ .../prog/en/modules/catalogue/results.tmpl

[Koha-patches] [PATCH] [SIGNED-OFF] Follow-up fix for Bug 5462, Fix variable names so we dont break template::toolkit

2011-02-09 Thread Marcel de Rooy
From: Owen Leonard A change was made to MARCdetail.tmpl without making a corresponding change to MARCdetail.pl. I've reworked the original change so that both can work together. 0XX --> tab0XX Apparently TMPL variables can't start with a number now? Signed-off-by: M

[Koha-patches] [PATCH] Bug 5735: Expanding/collapsing cloned fields in editor takes original field

2011-02-10 Thread Marcel de Rooy
Adds corrected onclick response for expanding marc tags. Removes some lines that did not work as promised. --- .../prog/en/modules/cataloguing/addbiblio.tmpl | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/a

[Koha-patches] [PATCH] Bug 5736: Fixing some zebra configuration errors in marc21/biblios/record.abs

2011-02-10 Thread Marcel de Rooy
Lines like melm 999 should ALWAYS follow the lines for subfields 999a, 999b etc. This is currently not the case for 410 411 490 611 710 785 and 800. Found this since I could not find back the contents of 710$9 fields. --- etc/zebradb/marc_defs/marc21/biblios/record.abs | 21 +

[Koha-patches] [PATCH] [SIGNED-OFF] Follow-up fix for Bug 5462, Fix variable names so we dont break template::toolkit

2011-02-13 Thread Marcel de Rooy
cover failure to apply. Signed-off-by: Marcel de Rooy --- catalogue/MARCdetail.pl|2 +- .../prog/en/modules/catalogue/MARCdetail.tmpl | 44 ++-- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/catalogue/MARCdetail.p

[Koha-patches] [PATCH] [3.2.X] Bug 5736: Fixing some zebra configuration errors in marc21/biblios/record.abs

2011-02-14 Thread Marcel de Rooy
Patch adapted for 3.2.X only. Signed in master. --- etc/zebradb/marc_defs/marc21/biblios/record.abs | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/etc/zebradb/marc_defs/marc21/biblios/record.abs b/etc/zebradb/marc_defs/marc21/biblios/record.abs index

[Koha-patches] [PATCH] Follow up on bug 2742: Correct language names in install

2011-02-14 Thread Marcel de Rooy
Rename the phonetic name in about, just like an earlier patch did elsewhere. Make the distinction between the two Dutch translations more clear. --- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl

[Koha-patches] [PATCH] Follow up on 5736: fix authorities record.abs

2011-02-14 Thread Marcel de Rooy
Follow up on 5736: Same problem with 100 and 100a in authorities/record.abs --- .../marc_defs/marc21/authorities/record.abs|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/etc/zebradb/marc_defs/marc21/authorities/record.abs b/etc/zebradb/marc_defs/marc21/authoriti

[Koha-patches] [PATCH] Bug 5756: Add MARC21 tag 751 (added geographical entry) to Zebra config

2011-02-14 Thread Marcel de Rooy
--- etc/zebradb/marc_defs/marc21/biblios/record.abs |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/etc/zebradb/marc_defs/marc21/biblios/record.abs b/etc/zebradb/marc_defs/marc21/biblios/record.abs index b066ee0..85eaedd 100755 --- a/etc/zebradb/marc_defs/marc21/biblios

[Koha-patches] [PATCH] [SIGNED-OFF] 3341: Fines calculation erroneous when a repeatable holiday is added

2011-02-17 Thread Marcel de Rooy
From: Frédérick Capovilla Signed-off-by: Marcel de Rooy --- C4/Overdues.pm |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Overdues.pm b/C4/Overdues.pm index adba979..b5e3cdf 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -488,12 +488,12 @@ sub UpdateFine

[Koha-patches] [PATCH] 3072: Search for Heading-Main in authorities

2011-02-18 Thread Marcel de Rooy
Includes Heading-Main in authorities bib1 attribute set. Also includes Any in authorities bib1 (was still missing). Also removes temporary fix in AuthoritiesMarc.pm. --- C4/AuthoritiesMarc.pm|7 +-- etc/zebradb/authorities/etc/bib1.att |2 ++ 2 files changed, 3 insertio

[Koha-patches] [PATCH] 2742: Wrong language name in the preferences

2011-02-21 Thread Marcel de Rooy
Follow up patch. Improvement suggested by Belgian translators (Hans Supply). --- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modu

[Koha-patches] [PATCH] [SIGNED-OFF] 2742 Encoding problem

2011-02-23 Thread Marcel de Rooy
Small correction of e umlaut. [Something happened with encoding of signed patch; my original patch did not show a wrong character.] Signed-off-by: Frédéric Demians --- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ko

[Koha-patches] [PATCH] [SIGNED-OFF] 2742 Encoding problem

2011-02-23 Thread Marcel de Rooy
Previous patch now suffered from similar problem. --- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl index 11f5d28.

[Koha-patches] [PATCH] 3154 Preference for building facets

2011-02-24 Thread Marcel de Rooy
Patch from Fridolyn Somers with input of Frederic Demians. I only added new Searching preference maxRecordsForFacets. This pref contains number of result records used in facet building. Pref not needed in update script; default 20 is used if it should not yet exist. --- C4/Search.pm

Re: [Koha-patches] [PATCH] 3154 Preference for building facets

2011-02-24 Thread Marcel de Rooy
. Lazy programmer ;) Marcel -Oorspronkelijk bericht- Van: Fischer, Katrin [mailto:katrin.fisc...@bsz-bw.de] Verzonden: donderdag 24 februari 2011 11:45 Aan: Marcel de Rooy Onderwerp: RE: [Koha-patches] [PATCH] 3154 Preference for building facets Hi Marcel, I was looking at your patch and I

[Koha-patches] [PATCH] Follow up fix on security patch

2011-02-28 Thread Marcel de Rooy
Fixing: Undefined subroutine prepare called on line 722. --- C4/AuthoritiesMarc.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm index 9315e55..bd5fe64 100644 --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -719,7

[Koha-patches] [PATCH] 3154 Preferences for building facets

2011-02-28 Thread Marcel de Rooy
Based on patch from Fridolyn Somers with input of Frederic Demians. Added new Searching preference maxRecordsForFacets. This pref contains number of result records used in facet building. Also added pref displayFacetCount (with thanks to Frederic). Follow up patch takes care of install issues; fun

[Koha-patches] [PATCH] 3154 Preferences for building facets (install)

2011-02-28 Thread Marcel de Rooy
Adds prefs for facets in sql install files and updatedatabase script. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |2 ++ installer/data/mysql/en/mandatory/sysprefs.sql |2 ++ .../1-Obligatoire/unimarc_standard_systemprefs.sql |4 +++- installer/data/mysql/it-IT/necessari

[Koha-patches] [PATCH] [SIGNED-OFF] Follow-up fix for Bug 5804, acqui duplicate warning

2011-02-28 Thread Marcel de Rooy
From: Owen Leonard Typo fix. Thanks for spotting it Marcel. Signed-off-by: Marcel de Rooy --- .../en/modules/acqui/neworderempty_duplicate.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui

[Koha-patches] [PATCH] [REVISED] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

2011-03-10 Thread Marcel de Rooy
This patch contains the functionality, not the install stuff. Revised: with input of Ian Walls: populate authorised_value_images only if needed; no changes anymore for template and search.pl. --- C4/Search.pm |2 +- .../en/modules/admin/preferences/staff

[Koha-patches] [PATCH] [REVISED] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install)

2011-03-10 Thread Marcel de Rooy
This patch contains only the install stuff. (Functionality in previous patch.) --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |2 +- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |2 +- installer/data/mysql/it-IT/nec

[Koha-patches] [PATCH] Same position for the tabs of Normal, MARC and ISBD view in opac detail

2011-03-10 Thread Marcel de Rooy
Adjusts three opac detail templates. Moves few styles to css. Removes duplicate view info from XSLT file. --- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 11 +++ .../opac-tmpl/prog/en/modules/opac-ISBDdetail.tmpl |2 +- .../opac-tmpl/prog/en/modules/opac-MARCdetail.tmpl |

[Koha-patches] [PATCH] Bug 5863: Add to Your Cart disappeared if login disabled on opac detail

2011-03-14 Thread Marcel de Rooy
Resolving an error in ready function by additional conditionals. Moving a line from ready to html just as in other view templates, correcting the order of menu options at the same time. --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |9 + 1 files changed, 5 insertions(+), 4 de

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5848: Remove duplicated tabs in opac details for Unimarc

2011-03-17 Thread Marcel de Rooy
From: Julian Maurice Signed-off-by: Marcel de Rooy --- .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl| 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt

[Koha-patches] [PATCH] [UPDATED] 3154 Preferences for building facets (functionality)

2011-03-17 Thread Marcel de Rooy
Based on patch from Fridolyn Somers with input of Frederic Demians. Added new Searching preference maxRecordsForFacets. This pref contains number of result records used in facet building. Also added pref displayFacetCount (with thanks to Frederic). Follow up patch takes care of install issues; fun

[Koha-patches] [PATCH] [UPDATED] 3154 Preferences for building facets (install)

2011-03-17 Thread Marcel de Rooy
Adds prefs for facets in sql install files and updatedatabase script. Rebased on March 17. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |3 ++- installer/data/mysql/en/mandatory/sysprefs.sql |2 ++ .../1-Obligatoire/unimarc_standard_systemprefs.sql |3 ++- installer/data

[Koha-patches] [PATCH] [UPDATED] Bug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements

2011-03-17 Thread Marcel de Rooy
Currently, the default for this MARC control field is hardcoded in the plugin code of marc21_field_008_authorities.pl (two occurrences). This patch moves it into a new syspref. If this pref should not exist, the old hardcoded value is used. Authorities preference file is updated too. A warning is

[Koha-patches] [PATCH] Bug 4839: Follow-up patch for installing pref

2011-03-17 Thread Marcel de Rooy
Installs syspref MARCAuthorityControlField008. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |2 +- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |2 +- installer/data/mysql/it-IT/necessari/sysprefs.sql |2 +-

[Koha-patches] [PATCH] [UPDATED] 5643: Few new template routines in MARC21slim2OPACResults.xsl

2011-03-17 Thread Marcel de Rooy
This patch only rearranges code and adds a new routine. Koha behavior does NOT change. New template routine ShowCallNumber added. Can be used in customization. New templates routines ShowELocation and ShowAvailable only contain moved code. Rebased on March 17. --- .../prog/en/xslt/MARC21slim2OPAC

[Koha-patches] [PATCH] [UPDATED] 5643: Few new template routines in MARC21slim2OPACResults.xsl

2011-03-17 Thread Marcel de Rooy
This patch only rearranges code and adds a new routine. Koha behavior does NOT change. New template routine ShowCallNumber added. Can be used in customization. New templates routines ShowELocation and ShowAvailable only contain moved code. Rebased on March 17. --- .../prog/en/xslt/MARC21slim2OPAC

[Koha-patches] [PATCH] [UPDATED] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install)

2011-03-17 Thread Marcel de Rooy
This patch contains only the install stuff. (Functionality in previous patch.) Rebased on March 17. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |2 +- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |2 +- installe

[Koha-patches] [PATCH] 5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed

2011-03-23 Thread Marcel de Rooy
Removes obsolete columns from aqbooksellers and aqbudgets if needed. aqbooksellers: deliverydays followupdays followupscancel invoicedisc nocalc specialty aqbudgets: budget_description These columns should not exist in a fresh install from kohastructure.sql, but originate from older 3.0 versions.

[Koha-patches] [PATCH] [UPDATED] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install)

2011-03-28 Thread Marcel de Rooy
This patch contains only the install stuff. (Functionality in previous patch.) Rebased on March 28. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |1 + installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |2 +- installer

[Koha-patches] [PATCH] [3.2.x] Bug 5863: Add to Your Cart disappeared if login disabled on opac detail

2011-03-28 Thread Marcel de Rooy
Resolving an error in ready function by additional conditionals. Moving a line from ready to html just as in other view templates, correcting the order of menu options at the same time. >From master. Rebased for 3.2.x --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |8 1 file

[Koha-patches] [PATCH 1/2] [3.2.x] Bug 3154: Preferences for building facets

2011-03-28 Thread Marcel de Rooy
Based on patch from Fridolyn Somers with input of Frederic Demians. Added new Searching preference maxRecordsForFacets. This pref contains number of result records used in facet building. Also added pref displayFacetCount (with thanks to Frederic). Follow up patch takes care of install issues; fun

[Koha-patches] [PATCH 2/2] [3.2.x] Bug 3154: Preferences for building facets

2011-03-28 Thread Marcel de Rooy
This follow up patch takes care of install issues. From master. Rebased for 3.2.x --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |4 +++- installer/data/mysql/en/mandatory/sysprefs.sql |2 ++ .../1-Obligatoire/unimarc_standard_systemprefs.sql |2 ++ installer/data/mysql/it

[Koha-patches] [PATCH] Fixing typo in kohastructure.sql

2011-03-30 Thread Marcel de Rooy
Fixing typo: adding colon. --- installer/data/mysql/kohastructure.sql |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index 1171cb1..e0bea81 100644 --- a/installer/data/mysql/kohastructure.sq

[Koha-patches] [PATCH] Textual changes only for update database script

2011-03-31 Thread Marcel de Rooy
Adding some version numbers and newlines to improve output in web installer. Tested it going from 3.00.06.009 to 3.03.00.035. --- installer/data/mysql/updatedatabase.pl | 60 1 files changed, 30 insertions(+), 30 deletions(-) diff --git a/installer/data/mysql/up

[Koha-patches] [PATCH] Bug 3628: opacSerialDefaultTab

2011-03-31 Thread Marcel de Rooy
This partial fix makes this existing pref visible in the interface. It should work for UNIMARC. Some work still needs to be done at the MARC side. --- .../prog/en/modules/admin/preferences/serials.pref | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/int

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5839: Add index stocknumber on 952$i

2011-04-04 Thread Marcel de Rooy
for your 952$i value in keyword search 4) Search for stocknumber, using stocknumber: or inv:<... Signed-off-by: Marcel de Rooy --- C4/Search.pm|2 ++ etc/zebradb/biblios/etc/bib1.att|1 + etc/zebradb/ccl.propert

[Koha-patches] [PATCH] Follow up fix for 5839 (items stocknumber)

2011-04-04 Thread Marcel de Rooy
New installer file for norway was not yet included. Tested with mysql. --- .../marc21/mandatory/marc21_framework_DEFAULT.sql |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/installer/data/mysql/nb-NO/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql b/installer

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5860: Adding duplicate stocknumber fails silently

2011-04-04 Thread Marcel de Rooy
From: Katrin Fischer When adding a duplicate stocknumber the duplicate was not saved to the database. This happened, because the field stocknumber in table items was declared to be unique. Discussion on bug suggests to lift this restriction. Signed-off-by: Marcel de Rooy Tested. Corrected

[Koha-patches] [PATCH] [SIGNED-OFF] [REBASED] 5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed

2011-04-06 Thread Marcel de Rooy
Removes obsolete columns from aqbooksellers and aqbudgets if needed. aqbooksellers: deliverydays followupdays followupscancel invoicedisc nocalc specialty aqbudgets: budget_description These columns should not exist in a fresh install from kohastructure.sql, but originate from older 3.0 versions.

[Koha-patches] [PATCH] 6083: Adding some version numbers and newlines to improve output in web installer

2011-04-06 Thread Marcel de Rooy
--- installer/data/mysql/updatedatabase.pl | 60 1 files changed, 30 insertions(+), 30 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 7931029..3bfafd8 100755 --- a/installer/data/mysql/updatedatab

[Koha-patches] [PATCH] 3072: Search for Heading-Main in authorities

2011-04-06 Thread Marcel de Rooy
Includes Heading-Main in authorities bib1 attribute set. Also includes Any in authorities bib1 (was still missing). Also removes temporary fix in AuthoritiesMarc.pm. Signed-off-by: Marcel de Rooy Rebased after pushed fix for #5924. --- C4/AuthoritiesMarc.pm|3 --- etc

[Koha-patches] [PATCH] 6094 Fixing ModAuthority problems

2011-04-07 Thread Marcel de Rooy
Pref MergeAuthoritiesOnUpdate does not exist; should be dontmerge. In: C4/AuthoritiesMarc.pm Subfolder tmp/modified_authorities should not be in $cgidir or $intranetdir. The apache user should not be assumed to have write access there. I would like to move it (back?) to /tmp/modified_authorities.

[Koha-patches] FW: [PATCH 2/2] [SIGNED-OFF] bug6064 adding forgotten news version in kohaversion

2011-04-07 Thread Marcel de Rooy
Stephane: I always understood that kohaversion.pl should not be changed by a developer; RM changes it. -Oorspronkelijk bericht- Van: koha-patches-boun...@lists.koha-community.org [mailto:koha-patches-boun...@lists.koha-community.org] Namens Stéphane Delaune Verzonden: donderdag 7 april 2

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5949: Hide 'Edit record' link when creating new order

2011-04-07 Thread Marcel de Rooy
ned-off-by: Marcel de Rooy --- .../prog/en/modules/acqui/neworderempty.tmpl |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl ind

[Koha-patches] [PATCH] [SIGNED-OFF] BZ6088: remove Perl warning

2011-04-07 Thread Marcel de Rooy
From: Paul Poulain caused by use warnings; Signed-off-by: Marcel de Rooy --- acqui/neworderempty.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index e6ceccc..386dda7 100755 --- a/acqui/neworderempty.pl +++ b/acqui

[Koha-patches] [PATCH] Removing a Perl warning

2011-04-07 Thread Marcel de Rooy
From: Paul Poulain Signed-off-by: Marcel de Rooy Applied small fix to proposed patch. Tested. No warnings. --- members/moremember.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/members/moremember.pl b/members/moremember.pl index 9dcfa3a..c0c0d87 100755 --- a

[Koha-patches] [PATCH] [SIGNED-OFF] Removing a Perl warning

2011-04-07 Thread Marcel de Rooy
From: Paul Poulain Signed-off-by: Marcel de Rooy Applied small fix to proposed patch. Tested. No warnings. --- members/moremember.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/members/moremember.pl b/members/moremember.pl index 9dcfa3a..c0c0d87 100755 --- a

[Koha-patches] [PATCH] [REVISED] 5660 Webinstaller should check if KohaOpacLanguage exists in staff

2011-04-07 Thread Marcel de Rooy
Small revision on April 7. --- installer/InstallAuth.pm | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm index 3a55b21..9885d19 100644 --- a/installer/InstallAuth.pm +++ b/installer/InstallAuth.pm @@ -

[Koha-patches] [PATCH] [REBASED] 5660 Webinstaller should check if KohaOpacLanguage exists in staff

2011-04-11 Thread Marcel de Rooy
Rebased on April 11. --- installer/InstallAuth.pm | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm index 81c38fb..447c1e6 100644 --- a/installer/InstallAuth.pm +++ b/installer/InstallAuth.pm @@ -110,

[Koha-patches] [PATCH] 5660 Webinstaller should check if KohaOpacLanguage exists in staff

2011-04-27 Thread Marcel de Rooy
Rebased on April 27 for master (3.05.00.001). --- installer/InstallAuth.pm | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm index 26ba5a7..3efc407 100644 --- a/installer/InstallAuth.pm +++ b/install

[Koha-patches] [PATCH] [FOLLOW-UP] 4959: Language inconsistencies on basket groups; skip confirmation when closing basket.

2011-04-27 Thread Marcel de Rooy
Follow up patch for installing pref BasketConfirmations. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |3 ++- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |3 ++- installer/data/mysql/it-IT/necessari/sysprefs.sql

[Koha-patches] [PATCH] 6290: Fix warning on XSLT.pm

2011-05-02 Thread Marcel de Rooy
--- C4/XSLT.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 28a70fc..4dafff3 100755 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -222,7 +222,7 @@ sub buildKohaItemsNamespace { } else { $status = "available"; } -

[Koha-patches] [PATCH] [SIGNED-OFF] 5684: Remove all items fields from a Z39.50 record imported for acquisition.

2011-05-13 Thread Marcel de Rooy
From: Frédérick Capovilla Signed-off-by: Marcel de Rooy --- acqui/neworderempty.pl |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index 386dda7..bd06b0c 100755 --- a/acqui/neworderempty.pl +++ b/acqui

[Koha-patches] [PATCH] [SIGNED-OFF] [3.4.X] 5684: Remove all items fields from a Z39.50 record imported for acquisition.

2011-05-13 Thread Marcel de Rooy
From: Frédérick Capovilla Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl May 13: Patch applies to 3.4.X as well. --- acqui/neworderempty.pl |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index 386dda7..bd06b0c

[Koha-patches] [PATCH] [SIGNED-OFF] [3.2.X] 5684: Remove all items fields from a Z39.50 record imported for acquisition.

2011-05-13 Thread Marcel de Rooy
From: Frédérick Capovilla Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl May 13: Patch for 3.2.X. --- acqui/neworderempty.pl |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index 7028ee2..f1bab82 100755 --- a

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5860 - Attempted follow up patch to fix itemstocknumberindex

2011-05-13 Thread Marcel de Rooy
From: Chris Cormack Signed-off-by: Marcel de Rooy May 13: Replaced information_schema construct with show indexes. Check existence on both names. Tested it. --- installer/data/mysql/updatedatabase.pl |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/installer/data

[Koha-patches] [PATCH] [3.2.X] 5860 Follow up fix for itemstocknumber index

2011-05-16 Thread Marcel de Rooy
Remove itemstocknumber index and recreate it. --- installer/data/mysql/updatedatabase.pl | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 6888b72..261bf90 100755 --- a/insta

[Koha-patches] [PATCH] [3.4.X] 5860 Follow up fix for itemstocknumber index

2011-05-16 Thread Marcel de Rooy
Remove itemstocknumber index and recreate it. --- installer/data/mysql/updatedatabase.pl | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index f503112..d802f8e 100755 --- a/instal

[Koha-patches] [PATCH] Second follow up fix for 5860

2011-05-16 Thread Marcel de Rooy
Added code also at end of updatedatabase. Some installs may need it. Since it only may recreate the index, it does not harm... NOTE: Please apply after first follow up fix! --- installer/data/mysql/updatedatabase.pl | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --g

[Koha-patches] [PATCH] [REVISED] 5860 Fixing stocknumber index

2011-05-16 Thread Marcel de Rooy
Fixing code for 3.3.0.42 update. Adding code at end of update script if install past that point already. --- installer/data/mysql/updatedatabase.pl | 30 ++ 1 files changed, 26 insertions(+), 4 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/inst

[Koha-patches] [PATCH] [REVISED] [3.4.X] 5860 Fixing stocknumber index

2011-05-16 Thread Marcel de Rooy
Fixing code for 3.3.0.42 update. Adding code at end of update script if install past that point already. --- installer/data/mysql/updatedatabase.pl | 29 + 1 files changed, 25 insertions(+), 4 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/insta

[Koha-patches] [PATCH] [REVISED] [3.2.X] 5860 Fixing stocknumber index

2011-05-16 Thread Marcel de Rooy
Fixing code for 3.2.6.1/3.2.7.1 update. Adding code at end of update script if install past that point already. --- installer/data/mysql/updatedatabase.pl | 34 ++- 1 files changed, 28 insertions(+), 6 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl

[Koha-patches] [PATCH] 4513: Resetting framework to Default seems impossible

2011-05-16 Thread Marcel de Rooy
Test this patch by opening a biblio saved in e.g. books framework. Change the framework in Staff Cataloging back to Default and save. Open the biblio again and check if it really has been set to Default. --- cataloguing/addbiblio.pl |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) di

[Koha-patches] [PATCH] [SIGNED-OFF] BUG6067 When Add Duplicate changing framework would lose data

2011-05-19 Thread Marcel de Rooy
From: Fridolyn SOMERS Signed-off-by: Marcel de Rooy --- cataloguing/addbiblio.pl |7 +++ .../prog/en/modules/cataloguing/addbiblio.tt |2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 6380 - Z39.50 Cataloging Search needs a way to try search again, even if results are found

2011-05-23 Thread Marcel de Rooy
tton to "Try Another Search" Do a search for something that returns no results -- The link for "Try Another Search" should now be a proper button. Signed-off-by: Marcel de Rooy [EDIT: Form slightly changed in order to remember biblio and framework. Link is no official html met

[Koha-patches] [PATCH 1/3] 6429: Sync history/about

2011-05-30 Thread Marcel de Rooy
Some initial corrections in history/about to improve syncing. --- docs/history.txt | 14 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt |2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/history.txt b/docs/history.txt i

[Koha-patches] [PATCH 2/3] 6429: Sync history/about

2011-05-30 Thread Marcel de Rooy
6620692116417";>MJ Ray Liz Rea Allen Reinmeyer + Serge Renaux +Waylon Robertson +Marcel de Rooy + Brice Sanchez https://www.ohloh.net/p/koha/contributors/6618544619438";>Robin She

[Koha-patches] [PATCH 3/3] 6429: Sync history/about

2011-05-30 Thread Marcel de Rooy
Helpful script for syncing about with history. --- docs/comp_about.pl | 119 1 files changed, 119 insertions(+), 0 deletions(-) create mode 100755 docs/comp_about.pl diff --git a/docs/comp_about.pl b/docs/comp_about.pl new file mode 100755 in

[Koha-patches] [PATCH 2/3] [REVISED] 6429: Sync history/about

2011-05-30 Thread Marcel de Rooy
rica Pavlinusic Polytechnic University https://www.ohloh.net/p/koha/contributors/6620692116417";>MJ Ray Liz Rea Allen Reinmeyer +Serge Renaux +Waylon Robertson +Mar

[Koha-patches] [PATCH] Bug 4839: Follow-up patch for installing pref

2011-06-01 Thread Marcel de Rooy
Installs syspref MARCAuthorityControlField008. Rebased June 1, 2011 for master. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |3 ++- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |3 ++- installer/data/mysql/it-IT

[Koha-patches] [PATCH] 6536: Z3950 Enhancements (DB Revision)

2011-06-30 Thread Marcel de Rooy
This patch contains db revision for Z3950 enhancements: SRU search targets, MARC conversion and additional XSLT processing. It also contains a few additional lines of code for updatedatabase routines SetVersion and TransformToNum in order to facilitate testing new db revisions which are still ma

[Koha-patches] [PATCH] 6584: Enable searching on Zebra's Bib-level index

2011-07-13 Thread Marcel de Rooy
Bib-level is already indexed in MARC21 record.abs. But you cannot search this index, because it is commented in ccl.properties and not listed in getIndexes of Search.pm. This very simple patch does only do those two things. --- C4/Search.pm |1 + etc/zebradb/ccl.properties |2

[Koha-patches] [PATCH] 5662: Show control number without organization code in OPAC URLs

2011-07-14 Thread Marcel de Rooy
OPAC detail xsl adjusted at four places: 773 when leader19=c, 775, 780, 785. Enable the pref UseControlNumber when testing this patch. And set pref OPACXSLTDetailsDisplay to using XSLT stylesheets. Test by adding a control number ($w) in abovementioned fields. Go to opac detail and check if the l

[Koha-patches] [PATCH] 5663: Show control number without organization code in staff URLs

2011-07-14 Thread Marcel de Rooy
Intranet detail xsl adjusted at 4 places: 773 when leader19=c, 775, 780, 785. Enable the pref UseControlNumber when testing this patch. And set pref XSLTDetailsDisplay to using XSLT stylesheets. Test by adding a control number ($w) in abovementioned fields. Go to staff detail and check if the lin

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 4433: Small display problem for topical subjects

2011-07-18 Thread Marcel de Rooy
without the subfield codes (at least $a in front), except the topical subject. This patch removes the subfield codes for the topical headings. Signed-off-by: Marcel de Rooy Works as advertised in opac and staff. (July 18, 2011) --- C4/AuthoritiesMarc.pm |4 ++-- 1 files changed, 2 insertions

[Koha-patches] [PATCH] [REVISED] 6094 Fixing ModAuthority problems

2011-07-25 Thread Marcel de Rooy
Pref MergeAuthoritiesOnUpdate does not exist; should be dontmerge. In: C4/AuthoritiesMarc.pm Subfolder modified_authorities should not be in $cgidir or $intranetdir. Implementing suggestion of Janus Kaczmarec, I move it to /var/tmp. The subfolder is created if not existing. This change applies to

  1   2   >