[Koha-patches] [PATCH] Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion

2010-11-12 Thread Colin Campbell
--- t/Koha.t |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/t/Koha.t b/t/Koha.t index 1742ddd..be5a838 100755 --- a/t/Koha.t +++ b/t/Koha.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More tests => 7; +use Test::More tests => 8; use_ok('C4::Koha'); @@

[Koha-patches] [PATCH] Bug 5392 Initialize vars used in building url strings

2010-11-12 Thread Colin Campbell
If no failures are to be added to the to the strings for redirect the corresponding variables are undefined causing warnings to be logged. Initialize them so that the error log is not being filled with trivia. --- reserve/renewscript.pl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Koha-patches] [PATCH] [SIGNED-OFF 1/3] Bug 4979: Acq: input fields for new record are too short

2010-11-12 Thread Galen Charlton
From: Katrin Fischer Patch rebased to HEAD, should also apply to 3.2 Signed-off-by: Galen Charlton --- .../prog/en/modules/acqui/neworderempty.tmpl | 24 ++-- 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/

[Koha-patches] [PATCH] [SIGNED-OFF 2/3] Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion

2010-11-12 Thread Galen Charlton
From: Colin Campbell Signed-off-by: Galen Charlton --- t/Koha.t |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/t/Koha.t b/t/Koha.t index 1742ddd..be5a838 100755 --- a/t/Koha.t +++ b/t/Koha.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More tests => 7; +u

[Koha-patches] [PATCH] [SIGNED-OFF 3/3] Bug 5392 Initialize vars used in building url strings

2010-11-12 Thread Galen Charlton
From: Colin Campbell If no failures are to be added to the to the strings for redirect the corresponding variables are undefined causing warnings to be logged. Initialize them so that the error log is not being filled with trivia. Signed-off-by: Galen Charlton --- reserve/renewscript.pl |4

[Koha-patches] [PATCH] bug 5393: add test case to check well-formedness of XML/XSLT files

2010-11-12 Thread Galen Charlton
Signed-off-by: Galen Charlton --- t/00-valid-xml.t | 44 1 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 t/00-valid-xml.t diff --git a/t/00-valid-xml.t b/t/00-valid-xml.t new file mode 100644 index 000..6e896ba --- /dev/nul

[Koha-patches] [PATCH] bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files

2010-11-12 Thread Frédéric Demians
From: Galen Charlton Signed-off-by: Galen Charlton Signed-off-by: Frédéric Demians --- t/00-valid-xml.t | 44 1 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 t/00-valid-xml.t diff --git a/t/00-valid-xml.t b/t/00-valid-xml.t

[Koha-patches] [Bug 5366] Pull Request [New Work]

2010-11-12 Thread Chris Nighswonger
The following changes since commit 636ceef18a4e5af28306c07597573dc2d6b292a5: Chris Nighswonger (1): [2/2] Bug 5366 - Standing enh req for code changes enabling database agnosticism are available in the git repository at: git://git.koha-community.org/wip/koha-fbc.git k_bug_5366 Chris

[Koha-patches] [PATCH] [SIGNED-OFF] bug 5393: add test case to check well-formedness of XML/XSLT files

2010-11-12 Thread Chris Nighswonger
From: Galen Charlton Signed-off-by: Galen Charlton Signed-off-by: Chris Nighswonger --- t/00-valid-xml.t | 44 1 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 t/00-valid-xml.t diff --git a/t/00-valid-xml.t b/t/00-valid-xml.t

[Koha-patches] [PATCH] Bug 5381 - Fines in notices prints always 0.00

2010-11-12 Thread Katrin Fischer
From: Chris Nighswonger This was due to passing off the biblionumber to GetFines rather than the itemnumber. Signed-off-by: Katrin Fischer --- misc/cronjobs/overdue_notices.pl | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/misc/cronjobs/overd

[Koha-patches] [3.0.x] [Bug 5394] Handle situation where bookseller is not found

2010-11-12 Thread MJ Ray
The following changes since commit dc7e0ecba7cd256ffab014ff6f6f658eaf561fb4: MJ Ray (1): [Bug 5394] Handle situation where bookseller is not found are available in the git repository at: g...@gitorious.org:koha/mainline.git for-3.0/bug_5394 Hope that helps, -- MJ Ray (slef), member

[Koha-patches] [PATCH] BUG 5058: small layout correction of vendor form

2010-11-12 Thread Katrin Fischer
From: Katrin Fischer Rebased to HEAD, should also apply to 3.2 --- .../prog/en/modules/acqui/supplier.tmpl|4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules

[Koha-patches] [PATCH] [SIGNED-OFF] BUG 5058: small layout correction of vendor form

2010-11-12 Thread Chris Nighswonger
From: Katrin Fischer Rebased to HEAD, should also apply to 3.2 Signed-off-by: Chris Nighswonger --- .../prog/en/modules/acqui/supplier.tmpl|4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tmpl b/koha

[Koha-patches] [PATCH] Bug 5059: Inconsistent use of ordering price and list price in vendor form

2010-11-12 Thread Katrin Fischer
From: Katrin Fischer Changes Ordering price to List price and make spelling more consistent. Patch originally send for 3.2, still applied to HEAD without conflicts. --- .../prog/en/modules/acqui/supplier.tmpl| 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5059: Inconsistent use of ordering price and list price in vendor form

2010-11-12 Thread Chris Nighswonger
From: Katrin Fischer Changes Ordering price to List price and make spelling more consistent. Patch originally send for 3.2, still applied to HEAD without conflicts. Signed-off-by: Chris Nighswonger --- .../prog/en/modules/acqui/supplier.tmpl| 12 ++-- 1 files changed, 6

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5175, XSL view doesn't link publisher name to search

2010-11-12 Thread Katrin Fischer
From: Owen Leonard This patch fixes the bug in both the OPAC and staff client Signed-off-by: Katrin Fischer --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl |8 +++- .../prog/en/xslt/MARC21slim2OPACDetail.xsl |6 ++ 2 files changed, 13 insertions(+), 1 deletions(-

[Koha-patches] [PATCH] [SIGNED-OFF]Bug 5396: New system preference UseTablesortForCirc

2010-11-12 Thread Ian Walls
From: Owen Leonard This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the circ/circulation.pl page. For patrons with many checkouts, this sort may cause very slow page loading (and therefore slow circulation transaction time), depending on t

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time

2010-11-12 Thread Chris Nighswonger
From: Owen Leonard This fix corrects the behavior of the checkboxes whether the user clicks the checkbox itself or the around it. Tested on a PC in Firefox 3.6, Chrome, Safari 5, and IE 8. Signed-off-by: Chris Nighswonger --- .../prog/en/modules/circ/circulation.tmpl | 74 +

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5210, back button on batch modification result page useless

2010-11-12 Thread Katrin Fischer
From: Owen Leonard I can't see any good use for a back button here, so I'm taking it out. An improvement might be to build in a method to resubmit the same batch of barcodes/item numbers again so that you could make additional changes to the same set. Signed-off-by: Katrin Fischer --- .../pro

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5269 - link to patron edit form when editing turned off

2010-11-12 Thread Chris Nighswonger
From: Owen Leonard Signed-off-by: Nicole Engard Signed-off-by: Chris Nighswonger --- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl b/koha-tmpl/opac-tmpl/prog/e

Re: [Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5175, XSL view doesn't link publisher name to search

2010-11-12 Thread Galen Charlton
Hi, On Fri, Nov 12, 2010 at 3:50 PM, Katrin Fischer wrote: >         Publisher: >             > +                 href="/cgi-bin/koha/catalogue/search.pl?q=pb:{marc:subfie...@code='b']}"> > +                     > +                        b > +                     > +               > +        

Re: [Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5175, XSL view doesn't link publisher name to search

2010-11-12 Thread Fischer, Katrin
Galen, you are right. I missed that :( -Original Message- From: koha-patches-boun...@lists.koha-community.org on behalf of Galen Charlton Sent: Fri 12.11.2010 22:14 To: Katrin Fischer Cc: koha-patches@lists.koha-community.org Subject: Re: [Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 51

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5175, XSL view doesn't link publisher name to search

2010-11-12 Thread Katrin Fischer
From: Owen Leonard Fixes the doubled up display of the publisher. This patch fixes the bug in both the OPAC and staff client --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 10 -- .../prog/en/xslt/MARC21slim2OPACDetail.xsl |8 +++- 2 files changed, 15 insertio

[Koha-patches] [PATCH 2/2] bug 5397: display renew count consistently

2010-11-12 Thread Galen Charlton
Display the renewal count for loans consistently; in particular, for loans that have never been renewed, display 0. Signed-off-by: Galen Charlton --- .../prog/en/modules/circ/circulation.tmpl |2 +- .../prog/en/modules/members/moremember.tmpl|2 +- 2 files changed, 2 ins

[Koha-patches] [PATCH 2/4] bug 4359 follow-up: noItemTypeImages should just control image display

2010-11-12 Thread Galen Charlton
Tweaked so that the item type column is always displayed in the checkout history in the OPAC; noItemTypeImages now just controls whether the icon displays. Signed-off-by: Galen Charlton --- .../prog/en/modules/opac-readingrecord.tmpl|4 ++-- 1 files changed, 2 insertions(+), 2 deleti

[Koha-patches] [PATCH 1/4] [SIGNED-OFF] Fix for Bug 4359, noItemTypeImages not active in OPAC

2010-11-12 Thread Galen Charlton
From: Owen Leonard - Auth.pm put the noItemTypeImages preference under "intranet only." Moved it to "OPAC or intranet." - Added check for the preference on the OPAC advanced search page. - Improved logic for displaying images on the reading history page. Signed-off-by: Galen Charlton --- C4/

[Koha-patches] [PATCH 3/4] bug 4359: make other pages in the OPAC respect noItemTypeImages

2010-11-12 Thread Galen Charlton
Signed-off-by: Galen Charlton --- .../opac-tmpl/prog/en/modules/opac-reserve.tmpl|4 .../prog/en/modules/opac-results-grouped.tmpl |9 + .../opac-tmpl/prog/en/modules/opac-results.tmpl|2 ++ .../opac-tmpl/prog/en/modules/opac-shelves.tmpl|5 - 4 f

[Koha-patches] [PATCH 4/4] bug 5398: make additional pages in staff interface obey noItemTypeImages

2010-11-12 Thread Galen Charlton
Signed-off-by: Galen Charlton --- .../prog/en/modules/catalogue/advsearch.tmpl |2 ++ .../prog/en/modules/reserve/request.tmpl |5 - .../prog/en/modules/suggestion/suggestion.tmpl |1 - .../prog/en/modules/virtualshelves/shelves.tmpl|2 +- 4 files chang

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 4912 - After editing private list redirect to private lists

2010-11-12 Thread Galen Charlton
From: Owen Leonard Signed-off-by: Galen Charlton --- .../prog/en/modules/virtualshelves/shelves.tmpl|6 +- koha-tmpl/opac-tmpl/prog/en/css/opac.css |5 - .../opac-tmpl/prog/en/modules/opac-shelves.tmpl|3 ++- 3 files changed, 11 insertions(+), 3 deletions(-

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 4913 - Budget pages should show currency name instead of symbol

2010-11-12 Thread Galen Charlton
From: Owen Leonard This patch adds a new include file to handle the display of the active currency name and a warning if no currency is active. Signed-off-by: Galen Charlton --- admin/aqbudgetperiods.pl |4 +++- admin/aqbudgets.pl |

[Koha-patches] [PATCH 2/2] bug 3850 followup - tweaks

2010-11-12 Thread Galen Charlton
* fix type that would break translation * moved acq menu back to left side I wonder if the export box is better moved back under the planning grid. Signed-off-by: Galen Charlton --- .../prog/en/modules/admin/aqplan.tmpl |5 + 1 files changed, 1 insertions(+), 4 deletions(-)

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 3271, Missing message when adding to a list with no items selected

2010-11-12 Thread Galen Charlton
From: Owen Leonard There is no visible Lists button to "attach" our warning to as there is in the OPAC, so warning message is displayed via a javascript alert. Signed-off-by: Galen Charlton --- koha-tmpl/intranet-tmpl/prog/en/js/basket.js |4 +--- 1 files changed, 1 insertions(+), 3 deleti

[Koha-patches] [PATCH] [SIGNED-OFF] Corrected patch for Bug 4520, facets "show more" doesn't work

2010-11-12 Thread Galen Charlton
From: Owen Leonard Re-doing Nahuel's fix so that it applies to master Signed-off-by: Galen Charlton --- catalogue/search.pl|1 + .../intranet-tmpl/prog/en/includes/facets.inc |2 +- .../opac-tmpl/prog/en/includes/opac-facets.inc |2 +- opac/

[Koha-patches] [PATCH] [SIGNED-OFF] Partial fix for Bug 4924, Public/Internal notes missing in staff normal view

2010-11-12 Thread Galen Charlton
From: Owen Leonard This fix adds only public notes. A div is added as a hook for styling Signed-off-by: Galen Charlton --- catalogue/detail.pl|3 ++- .../prog/en/modules/catalogue/detail.tmpl |2 ++ 2 files changed, 4 insertions(+), 1 deletions(

[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 4933, Link to subfield's edit tab from subfield structure admin

2010-11-12 Thread Galen Charlton
From: Owen Leonard - Also corrects framework display in the case of the default Signed-off-by: Galen Charlton --- .../en/modules/admin/marc_subfields_structure.tmpl |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/ma

[Koha-patches] [PATCH] bug 5399: remove useless eval 'use C4::Foo'

2010-11-12 Thread Galen Charlton
Also add a couple FIXMEs Signed-off-by: Galen Charlton --- acqui/addorderiso2709.pl |6 +- acqui/basketgroup.pl |7 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index 903d2db..25366b1 100755 --- a/acqui