Re: [Koha-devel] Use of TMPL_IF EXPR

2010-01-12 Thread Joe Atzberger
EXPR considered harmful. Basically, EXPR does not do what any sane person would expect, i.e. evaluate the expression in the flow of template logic. H:T:P, which we are using because of it's single-pass performance advantage, actually evaluates the ALL EXPR statements in an additional pre-pass. T

Re: [Koha-devel] Use of TMPL_IF EXPR

2009-12-31 Thread LAURENT Henri-Damien
In fact, from what I know and experienced TMPL_IF EXPR is quite demanding if variable is undefined, it writes a log message, and would sometimes fail. So that decision was taken to remove that. hopes that helps. -- Henri-Damien LAURENT Garry Collum wrote: > The one time I used EXPR in one of my p

Re: [Koha-devel] Use of TMPL_IF EXPR

2009-12-30 Thread Garry Collum
The one time I used EXPR in one of my patches, Galen figuratively smacked me around because it added a bunch of garbage to the apache logs. I rewrote the patch without EXPR. Garry On Wed, Dec 30, 2009 at 3:20 PM, MJ Ray wrote: > Owen Leonard asked: >> Re: Bug 2670 (http://bugs.koha.org/cgi-bin/

Re: [Koha-devel] Use of TMPL_IF EXPR

2009-12-30 Thread Owen Leonard
> Is it a performance worry or a security worry? What I know is that the EXPR syntax sometimes leads to lines like this in the error log: "EXPR:at pos 25: non-initialized variable loggedinusername" This happens when one of the variables being checked by the EXPR doesn't exist. So in this case th

Re: [Koha-devel] Use of TMPL_IF EXPR

2009-12-30 Thread MJ Ray
Owen Leonard asked: > Re: Bug 2670 (http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2670) > > Is it possible to set up guidelines under which EXPR is allowed? If we > can confirm that variables will be output under all circumstances > would an EXPR be allowed? hdl's bug report doesn't expl