Re: [Koha-devel] Tab stops in source code

2008-11-14 Thread Ambrose Li
2008/11/12 Rick Welykochy <[EMAIL PROTECTED]>: > # Please use 8-character tabs for this file (indents are every 4 characters) > > Does this mean that tabs should not be used for indentation, > since a tab would indent 8 character positions in the source? > > Does this imply that we should be using

Re: [Koha-devel] Tab stops in source code

2008-11-14 Thread Sébastien Nadeau
Hi, > -Message d'origine- > De : [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] De la part de Rick > Welykochy > Envoyé : 13 novembre 2008 20:08 > Objet : Re: [Koha-devel] Tab stops in source code > > TABs are metadata, not display data. They give the progra

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Rick Welykochy
Mason James wrote: > check this link for hearty examples of 'tabs versus spaces' > discussion, enjoy ;) > > http://www.perlmonks.org/?node_id=576936 > > > for me, the above discussion eventually has a obvious conclusion, > which is... > >tabs have the possibility to be displayed in a w

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Mason James
On 2008/11/14, at 2:50 AM, Paul POULAIN wrote: > Rick Welykochy a écrit : >> Mason James wrote: >> >>> but i think we might have to allow either tabs or spaces from >>> developers - >>> (thats perltidys behavior too afaik) >> >> Why would anyone indent with spaces? check this link for hearty

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Jesse Weaver
On Thu, Nov 13, 2008 at 7:03 AM, Owen Leonard <[EMAIL PROTECTED]> wrote: > >> And what about the templates? They are often mind-bending to edit, and > I've > >> seen no tools to assist in comprehending their structure. > > > > agreed... > > The Perl scripts are mind-bending to me. I suspect it's w

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Owen Leonard
>> And what about the templates? They are often mind-bending to edit, and I've >> seen no tools to assist in comprehending their structure. > > agreed... The Perl scripts are mind-bending to me. I suspect it's whatever you're most used to (I've spent WAY too much time in template world by now). Bu

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Paul POULAIN
Rick Welykochy a écrit : > Mason James wrote: > >> but i think we might have to allow either tabs or spaces from developers - >> (thats perltidys behavior too afaik) > > Why would anyone indent with spaces? we spoke of that a loonnnggg time ago. I don't remember the details, but i remember that

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Andrew Moore
On Thu, Nov 13, 2008 at 12:45 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > > As far as a standardised .perltidyrc, my only comment is "please > explain!" Hi again, Rick - perltidy is a tool that attempts to format perl code in a consistent way. That .perltidyrc file sets most things to the def

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Andrew Moore
On Thu, Nov 13, 2008 at 12:45 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > May I assume then that the answer to tab stops is: > > (*) yes, use them to indent That doesn't seem to be historically the most preferred method. Here are some statistics (that are probably lying in some way): number o

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Rick Welykochy
Mason James wrote: > but i think we might have to allow either tabs or spaces from developers - > (thats perltidys behavior too afaik) Why would anyone indent with spaces? > the important thing is a consistent indent length of 4, i think. Hooray for that! >> As far as a standardised .perltidy

Re: [Koha-devel] Tab stops in source code

2008-11-13 Thread Mason James
On 2008/11/13, at 7:45 PM, Rick Welykochy wrote: > Mason James wrote: > >> I don't know the history of this comment, but i wouldnt wotry too >> much about it >> its old and not very well enforced (at least) >> I think we should all agree on a standardised .perltidyrc format, >> and i vote fo

Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Rick Welykochy
Mason James wrote: > I don't know the history of this comment, but i wouldnt wotry too much > about it > its old and not very well enforced (at least) > > I think we should all agree on a standardised .perltidyrc format, and i > vote for Andy's ;) > Ive been using Andy's since he first posted

Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Mason James
On 2008/11/13, at 3:35 PM, Andrew Moore wrote: > On Wed, Nov 12, 2008 at 8:15 PM, Rick Welykochy > <[EMAIL PROTECTED]> wrote: >> Hi all >> >> In the file abort.pl in Koha 3 I see the follow cryptic comment: >> >> # Please use 8-character tabs for this file (indents are every 4 >> characters)

Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Andrew Moore
On Wed, Nov 12, 2008 at 8:15 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Hi all > > In the file abort.pl in Koha 3 I see the follow cryptic comment: > > # Please use 8-character tabs for this file (indents are every 4 characters) > > Does this mean that tabs should not be used for indentation,

[Koha-devel] Tab stops in source code

2008-11-12 Thread Rick Welykochy
Hi all In the file abort.pl in Koha 3 I see the follow cryptic comment: # Please use 8-character tabs for this file (indents are every 4 characters) Does this mean that tabs should not be used for indentation, since a tab would indent 8 character positions in the source? Does this imply that we