Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Henri-Damien LAURENT
Rick Welykochy a écrit : > Henri-Damien LAURENT wrote: > >> But paul also spoke about zebra queries and they are not logged nor >> saved into the database at the moment >> which could be good for storing user queries history but is an other >> point. > > Which could perhaps be considered an audit

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Rick Welykochy
Henri-Damien LAURENT wrote: > But paul also spoke about zebra queries and they are not logged nor > saved into the database at the moment > which could be good for storing user queries history but is an other point. Which could perhaps be considered an audit function. Has consideration been give

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Henri-Damien LAURENT
Rick Welykochy a écrit : > Paul POULAIN wrote >> So I think queries should be logged. >> >> + that would give us some datas to analyse the queries done by users. We >> just need the analysis too to be written ;-) >> > > Not in a production environment. You are imposing your own debugging > re

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Andrew Moore
On Fri, Aug 29, 2008 at 11:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > I agree, except for query logging. It has been proven many times to me > that it's usefull : the library tells you "I search this, and got no > results, there's a bug in koha". > You look in the logs, and see that the searc

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Rick Welykochy
Paul POULAIN wrote: > So I think queries should be logged. > > + that would give us some datas to analyse the queries done by users. We > just need the analysis too to be written ;-) Not in a production environment. You are imposing your own debugging requirements on all users of a production s

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Galen Charlton
Hi, On Fri, Aug 29, 2008 at 11:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > I agree, except for query logging. It has been proven many times to me > that it's usefull : the library tells you "I search this, and got no > results, there's a bug in koha". > You look in the logs, and see that the

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-29 Thread Paul POULAIN
Rick Welykochy a écrit : > Galen Charlton wrote: > >> Ideally, all Perl scripts and modules should have warnings enabled by >> the time 3.2 is released. > > 1000 applauds. Furthermore, demand that the error_log is *empty* > during normal use, i.e. a non debug environment. I agree, except for quer

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-12 Thread Galen Charlton
Hi, On Tue, Aug 12, 2008 at 12:00 AM, Chris Nighswonger <[EMAIL PROTECTED]> wrote: > On Tue, Aug 12, 2008 at 12:56 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: >> I hope 'use strict' is in there as well. >> Or in another bug report. > > If I'm not mistaken, we 'use strict' already. We do, but th

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-11 Thread Chris Nighswonger
On Tue, Aug 12, 2008 at 12:56 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Galen Charlton wrote: >> Hi, >> >> On Tue, Aug 5, 2008 at 12:07 PM, Galen Charlton >> <[EMAIL PROTECTED]> wrote: >>> I propose the following steps to implement this: >> ... >>> 5. Create a standing blocker bug for 3.2 for

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-11 Thread Rick Welykochy
Galen Charlton wrote: > Hi, > > On Tue, Aug 5, 2008 at 12:07 PM, Galen Charlton > <[EMAIL PROTECTED]> wrote: >> I propose the following steps to implement this: > ... >> 5. Create a standing blocker bug for 3.2 for adding "use warnings". > > I have opened bug 2505 for this. I hope 'use strict'

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-11 Thread Galen Charlton
Hi, On Tue, Aug 5, 2008 at 12:07 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > I propose the following steps to implement this: ... > 5. Create a standing blocker bug for 3.2 for adding "use warnings". I have opened bug 2505 for this. Regards, Galen -- Galen Charlton VP, Research & Developme

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-05 Thread Andrew Moore
On Tue, Aug 5, 2008 at 12:07 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Ideally, all Perl scripts and modules should have warnings enabled by > the time 3.2 is released. I'm surprised we haven't done this yet. I hadn't worked on code that didn't use strict and warnings in years before I start

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-05 Thread Chris Nighswonger
On Tue, Aug 5, 2008 at 1:07 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Hi, > > Perl's warnings pragma is the cheapest way to find bugs. We already > use the strict pragma; now it's time to add warnings. More > importantly, it's time to review the messages produced by the warnings > pragma and

Re: [Koha-devel] RFC 3.2 - turn on warnings

2008-08-05 Thread Rick Welykochy
Galen Charlton wrote: > Ideally, all Perl scripts and modules should have warnings enabled by > the time 3.2 is released. 1000 applauds. Furthermore, demand that the error_log is *empty* during normal use, i.e. a non debug environment. > I propose the following steps to implement this: > > 1.

[Koha-devel] RFC 3.2 - turn on warnings

2008-08-05 Thread Galen Charlton
Hi, Perl's warnings pragma is the cheapest way to find bugs. We already use the strict pragma; now it's time to add warnings. More importantly, it's time to review the messages produced by the warnings pragma and fix the underlying issues. To reiterate, this RFC has two goals: turning on warnings