Re: [Koha-devel] Avoid $sth->finish

2009/6/4 Joe Atzberger > Kohackers -- > > I want to mention this because I've seen a lot of recent patches still > using the old style of code calling $sth->finish() explicitly. I know a lot > of the codebase still does this internally, but for Koha such usage is > almost always wrong. > > One w

[Koha-devel] RFC: Upgrading to jQuery 1.3.2

Currently, Koha uses jQuery 1.2.3. I would like to get it upgraded to the current release which is *1.3.2 *. The significant changes that the 1.3 series brings can be found here: *http://docs.jquery.com/Release:jQuery_1.3* The 1.3 series brings many

Re: [Koha-devel] 'OpacSuppression' syspref?

On Sun, Mar 29, 2009 at 9:08 PM, Mason James wrote: > > my little point here is that the feature doesnt appear to exist in > 3.x ( or 2.2.x or dev_week according to grep) > > so we have a syspref and a manual entry - but no commited feature. > > do we remove the dead syspref, or add the feature to

Re: [Koha-devel] A solution to add debugger functionality to most koha *.pl scripts, thoughts please?

On Tue, Feb 10, 2009 at 9:38 AM, Mason James wrote: > > Woo, this is all new stuff for me. > > I'll play about and test this code of yours during my work week, and read > up on the OO->import example you gave. > > I aim to send in a patch based on your code in the next few days. > > Thanks again J

Re: [Koha-devel] A solution to add debugger functionality to most koha *.pl scripts, thoughts please?

Also, if you want to be able to just type "Dumper" (instead of Data::Dumper::Dumper), add "Dumper" to the list of symbols that C4::Debug exports. On Mon, Feb 9, 2009 at 10:30 PM, John Beppu wrote: > Give C4::Debug an import() function like this: > > sub

Re: [Koha-devel] A solution to add debugger functionality to most koha *.pl scripts, thoughts please?

Give C4::Debug an import() function like this: sub import { if ($debug) { require Smart::Comments; Smart::Comments->import; require Data::Dumper; Data::Dumper->import; } C4::Debug->export_to_level(1, @_); } Th

Re: [Koha-devel] [Koha-patches] [PATCH] Removed RSS Option from UI

I agree that it was quite a disappointment to only see about 10% improvement in the request rate despite eliminating so many database queries. I was expecting a much bigger speed increase, too. If you want to benchmark it yourself, here's how I ran apache bench against koha: ab -H "Cookie: CGISE

Re: [Koha-devel] [Koha-patches] [PATCH] Removed RSS Option from UI

No problem. I'll use the word "undo" the next time I do something like that. I'm still kind of a n00b to this code base, so it'll probably happen again. --beppu On Wed, Feb 4, 2009 at 1:57 AM, MJ Ray wrote: > John Beppu wrote: > > This was also my first e

Re: [Koha-devel] [Koha-patches] [PATCH] Removed RSS Option from UI

Sure. The purpose of this big set of patches was to make it possible for koha to send notifications to borrowers upon checkout and check-in. Next, you might be wondering why this seemingly simple task took 17 patches to accomplish. ;-) First, the high number of patches reflects the back and for

Re: [Koha-devel] [Koha-patches] [PATCH] Removed RSS Option from UI

This is probably not what you think it is. It's not like we're removing RSS feeds from the entire system. We're actually just removing UI elements for a messaging system feature that never even existed. To clarify what happened, please run this query on your system: SELECT * FROM message_transp