Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Rick Welykochy
Mason James wrote: > I don't know the history of this comment, but i wouldnt wotry too much > about it > its old and not very well enforced (at least) > > I think we should all agree on a standardised .perltidyrc format, and i > vote for Andy's ;) > Ive been using Andy's since he first posted

Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Mason James
On 2008/11/13, at 3:35 PM, Andrew Moore wrote: > On Wed, Nov 12, 2008 at 8:15 PM, Rick Welykochy > <[EMAIL PROTECTED]> wrote: >> Hi all >> >> In the file abort.pl in Koha 3 I see the follow cryptic comment: >> >> # Please use 8-character tabs for this file (indents are every 4 >> characters)

Re: [Koha-devel] Tab stops in source code

2008-11-12 Thread Andrew Moore
On Wed, Nov 12, 2008 at 8:15 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Hi all > > In the file abort.pl in Koha 3 I see the follow cryptic comment: > > # Please use 8-character tabs for this file (indents are every 4 characters) > > Does this mean that tabs should not be used for indentation,

[Koha-devel] The authnotrequired flag in scripts

2008-11-12 Thread Rick Welykochy
Hi all I am about to lock down a client Koha site so that users *MUST* be logged in to access any page. In Koha/2.2.9 this was straightforward: vi `grep -rl "authnotrequired => 1" /usr/local/koha/` and change each "authnotrequired => 1" to "authnotrequired => 0" It appears that things

[Koha-devel] Tab stops in source code

2008-11-12 Thread Rick Welykochy
Hi all In the file abort.pl in Koha 3 I see the follow cryptic comment: # Please use 8-character tabs for this file (indents are every 4 characters) Does this mean that tabs should not be used for indentation, since a tab would indent 8 character positions in the source? Does this imply that we

Re: [Koha-devel] HTML::Template::Pro problems?

2008-11-12 Thread Galen Charlton
Hi John, On Wed, Nov 12, 2008 at 4:55 PM, Chadwick, John, DCA <[EMAIL PROTECTED]> wrote: > [Wed Nov 12 08:51:37 2008] [error] [client x] HTML::Template::Pro:in > TMPL_IF at pos 2399:end tag:found e instead of > at pos 2425 I've submitted a patch for this particular error (see bug 2779). Rega

[Koha-devel] HTML::Template::Pro problems?

2008-11-12 Thread Chadwick, John, DCA
We are having some search problems (keyword search doesn't work) when we configure default.idx to use the icu.xml file to handle diacritics. Koha 3.01.00.002 on Ubuntu 8.04. Zebra 2.0.34 I am noticing some interesting errors in the koha-opac-error_log file: [Thu Nov 06 11:47:19 2008] [e

Re: [Koha-devel] "New Thing" or "New thing"

2008-11-12 Thread Joshua Ferraro
On Wed, Nov 12, 2008 at 9:39 AM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Hi, > > On Wed, Nov 12, 2008 at 4:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: >> Do we (mainly owen ?) have a rule for uppercase & lower case ? >> something like : >> - in button, each word has ucfirst >> - otherwise, o

Re: [Koha-devel] "New Thing" or "New thing"

2008-11-12 Thread Galen Charlton
Hi, On Wed, Nov 12, 2008 at 4:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Do we (mainly owen ?) have a rule for uppercase & lower case ? > something like : > - in button, each word has ucfirst > - otherwise, only the 1st word has ucfirst I don't think that's been standardized, but I think it

[Koha-devel] "New Thing" or "New thing"

2008-11-12 Thread Paul POULAIN
In most parts of Koha strings have a lot of ucfirt on each word : New Item Type, Modify Branch, Edit Permissions some times, it's written in a most classic syntax : New item type, Modify branch, Edit permissions Do we (mainly owen ?) have a rule for uppercase & lower case ? something like : - in

Re: [Koha-devel] [RFC ver2 4/4] DBIx::Class - Changes to C4::Members to start using DBIx::Class

2008-11-12 Thread Paul POULAIN
Rick Welykochy a écrit : > Ryan Higgins wrote: > >> I am guessing that this reveals a lack of fk defs in our base schema in >> this module. >> While this may seem like a real pain, and seem to raise the bar, so to >> speak, in terms >> of the amount of effort required to adopt an ORM, I think th