Re: [Koha-devel] RFC 3.2: stop copying item data to MARC and MARCXML

2008-09-30 Thread Ryan Higgins
Oops -- hit send instead of save :/ to complete my thought : On Tue, Sep 30, 2008 at 1:36 PM, Ryan Higgins <[EMAIL PROTECTED]>wrote: > > Yes, this will be a significant change, but one I think is necessary. > It will only be more difficult to test later when more features are added. > > Serial

Re: [Koha-devel] RFC 3.2: stop copying item data to MARC and MARCXML

2008-09-30 Thread Ryan Higgins
Yes, this will be a significant change, but one I think is necessary. It will only be more difficult to test later when more features are added. Serial records become unmanageable when they On Tue, Sep 30, 2008 at 8:26 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Galen Charlton a écrit : > > >

Re: [Koha-devel] koha code cleaning bug?

2008-09-30 Thread Galen Charlton
Hi, On Tue, Sep 30, 2008 at 3:59 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > Marc Chantreux <[EMAIL PROTECTED]> wrote: >> $_ is not the only one point that can confuse the code reader so i also >> ban for my code: [...list of useful things...] > > That would be a shame. I've seen at least one of the

Re: [Koha-devel] RFC 3.2: stop copying item data to MARC and MARCXML

2008-09-30 Thread Paul POULAIN
Galen Charlton a écrit : > Consequently, I propose the following changes, in order of priority: > > 1. Take item data out of biblioitems.marc*. Instead, whenever item > records need to be embedded in a MARC bib record (primarily during > Zebra indexing or record export), do it on the fly. If a

Re: [Koha-devel] koha code cleaning bug?

2008-09-30 Thread Paul POULAIN
Galen Charlton a écrit : > Hi, > > On Mon, Sep 29, 2008 at 2:42 PM, Marc Chantreux > <[EMAIL PROTECTED]> wrote: >> On Mon, Sep 29, 2008 at 10:03:19AM -0500, Galen Charlton wrote: perl 5.10 makes $_ lexical and add the (_) prototype. It would be sad to not use it imho. >>> Which is fine,

Re: [Koha-devel] koha code cleaning bug?

2008-09-30 Thread Chris Nighswonger
On Mon, Sep 29, 2008 at 12:43 PM, Joe Atzberger <[EMAIL PROTECTED]> wrote: > > > On Mon, Sep 29, 2008 at 11:03 AM, Galen Charlton > <[EMAIL PROTECTED]> wrote: >> >> Hi, >> >> On Mon, Sep 29, 2008 at 9:42 AM, Marc Chantreux >> <[EMAIL PROTECTED]> wrote: >> > do you think that: >> > >> > for my $var

Re: [Koha-devel] koha code cleaning bug?

2008-09-30 Thread MJ Ray
Marc Chantreux <[EMAIL PROTECTED]> wrote: > I don't want another koha developper to loose some time to read code > just because i gain some time to write it (i don't want to blame myself > for it). Using perl stuff makes sense if everyone does it and even if it > will be officially recommanded by t

Re: [Koha-devel] koha code cleaning bug?

2008-09-30 Thread Marc Chantreux
On Mon, Sep 29, 2008 at 03:27:52PM -0500, Galen Charlton wrote: > We could, but it regardless of the decision, it would be of little > practical effect unless it turns out people *really* care one way or > the other. You know my opinion on the use of $_ as an implicit > iterator, but I would not u