[Koha-devel] Tidy your code! And run the QA script!

2023-07-13 Thread Tomas Cohen Arazi
Hi all. I've been trying to push as much as I can from the PQA queue, and I'm finding that most of the patches haven't been tidied up yet or have trivially caught issues (maybe not most, but a lot). For example, this is what I find when I run an up to date KTD and the code is not tidy: ``` kohade

Re: [Koha-devel] Tidy your code! And run the QA script!

2023-07-13 Thread Marcel de Rooy
Great job, Tomas. Keep pushing; your queue is not empty yet 😉 As this is the first mention about requiring perl tidied code, I would assume that we will be enforcing it (as QA team) only on code that was submitted from now on. And we need some common sense too imo. We shouldnt reject patches onl