Re: [Koha-devel] Good enough?

2022-12-05 Thread Marcel de Rooy
Could you provide more info on those git hooks? A wiki URL? Marcel -Original Message- From: Koha-devel On Behalf Of Jonathan Druart Sent: Friday, December 2, 2022 3:43 PM To: koha-devel Subject: [Koha-devel] Good enough? Hi devs, I was wondering... How good is your "good enough"? It'

Re: [Koha-devel] Good enough?

2022-12-05 Thread Jonathan Druart
I don't think we should run the whole test suite everytime we attach patches, that would be very expensive in terms of resources. However it would be interesting to have a temporary 'master' branch that would become 'master' only if jenkins is happy. "master" would never be broken :D Using koha-te

Re: [Koha-devel] Good enough?

2022-12-05 Thread Jonathan Druart
Existing hooks can be found at https://wiki.koha-community.org/wiki/Tips_and_tricks#Hooks Le lun. 5 déc. 2022 à 11:34, Marcel de Rooy a écrit : > > Could you provide more info on those git hooks? A wiki URL? > > Marcel > > -Original Message- > From: Koha-devel On Behalf Of > Jonathan Dr

Re: [Koha-devel] Good enough?

2022-12-05 Thread Marcel de Rooy
Thanks for sending this link. Could we merge that code with QA code we already pushed into our codebase somehow ? -Original Message- From: Koha-devel On Behalf Of Jonathan Druart Sent: Monday, December 5, 2022 2:56 PM To: koha-devel Subject: Re: [Koha-devel] Good enough? Existing hook

Re: [Koha-devel] Good enough?

2022-12-05 Thread Paul Poulain
From what Julian write, I don't think he's suggesting running jenkins every type a patch is attached, but more something where a developper could send a message "hey, bot, can you check if this patch passes all tests ?". that would be manual (and I have no idea how to do that ;) My 1 cent (not

Re: [Koha-devel] Good enough?

2022-12-05 Thread Tomas Cohen Arazi
El vie, 2 dic 2022 a las 11:43, Jonathan Druart (< jonathan.dru...@bugs.koha-community.org>) escribió: > 10. CI should drive the pushes. No more push if CI is not green. The > more we wait the harder it is to track down the origin of the problem. > Last cycle some jobs have been red for months, an

[Koha-devel] Setting up Koha Testing Docker

2022-12-05 Thread Lamancusa, Emily
Hello all, I'm trying to set up a Koha Testing Docker on my local machine (running Pop!_OS 22.04). I haven't used Docker before, and I have a few questions about how to get it set up. 1. It looks like Linux users have the option to install the whole Docker Desktop VM, or install just Docker En

Re: [Koha-devel] Good enough?

2022-12-05 Thread Jonathan Druart
As said in the email I am planning to integrate them into our dev env (via misc4dev), see https://gitlab.com/koha-community/koha-misc4dev/-/issues/59 Le lun. 5 déc. 2022 à 15:17, Marcel de Rooy a écrit : > > Thanks for sending this link. > Could we merge that code with QA code we already pushed i

Re: [Koha-devel] Setting up Koha Testing Docker

2022-12-05 Thread Nick Clemens
1 - On Linux you do not need Docker Desktop - I have docker.io and docker-compose - I set this up long ago, so don't remember the steps, but you should not require a licence 2 - That is up to you. For editing code I think most developers use an IDE or something outside the docker container - I pers

Re: [Koha-devel] Setting up Koha Testing Docker

2022-12-05 Thread Amorim, Pedro
Hi Emily, Nick already laid it all out pretty well but just to add to it: My suggestion would be to follow the instructions at koha-testing-docker https://gitlab.com/koha-community/koha-testing-docker which also include docker instructions links. You will end up with 2 directories, one for k-t-d a

Re: [Koha-devel] Good enough?

2022-12-05 Thread Julian Maurice
Yes it is expensive. But manual testing is much more expensive. I'd rather pay for some CPU time than do manually what a bot can do better and faster than me. Free services exist too (CircleCI, github actions, ...) Pushing to a temporary master branch is not a bad idea (a never-broken master b

Re: [Koha-devel] Good enough?

2022-12-05 Thread Jonathan Druart
Having the hooks installed automatically will help devs catch small inconsistencies, that's a first step for the easy-to-catch things. The run_tests.pl script in misc4dev will hopefully help to run the tests by anybody. Running the tests on a DB without the sample data or with existing data is al

Re: [Koha-devel] Good enough?

2022-12-05 Thread Tomas Cohen Arazi
El lun, 5 dic 2022 a las 14:24, Julian Maurice () escribió: > Yes it is expensive. But manual testing is much more expensive. I'd > rather pay for some CPU time than do manually what a bot can do better > and faster than me. Free services exist too (CircleCI, github actions, ...) > When you devel

[Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread David Cook
Hi all, Just wondering if my email titled “x-koha-query header doesn't support UTF-8 data” actually made it to the koha-devel list as I didn’t get any replies to what I perceive as a significant issue. Basically, the x-koha-query header can only support ISO 8859-1/Latin-1 encoded characters

Re: [Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread Galen Charlton
Hi, On Mon, Dec 5, 2022 at 5:40 PM David Cook wrote: > At the moment, it’s not widely used by Koha itself, so I don’t think > it will be hard to remove from Koha, but any third-party integrations > would need to refactor to use a different option. This might not be a huge factor, though of cours

Re: [Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread Tomas Cohen Arazi
I recall we used the header at some point, to keep the base query clean when adding new filters. The only alternative is forcing the use of some form of ascii encoding (base64?) But I agree we should better deprecate it. It's use in the codebase on DT is tied to an option switch and probably not

Re: [Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread David Cook
Perhaps Bug 30165 allowing multiple “q” parameters would provide an alternative as well? In the DataTables, it looks like it’s used for receiving acquisitions and something with POS registers. In master, the acquisitions issue is solved by turning off that option switch. (Although in ol

Re: [Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread David Cook
Btw looks like Bug 30165 is what resolves the UTF-8 issue for the orders route… David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: David Cook Sent: Tuesday, 6 December 20

[Koha-devel] Maximum execution time for background jobs?

2022-12-05 Thread David Cook
Hi all, I was closing old Bugzilla bugs when I bumped into "Bug 10460 - way to stop a run away report". It got me thinking about maximum execution time for background jobs. What do people think about background jobs workers killing their child processes if they exceed a maximum execution ti

[Koha-devel] Formally give up on trying to provide PostgreSQL DB support?

2022-12-05 Thread David Cook
Hi all, Should we formally give up on trying to provide PostgreSQL support? I find it highly unlikely that we will ever provide it. We may as well close issues like the following: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 https://bugs.koha-community.org/bugzilla3