[Koha-devel] Price format in order by email

2018-10-24 Thread Holger Meissner
Dear koha devs, when we send an order by email <> is formatted with decimal point and six decimal places, in spite of syspref CurrencyFormat set to EUR. Is anyone working on this? Is there some kind of workaround? koha version 17.11.10.000. Thanks, Holger _

[Koha-devel] Koha 17.11.11 release

2018-10-24 Thread Fridolin SOMERS
The Koha community is proud to announce the release of Koha 17.11.11. This is a maintenance release. The full release notes are available at https://koha-community.org/koha-17-11-11-release/ Debian packages will be upgraded in a few days. I've proposed to continue maitaining 17.11.x in Koha

Re: [Koha-devel] Price format in order by email

2018-10-24 Thread Barton Chittenden
I'm guessing that this could be fixed using template toolkit in the notice, but I don't know the syntax off hand. On Wed, Oct 24, 2018, 6:38 AM Holger Meissner < holger.meiss...@hs-gesundheit.de> wrote: > Dear koha devs, > > when we send an order by email <> is formatted with > decimal point and

Re: [Koha-devel] Price format in order by email

2018-10-24 Thread Holger Meissner
Thank you, Barton! [%- USE Price -%] [% <> | $Price %] did the trick :) ___ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : ht

Re: [Koha-devel] Price format in order by email

2018-10-24 Thread Jonathan Druart
Indeed, you should use the TT syntax, but not both :) Can you try the following instead: [%- USE Price -%] [% order | $Price %] You certainly need to loop on "orders" before. On Wed, 24 Oct 2018 at 12:08 Holger Meissner < holger.meiss...@hs-gesundheit.de> wrote: > Thank you, Barton! > > [%- US

[Koha-devel] The order of "use"

2018-10-24 Thread Mark Tompsett
Greetings, I was looking at bug 21641, and noticed the patch was explicitly stating C4::Accounts:: on the function in question. I vaguely recalled this sort of symptom shows itself in a knotted “use” mess. C4::Circulation –> C4::Members –> C4::Accounts C4::Circulation –> C4::Accounts C4::Circul

Re: [Koha-devel] The order of "use"

2018-10-24 Thread Jonathan Druart
See commit ce96080f3005be5a63c9f2cab8d4b6c81e9b5b27 Bug 21133: Fix use statements order On Wed, 24 Oct 2018 at 13:42 Mark Tompsett wrote: > Greetings, > > I was looking at bug 21641, and noticed the patch was explicitly stating > C4::Accounts:: on the function in question. I vaguely recalle

Re: [Koha-devel] The order of "use"

2018-10-24 Thread David Cook
Whether or not to prefix the function with "C4::Accounts::" is something we should probably talk about at some point. Historically, a lot of Koha modules use the "Exporter" module to export their functions into the main namespace of the caller. When "use C4::Accounts" runs, it automatically ca

Re: [Koha-devel] The order of "use"

2018-10-24 Thread Jonathan Druart
"At some point", yes... *Bug 8244* - Script to find exporter problems *Bug 17600* - Standardize the EXPORT On Wed, 24 Oct 2018 at 20:24 David Cook wrote: > Whether o

Re: [Koha-devel] The order of "use"

2018-10-24 Thread David Cook
I meant on koha-devel, but here we are now. Ahh I see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600#c82. It is frustrating when we don’t get the feedback for which we’re hoping. I actually don’t monitor the Koha Bugs List listserv as the volume is just too high(I’m 55,

Re: [Koha-devel] The order of "use"

2018-10-24 Thread Jonathan Druart
"What's on in koha-devel", #8 and #9 :) On Wed, 24 Oct 2018 at 21:38 David Cook wrote: > I meant on koha-devel, but here we are now. > > > > Ahh I see > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600#c82. It > is frustrating when we don’t get the feedback for which we’re hoping.

Re: [Koha-devel] The order of "use"

2018-10-24 Thread David Cook
Touché! I’ll endeavour to read those more attentively! I never go to meetings as they don’t work for my timezone, but surely I could read these emails more carefully. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 089