[Koha-devel] Generic OpenIDConnect client

2018-10-17 Thread David Cook
Hi all, About 4 years ago, I wrote a generic OpenIDConnect client, and kept telling myself that I would upstream it but I never did. until now: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586. I wrote it for 1 specific client, so it exists heavily in a set of "Prosentient"

[Koha-devel] Is finesMode = test still operational and sending emails?

2018-10-17 Thread Magnus Enger
Hi! The help of the cronjob fines.pl says: This script calculates and charges overdue fines to patron accounts. The Koha system preference 'finesMode' controls whether the fines are calculated and charged to the patron accounts ("Calculate and charge"); calculated and emailed to the admin but not

Re: [Koha-devel] Generic OpenIDConnect client

2018-10-17 Thread Tomas Cohen Arazi
David, it is nice to see your code submitted! I implemented a generic prototype too, based on the current code for Google's. At that point the doubts I had were about how to inject new routes for the callback. But that's solved the way we did in bug 21116. I didn't submit my prototype because: -

Re: [Koha-devel] Generic OpenIDConnect client

2018-10-17 Thread Mark Tompsett
Greetings, tcohen wrote in response to dcook’s request for feedback: > - I had the feeling this should be done with plugins. > Because every implementation has its details that make them less compatible > with the other. I concur with this idea. Tangentially, it would also make refactoring auth

Re: [Koha-devel] Generic OpenIDConnect client

2018-10-17 Thread Tomas Cohen Arazi
We would still need to refactor and modularize auth El mié., 17 de oct. de 2018 12:00, Mark Tompsett escribió: > Greetings, > > tcohen wrote in response to dcook’s request for feedback: > > - I had the feeling this should be done with plugins. > > Because every implementation has its details tha

[Koha-devel] Master broken by 20521 (sql modes)

2018-10-17 Thread Jonathan Druart
Hi devs, I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell). I am working on fixing the different

Re: [Koha-devel] Master broken by 20521 (sql modes)

2018-10-17 Thread Katrin Fischer
Hi all, I guess this effects the sandboxes as well? This afternoon and tomorrow morning is a hackday in Sweden and I was hoping for some sign-offs! Katrin On 18.10.18 01:38, Jonathan Druart wrote: Hi devs, I quick email to let you know that master and tests are (completely) broken because