Re: [Koha-devel] Migrate/Upgrade from 2.2.3 to latest.

2016-09-14 Thread Jonathan Druart
These errors are fixes by 3.01.00.009, certainly because MySQL strictness has changed since 3.00.00.068 Try to change the 2 code columns to default null. If it works, please open a new bug report (and attach a patch if you know how to do it :)) Cheers, Jonathan 2016-09-13 16:34 GMT+01:00 Rodrigo

Re: [Koha-devel] Coding patterns discussion

2016-09-14 Thread Jonathan Druart
Hi, We used to have problems with transactions, if they were used from the a subroutine/method which was called from tests (which use transactions as well), it did not work. Two transactions could not be started together. Now that we are using DBIx::Class transactions it works correctly and we wil

[Koha-devel] What's on in Koha devel #4

2016-09-14 Thread Jonathan Druart
Hi devs, No new topic this month. Please see bellow the progress of the regular ones. = Security issues = They are almost all pushed. Please see the following 2 omnibus to know what is left: bug 14568 - [OMNIBUS] XSS in Staff Client bug 17096 - [OMNIBUS] CSRF protections = Caching system = Last

Re: [Koha-devel] Migrate/Upgrade from 2.2.3 to latest.

2016-09-14 Thread Rodrigo Santellan
Jonathan, I'm planning to open a bug report and patches when I finish. Don't want open more than one bug. I'm adjusting some SQL that are not ok. Regards On Wed, Sep 14, 2016 at 4:16 AM, Jonathan Druart < jonathan.dru...@bugs.koha-community.org> wrote: > These errors are fixes by 3.01.00.009,

Re: [Koha-devel] What's on in Koha devel #4

2016-09-14 Thread Tomas Cohen Arazi
Hi, nice overview again, Jonathan! El mié., 14 sept. 2016 a las 6:40, Jonathan Druart (< jonathan.dru...@bugs.koha-community.org>) escribió: > > = RESTful API = > Last month I have asked some general questions about the RESTful API > and the different patches waiting for QA/SO. > I did not receiv

Re: [Koha-devel] Coding patterns discussion

2016-09-14 Thread Tomas Cohen Arazi
El mié., 14 sept. 2016 a las 4:58, Jonathan Druart (< jonathan.dru...@bugs.koha-community.org>) escribió: > Hi, > > We used to have problems with transactions, if they were used from the > a subroutine/method which was called from tests (which use > transactions as well), it did not work. > Two tr

[Koha-devel] Circulation rule update

2016-09-14 Thread Cybermon
Dear All, Actually, I was updated Koha circulation rules. But not changed default_branch_circ_rules field of database. How can I update from 3 to 10 default_branch_circ_rules fields ? Please see below library rules from mysql database. mysql> select * from default_borrower_circ_rules; +--

Re: [Koha-devel] Migrate/Upgrade from 2.2.3 to latest.

2016-09-14 Thread Rodrigo Santellan
I have almost complete the updatadatabase.pl without db errors. Now I'm missing some data on userflags, what should be the 13 module_bit Upgrade to 3.00.00.067 done (Updating patronimages syspref to reflect current kohastructure.sql. ) DBD::mysql::db do failed: Cannot add or update a child row: a

Re: [Koha-devel] Migrate/Upgrade from 2.2.3 to latest.

2016-09-14 Thread Michael Hafen
module_bit 13 is for tools. From installer/data/mysql/userflags.sql : INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES (13,'tools','Use all tools (expand for granular tools permissions)',0); On Wed, Sep 14, 2016 at 1:10 PM, Rodrigo Santellan wrote: > I have almost complete the upd

Re: [Koha-devel] Migrate/Upgrade from 2.2.3 to latest.

2016-09-14 Thread Rodrigo Santellan
I truncate the tables and try to use the: userpermissions.sql file. My problem is that code is defined like varchar(30) on update "3.00.00.068" but on http://schema.koha-community.org/tables/permissions.html is a varchar(64) I assume the later is the correct. When was this changed? Regards. On W

Re: [Koha-devel] Curiosity why is cardnumber field size 16?

2016-09-14 Thread Mark Tompsett
Greetings, Thanks, Marc V. for the bugzilla link. I’ve added an amendment to that bug which should make a separate “resize the cardnumber” bug very simple (Yes, +1 to the idea of increasing its size). Feel free to test bug 15690. Look at a preference and run a prove. Not very hard. https://bugs

Re: [Koha-devel] Coding patterns discussion

2016-09-14 Thread David Cook
After reviewing http://search.cpan.org/~ether/Try-Tiny-0.27/lib/Try/Tiny.pm, I’d add a semi-colon to the end of that sample code, since catch {} apparently is just an argument to try(): “catch (&;@) Intended to be used in the sec