Re: [Koha-devel] feature for bugzilla ?

2016-02-10 Thread Julian Maurice
For those who use it and didn't notice, it stopped working because of the Bugzilla transition from http to https. You'll need the latest version to continue to use it. Le 05/01/2016 14:03, Julian Maurice a écrit : > Here's a slightly different version: http://pastebin.com/3kwqszbH > Changes: > - O

Re: [Koha-devel] Introduce the use of Grunt or Gulp?

2016-02-10 Thread Owen Leonard
> Jake [2] *is* packaged for Debian -- would that work for you as an > alternative, Owen? After a quick look at Jake I'm concerned that it is not as fully-featured or well-documented than Grunt or Gulp. The wider adoption of Grunt and Gulp mean that there is a more vibrant array of plugins for eac

[Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Jonathan Druart
Hi devs, I have a very bad news... Working on bug 15715, I have found that the patchset introduced by bug 13618 (Prevent XSS in the Staff Client and the OPAC) causes a very important performance issue. Indeed, for each variable displayed in the template, a Template::Stash::AutoEscaping->get metho

Re: [Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Marcel de Rooy
Too bad, especially since we already have performance issues.. I would go for option 1 part a = revert. (It is one of the last pushes, I think.) And some further research on 2,3 or 4 ? :) Van: koha-devel-boun...@lists.koha-community.org [koha-devel-boun..

[Koha-devel] NorwegianPatronDB

2016-02-10 Thread Philippe Blouin
Hi! I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::*NorwegianPatronDB* at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::*NorwegianPatronDB* at /blurred/

Re: [Koha-devel] NorwegianPatronDB

2016-02-10 Thread David Cook
I think you're right, Philippe. I've noticed the same thing. In fact, the "Unable to load Koha::NorwegianPatronDB" was added after the fact to stop the absence of those libraries causing Koha to die. I don't necessarily see the point of having that warning there though, as most Koha users

Re: [Koha-devel] Introduce the use of Grunt or Gulp?

2016-02-10 Thread Galen Charlton
Hi, On Wed, Feb 10, 2016 at 9:35 AM, Owen Leonard wrote: > After a quick look at Jake I'm concerned that it is not as > fully-featured or well-documented than Grunt or Gulp. I agree, although for the specific purpose of compiling LESS, minifying Javascript (and doing that dynamically for the pur

Re: [Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Brendan Gallagher
I have been slow to push anything much since I pushed that big one to give a little time. I can revert that patch set which is still an option On Wednesday, February 10, 2016, Marcel de Rooy wrote: > Too bad, especially since we already have performance issues.. > I would go for option 1 part a

Re: [Koha-devel] NorwegianPatronDB

2016-02-10 Thread Mark Tompsett
Greetings, It seems that “$debug && warn” is a popular style used in C4/Member already. I don’t think a system preference is needed. Just a $debug prepend, perhaps? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Sign it off, kill it, suggest a counter-patch, whatever. I do think

Re: [Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Mark Tompsett
Greetings, Jonathan Druart wrote: Indeed, for each variable displayed in the template, a Template::Stash::AutoEscaping->get method is called. ... and then, in the template +[% FOR l IN loop %] +[% l.foo %] [% l.bar %] + +[% END %] It will display 10k foo and 10k bar There are indeed 2

Re: [Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Chris Cormack
* Mark Tompsett (mtomp...@hotmail.com) wrote: > Greetings, > > Jonathan Druart wrote: > >Indeed, for each variable displayed in the template, a > >Template::Stash::AutoEscaping->get method is called. > ... > >and then, in the template > >+[% FOR l IN loop %] > >+[% l.foo %] [% l.bar %] > >+

Re: [Koha-devel] Huge performance issue cause by bug 13618 (XSS)

2016-02-10 Thread Renvoize, Martin
Interestingly enough there was recently a long debate about xss escaping over in the Mojo irc channel. They obviously have their own temptation engine which uses Mojo::DOM in parts (which includes the xss_escape code). I'm envisioning the we'll end up needing to do that digging into Template::Stas