Re: [Koha-devel] Test: planned count or done_testing()

2017-11-26 Thread Jonathan Druart
I do not think it's a good idea, it can hide bugs [examples needed] > We can always add a count where we really want it. When do you know it is needed? :) We could also use use Test::More plan => $number_of_tests; BEGIN{ $number_of_tests += 1 }; subtest "first subtest" => sub { ok(); } BEGIN{ $n

Re: [Koha-devel] Test: planned count or done_testing()

2017-11-16 Thread Kyle Hall
+1 from me as well! Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadv

Re: [Koha-devel] Test: planned count or done_testing()

2017-11-15 Thread Indranil Das Gupta
+1 from me. -- Indranil Das Gupta L2C2 Technologies Phone : +91-98300-20971 Blog: http://blog.l2c2.co.in IRC : indradg on irc://irc.freenode.net Twitter : indradg On Thu, Nov 16, 2017 at 12:29 PM, Mason James wrote: > > On 14/11/17 05:43, Mark Tompsett wrote: > > Greetings, > > Whil

Re: [Koha-devel] Test: planned count or done_testing()

2017-11-15 Thread Mason James
On 14/11/17 05:43, Mark Tompsett wrote: > Greetings, >   > While testing various bugs, frequently conflicts come up with tests > where one bug adds a test, and another adds two tests, and the count > difference causes the need to correct the test plan count while > rebasing. So, I was wondering if

Re: [Koha-devel] Test: planned count or done_testing()

2017-11-15 Thread Marcel de Rooy
Less strict, but more pragmatic. I think we spend more time on rebasing test counts than we will probably spend on checking tests that passed but should have failed on counts. We can always add a count where we really want it. No objection from me. _