Re: [Koha-devel] QA script - New check for spelling

2015-07-08 Thread Marcel de Rooy
> Done. Now the script warn instead of die and mark the test "spelling" > as skipped. Great. Thanks. ___ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://ww

Re: [Koha-devel] QA script - New check for spelling

2015-07-08 Thread Jonathan Druart
See man codespell: --dictionary=FILE Custom dictionary file that contains spelling corrections. If this flag is not specified then default dictionary "/usr/share/codespell/dictionary.txt" is used. So it's possible to provide a customi(s|z)ed file for our need. Note that grep -P "colou?r" /usr/s

Re: [Koha-devel] QA script - New check for spelling

2015-07-08 Thread Jonathan Druart
2015-06-25 13:53 GMT+01:00 Marcel de Rooy : >> Maybe the script should not process this check if codespell is not >> installed. Patch welcomed ;-) > > Sorry, but I would rather prefer that you wrote that patch ;) Done. Now the script warn instead of die and mark the test "spelling" as skipped. >>

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Mark Tompsett
Greetings, Marcel de Rooy wrote: We should spend our QA time on the code not the spelling of comments. I don’t know about you, but how often do you comment your code? Next, perldoc’ing is already validated. Spelling is only a minor step past that. Not that I support the spelling check, but I

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Marcel de Rooy
> Maybe the script should not process this check if codespell is not installed. > Patch welcomed ;-) Sorry, but I would rather prefer that you wrote that patch ;) > It's in test for the moment, we will see if the number of false positive is > high or not. Why do you worry about them? We should

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Mark Tompsett
Greetings, Christopher nighswongerchris.nighswon...@gmail.com wrote: > Of course if we stick to using US English (or whatever, really) > as the default, that should really not be an issue. Agreed. > Seems like we've been down this road before. This patch makes the road more apparent. This may or ma

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Mark Tompsett
Greetings, Jonathan Druart wrote: It's in test for the moment, we will see if the number of false positive is high or not. Why do you worry about them? I’m sure Mr. Colorful Colour will help explain why color and other words like it might be an issue, neighbour. :) Your friendly neighborho

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Jonathan Druart
Maybe the script should not process this check if codespell is not installed. Patch welcomed ;-) It's in test for the moment, we will see if the number of false positive is high or not. Why do you worry about them? On 25 Jun 2015 09:06, "Marcel de Rooy" wrote: > There is no package for codespell

Re: [Koha-devel] QA script - New check for spelling

2015-06-25 Thread Marcel de Rooy
There is no package for codespell on Wheezy. But I would like to keep using the qa script :) I am not sure if we should check spelling in QA and/or spend time on false negatives too.. -Oorspronkelijk bericht- Van: koha-devel-boun...@lists.koha-community.org [mailto:koha-devel-boun...@li