Re: [Koha-devel] A case against some uses of C4::Context->userenv

2019-09-30 Thread Michael Hafen
> Office: 02 9212 0899 > > Direct: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Renvoize, Martin > *Sent:* Saturday, 28 September 2019 3:14 AM > *To:* Tomas Cohen Arazi > *Cc:* koha-devel > *Subject:* Re: [Koha-devel] A case against some uses of &g

Re: [Koha-devel] A case against some uses of C4::Context->userenv

2019-09-29 Thread dcook
2019 3:14 AM To: Tomas Cohen Arazi Cc: koha-devel Subject: Re: [Koha-devel] A case against some uses of C4::Context->userenv I generally agree here, I'd rather explicitly pass things like this into objects on instantiation and die if they're not present.. that way we catch cas

Re: [Koha-devel] A case against some uses of C4::Context->userenv

2019-09-28 Thread Marcel de Rooy
gratis Please think before you print Van: Koha-devel namens Renvoize, Martin Verzonden: vrijdag 27 september 2019 19:13 Aan: Tomas Cohen Arazi CC: koha-devel Onderwerp: Re: [Koha-devel] A case against some uses of C4::Context->userenv I generally agree here, I'd rather explici

Re: [Koha-devel] A case against some uses of C4::Context->userenv

2019-09-27 Thread Renvoize, Martin
I generally agree here, I'd rather explicitly pass things like this into objects on instantiation and die if they're not present.. that way we catch cases of missing environments early and as you state, userenv harks back the CGI days and we should generally be moving forward and away from those p