Re: [Koha-devel] Suggestion: create a deprecated() function in Koha.

2018-06-25 Thread Jonathan Druart
Hi Barton, I usually follow the same pattern for the commit messages when I remove a subroutine from C4. We could list them (something like `git log|grep "Move (.*) to Koha::*"`) for each release then provide a script to catch removed subroutine. However it will not help to know in advance (versio

Re: [Koha-devel] Suggestion: create a deprecated() function in Koha.

2018-06-25 Thread Renvoize, Martin
I've seen this sort of thing in a few projects and it works reasonably nicely.. though I'm not sure how it would work in Koha as we seem to replace all calls to a function and remove the function at the same time. If we did switch to this approach I'd suggest adding code to allow it to report to H

[Koha-devel] Suggestion: create a deprecated() function in Koha.

2018-06-22 Thread Barton Chittenden
It would be useful for Koha to have a 'Deprecated' function, which would send a warning about the caller() function and the version of Koha where the function will be deprecated, and what it will be replaced by... so let's say that C4::Adequate::DoEET() is being replaced by Koha::Awesome->sauce().