Re: [Koha-devel] Signing-off a patch for a customer

2012-05-30 Thread Magnus Enger
On 30 May 2012 02:38, Chris Cormack wrote: > On 30 May 2012 12:30, Chris Nighswonger wrote: >> On Tue, May 29, 2012 at 11:12 AM, Ian Walls wrote: >>> >>> To me, the role of QA is to be highly conservative.  The QA team needs to >>> look at a piece of incoming code, and not only judge it on how w

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Chris Cormack
On 30 May 2012 12:30, Chris Nighswonger wrote: > On Tue, May 29, 2012 at 11:12 AM, Ian Walls wrote: >> >> To me, the role of QA is to be highly conservative.  The QA team needs to >> look at a piece of incoming code, and not only judge it on how well it does >> it's intended purpose, but how it a

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Chris Nighswonger
On Tue, May 29, 2012 at 11:12 AM, Ian Walls wrote: > To me, the role of QA is to be highly conservative. The QA team needs to > look at a piece of incoming code, and not only judge it on how well it does > it's intended purpose, but how it affects all the other code and workflows > that surround

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Ian Walls
To me, the role of QA is to be highly conservative. The QA team needs to look at a piece of incoming code, and not only judge it on how well it does it's intended purpose, but how it affects all the other code and workflows that surround it. The folks creating and signing off on code are often lo

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Paul Poulain
Le 29/05/2012 13:50, Marcel de Rooy a écrit : > I agree with most responses in this thread: If a company makes a patch, a > customer of that company signs off, > it should not be QAed by that company, but by a "neutral" party. > The QAer should even be allowed to ask for a second outside signoff

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Marcel de Rooy
Van: koha-devel-boun...@lists.koha-community.org [koha-devel-boun...@lists.koha-community.org] namens Kyle Hall [kyle.m.h...@gmail.com] Verzonden: dinsdag 29 mei 2012 12:30 To: Dobrica Pavlinusic Cc: koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] Signing-off a patch for a customer I

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Kyle Hall
I am also of the mind the sign-off should be allowed by another employee of the same organization as the developer, provided they signer has no history of signing off on patches without testing. I do strongly also believe that QA must then be done by a disinterested party. Kyle On Tue, May 29, 20

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Chris Cormack
On 29 May 2012 21:24, Dobrica Pavlinusic wrote: > On Tue, May 29, 2012 at 10:00:12AM +0200, Paul Poulain wrote: >> Le 29/05/2012 09:50, Nicole Engard a écrit : >> > Just to add in my opinion here. >> > >> > As someone who has been in Paul's situation, where a library (that has >> > paid us to writ

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Dobrica Pavlinusic
On Tue, May 29, 2012 at 10:00:12AM +0200, Paul Poulain wrote: > Le 29/05/2012 09:50, Nicole Engard a écrit : > > Just to add in my opinion here. > > > > As someone who has been in Paul's situation, where a library (that has > > paid us to write them code) has been testing (and sometimes using the

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Paul Poulain
Le 29/05/2012 09:50, Nicole Engard a écrit : > Just to add in my opinion here. > > As someone who has been in Paul's situation, where a library (that has > paid us to write them code) has been testing (and sometimes using the > code in production) and has confirmed that things work I agree that >

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-29 Thread Nicole Engard
Just to add in my opinion here. As someone who has been in Paul's situation, where a library (that has paid us to write them code) has been testing (and sometimes using the code in production) and has confirmed that things work I agree that putting a sign off in their name should be an okay practi

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Chris Cormack
On 29 May 2012 07:58, Chris Cormack wrote: > > On May 29, 2012 4:30 AM, "Paul Poulain" wrote: >> >> Le 28/05/2012 18:14, Chris Nighswonger a écrit : >> >> > Have them use *french* then... or whatever language they are comfortable >> > in. There are enough resources to handle translation around he

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Chris Cormack
On May 29, 2012 4:30 AM, "Paul Poulain" wrote: > > Le 28/05/2012 18:14, Chris Nighswonger a écrit : > > > Have them use *french* then... or whatever language they are comfortable > > in. There are enough resources to handle translation around here I think. > > Does BZ have a multi-lingual interfac

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Paul Poulain
Le 28/05/2012 18:14, Chris Nighswonger a écrit : > Have them use *french* then... or whatever language they are comfortable > in. There are enough resources to handle translation around here I think. > Does BZ have a multi-lingual interface? Yes it does. although the quality was quite average la

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Paul Poulain
Le 28/05/2012 18:16, Chris Nighswonger a écrit : > On Mon, May 28, 2012 at 11:46 AM, Jared Camins-Esakov > mailto:jcam...@cpbibliography.com>> wrote: > Having things scripted so that anyone on a sandbox can sign-off both in > BZ and git would be spectacular. Perhaps authentication could be > coordi

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Chris Nighswonger
On Mon, May 28, 2012 at 11:46 AM, Jared Camins-Esakov < jcam...@cpbibliography.com> wrote: > > I don't want to break the rule. I just request that 3 identified ppl >> from BibLibre can sign-off in the name of the customer (I like the Proxy >> term). >> > > In case this wasn't clear, I have absolut

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Chris Nighswonger
On Mon, May 28, 2012 at 12:08 PM, Paul Poulain wrote: > Le 28/05/2012 17:46, Jared Camins-Esakov a écrit : > > Paul, et. al., > > > > Sorry about the second e-mail ten seconds after the first. > > > > (I don't want to count bug 6858 in this list, because, for me, it has > > been tested by

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Paul Poulain
Le 28/05/2012 17:46, Jared Camins-Esakov a écrit : > Paul, et. al., > > Sorry about the second e-mail ten seconds after the first. > > (I don't want to count bug 6858 in this list, because, for me, it has > been tested by a dis-interested -well, in fact, calling the library > "dis-int

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Fischer, Katrin
Hope that makes sense, Katrin -Ursprüngliche Nachricht- Von: koha-devel-boun...@lists.koha-community.org im Auftrag von Jared Camins-Esakov Gesendet: Mo 28.05.2012 17:40 An: Marc Balmer Cc: koha-devel@lists.koha-community.org Betreff: Re: [Koha-devel] Signing-off a patch for a customer Marc, But, if

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Mirko
Marc Balmer wrote > Am 28.05.12 17:19, schrieb Fischer, Katrin: >> Hi Paul and all, >> >> I agree with Chris N. here. Every exception we make, makes it harder to >> explain and stick to our rules. >> I tinkk every patch should at least have 2 parties involved. > > But, if the patch we speak about,

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Jared Camins-Esakov
Paul, et. al., Sorry about the second e-mail ten seconds after the first. (I don't want to count bug 6858 in this list, because, for me, it has > been tested by a dis-interested -well, in fact, calling the library > "dis-interested" is maybe not the best term, but nevermind ;-) ) > I don't see h

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Jared Camins-Esakov
Marc, But, if the patch we speak about, has been tested at the library, that > makes it already two involved parties, I would say. > Neither of the parties is disinterested. I think having the sign-off by the library is probably okay for this type of patch where there are only a certain number of

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Paul Poulain
Le 28/05/2012 17:03, Chris Nighswonger a écrit : > Hi Paul, > I believe we need to stick with the principles we agreed to. This patch > clearly missed the "approval" of a dis-interested party in its initial > commit to master. (Perhaps Katrin mentioned this at some point, but I'm > not sure.) We n

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Marc Balmer
012 17:03 > An: Paul Poulain > Cc: koha-devel@lists.koha-community.org > Betreff: Re: [Koha-devel] Signing-off a patch for a customer > > Hi Paul, > > On Mon, May 28, 2012 at 10:48 AM, Paul Poulain > wrote: > >> Hello koha-devel, >> >> I just pushed

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Fischer, Katrin
Nighswonger Gesendet: Mo 28.05.2012 17:03 An: Paul Poulain Cc: koha-devel@lists.koha-community.org Betreff: Re: [Koha-devel] Signing-off a patch for a customer Hi Paul, On Mon, May 28, 2012 at 10:48 AM, Paul Poulain wrote: > Hello koha-devel, > > I just pushed a follow-up for bug 685

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Chris Nighswonger
Hi Paul, On Mon, May 28, 2012 at 10:48 AM, Paul Poulain wrote: > Hello koha-devel, > > I just pushed a follow-up for bug 6858. If you look at the patch, you'll > see that the author is from BibLibre, as well as the sign-offer. But if > you look more carefully on the patch comments, you may unders

Re: [Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Marc Balmer
Am 28.05.12 16:48, schrieb Paul Poulain: > Hello koha-devel, > > I just pushed a follow-up for bug 6858. If you look at the patch, you'll > see that the author is from BibLibre, as well as the sign-offer. But if > you look more carefully on the patch comments, you may understand that > Stephane De

[Koha-devel] Signing-off a patch for a customer

2012-05-28 Thread Paul Poulain
Hello koha-devel, I just pushed a follow-up for bug 6858. If you look at the patch, you'll see that the author is from BibLibre, as well as the sign-offer. But if you look more carefully on the patch comments, you may understand that Stephane Delaye has signed-off "in the name of the library". We'