> Done. Now the script warn instead of die and mark the test "spelling"
> as skipped.
Great. Thanks.
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://ww
See man codespell:
--dictionary=FILE
Custom dictionary file that contains spelling corrections. If this
flag is not specified then default dictionary
"/usr/share/codespell/dictionary.txt" is used.
So it's possible to provide a customi(s|z)ed file for our need.
Note that
grep -P "colou?r" /usr/s
2015-06-25 13:53 GMT+01:00 Marcel de Rooy :
>> Maybe the script should not process this check if codespell is not
>> installed. Patch welcomed ;-)
>
> Sorry, but I would rather prefer that you wrote that patch ;)
Done. Now the script warn instead of die and mark the test "spelling"
as skipped.
>>
Greetings,
Marcel de Rooy wrote:
We should spend our QA time on the code not the spelling of comments.
I don’t know about you, but how often do you comment your code?
Next, perldoc’ing is already validated. Spelling is only a minor step past
that.
Not that I support the spelling check, but I
> Maybe the script should not process this check if codespell is not installed.
> Patch welcomed ;-)
Sorry, but I would rather prefer that you wrote that patch ;)
> It's in test for the moment, we will see if the number of false positive is
> high or not. Why do you worry about them?
We should
Greetings,
Christopher nighswongerchris.nighswon...@gmail.com wrote:
> Of course if we stick to using US English (or whatever, really)
> as the default, that should really not be an issue.
Agreed.
> Seems like we've been down this road before.
This patch makes the road more apparent. This may or ma
Greetings,
Jonathan Druart wrote:
It's in test for the moment, we will see
if the number of false positive is high or not.
Why do you worry about them?
I’m sure Mr. Colorful Colour will help explain why color and other words
like it might be an issue, neighbour. :)
Your friendly neighborho
mailto:
> koha-devel-boun...@lists.koha-community.org] Namens Jonathan Druart
> Verzonden: donderdag 18 juni 2015 16:34
> Aan: koha-devel@lists.koha-community.org
> Onderwerp: [Koha-devel] QA script - New check for spelling
>
> Hi devs,
>
> QAing bug 14383, I have just added a new chec
...@lists.koha-community.org] Namens Jonathan Druart
Verzonden: donderdag 18 juni 2015 16:34
Aan: koha-devel@lists.koha-community.org
Onderwerp: [Koha-devel] QA script - New check for spelling
Hi devs,
QAing bug 14383, I have just added a new check in the QA script to check the
spelling in the code
Hi devs,
QAing bug 14383, I have just added a new check in the QA script to
check the spelling in the code comments.
Let me know if you find any issues.
You will have to install codespell (apt-get install codespell).
Cheers,
Jonathan
___
Koha-devel mail
10 matches
Mail list logo
