On 01/08/2011 15:26, Edgar Fuß wrote:
>> It's convention, not law
> I think there's an additional benefit in having Perl scripts end in .pl:
> Automated queries. It's not only replacing the shebang line. Think of
> ``who used module Foo::Bar'' or ``does anyone still call
> Foo::Bar::deprecated''.
> It's convention, not law
I think there's an additional benefit in having Perl scripts end in .pl:
Automated queries. It's not only replacing the shebang line. Think of ``who
used module Foo::Bar'' or ``does anyone still call Foo::Bar::deprecated''. You
would otherwise need a manually maintaine
> it would be a bit of a pain to change it.
I've a patch for that in my pkgsrc Koha source package.
However, that doesn't cover the case of unapi being used externally.
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-com
There are reasons that these scripts lack that extension. koha-preferences
doesn't have the extension since it's a utility intended to be run from the
command line, as opposed to a cronjob or CGI script. Services just lack the
extension to distinguish them from user-facing CGI scripts. Besides, if
> There's no reason for a perl program to end in .pl beyond convention
Yes, of course.
But if you have nearly all of the scripts ending in .pl and a fix-perl-path.PL
that seems to suggest all the scripts do end in .pl, that's confusing.
Let me elaborate on how this hit me:
I was working for a fix
On 30/07/11 20:51, Edgar Fuß wrote:
> Some of Koha's Perl scripts have filenames not ending in .pl.
> This just hit me badly because those are not handled by fix-perl-path.PL.
There's no reason for a perl program to end in .pl beyond convention
(and a discredited convention in some circles) I thin
> ./opac/unapi
I can't comment on the rest, but I know that changing this
publicly-accessible path would break any current usage that relies on
it. I have non-Koha scripts that use unapi to pull data from Koha. If
you change the path my scripts will break.
-- Owen
--
Web Developer
Athens Coun
Some of Koha's Perl scripts have filenames not ending in .pl.
This just hit me badly because those are not handled by fix-perl-path.PL.
Personally, I could just get away with pkgsrc's REPLACE_PERL feature, but maybe
other people would benefit from correct interpreter paths too.
So, is there any re