Re: [Koha-devel] Low hanging fruit: Removing un-needed use statements in C4 namespace

2018-04-18 Thread Jonathan Druart
I think the first step to fight with this problem is bug 17600 - Standardize the EXPORT On Tue, 17 Apr 2018 at 22:05 Barton Chittenden wrote: > Continuing to fiddle around with this. I commented out all of the use > statements in C4/Reserves.pm, then uncommented them one by one until the > circu

Re: [Koha-devel] Low hanging fruit: Removing un-needed use statements in C4 namespace

2018-04-17 Thread Barton Chittenden
Continuing to fiddle around with this. I commented out all of the use statements in C4/Reserves.pm, then uncommented them one by one until the circular dependencies came back. There are two modules that create the dependencies in C4::Reserves: C4::Accounts; C4::Letters; On Tue, Apr 17, 2018 at

[Koha-devel] Low hanging fruit: Removing un-needed use statements in C4 namespace

2018-04-17 Thread Barton Chittenden
Just to see what happens, I enabled warnings in C4/Reserves.pm. All of the warnings were of the form Subroutine * redefined at C4/Reserves.pm line *. This is happening because of circular dependencies, e.g. C4/Reserves.pm uses C4::Members C4::Circulation Those modules in turn use