Re: [Koha-devel] Koha:::Logger configuration maintenance

2020-03-19 Thread dcook
Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Tomas Cohen Arazi Sent: Friday, 20 March 2020 12:46 AM To: Kyle Hall Cc: koha-devel Subject: Re: [Koha-devel] Koha:::Logger configuration

Re: [Koha-devel] Koha:::Logger configuration maintenance

2020-03-19 Thread Tomas Cohen Arazi
Thanks for your answer, Kyle. The problem is that the Debian check works for files the installer puts on the FS, but not for the instance's ones we create ourselves. I'm crafting a little patch for koha-common.postinst that checks for the instance's log4perl.conf checking if there's an entry for t

Re: [Koha-devel] Koha:::Logger configuration maintenance

2020-03-19 Thread Kyle Hall
Tomas, I think the general idea is the same as for koha-conf.xml. The current log4perl.conf has been forwards compatible. We could add new recommendations for updating the log4perl.conf to the release notes and such. Other Debian packages check to see if a config has been altered and decide if they

Re: [Koha-devel] Koha:::Logger configuration maintenance

2020-03-19 Thread Tomas Cohen Arazi
Would you accept something like appending the new configuration bit on already created instances? During upgrade? for i in $(koha-list); do cat "the entries" >> /etc/koha/sites/$i/log4perl.conf done The same will happen for SIP and other targets... Oh, and I noticed we didn't consider this f

[Koha-devel] Koha:::Logger configuration maintenance

2020-03-16 Thread Tomas Cohen Arazi
Hi all. I'm not that familiar with our Koha::Logger class usage, but I noticed there's no 'api' target and it would be handy to have it. There's a bug for a 'sip' target and for other things. It looks like the main reason for adopting log4perl was the flexibility it provided, and it makes sense: ma