Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

Hi, On Mon, Nov 15, 2010 at 10:51 AM, Zeno Tajoli wrote: > In fact the patch is in the attach file, > http://lists.koha-community.org/pipermail/koha-patches/attachments/20101115/38d3ceff/attachment-0001.obj > > Do you think is a correct way to send a patch ? I've found it slightly quicker to pro

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

Hi, I have a request about "Guidelines for Patch Acceptance/Rejection". In specific about "How do we send the patches to koha-patc...@lists.koha-community.org ? Now I work on Windows 7 with GitExtensions ver 2.25 To send a mail with a patch i need to us

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

Le 14/11/2010 20:45, Chris Cormack a écrit : > On 15 November 2010 08:41, LAURENT Henri-Damien > wrote: >> Le 11/11/2010 04:07, Chris Cormack a écrit : Question for Mr. 3.4 RM: >>> :) >>> Is the procedure for dealing with DB revision numbers still the same? As far as I re

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

On 15 November 2010 08:41, LAURENT Henri-Damien wrote: > Le 11/11/2010 04:07, Chris Cormack a écrit : >>> Question for Mr. 3.4 RM: >>> >> :) >> >>> Is the procedure for dealing with DB revision numbers still the same? As far >>> as I remember from the 3.2 development days, the procedure was to pat

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

Le 11/11/2010 04:07, Chris Cormack a écrit : >> Question for Mr. 3.4 RM: >> > :) > >> Is the procedure for dealing with DB revision numbers still the same? As far >> as I remember from the 3.2 development days, the procedure was to patch >> kohastructure.sql (or sysprefs.sql, or whatever), then ad

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

I have compiled these guidelines into a wiki page: http://wiki.koha-community.org/wiki/Guidelines_for_Patch_Acceptance/Rejection. If others would like to weigh in, please feel free to update the page in the wiki. Cheers, -Ian On Thu, Nov 11, 2010 at 7:50 AM, Galen Charlton wrote: > Hi, > > On

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

Hi, On Thu, Nov 11, 2010 at 4:11 AM, Colin Campbell wrote: > It is worth stressing that there are things which will encourage quick > adoption of a patch. > Good commit messages, tests that prove it does what it says and doesn't > add needlessly to the amount of entropy in the universe. Here are

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

It is worth stressing that there are things which will encourage quick adoption of a patch. Good commit messages, tests that prove it does what it says and doesn't add needlessly to the amount of entropy in the universe. -- Colin Campbell Chief Software Engineer, PTFS Europe Limited Content Mana

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

> Question for Mr. 3.4 RM: > :) > Is the procedure for dealing with DB revision numbers still the same? As far > as I remember from the 3.2 development days, the procedure was to patch > kohastructure.sql (or sysprefs.sql, or whatever), then add the update to the > end of updatedatabase.pl with a

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

2010/11/10 Chris Cormack > I have a few extra rules for 3.4 also > > From here http://wiki.koha-community.org/wiki/Roadmap_to_3.4 > > All patches should have at least 1 signoff before the Release Manager > looks at them, (exceptions will be made for trivial patches). > Preferably 2 signoffs, 1 fr

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

And another for 3.2.x: All patches which will not apply cleanly to 3.2.x should be ported and submitted as separate patches marked for 3.2.x. (Hopefully the number of these sort of patches will be few.) Kind Regards, Chris On Wed, Nov 10, 2010 at 6:35 PM, Chris Cormack wrote: > I have a few ex

Re: [Koha-devel] Guidelines for Patch Acceptance/Rejection

I have a few extra rules for 3.4 also >From here http://wiki.koha-community.org/wiki/Roadmap_to_3.4 All patches should have at least 1 signoff before the Release Manager looks at them, (exceptions will be made for trivial patches). Preferably 2 signoffs, 1 from the QA manager and 1 from someone e

[Koha-devel] Guidelines for Patch Acceptance/Rejection

Everyone, While there can be no guarantees as to whether a patch will be committed into the Koha codebase, I think in practice there are several requirements. This email is an attempt to identify a few of them, and hopefully start a discussion about whether they are truly requirements, and what