Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-18 Thread Marcel de Rooy
Yeah I probably missed it while catching up ;) What you say makes sense, but the problem probably boils down to the gap between theory and practice. Op vr 18 jun. 2021 om 09:36 schreef Joonas Kylmälä < joonas.kylm...@helsinki.fi>: > Hi Marcel, > > On 18/06/2021 09:45, Marcel de Rooy wrote: > > Ag

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-18 Thread Joonas Kylmälä
Hi Marcel, On 18/06/2021 09:45, Marcel de Rooy wrote: > Agree with Julian here. It depends. > You could squash follow-up patches yourself too before reverting them? > In some cases patches tell us a nice story, in a lot of cases it might > be confusing or messy.. I think you might not have seen y

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-17 Thread Marcel de Rooy
aflevering van Rijksmuseum Unlocked RM xxx ​Please think before you print Van: Koha-devel namens Joonas Kylmälä Verzonden: vrijdag 4 juni 2021 12:36 Aan: koha-devel Onderwerp: [Koha-devel] Follow-up patches and why not to use them Hi, I just bumped in another case of follow-up patch style

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-06 Thread Joonas Kylmälä
Hi, On 04/06/2021 15:42, Julian Maurice wrote: > Do you know you can revert multiple commits at once (ie. only one > "revert commit" that revert a series of commits) ? Would that make it > easier for cases like that ? > And when trying to find all commits of a particular bug, git log --grep > is y

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-04 Thread Julian Maurice
Hi Joonas, Do you know you can revert multiple commits at once (ie. only one "revert commit" that revert a series of commits) ? Would that make it easier for cases like that ? And when trying to find all commits of a particular bug, git log --grep is your friend. Also, you can show a list of

[Koha-devel] Follow-up patches and why not to use them

2021-06-04 Thread Joonas Kylmälä
Hi, I just bumped in another case of follow-up patch style causing us trouble. In bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 I had to spend considerable amount of time just reverting all the problematic patches and making sure I didn't miss any related patches, instead of