Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread Owen Leonard
> But when no-one find time to sign-off a patch, it results in patches > being lost in limbo. And when someone suddenly takes care, unfortunately, > the patch does not apply anymore, so the patch writer has to rebase,... Yes, and that's why we should all be maintaining our own git branches for any

Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread Ian Walls
Paul, I agree that having 140 patches needing signoff is way too many; I'd like to see all them signed off and ready for QA. Lots of good stuff out there, and if it's not being integrated, we're losing out. However, the workflow is a good one from a quality assurance point of view. Someone writ

Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread Paul Poulain
Le 11/05/2011 16:22, Chris Cormack a écrit : > On 12 May 2011 00:19, Marcel de Rooy wrote: >> Liked that article! >> As relative new member of the community, I am wondering if the current >> signoff/passed_qa procedure really encourages new members to keep sending >> patches. >> It could happen

Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread Chris Cormack
On 12 May 2011 00:19, Marcel de Rooy wrote: > Liked that article! > As relative new member of the community, I am wondering if the current > signoff/passed_qa procedure really encourages new members to keep sending > patches. > It could happen easily now that a patch does not get any attention.

Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread Owen Leonard
> Graph analysis showed very clearly that every time we would freeze, the > community would shrink drastically and it would take several months after we > un-froze for the size of the community to recover Sure, because fixing bugs is very unsexy. It's great to get all the feature contributions be

Re: [Koha-devel] FW: Code simplicity document

2011-05-11 Thread David Schuster
I too enjoyed this article and took note of this and saw during the IRC meeting a comment about after a release how the community drops off. "In the past, before a major release, we would “freeze” the trunk. This meant that no new features could be developed for several weeks or months until we fe

[Koha-devel] FW: Code simplicity document

2011-05-11 Thread Marcel de Rooy
Liked that article! As relative new member of the community, I am wondering if the current signoff/passed_qa procedure really encourages new members to keep sending patches. It could happen easily now that a patch does not get any attention. What makes someone now select a patch for signoff? C